237002 2022-02-21 15:52:13 -0800 CachedResourceLoader::allCachedSVGImages() reparses resource URLs unnecessarily 2022-02-22 17:28:21 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ews-watchlist ggaren japhet jbedard webkit-bug-importer youennf oldest_to_newest 1844423 0 cdumez 2022-02-21 15:52:13 -0800 CachedResourceLoader::allCachedSVGImages() reparses resource URLs unnecessarily: Sample Count, Samples %, Normalized CPU %, Symbol 40, 0.1%, 0.0%, WebCore::CachedResourceLoader::allCachedSVGImages() const (in WebCore) 34, 0.1%, 0.0%, WebCore::CachedResourceLoader::cachedResource(WTF::String const&) const (in WebCore) 31, 0.1%, 0.0%, WebCore::Document::completeURL(WTF::String const&, WebCore::ScriptExecutionContext::ForceUTF8) const (in WebCore) 31, 0.1%, 0.0%, WebCore::Document::completeURL(WTF::String const&, WTF::URL const&, WebCore::ScriptExecutionContext::ForceUTF8) const (in WebCore) 30, 0.0%, 0.0%, WTF::URL::URL(WTF::URL const&, WTF::String const&, WTF::URLTextEncoding const*) (in JavaScriptCore) 30, 0.0%, 0.0%, WTF::URLParser::URLParser(WTF::String const&, WTF::URL const&, WTF::URLTextEncoding const*) (in JavaScriptCore) 29, 0.0%, 0.0%, void WTF::URLParser::parse<unsigned char>(unsigned char const*, unsigned int, WTF::URL const&, WTF::URLTextEncoding const*) (in JavaScriptCore) 1844426 1 452790 cdumez 2022-02-21 15:57:17 -0800 Created attachment 452790 Patch 1844720 2 jbedard 2022-02-22 08:22:03 -0800 Stopped https://ews-build.webkit.org/#/builders/70/builds/974, the 3 failures seen are already known. 1844726 3 cdumez 2022-02-22 08:28:49 -0800 (In reply to Jonathan Bedard from comment #2) > Stopped https://ews-build.webkit.org/#/builders/70/builds/974, the 3 > failures seen are already known. Oh, thank you for letting me know! My patch touches SVG and the 3 failures were on SVG tests so I was about to investigate. 1844878 4 452790 darin 2022-02-22 14:46:22 -0800 Comment on attachment 452790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452790&action=review > Source/WebCore/ChangeLog:10 > + Store URLs in the HashMaps instead of Strings since we have URLs initially and we > + need URLs eventually. This avoids having to re-parse the URL unnecessarily, which > + is fairly expensive. It also makes the maps bigger; URLs share the strings, but the parsed offsets are separate in each URL. Hope that extra memory use is OK. 1844957 5 ews-feeder 2022-02-22 17:27:41 -0800 Committed r290341 (247661@main): <https://commits.webkit.org/247661@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452790. 1844958 6 webkit-bug-importer 2022-02-22 17:28:21 -0800 <rdar://problem/89326498> 452790 2022-02-21 15:57:17 -0800 2022-02-22 17:27:44 -0800 Patch bug-237002-20220221155716.patch text/plain 3811 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhmOTRmNWJiMGM4YzNl YTdiYTY5NzU5MzdmNTJkY2FjZWUyMzA3ZS4uYzVkZTkzMTEzNTIyZjAxYTQwMzkzZTYzYjA3OGZj NTdjZGU4Zjg2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAyLTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FjaGVkUmVzb3VyY2VMb2Fk ZXI6OmFsbENhY2hlZFNWR0ltYWdlcygpIHJlcGFyc2VzIHJlc291cmNlIFVSTHMgdW5uZWNlc3Nh cmlseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM3 MDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3Rv cmUgVVJMcyBpbiB0aGUgSGFzaE1hcHMgaW5zdGVhZCBvZiBTdHJpbmdzIHNpbmNlIHdlIGhhdmUg VVJMcyBpbml0aWFsbHkgYW5kIHdlCisgICAgICAgIG5lZWQgVVJMcyBldmVudHVhbGx5LiBUaGlz IGF2b2lkcyBoYXZpbmcgdG8gcmUtcGFyc2UgdGhlIFVSTCB1bm5lY2Vzc2FyaWx5LCB3aGljaAor ICAgICAgICBpcyBmYWlybHkgZXhwZW5zaXZlLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNl TG9hZGVyOjpyZXF1ZXN0UmVzb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3Vy Y2VMb2FkZXI6OmRldGVybWluZVJldmFsaWRhdGlvblBvbGljeSBjb25zdCk6CisgICAgICAgIChX ZWJDb3JlOjpDYWNoZWRSZXNvdXJjZUxvYWRlcjo6bm90aWZ5RmluaXNoZWQpOgorICAgICAgICAq IGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5oOgorCiAyMDIyLTAyLTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBzZXJ2aWNlIHdvcmtl ciBhbmQgcHVzaCBBUEkgcHJlZmVyZW5jZSBmcm9tIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXMgdG8g U2V0dGluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRS ZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVz b3VyY2VMb2FkZXIuY3BwCmluZGV4IDgxN2FjYzA2ZDNmNzQ0YzlhZWVkNTg3MGJkZWQ0MWMxZDMw OTNiOGYuLjhjOWQwYzhkYWVmNGQ2MjZhMWI3NDA3MWNkOWFkNTFjNzA4NzU2MDYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNw cApAQCAtMTA5Miw3ICsxMDkyLDcgQEAgUmVzb3VyY2VFcnJvck9yPENhY2hlZFJlc291cmNlSGFu ZGxlPENhY2hlZFJlc291cmNlPj4gQ2FjaGVkUmVzb3VyY2VMb2FkZXI6OnJlcXUKICAgICB9CiAK ICAgICBpZiAoZG9jdW1lbnQoKSAmJiAhZG9jdW1lbnQoKS0+bG9hZEV2ZW50RmluaXNoZWQoKSAm JiAhcmVzb3VyY2UtPnJlc291cmNlUmVxdWVzdCgpLnVybCgpLnByb3RvY29sSXNEYXRhKCkpCi0g ICAgICAgIG1fdmFsaWRhdGVkVVJMcy5hZGQocmVzb3VyY2UtPnJlc291cmNlUmVxdWVzdCgpLnVy bCgpLnN0cmluZygpKTsKKyAgICAgICAgbV92YWxpZGF0ZWRVUkxzLmFkZChyZXNvdXJjZS0+cmVz b3VyY2VSZXF1ZXN0KCkudXJsKCkpOwogCiAgICAgQVNTRVJUKHJlc291cmNlLT51cmwoKSA9PSB1 cmwuc3RyaW5nKCkpOwogICAgIG1fZG9jdW1lbnRSZXNvdXJjZXMuc2V0KHJlc291cmNlLT51cmwo KS5zdHJpbmcoKSwgcmVzb3VyY2UpOwpAQCAtMTMwMCw3ICsxMzAwLDcgQEAgQ2FjaGVkUmVzb3Vy Y2VMb2FkZXI6OlJldmFsaWRhdGlvblBvbGljeSBDYWNoZWRSZXNvdXJjZUxvYWRlcjo6ZGV0ZXJt aW5lUmV2YWxpZGEKICAgICB9CiAKICAgICAvLyBEdXJpbmcgdGhlIGluaXRpYWwgbG9hZCwgYXZv aWQgbG9hZGluZyB0aGUgc2FtZSByZXNvdXJjZSBtdWx0aXBsZSB0aW1lcyBmb3IgYSBzaW5nbGUg ZG9jdW1lbnQsIGV2ZW4gaWYgdGhlIGNhY2hlIHBvbGljaWVzIHdvdWxkIHRlbGwgdXMgdG8uCi0g ICAgaWYgKGRvY3VtZW50KCkgJiYgIWRvY3VtZW50KCktPmxvYWRFdmVudEZpbmlzaGVkKCkgJiYg bV92YWxpZGF0ZWRVUkxzLmNvbnRhaW5zKGV4aXN0aW5nUmVzb3VyY2UtPnVybCgpLnN0cmluZygp KSkKKyAgICBpZiAoZG9jdW1lbnQoKSAmJiAhZG9jdW1lbnQoKS0+bG9hZEV2ZW50RmluaXNoZWQo KSAmJiBtX3ZhbGlkYXRlZFVSTHMuY29udGFpbnMoZXhpc3RpbmdSZXNvdXJjZS0+dXJsKCkpKQog ICAgICAgICByZXR1cm4gVXNlOwogCiAgICAgLy8gQ2FjaGVQb2xpY3k6OlJlbG9hZCBhbHdheXMg cmVsb2FkcwpAQCAtMTUwOSw3ICsxNTA5LDcgQEAgdm9pZCBDYWNoZWRSZXNvdXJjZUxvYWRlcjo6 ZGVjcmVtZW50UmVxdWVzdENvdW50KGNvbnN0IENhY2hlZFJlc291cmNlJiByZXNvdXJjZSkKIHZv aWQgQ2FjaGVkUmVzb3VyY2VMb2FkZXI6Om5vdGlmeUZpbmlzaGVkKGNvbnN0IENhY2hlZFJlc291 cmNlJiByZXNvdXJjZSkKIHsKICAgICBpZiAoaXNTVkdJbWFnZUNhY2hlZFJlc291cmNlKCZyZXNv dXJjZSkpCi0gICAgICAgIG1fY2FjaGVkU1ZHSW1hZ2VzVVJMcy5hZGQocmVzb3VyY2UudXJsKCku c3RyaW5nKCkpOworICAgICAgICBtX2NhY2hlZFNWR0ltYWdlc1VSTHMuYWRkKHJlc291cmNlLnVy bCgpKTsKIH0KIAogVmVjdG9yPFJlZjxTVkdJbWFnZT4+IENhY2hlZFJlc291cmNlTG9hZGVyOjph bGxDYWNoZWRTVkdJbWFnZXMoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv Y2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuaAppbmRleCA3YWE1N2JjMDBkMzQwMjk4NWQ5ZThh OTFjZWZlZmZiNmQzYzYzYzExLi4zZmFkOWE0OTMwNzI1Zjg2YjUyZjcxMzViMmJhNjliOWE1NTQ0 OWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy Y2VMb2FkZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy Y2VMb2FkZXIuaApAQCAtMjAwLDggKzIwMCw4IEBAIHByaXZhdGU6CiAgICAgYm9vbCBjYW5SZXF1 ZXN0QWZ0ZXJSZWRpcmVjdGlvbihDYWNoZWRSZXNvdXJjZTo6VHlwZSwgY29uc3QgVVJMJiwgY29u c3QgUmVzb3VyY2VMb2FkZXJPcHRpb25zJiwgY29uc3QgVVJMJiBwcmVSZWRpcmVjdFVSTCkgY29u c3Q7CiAgICAgYm9vbCBjYW5SZXF1ZXN0SW5Db250ZW50RGlzcG9zaXRpb25BdHRhY2htZW50U2Fu ZGJveChDYWNoZWRSZXNvdXJjZTo6VHlwZSwgY29uc3QgVVJMJikgY29uc3Q7CiAKLSAgICBIYXNo U2V0PFN0cmluZz4gbV92YWxpZGF0ZWRVUkxzOwotICAgIEhhc2hTZXQ8U3RyaW5nPiBtX2NhY2hl ZFNWR0ltYWdlc1VSTHM7CisgICAgSGFzaFNldDxVUkw+IG1fdmFsaWRhdGVkVVJMczsKKyAgICBI YXNoU2V0PFVSTD4gbV9jYWNoZWRTVkdJbWFnZXNVUkxzOwogICAgIG11dGFibGUgRG9jdW1lbnRS ZXNvdXJjZU1hcCBtX2RvY3VtZW50UmVzb3VyY2VzOwogICAgIFdlYWtQdHI8RG9jdW1lbnQ+IG1f ZG9jdW1lbnQ7CiAgICAgRG9jdW1lbnRMb2FkZXIqIG1fZG9jdW1lbnRMb2FkZXI7Cg==