236995 2022-02-21 13:46:00 -0800 Use ArgumentParser for parsing args in generate-compile-commands 2022-02-21 22:45:21 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 brandonstewart webkit-unassigned ap emw webkit-bug-importer oldest_to_newest 1844368 0 brandonstewart 2022-02-21 13:46:00 -0800 Use ArgumentParser for parsing args in generate-compile-commands 1844372 1 452771 brandonstewart 2022-02-21 13:49:05 -0800 Created attachment 452771 Patch 1844383 2 452771 ap 2022-02-21 14:12:51 -0800 Comment on attachment 452771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452771&action=review > Tools/Scripts/generate-compile-commands:39 > +parser = argparse.ArgumentParser(description='Generate compile_commands.json', usage='generate-compile-commands WebKitBuild/Release') Can/should this say something about how it's used overall, via `make EXPORT_COMPILE_COMMANDS=YES`? I've been following this project relatively closely, and yet I'm not sure how to set up code completion in BBEdit using this. Or maybe there could be a wiki page, linked from here. > Tools/Scripts/generate-compile-commands:40 > +parser.add_argument('built_products_dir', help='path to the build directory containing generated compile commands (ex: WebKitBuild/Release)') This seems like it should be required=True 1844474 3 emw 2022-02-21 17:36:57 -0800 LGTM! (In reply to Alexey Proskuryakov from comment #2) > > > Tools/Scripts/generate-compile-commands:40 > > +parser.add_argument('built_products_dir', help='path to the build directory containing generated compile commands (ex: WebKitBuild/Release)') > > This seems like it should be required=True Positional arguments are `required` by default, so it should be fine as-is. 1844505 4 brandonstewart 2022-02-21 18:38:03 -0800 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 452771 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452771&action=review > > > Tools/Scripts/generate-compile-commands:39 > > +parser = argparse.ArgumentParser(description='Generate compile_commands.json', usage='generate-compile-commands WebKitBuild/Release') > > Can/should this say something about how it's used overall, via `make > EXPORT_COMPILE_COMMANDS=YES`? I've been following this project relatively > closely, and yet I'm not sure how to set up code completion in BBEdit using > this. > > Or maybe there could be a wiki page, linked from here. > Created a page on trac on how to setup clangd. https://trac.webkit.org/wiki/Clangd It may be useful to link to the trac page in this command. > > Tools/Scripts/generate-compile-commands:40 > > +parser.add_argument('built_products_dir', help='path to the build directory containing generated compile commands (ex: WebKitBuild/Release)') > > This seems like it should be required=True If you call generate-compile-comamnds without an argument it will throw an error with a description on how to use it. > generate-compile-commands usage: generate-compile-commands WebKitBuild/Release generate-compile-commands: error: the following arguments are required: built_products_dir 1844523 5 452817 brandonstewart 2022-02-21 19:38:27 -0800 Created attachment 452817 Patch 1844524 6 brandonstewart 2022-02-21 19:39:15 -0800 Added better documentation on usage > generate-compile-commands -h usage: make r EXPORT_COMPILE_COMMANDS=YES generate-compile-commands WebKitBuild/Release https://trac.webkit.org/wiki/Clangd Generate compile_commands.json positional arguments: built_products_dir path to the build directory containing generated compile commands (ex: WebKitBuild/Release) optional arguments: -h, --help show this help message and exit 1844554 7 ews-feeder 2022-02-21 22:44:52 -0800 Committed r290289 (247613@main): <https://commits.webkit.org/247613@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452817. 1844555 8 webkit-bug-importer 2022-02-21 22:45:21 -0800 <rdar://problem/89276925> 452771 2022-02-21 13:49:05 -0800 2022-02-21 19:38:24 -0800 Patch bug-236995-20220221134904.patch text/plain 1851 brandonstewart U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzhkZTVjN2U1MDMxYzFmNzE4MGQyZmMyZDYwMTBmNGEz NTQzYjcxOS4uNjM2YzcxYjg5OGZhN2Q0ZDNlMTAyYzA4OTcwNWE2ZTJiYjNlZjA1OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIyLTAyLTIxICBCcmFuZG9uIFN0ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5j b20+CisKKyAgICAgICAgVXNlIEFyZ3VtZW50UGFyc2VyIGZvciBwYXJzaW5nIGFyZ3MgaW4gZ2Vu ZXJhdGUtY29tcGlsZS1jb21tYW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2OTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXNlIGFyZ3VtZW50IHBhcnNlciBpbnN0ZWFkIG9mIHN5cy5hcmd2WzFd IGZvciBnZXR0aW5nIGJ1aWxkIGRpci4KKworICAgICAgICAqIFNjcmlwdHMvZ2VuZXJhdGUtY29t cGlsZS1jb21tYW5kczoKKwogMjAyMi0wMi0xNyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBh cHBsZS5jb20+CiAKICAgICAgICAgW3J1bi13ZWJraXQtdGVzdHNdIFVzZSBQeXRob24gMyAoUGFy dCAxKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS1jb21waWxlLWNvbW1hbmRz IGIvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS1jb21waWxlLWNvbW1hbmRzCmluZGV4IDk1MmM4MjY4 ZGE3Y2Q1ZDA0MWE4MDE4NDMyNzNlMThmNmZkNzZjZmUuLjFlYTcwNWUwY2QzZjNhNmE5OWIwNDFk MWM2OTk4NzdhYTEwOTIxNzIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvZ2VuZXJhdGUtY29t cGlsZS1jb21tYW5kcworKysgYi9Ub29scy9TY3JpcHRzL2dlbmVyYXRlLWNvbXBpbGUtY29tbWFu ZHMKQEAgLTMzLDYgKzMzLDEyIEBAIGltcG9ydCBvcwogaW1wb3J0IHN5cwogaW1wb3J0IGdsb2IK IGltcG9ydCBqc29uCitpbXBvcnQgYXJncGFyc2UKKworIyBHZXQgY29tbWFuZCBsaW5lIGFyZ3MK K3BhcnNlciA9IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPSdHZW5lcmF0ZSBj b21waWxlX2NvbW1hbmRzLmpzb24nLCB1c2FnZT0nZ2VuZXJhdGUtY29tcGlsZS1jb21tYW5kcyBX ZWJLaXRCdWlsZC9SZWxlYXNlJykKK3BhcnNlci5hZGRfYXJndW1lbnQoJ2J1aWx0X3Byb2R1Y3Rz X2RpcicsIGhlbHA9J3BhdGggdG8gdGhlIGJ1aWxkIGRpcmVjdG9yeSBjb250YWluaW5nIGdlbmVy YXRlZCBjb21waWxlIGNvbW1hbmRzIChleDogV2ViS2l0QnVpbGQvUmVsZWFzZSknKQorb3B0cyA9 IHBhcnNlci5wYXJzZV9hcmdzKCkKIAogIyBDaGFuZ2UgdG8gdGhlIHJvb3Qgb2YgV2ViS2l0IERp cmVjdG9yeQogZmlsZV9kaXIgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5yZWFscGF0aChfX2Zp bGVfXykpCkBAIC00MCw3ICs0Niw3IEBAIGJhc2VfZGlyID0gZmlsZV9kaXIgKyAiLy4uLy4uLyIK IG9zLmNoZGlyKGJhc2VfZGlyKQogCiAjIENoZWNrIGNvbXBpbGVfY29tbWFuZHMgZm9sZGVyIGV4 aXN0cwotY29tcGlsZV9jb21tYW5kc19kaXIgPSBzeXMuYXJndlsxXSArICIvY29tcGlsZV9jb21t YW5kcy8iCitjb21waWxlX2NvbW1hbmRzX2RpciA9IG9wdHMuYnVpbHRfcHJvZHVjdHNfZGlyICsg Ii9jb21waWxlX2NvbW1hbmRzLyIKIAogaWYgbm90IG9zLnBhdGguZXhpc3RzKGNvbXBpbGVfY29t bWFuZHNfZGlyKToKICAgICBwcmludCgiUGxlYXNlIHNwZWNpZnkgdGhlIGJ1aWxkIGRpcmVjdG9y eSB3aXRoIGNvbXBpbGVfY29tbWFuZHMuIikK 452817 2022-02-21 19:38:27 -0800 2022-02-21 22:44:54 -0800 Patch bug-236995-20220221193826.patch text/plain 2022 brandonstewart U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzhkZTVjN2U1MDMxYzFmNzE4MGQyZmMyZDYwMTBmNGEz NTQzYjcxOS4uNjM2YzcxYjg5OGZhN2Q0ZDNlMTAyYzA4OTcwNWE2ZTJiYjNlZjA1OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIyLTAyLTIxICBCcmFuZG9uIFN0ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5j b20+CisKKyAgICAgICAgVXNlIEFyZ3VtZW50UGFyc2VyIGZvciBwYXJzaW5nIGFyZ3MgaW4gZ2Vu ZXJhdGUtY29tcGlsZS1jb21tYW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2OTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXNlIGFyZ3VtZW50IHBhcnNlciBpbnN0ZWFkIG9mIHN5cy5hcmd2WzFd IGZvciBnZXR0aW5nIGJ1aWxkIGRpci4KKworICAgICAgICAqIFNjcmlwdHMvZ2VuZXJhdGUtY29t cGlsZS1jb21tYW5kczoKKwogMjAyMi0wMi0xNyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBh cHBsZS5jb20+CiAKICAgICAgICAgW3J1bi13ZWJraXQtdGVzdHNdIFVzZSBQeXRob24gMyAoUGFy dCAxKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS1jb21waWxlLWNvbW1hbmRz IGIvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS1jb21waWxlLWNvbW1hbmRzCmluZGV4IDk1MmM4MjY4 ZGE3Y2Q1ZDA0MWE4MDE4NDMyNzNlMThmNmZkNzZjZmUuLjFjM2YwYmYxOWRlZTRmOGU4M2Y4MTRm MzE0OTEwNjU2NzA5YmZhN2MgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvZ2VuZXJhdGUtY29t cGlsZS1jb21tYW5kcworKysgYi9Ub29scy9TY3JpcHRzL2dlbmVyYXRlLWNvbXBpbGUtY29tbWFu ZHMKQEAgLTMzLDYgKzMzLDE5IEBAIGltcG9ydCBvcwogaW1wb3J0IHN5cwogaW1wb3J0IGdsb2IK IGltcG9ydCBqc29uCitpbXBvcnQgYXJncGFyc2UKKworIyBHZXQgY29tbWFuZCBsaW5lIGFyZ3MK K3BhcnNlciA9IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPSdHZW5lcmF0ZSBj b21waWxlX2NvbW1hbmRzLmpzb24nLCAKKyAgICAgICAgICAgIHVzYWdlPSIiIgorICAgICAgICAg ICAgICAgICAgbWFrZSByIEVYUE9SVF9DT01QSUxFX0NPTU1BTkRTPVlFUworICAgICAgICAgICAg ICAgICAgZ2VuZXJhdGUtY29tcGlsZS1jb21tYW5kcyBXZWJLaXRCdWlsZC9SZWxlYXNlCisKKyAg ICAgICAgICAgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvQ2xhbmdkCisgICAg ICAgICAgICAgICAgICAiIiIpCisKK3BhcnNlci5hZGRfYXJndW1lbnQoJ2J1aWx0X3Byb2R1Y3Rz X2RpcicsIGhlbHA9J3BhdGggdG8gdGhlIGJ1aWxkIGRpcmVjdG9yeSBjb250YWluaW5nIGdlbmVy YXRlZCBjb21waWxlIGNvbW1hbmRzIChleDogV2ViS2l0QnVpbGQvUmVsZWFzZSknKQorb3B0cyA9 IHBhcnNlci5wYXJzZV9hcmdzKCkKIAogIyBDaGFuZ2UgdG8gdGhlIHJvb3Qgb2YgV2ViS2l0IERp cmVjdG9yeQogZmlsZV9kaXIgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5yZWFscGF0aChfX2Zp bGVfXykpCkBAIC00MCw3ICs1Myw3IEBAIGJhc2VfZGlyID0gZmlsZV9kaXIgKyAiLy4uLy4uLyIK IG9zLmNoZGlyKGJhc2VfZGlyKQogCiAjIENoZWNrIGNvbXBpbGVfY29tbWFuZHMgZm9sZGVyIGV4 aXN0cwotY29tcGlsZV9jb21tYW5kc19kaXIgPSBzeXMuYXJndlsxXSArICIvY29tcGlsZV9jb21t YW5kcy8iCitjb21waWxlX2NvbW1hbmRzX2RpciA9IG9wdHMuYnVpbHRfcHJvZHVjdHNfZGlyICsg Ii9jb21waWxlX2NvbW1hbmRzLyIKIAogaWYgbm90IG9zLnBhdGguZXhpc3RzKGNvbXBpbGVfY29t bWFuZHNfZGlyKToKICAgICBwcmludCgiUGxlYXNlIHNwZWNpZnkgdGhlIGJ1aWxkIGRpcmVjdG9y eSB3aXRoIGNvbXBpbGVfY29tbWFuZHMuIikK