236994 2022-02-21 13:41:30 -0800 AX: Only compute ariaTreeRows for isTree() objects 2022-02-22 09:09:06 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1844366 0 tyler_w 2022-02-21 13:41:30 -0800 We only expose AXPropertyName::ARIATreeRows for isTree() objects, but compute it for every object, which is wasteful. 1844367 1 webkit-bug-importer 2022-02-21 13:41:43 -0800 <rdar://problem/89254349> 1844369 2 452768 tyler_w 2022-02-21 13:46:15 -0800 Created attachment 452768 Patch 1844736 3 ews-feeder 2022-02-22 09:09:03 -0800 Committed r290310 (247633@main): <https://commits.webkit.org/247633@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452768. 452768 2022-02-21 13:46:15 -0800 2022-02-22 09:09:04 -0800 Patch bug-236994-20220221154614.patch text/plain 5127 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE2MGQwOTNkYzMxNzc0 ZjUzMzEzYzE2NDVkNWJiOThhODdjNGE0MC4uYmM4MDgyMzAxYmJlMzU5NmM2MWYzOTE0YjRiNDEz Njg0OWU1YjI5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAyLTIxICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE9ubHkgY29tcHV0 ZSBhcmlhVHJlZVJvd3MgZm9yIGlzVHJlZSgpIG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjk5NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG9ubHkgZXhwb3NlIEFYUHJvcGVydHlOYW1l OjpBUklBVHJlZVJvd3MgZm9yIGlzVHJlZSgpIG9iamVjdHMsIGJ1dCBjb21wdXRlIGl0IGZvciBl dmVyeSBvYmplY3QsIHdoaWNoIGlzIHdhc3RlZnVsLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxz byBpbmNsdWRlcyBhIGRyaXZlLWJ5IGZpeGluZyBvZiBzZXR0aW5nIEFYUHJvcGVydHlOYW1lOjpJ c1RyZWVJdGVtLiBQcmlvciB0byB0aGlzIHBhdGNoLAorICAgICAgICB3ZSBuZXZlciBzZXQgdGhp cyBwcm9wZXJ0eS4gQWxzbywgd2Ugbm93IG9ubHkgc3RvcmUgQVhQcm9wZXJ0eU5hbWU6OkFSSUFU cmVlSXRlbUNvbnRlbnQgZm9yIGlzVHJlZUl0ZW0oKSBvYmplY3RzLgorCisgICAgICAgIFRoZSBB WFByb3BlcnR5TmFtZTo6SXNUcmVlSXRlbSBmaXggbWFrZXMgdGVzdCBhY2Nlc3NpYmlsaXR5L3Jv bGVzLWV4cG9zZWQuaHRtbCBjbG9zZXIgdG8gcGFzc2luZyB3aXRoIElUTSBlbmFibGVkLgorCisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmFyaWFUcmVlUm93cyk6CisgICAgICAgIFJl bW92ZSB1bm5jZXNzYXJ5IHRhYiBjaGFyYWN0ZXIuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9p c29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBWElz b2xhdGVkT2JqZWN0Ojppbml0aWFsaXplQXR0cmlidXRlRGF0YSk6CisKIDIwMjItMDItMTggIFBl bmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXVtNb2Rlcm4gTWVk aWEgQ29udHJvbHNdIEFkZCBhbiBhbHRlcm5hdGl2ZSBvdmVyZmxvdyBpY29uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRl eCA4Mjc3MGE3ZjJkNjZmNzgxYjhjNzM2M2NlOTcwYWFiNTQ4ZTg5YTNiLi4zMTNhMThjZTJjZTM4 ZDdiM2VlYWJiNjZkNGM0MGIyYzBkZmE2ZGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKQEAgLTE4OTgsNyArMTg5OCw3 IEBAIHZvaWQgQWNjZXNzaWJpbGl0eU9iamVjdDo6YXJpYVRyZWVSb3dzKEFjY2Vzc2liaWxpdHlD aGlsZHJlblZlY3RvciYgcm93cywgQWNjZXNzCiB7CiAgICAgQWNjZXNzaWJpbGl0eUNoaWxkcmVu VmVjdG9yIGFyaWFPd25zOwogICAgIGFyaWFPd25zRWxlbWVudHMoYXJpYU93bnMpOwotICAgIAor CiAgICAgYW5jZXN0b3JzLmFwcGVuZCh0aGlzKTsKIAogICAgIC8vIFRoZSBvcmRlcmluZyBvZiBy b3dzIGlzIGZpcnN0IERPTSBjaGlsZHJlbiAqbm90KiBpbiBhcmlhLW93bnMsIGZvbGxvd2VkIGJ5 IGFsbCBzcGVjaWZpZWQKQEAgLTE5NTEsNyArMTk1MSw3IEBAIHZvaWQgQWNjZXNzaWJpbGl0eU9i amVjdDo6YXJpYVRyZWVSb3dzKEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYgcm93cywgQWNj ZXNzCiAgICAgYW5jZXN0b3JzLnJlbW92ZUxhc3QoKTsKIH0KIAotdm9pZCBBY2Nlc3NpYmlsaXR5 T2JqZWN0OjphcmlhVHJlZVJvd3MoQWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9yJiByb3dzICAg ICkKK3ZvaWQgQWNjZXNzaWJpbGl0eU9iamVjdDo6YXJpYVRyZWVSb3dzKEFjY2Vzc2liaWxpdHlD aGlsZHJlblZlY3RvciYgcm93cykKIHsKICAgICBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3Ig YW5jZXN0b3JzOwogICAgIGFyaWFUcmVlUm93cyhyb3dzLCBhbmNlc3RvcnMpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9i amVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElz b2xhdGVkT2JqZWN0LmNwcAppbmRleCBiZGY4MjVkMmQxYzBjNGFkOTZmMDg1ZmNjNmFlMGYzMTAy MzkwMGQxLi42OTNlOWZlOWZlYzIxMjIxNDAxYmNmMTc3NTg4NzBmYzRhOGFkMmNhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVk T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJl ZS9BWElzb2xhdGVkT2JqZWN0LmNwcApAQCAtMTMxLDcgKzEzMSw2IEBAIHZvaWQgQVhJc29sYXRl ZE9iamVjdDo6aW5pdGlhbGl6ZUF0dHJpYnV0ZURhdGEoQVhDb3JlT2JqZWN0JiBjb3JlT2JqZWN0 LCBib29sIGlzCiAgICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6OklzU2xpZGVyLCBvYmpl Y3QuaXNTbGlkZXIoKSk7CiAgICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6OklzU3R5bGVG b3JtYXRHcm91cCwgb2JqZWN0LmlzU3R5bGVGb3JtYXRHcm91cCgpKTsKICAgICBzZXRQcm9wZXJ0 eShBWFByb3BlcnR5TmFtZTo6SXNUZXh0Q29udHJvbCwgb2JqZWN0LmlzVGV4dENvbnRyb2woKSk7 Ci0gICAgc2V0UHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6OklzVHJlZSwgb2JqZWN0LmlzVHJlZSgp KTsKICAgICBzZXRQcm9wZXJ0eShBWFByb3BlcnR5TmFtZTo6SXNVbm9yZGVyZWRMaXN0LCBvYmpl Y3QuaXNVbm9yZGVyZWRMaXN0KCkpOwogICAgIHNldFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpJ c1VudmlzaXRlZCwgb2JqZWN0LmlzVW52aXNpdGVkKCkpOwogICAgIHNldFByb3BlcnR5KEFYUHJv cGVydHlOYW1lOjpJc1ZhbHVlQXV0b2ZpbGxBdmFpbGFibGUsIG9iamVjdC5pc1ZhbHVlQXV0b2Zp bGxBdmFpbGFibGUoKSk7CkBAIC0yODIsOCArMjgxLDIzIEBAIHZvaWQgQVhJc29sYXRlZE9iamVj dDo6aW5pdGlhbGl6ZUF0dHJpYnV0ZURhdGEoQVhDb3JlT2JqZWN0JiBjb3JlT2JqZWN0LCBib29s IGlzCiAgICAgICAgIHNldE9iamVjdFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpEaXNjbG9zZWRC eVJvdywgb2JqZWN0LmRpc2Nsb3NlZEJ5Um93KCkpOwogICAgIH0KIAotICAgIGlmIChvYmplY3Qu aXNUcmVlSXRlbSgpKQorICAgIGlmIChvYmplY3QuaXNUcmVlSXRlbSgpKSB7CisgICAgICAgIHNl dFByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpJc1RyZWVJdGVtLCB0cnVlKTsKKworICAgICAgICBB Y2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3IgYXJpYVRyZWVJdGVtQ29udGVudDsKKyAgICAgICAg b2JqZWN0LmFyaWFUcmVlSXRlbUNvbnRlbnQoYXJpYVRyZWVJdGVtQ29udGVudCk7CisgICAgICAg IHNldE9iamVjdFZlY3RvclByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpBUklBVHJlZUl0ZW1Db250 ZW50LCBhcmlhVHJlZUl0ZW1Db250ZW50KTsKKwogICAgICAgICBzZXRPYmplY3RWZWN0b3JQcm9w ZXJ0eShBWFByb3BlcnR5TmFtZTo6RGlzY2xvc2VkUm93cywgb2JqZWN0LmRpc2Nsb3NlZFJvd3Mo KSk7CisgICAgfQorCisgICAgaWYgKG9iamVjdC5pc1RyZWUoKSkgeworICAgICAgICBzZXRQcm9w ZXJ0eShBWFByb3BlcnR5TmFtZTo6SXNUcmVlLCB0cnVlKTsKKworICAgICAgICBBY2Nlc3NpYmls aXR5Q2hpbGRyZW5WZWN0b3IgYXJpYVRyZWVSb3dzOworICAgICAgICBvYmplY3QuYXJpYVRyZWVS b3dzKGFyaWFUcmVlUm93cyk7CisgICAgICAgIHNldE9iamVjdFZlY3RvclByb3BlcnR5KEFYUHJv cGVydHlOYW1lOjpBUklBVHJlZVJvd3MsIGFyaWFUcmVlUm93cyk7CisgICAgfQogCiAgICAgaWYg KG9iamVjdC5pc1RleHRDb250cm9sKCkpCiAgICAgICAgIHNldFByb3BlcnR5KEFYUHJvcGVydHlO YW1lOjpUZXh0TGVuZ3RoLCBvYmplY3QudGV4dExlbmd0aCgpKTsKQEAgLTMxMiwxNCArMzI2LDYg QEAgdm9pZCBBWElzb2xhdGVkT2JqZWN0Ojppbml0aWFsaXplQXR0cmlidXRlRGF0YShBWENvcmVP YmplY3QmIGNvcmVPYmplY3QsIGJvb2wgaXMKICAgICBvYmplY3QudGFiQ2hpbGRyZW4odGFiQ2hp bGRyZW4pOwogICAgIHNldE9iamVjdFZlY3RvclByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpUYWJD aGlsZHJlbiwgdGFiQ2hpbGRyZW4pOwogCi0gICAgQWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9y IGFyaWFUcmVlUm93czsKLSAgICBvYmplY3QuYXJpYVRyZWVSb3dzKGFyaWFUcmVlUm93cyk7Ci0g ICAgc2V0T2JqZWN0VmVjdG9yUHJvcGVydHkoQVhQcm9wZXJ0eU5hbWU6OkFSSUFUcmVlUm93cywg YXJpYVRyZWVSb3dzKTsKLQotICAgIEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciBhcmlhVHJl ZUl0ZW1Db250ZW50OwotICAgIG9iamVjdC5hcmlhVHJlZUl0ZW1Db250ZW50KGFyaWFUcmVlSXRl bUNvbnRlbnQpOwotICAgIHNldE9iamVjdFZlY3RvclByb3BlcnR5KEFYUHJvcGVydHlOYW1lOjpB UklBVHJlZUl0ZW1Db250ZW50LCBhcmlhVHJlZUl0ZW1Db250ZW50KTsKLQogICAgIEFjY2Vzc2li aWxpdHlDaGlsZHJlblZlY3RvciBsaW5rZWRVSUVsZW1lbnRzOwogICAgIG9iamVjdC5saW5rZWRV SUVsZW1lbnRzKGxpbmtlZFVJRWxlbWVudHMpOwogICAgIHNldE9iamVjdFZlY3RvclByb3BlcnR5 KEFYUHJvcGVydHlOYW1lOjpMaW5rZWRVSUVsZW1lbnRzLCBsaW5rZWRVSUVsZW1lbnRzKTsK