236976 2022-02-21 08:00:41 -0800 Ensure generated inline assembler that setups segments returns to previous state 2022-02-23 01:30:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=236506 InRadar P2 Normal --- 1 aperez aperez aperez ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1844211 0 aperez 2022-02-21 08:00:41 -0800 After fixing bug #236506 there are still a few locations which make use of inline assembler in C++ code explicitly setting the segment where to emit output without returning the assembler to its previous state. Let's get them fixed as well! 1844212 1 452735 aperez 2022-02-21 08:03:52 -0800 Created attachment 452735 Patch 1844387 2 452735 ysuzuki 2022-02-21 14:28:50 -0800 Comment on attachment 452735 Patch r=me 1845049 3 ews-feeder 2022-02-23 01:29:58 -0800 Committed r290359 (247677@main): <https://commits.webkit.org/247677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452735. 1845050 4 webkit-bug-importer 2022-02-23 01:30:23 -0800 <rdar://problem/89343981> 452735 2022-02-21 08:03:52 -0800 2022-02-23 01:29:59 -0800 Patch bug-236976-20220221180351.patch text/plain 3261 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm MWE3OGZkNjRkMzEwZjllNTIyOWI2Y2IzYjIwNDgwYzExOTAyMDYyLi45ODRlMDMwOWYxYWI0ZWVj YjkzM2Y2ZmU2YjEwMTIwMDFkNDE1Nzc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMi0wMi0yMSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIEVuc3VyZSBnZW5lcmF0ZWQgaW5saW5lIGFzc2VtYmxlciB0 aGF0IHNldHVwcyBzZWdtZW50cyByZXR1cm5zIHRvIHByZXZpb3VzIHN0YXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY5NzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgLnByZXZpb3VzIGluIGlu bGluZSBhc3NlbWJsZXIgaW4gb3JkZXIgdG8gZW5zdXJlIHRoYXQgbWl4ZWQgZW1pc3Npb24gb2Yg YXNzZW1ibGVyCisgICAgICAgIGZ1bmN0aW9ucyBhbmQgb3RoZXIgZGVmaW5pdGlvbnMgY29ycmVj dGx5IHB1dHMgZWFjaCBvZiB0aGVtIGluIHRoZWlyIHJpZ2h0ZnVsIHNlY3Rpb25zCisgICAgICAg IGluIHRoZSBvdXRwdXQgb2JqZWN0IGNvZGUuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJBUk02NC5jcHA6CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN djcuY3BwOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuY3BwOgorICAg ICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5jcHA6CisKIDIwMjItMDIt MTkgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJldmVydGluZyByMjkwMTk0IGFuZCByMjkwMjEwLgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5jcHAKaW5k ZXggZWU2NTEzM2Y3NmJmMWQzNTY4OWIyMTU4NWIxNzgzN2ViZmJiMzA1YS4uZjEwNTdmODZjNGEy N2Y3ZWRiMTlhZWI1YjViNTYwMzJkZTMyZGI3YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuY3BwCkBAIC01NzIsNiAr NTcyLDcgQEAgYXNtICgKICNlbHNlCiAgICAgInJldCIgIlxuIgogI2VuZGlmCisgICAgIi5wcmV2 aW91cyIgIlxuIgogKTsKICNlbmRpZiAvLyBDT01QSUxFUihHQ0NfQ09NUEFUSUJMRSkKIApkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TXY3LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk12Ny5jcHAKaW5kZXggYmM4ZTU1N2YxZTBhNTZmZGIyOTE5YTkyOWQ1MGJhYTczN2VjNWViMC4u Zjc1ZjRkMDk1NGRiNGYzNjMzOTFjMTllZGZiMjA2MTFmODk4YTk4NyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuY3Bw CkBAIC0zNjEsNiArMzYxLDcgQEAgYXNtICgKICAgICAvLyBSZXN0b3JlIHRoZSBzcCBhbmQgcGMu CiAgICAgImxkciAgICAgICBzcCwgW3NwLCAjIiBTVFJJTkdJWkVfVkFMVUVfT0YoUFJPQkVfQ1BV X1NQX09GRlNFVCkgIl0iICJcbiIKICAgICAicG9wICAgICAgIHsgcGMgfSIgIlxuIgorICAgICIu cHJldmlvdXMiICJcbiIKICk7CiAjZW5kaWYgLy8gQ09NUElMRVIoR0NDX0NPTVBBVElCTEUpCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJNSVBTLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJNSVBTLmNwcAppbmRleCBlYmVkN2M5MWYwMWJkYjM3MDM5MzYwOGU1MmU5NzdhYTM4ZTdiYzFh Li44ZTFlYmJhZDA0ZjcxZTk5NTgzNzJkMmJlMzZjYzk5OWY0MmFjMjJkIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuY3Bw CkBAIC01NDksNiArNTQ5LDcgQEAgYXNtICgKICAgICAianIgICAgICAgICRyYSIgIlxuIgogICAg ICJub3AiICJcbiIKICAgICAiLnNldCBwb3AiICJcbiIKKyAgICAiLnByZXZpb3VzIiAiXG4iCiAp OwogI2VuZGlmIC8vIENPTVBJTEVSKEdDQ19DT01QQVRJQkxFKQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24u Y3BwCmluZGV4IGZlYjg0MDJiZWRiNTVmZWZmZmQ2MWM5M2RkOWMyZjYzZDI5N2EwNzEuLjFlYjQy NTIyMzdkMjM4ZWI5OTFiZTA2OTllNjBkMTI2MDQ4YjNkYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24u Y3BwCkBAIC0zNDEsNiArMzQxLDcgQEAgYXNtICgKICAgICAicG9wbCAlZWN4IiAiXG4iCiAgICAg InBvcGwgJWVicCIgIlxuIgogICAgICJyZXQiICJcbiIKKyAgICAiLnByZXZpb3VzIiAiXG4iCiAp OwogI2VuZGlmCiAKQEAgLTcwOSw2ICs3MTAsNyBAQCBhc20gKAogICAgICJwb3BxICVyY3giICJc biIKICAgICAicG9wcSAlcmJwIiAiXG4iCiAgICAgInJldCIgIlxuIgorICAgICIucHJldmlvdXMi ICJcbiIKICk7CiAjZW5kaWYgLy8gQ09NUElMRVIoR0NDX0NPTVBBVElCTEUpCiAjZW5kaWYgLy8g Q1BVKFg4Nl82NCkK