236971 2022-02-21 06:01:40 -0800 [GTK][WPE] Suspend web process after some time in the process cache 2022-02-22 00:47:50 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1844177 0 cgarcia 2022-02-21 06:01:40 -0800 And resume them when they are restored 1844178 1 452728 cgarcia 2022-02-21 06:03:19 -0800 Created attachment 452728 Patch 1844199 2 452728 mcatanzaro 2022-02-21 07:40:48 -0800 Comment on attachment 452728 Patch What could go wrong? :) 1844201 3 452728 mcatanzaro 2022-02-21 07:43:26 -0800 Comment on attachment 452728 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452728&action=review > Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:81 > +void WebProcessProxy::platformSuspendProcess() > +{ > + auto id = processIdentifier(); > + if (!id) > + return; > + > + RELEASE_LOG(Process, "%p - [PID=%i] WebProcessProxy::platformSuspendProcess", this, id); > + kill(id, SIGSTOP); > +} Since there is nothing GTK/WPE-specific here, I think I would move this to a WebProcessProxyUnix.cpp and guard it with #if !PLATFORM(COCOA). Then instead of #if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE) guards, you would only need to use #if PLATFORM(MAC) || OS(UNIX) guards instead. Um, is OS(UNIX) true for PLATFORM(IOS_FAMILY)? I'm not sure. Got to be careful about that, if so. 1844585 4 cgarcia 2022-02-22 00:47:50 -0800 Committed r290291 (247615@trunk): <https://commits.webkit.org/247615@trunk> 452728 2022-02-21 06:03:19 -0800 2022-02-21 15:42:00 -0800 Patch wk-suspend-cached-process.diff text/plain 5782 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzZhYmRkNDhkZjNmLi43NDIyZjNlZTNhZmQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjMgQEAKKzIwMjItMDItMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gU3VzcGVuZCB3ZWIgcHJvY2VzcyBhZnRlciBz b21lIHRpbWUgaW4gdGhlIHByb2Nlc3MgY2FjaGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjk3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBwbGF0Zm9ybVN1c3BlbmRQcm9jZXNzKCkg YW5kIHBsYXRmb3JtUmVzdW1lUHJvY2VzcygpIGZvciBHVEsgYW5kIFdQRSBwb3J0cy4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzQ2FjaGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzQ2FjaGU6OmFkZFByb2Nlc3MpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNz Q2FjaGU6OkNhY2hlZFByb2Nlc3M6OkNhY2hlZFByb2Nlc3MpOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzQ2FjaGU6OkNhY2hlZFByb2Nlc3M6On5DYWNoZWRQcm9jZXNzKToKKyAgICAgICAg KFdlYktpdDo6V2ViUHJvY2Vzc0NhY2hlOjpDYWNoZWRQcm9jZXNzOjp0YWtlUHJvY2Vzcyk6Cisg ICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NDYWNoZS5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9XZWJQcm9jZXNzUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvZ2xpYi9XZWJQcm9jZXNz UHJveHlHTGliLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5OjpwbGF0Zm9y bVN1c3BlbmRQcm9jZXNzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5OjpwbGF0 Zm9ybVJlc3VtZVByb2Nlc3MpOgorCiAyMDIyLTAyLTE5ICBKb24gTGVlICA8am9ubGVlQGFwcGxl LmNvbT4KIAogICAgICAgICBUdXJuIFdlYkdMIGluIEdQVSBQcm9jZXNzIG9uIGJ5IGRlZmF1bHQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NDYWNoZS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzQ2FjaGUuY3BwCmluZGV4IGY0MTQx Yjk1Y2NhMC4uNTFmY2JlNjYzNDFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQcm9jZXNzQ2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBy b2Nlc3NDYWNoZS5jcHAKQEAgLTEzNyw3ICsxMzcsNyBAQCBib29sIFdlYlByb2Nlc3NDYWNoZTo6 YWRkUHJvY2VzcyhzdGQ6OnVuaXF1ZV9wdHI8Q2FjaGVkUHJvY2Vzcz4mJiBjYWNoZWRQcm9jZXNz KQogICAgICAgICBtX3Byb2Nlc3Nlc1BlclJlZ2lzdHJhYmxlRG9tYWluLnJlbW92ZShpdCk7CiAg ICAgfQogCi0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0o R1RLKSB8fCBQTEFURk9STShXUEUpCiAgICAgY2FjaGVkUHJvY2Vzcy0+c3RhcnRTdXNwZW5zaW9u VGltZXIoKTsKICNlbmRpZgogCkBAIC0yNzEsNyArMjcxLDcgQEAgdm9pZCBXZWJQcm9jZXNzQ2Fj aGU6OnJlbW92ZVByb2Nlc3MoV2ViUHJvY2Vzc1Byb3h5JiBwcm9jZXNzLCBTaG91bGRTaHV0RG93 blByb2MKIFdlYlByb2Nlc3NDYWNoZTo6Q2FjaGVkUHJvY2Vzczo6Q2FjaGVkUHJvY2VzcyhSZWY8 V2ViUHJvY2Vzc1Byb3h5PiYmIHByb2Nlc3MpCiAgICAgOiBtX3Byb2Nlc3MoV1RGTW92ZShwcm9j ZXNzKSkKICAgICAsIG1fZXZpY3Rpb25UaW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMsICZDYWNo ZWRQcm9jZXNzOjpldmljdGlvblRpbWVyRmlyZWQpCi0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBM QVRGT1JNKE1BQykgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpCiAgICAgLCBtX3N1 c3BlbnNpb25UaW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMsICZDYWNoZWRQcm9jZXNzOjpzdXNw ZW5zaW9uVGltZXJGaXJlZCkKICNlbmRpZgogewpAQCAtMjkwLDcgKzI5MCw3IEBAIFdlYlByb2Nl c3NDYWNoZTo6Q2FjaGVkUHJvY2Vzczo6fkNhY2hlZFByb2Nlc3MoKQogICAgIEFTU0VSVCghbV9w cm9jZXNzLT5wcm92aXNpb25hbFBhZ2VDb3VudCgpKTsKICAgICBBU1NFUlQoIW1fcHJvY2Vzcy0+ c3VzcGVuZGVkUGFnZUNvdW50KCkpOwogCi0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JN KE1BQykgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpCiAgICAgaWYgKGlzU3VzcGVu ZGVkKCkpCiAgICAgICAgIG1fcHJvY2Vzcy0+cGxhdGZvcm1SZXN1bWVQcm9jZXNzKCk7CiAjZW5k aWYKQEAgLTMwMiw3ICszMDIsNyBAQCBSZWY8V2ViUHJvY2Vzc1Byb3h5PiBXZWJQcm9jZXNzQ2Fj aGU6OkNhY2hlZFByb2Nlc3M6OnRha2VQcm9jZXNzKCkKIHsKICAgICBBU1NFUlQobV9wcm9jZXNz KTsKICAgICBtX2V2aWN0aW9uVGltZXIuc3RvcCgpOwotI2lmIFBMQVRGT1JNKE1BQykKKyNpZiBQ TEFURk9STShNQUMpIHx8IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQogICAgIGlmIChp c1N1c3BlbmRlZCgpKQogICAgICAgICBtX3Byb2Nlc3MtPnBsYXRmb3JtUmVzdW1lUHJvY2Vzcygp OwogICAgIGVsc2UKQEAgLTMxOCw3ICszMTgsNyBAQCB2b2lkIFdlYlByb2Nlc3NDYWNoZTo6Q2Fj aGVkUHJvY2Vzczo6ZXZpY3Rpb25UaW1lckZpcmVkKCkKICAgICBtX3Byb2Nlc3MtPnByb2Nlc3NQ b29sKCkud2ViUHJvY2Vzc0NhY2hlKCkucmVtb3ZlUHJvY2VzcygqbV9wcm9jZXNzLCBTaG91bGRT aHV0RG93blByb2Nlc3M6Olllcyk7CiB9CiAKLSNpZiBQTEFURk9STShNQUMpCisjaWYgUExBVEZP Uk0oTUFDKSB8fCBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkKIHZvaWQgV2ViUHJvY2Vz c0NhY2hlOjpDYWNoZWRQcm9jZXNzOjpzdGFydFN1c3BlbnNpb25UaW1lcigpCiB7CiAgICAgbV9z dXNwZW5zaW9uVGltZXIuc3RhcnRPbmVTaG90KGNhY2hlZFByb2Nlc3NTdXNwZW5zaW9uRGVsYXkp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc0NhY2hlLmgg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzQ2FjaGUuaAppbmRleCA1N2ZkOWIw YTEzYTYuLmQ3OWVlODU2MThhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUHJvY2Vzc0NhY2hlLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vz c0NhY2hlLmgKQEAgLTc0LDE5ICs3NCwxOSBAQCBwcml2YXRlOgogICAgICAgICBXZWJQcm9jZXNz UHJveHkmIHByb2Nlc3MoKSB7IEFTU0VSVChtX3Byb2Nlc3MpOyByZXR1cm4gKm1fcHJvY2Vzczsg fQogICAgICAgICB2b2lkIHN0YXJ0U3VzcGVuc2lvblRpbWVyKCk7CiAKLSNpZiBQTEFURk9STShN QUMpCisjaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkK ICAgICAgICAgYm9vbCBpc1N1c3BlbmRlZCgpIGNvbnN0IHsgcmV0dXJuICFtX3N1c3BlbnNpb25U aW1lci5pc0FjdGl2ZSgpOyB9CiAjZW5kaWYKIAogICAgIHByaXZhdGU6CiAgICAgICAgIHZvaWQg ZXZpY3Rpb25UaW1lckZpcmVkKCk7Ci0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKE1B QykgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpCiAgICAgICAgIHZvaWQgc3VzcGVu c2lvblRpbWVyRmlyZWQoKTsKICNlbmRpZgogCiAgICAgICAgIFJlZlB0cjxXZWJQcm9jZXNzUHJv eHk+IG1fcHJvY2VzczsKICAgICAgICAgUnVuTG9vcDo6VGltZXI8Q2FjaGVkUHJvY2Vzcz4gbV9l dmljdGlvblRpbWVyOwotI2lmIFBMQVRGT1JNKE1BQykKKyNpZiBQTEFURk9STShNQUMpIHx8IFBM QVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQogICAgICAgICBSdW5Mb29wOjpUaW1lcjxDYWNo ZWRQcm9jZXNzPiBtX3N1c3BlbnNpb25UaW1lcjsKICNlbmRpZgogICAgIH07CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuaCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5oCmluZGV4IDI1YWM3NWM1ZmJmOC4uOTFkMjFk MjgzNjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJv eHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuaApAQCAt NDIwLDcgKzQyMCw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgbWFya1Byb2Nlc3NBc1JlY2VudGx5 VXNlZCgpOwogCi0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZP Uk0oR1RLKSB8fCBQTEFURk9STShXUEUpCiAgICAgdm9pZCBwbGF0Zm9ybVN1c3BlbmRQcm9jZXNz KCk7CiAgICAgdm9pZCBwbGF0Zm9ybVJlc3VtZVByb2Nlc3MoKTsKICNlbmRpZgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ2xpYi9XZWJQcm9jZXNzUHJveHlHTGliLmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2dsaWIvV2ViUHJvY2Vzc1Byb3h5R0xpYi5jcHAKaW5k ZXggZDRmMzIzMjNjNWIzLi5jODA4NzM0MDZmODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2dsaWIvV2ViUHJvY2Vzc1Byb3h5R0xpYi5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvZ2xpYi9XZWJQcm9jZXNzUHJveHlHTGliLmNwcApAQCAtMjksOSArMjksMTEg QEAKICNpbmNsdWRlICJVc2VyTWVzc2FnZS5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3NQb29sLmgi CiAjaW5jbHVkZSAiV2Vic2l0ZURhdGFTdG9yZS5oIgotI2luY2x1ZGUgPFdlYkNvcmUvUGxhdGZv cm1EaXNwbGF5Lmg+CisjaW5jbHVkZSA8c2lnbmFsLmg+CisjaW5jbHVkZSA8c3lzL3R5cGVzLmg+ CiAjaW5jbHVkZSA8d3RmL0ZpbGVTeXN0ZW0uaD4KIAorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC02OCw0ICs3MCwyNCBAQCB2b2lkIFdlYlByb2Nl c3NQcm94eTo6c2VuZE1lc3NhZ2VUb1dlYkNvbnRleHQoVXNlck1lc3NhZ2UmJiBtZXNzYWdlKQog ICAgIHNlbmRNZXNzYWdlVG9XZWJDb250ZXh0V2l0aFJlcGx5KFdURk1vdmUobWVzc2FnZSksIFtd KFVzZXJNZXNzYWdlJiYpIHsgfSk7CiB9CiAKLX07Cit2b2lkIFdlYlByb2Nlc3NQcm94eTo6cGxh dGZvcm1TdXNwZW5kUHJvY2VzcygpCit7CisgICAgYXV0byBpZCA9IHByb2Nlc3NJZGVudGlmaWVy KCk7CisgICAgaWYgKCFpZCkKKyAgICAgICAgcmV0dXJuOworCisgICAgUkVMRUFTRV9MT0coUHJv Y2VzcywgIiVwIC0gW1BJRD0laV0gV2ViUHJvY2Vzc1Byb3h5OjpwbGF0Zm9ybVN1c3BlbmRQcm9j ZXNzIiwgdGhpcywgaWQpOworICAgIGtpbGwoaWQsIFNJR1NUT1ApOworfQorCit2b2lkIFdlYlBy b2Nlc3NQcm94eTo6cGxhdGZvcm1SZXN1bWVQcm9jZXNzKCkKK3sKKyAgICBhdXRvIGlkID0gcHJv Y2Vzc0lkZW50aWZpZXIoKTsKKyAgICBpZiAoIWlkKQorICAgICAgICByZXR1cm47CisKKyAgICBS RUxFQVNFX0xPRyhQcm9jZXNzLCAiJXAgLSBbUElEPSVpXSBXZWJQcm9jZXNzUHJveHk6OnBsYXRm b3JtUmVzdW1lUHJvY2VzcyIsIHRoaXMsIGlkKTsKKyAgICBraWxsKGlkLCBTSUdDT05UKTsKK30K KworfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==