23697 2009-02-02 14:01:12 -0800 Leaks seen on Worker tests 2009-02-02 22:40:01 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap levin oldest_to_newest 108034 0 ap 2009-02-02 14:01:12 -0800 See e.g. <http://build.webkit.org/results/trunk-mac-intel-debug/5945/DumpRenderTree2-leaks.txt>. I have a fix, patch forthcoming. 108036 1 27260 ap 2009-02-02 14:06:11 -0800 Created attachment 27260 proposed fix The issue turned out to be much simpler than I thought. 108038 2 levin 2009-02-02 14:31:28 -0800 Interesting. Looks good to me (but I'm not a reviewer so it doesn't matter). The key thing to note is that workerContextDestroyedInternal may get called due to a posted task before the worker object is destroyed. Then when the worker object is destroyed later, it should call workerContextDestroyedInternal(); to do the final clean up. One issue the comment in WorkerMessagingProxy::workerObjectDestroyed() workerContextDestroyedInternal(); // It never existed, just do our cleanup. isn't really accurate anymore. Really, the worker thread no longer exists at this point. 108040 3 27260 darin 2009-02-02 14:40:17 -0800 Comment on attachment 27260 proposed fix r=me 108087 4 ap 2009-02-02 22:40:01 -0800 Committed revision 40523. I've removed the obsolete comment - thanks Dave! 27260 2009-02-02 14:06:11 -0800 2009-02-02 14:40:17 -0800 proposed fix WorkerLeak.txt text/plain 1283 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDQ5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDItMDIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY5NworICAgICAgICBM ZWFrcyBzZWVuIG9uIFdvcmtlciB0ZXN0cworCisgICAgICAgICogZG9tL1dvcmtlck1lc3NhZ2lu Z1Byb3h5LmNwcDogKFdlYkNvcmU6Oldvcmtlck1lc3NhZ2luZ1Byb3h5Ojp3b3JrZXJDb250ZXh0 RGVzdHJveWVkSW50ZXJuYWwpOgorICAgICAgICBaZXJvIG91dCBtX3dvcmtlclRocmVhZCwgc28g dGhhdCB0aGUgcHJveHkgY291bGQgYmUgZGVsZXRlZCBvbmNlIHdvcmtlck9iamVjdERlc3Ryb3ll ZCgpCisgICAgICAgIGlzIGNhbGxlZC4KKwogMjAwOS0wMi0wMiAgR2VuZXZpZXZlIE1hayAgPGdl bkBzdGFpa29zLm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KSW5k ZXg6IFdlYkNvcmUvZG9tL1dvcmtlck1lc3NhZ2luZ1Byb3h5LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2RvbS9Xb3JrZXJNZXNzYWdpbmdQcm94eS5jcHAJKHJldmlzaW9uIDQwNDc1KQorKysg V2ViQ29yZS9kb20vV29ya2VyTWVzc2FnaW5nUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NzAsNiArMjcwLDcgQEAgdm9pZCBXb3JrZXJNZXNzYWdpbmdQcm94eTo6d29ya2VyQ29udGV4dAog ewogICAgIC8vIFdvcmtlckNvbnRleHREZXN0cm95ZWRUYXNrIGlzIGFsd2F5cyB0aGUgbGFzdCB0 byBiZSBwZXJmb3JtZWQsIHNvIHRoZSBwcm94eSBpcyBub3QgbmVlZGVkIGZvciBjb21tdW5pY2F0 aW9uCiAgICAgLy8gaW4gZWl0aGVyIHNpZGUgYW55IG1vcmUuIEhvd2V2ZXIsIHRoZSBXb3JrZXIg b2JqZWN0IG1heSBzdGlsbCBleGlzdCwgYW5kIGl0IGFzc3VtZXMgdGhhdCB0aGUgcHJveHkgZXhp c3RzLCB0b28uCisgICAgbV93b3JrZXJUaHJlYWQgPSAwOwogICAgIGlmICghbV93b3JrZXJPYmpl Y3QpCiAgICAgICAgIGRlbGV0ZSB0aGlzOwogfQo=