236962 2022-02-21 00:55:16 -0800 [GTK][WPE] ANGLE: make USE_ANGLE_WEBGL build option public 2022-02-21 06:32:44 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned alex annulen bugs-noreply clord ews-watchlist gyuyoung.kim ryuan.choi sergio zdobersek oldest_to_newest 1844142 0 cgarcia 2022-02-21 00:55:16 -0800 Since it introduces new dependencies, the build option should be public and a fatal error message should be shown when the option is enabled and any for the dependencies is missing. 1844143 1 452718 cgarcia 2022-02-21 00:56:35 -0800 Created attachment 452718 Patch 1844150 2 452718 clord 2022-02-21 01:49:40 -0800 Comment on attachment 452718 Patch LGTM. 1844188 3 ews-feeder 2022-02-21 06:32:39 -0800 Committed r290241 (247566@main): <https://commits.webkit.org/247566@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452718. 452718 2022-02-21 00:56:35 -0800 2022-02-21 06:32:41 -0800 Patch wk-angle.diff text/plain 4912 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxMWMwMWUyMjVlYzUuLmVi NmE3M2Y3MWE1YiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDIyLTAyLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEFOR0xFOiBtYWtlIFVTRV9BTkdMRV9XRUJH TCBidWlsZCBvcHRpb24gcHVibGljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzY5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW5jZSBpdCBpbnRyb2R1Y2VzIG5ldyBkZXBlbmRlbmNpZXMsIHRoZSBi dWlsZCBvcHRpb24gc2hvdWxkIGJlIHB1YmxpYyBhbmQgYSBmYXRhbCBlcnJvciBtZXNzYWdlIHNo b3VsZCBiZQorICAgICAgICBzaG93biB3aGVuIHRoZSBvcHRpb24gaXMgZW5hYmxlZCBhbmQgYW55 IGZvciB0aGUgZGVwZW5kZW5jaWVzIGlzIG1pc3NpbmcuCisKKyAgICAgICAgKiBTb3VyY2UvY21h a2UvT3B0aW9uc0dUSy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5j bWFrZToKKwogMjAyMi0wMi0yMCAgQnJhbmRvbiBTdGV3YXJ0ICA8YnJhbmRvbnN0ZXdhcnRAYXBw bGUuY29tPgogCiAgICAgICAgIEdlbmVyYXRlIGNvbXBpbGVfY29tbWFuZHMuanNvbiBvbiBtYWNP UyBCdWlsZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291 cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKaW5kZXggODkzN2I5NzVlMWY2Li45ZjdmYTA5ZDIz MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC02MCw2ICs2MCw3IEBAIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9KT1VSTkFMRF9MT0cgIldoZXRoZXIgdG8gZW5hYmxlIGpvdXJuYWxkIGxv Z2dpbmciIFBVCiBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfUVVBUlRaX1RBUkdFVCAiV2hl dGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgdGhlIFF1YXJ0eiB3aW5kb3dpbmcgdGFyZ2V0LiIg UFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dBWUxBTkRfVEFSR0VUICJX aGV0aGVyIHRvIGVuYWJsZSBzdXBwb3J0IGZvciB0aGUgV2F5bGFuZCB3aW5kb3dpbmcgdGFyZ2V0 LiIgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1gxMV9UQVJHRVQgIldo ZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIHRoZSBYMTEgd2luZG93aW5nIHRhcmdldC4iIFBV QkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGSU5FKFVTRV9BTkdMRV9XRUJHTCAiV2hldGhlciB0 byB1c2UgQU5HTEUgYXMgV2ViR0wgYmFja2VuZC4iIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9O X0RFRklORShVU0VfQVZJRiAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgQVZJRiBpbWFn ZXMuIiBQVUJMSUMgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKIFdFQktJVF9PUFRJ T05fREVGSU5FKFVTRV9HVEs0ICJXaGV0aGVyIHRvIGVuYWJsZSB1c2FnZSBvZiBHVEs0IGluc3Rl YWQgb2YgR1RLMy4iIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfSlBFR1hM ICJXaGV0aGVyIHRvIGVuYWJsZSBzdXBwb3J0IGZvciBKUEVHLVhMIGltYWdlcy4iIFBVQkxJQyAk e0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQpAQCAtNzUsNyArNzYsNiBAQCBXRUJLSVRf T1BUSU9OX0RFRklORShVU0VfV1BFX1JFTkRFUkVSICJXaGV0aGVyIHRvIGVuYWJsZSBXUEUgcmVu ZGVyaW5nIiBQVUJMSUMgTwogCiAjIFByaXZhdGUgb3B0aW9ucyBzcGVjaWZpYyB0byB0aGUgR1RL IHBvcnQuIENoYW5naW5nIHRoZXNlIG9wdGlvbnMgaXMKICMgY29tcGxldGVseSB1bnN1cHBvcnRl ZC4gVGhleSBhcmUgaW50ZW5kZWQgZm9yIHVzZSBvbmx5IGJ5IFdlYktpdCBkZXZlbG9wZXJzLgot V0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX0FOR0xFX1dFQkdMICJXaGV0aGVyIHRvIHVzZSBBTkdM RSBhcyBXZWJHTCBiYWNrZW5kLiIgUFJJVkFURSBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRklORShV U0VfQVRTUEkgIldoZXRoZXIgdG8gdXNlIHRoZSBBVFNQSSBhMTF5IGltcGxlbWVudGF0aW9uIGlu c3RlYWQgb2YgQVRLLiIgUFJJVkFURSBPTikKIAogV0VCS0lUX09QVElPTl9ERVBFTkQoRU5BQkxF XzNEX1RSQU5TRk9STVMgVVNFX09QRU5HTF9PUl9FUykKQEAgLTM4NCw4ICszODQsMTUgQEAgZW5k aWYgKCkKIGlmIChVU0VfQU5HTEVfV0VCR0wpCiAgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQo VVNFX0FOR0xFIFRSVUUpCiAKLSAgICBmaW5kX3BhY2thZ2UoR0JNIFJFUVVJUkVEKQotICAgIGZp bmRfcGFja2FnZShMaWJEUk0gUkVRVUlSRUQpCisgICAgZmluZF9wYWNrYWdlKEdCTSkKKyAgICBp ZiAoTk9UIEdCTV9GT1VORCkKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiR0JNIGlzIG5l ZWRlZCBmb3IgVVNFX0FOR0xFX1dFQkdMIikKKyAgICBlbmRpZiAoKQorCisgICAgZmluZF9wYWNr YWdlKExpYkRSTSkKKyAgICBpZiAoTk9UIExJQkRSTV9GT1VORCkKKyAgICAgICAgbWVzc2FnZShG QVRBTF9FUlJPUiAibGliZHJtIGlzIG5lZWRlZCBmb3IgVVNFX0FOR0xFX1dFQkdMIikKKyAgICBl bmRpZiAoKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9TUEVMTENIRUNLKQpkaWZmIC0tZ2l0IGEv U291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5j bWFrZQppbmRleCA1MDZlZmI3NzgwZTAuLjBiOTE5OGVhMTVlNSAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL09wdGlvbnNXUEUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21h a2UKQEAgLTc1LDYgKzc1LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX1dFQlhSIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVQKIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9HVEtET0MgIldoZXRoZXIgb3Igbm90IHRvIHVzZSBnZW5lcmF0ZSBn dGtkb2MuIiBQVUJMSUMgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0pPVVJOQUxE X0xPRyAiV2hldGhlciB0byBlbmFibGUgam91cm5hbGQgbG9nZ2luZyIgUFVCTElDIE9OKQogV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dQRV9RVF9BUEkgIldoZXRoZXIgdG8gZW5hYmxlIHN1 cHBvcnQgZm9yIHRoZSBRdDUvUU1MIHBsdWdpbiIgUFVCTElDICR7RU5BQkxFX0RFVkVMT1BFUl9N T0RFfSkKK1dFQktJVF9PUFRJT05fREVGSU5FKFVTRV9BTkdMRV9XRUJHTCAiV2hldGhlciB0byB1 c2UgQU5HTEUgYXMgV2ViR0wgYmFja2VuZC4iIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RF RklORShVU0VfQVZJRiAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgQVZJRiBpbWFnZXMu IiBQVUJMSUMgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKIFdFQktJVF9PUFRJT05f REVGSU5FKFVTRV9KUEVHWEwgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIEpQRUctWEwg aW1hZ2VzLiIgUFVCTElDICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiBXRUJLSVRf T1BUSU9OX0RFRklORShVU0VfTENNUyAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgaW1h Z2UgY29sb3IgbWFuYWdlbWVudCB1c2luZyBsaWJjbXMyLiIgUFVCTElDIE9OKQpAQCAtODUsNyAr ODYsNiBAQCBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfV09GRjIgIldoZXRoZXIgdG8gZW5hYmxl IHN1cHBvcnQgZm9yIFdPRkYyIFdlYiBGb250cy4iCiAjIFByaXZhdGUgb3B0aW9ucyBzcGVjaWZp YyB0byB0aGUgV1BFIHBvcnQuCiBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfR1NUUkVBTUVSX0hP TEVQVU5DSCAiV2hldGhlciB0byBlbmFibGUgR1N0cmVhbWVyIGhvbGVwdW5jaCIgUFJJVkFURSBP RkYpCiBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfRVhURVJOQUxfSE9MRVBVTkNIICJXaGV0aGVy IHRvIGVuYWJsZSBleHRlcm5hbCBob2xlcHVuY2giIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09QVElP Tl9ERUZJTkUoVVNFX0FOR0xFX1dFQkdMICJXaGV0aGVyIHRvIHVzZSBBTkdMRSBhcyBXZWJHTCBi YWNrZW5kLiIgUFJJVkFURSBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFUEVORChVU0VfQU5HTEVfV0VC R0wgRU5BQkxFX1dFQkdMKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX0FUU1BJICJXaGV0aGVy IHRvIHVzZSB0aGUgQVRTUEkgYTExeSBpbXBsZW1lbnRhdGlvbiBpbnN0ZWFkIG9mIEFUSy4iIFBS SVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfV0VCR0wyIFVTRV9BTkdMRV9X RUJHTCkKQEAgLTE3Nyw4ICsxNzcsMTUgQEAgZW5kaWYgKCkKIGlmIChVU0VfQU5HTEVfV0VCR0wp CiAgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX0FOR0xFIFRSVUUpCiAKLSAgICBmaW5k X3BhY2thZ2UoR0JNIFJFUVVJUkVEKQotICAgIGZpbmRfcGFja2FnZShMaWJEUk0gUkVRVUlSRUQp CisgICAgZmluZF9wYWNrYWdlKEdCTSkKKyAgICBpZiAoTk9UIEdCTV9GT1VORCkKKyAgICAgICAg bWVzc2FnZShGQVRBTF9FUlJPUiAiR0JNIGlzIG5lZWRlZCBmb3IgVVNFX0FOR0xFX1dFQkdMIikK KyAgICBlbmRpZiAoKQorCisgICAgZmluZF9wYWNrYWdlKExpYkRSTSkKKyAgICBpZiAoTk9UIExJ QkRSTV9GT1VORCkKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAibGliZHJtIGlzIG5lZWRl ZCBmb3IgVVNFX0FOR0xFX1dFQkdMIikKKyAgICBlbmRpZiAoKQogZW5kaWYgKCkKIAogaWYgKFVT RV9KUEVHWEwpCg==