236869 2022-02-18 16:11:58 -0800 [JSC] Make ArrayPrototype just an array 2022-06-23 16:54:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 236890 1 ysuzuki ysuzuki bfulgham commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1843693 0 ysuzuki 2022-02-18 16:11:58 -0800 [JSC] Make ArrayPrototype just an array 1843696 1 452598 ysuzuki 2022-02-18 16:13:09 -0800 Created attachment 452598 Patch 1843698 2 ysuzuki 2022-02-18 16:14:12 -0800 This makes RuntimeArray only DerivedArray. Once RuntimeArray is removed, we can just remove DerivedArray. 1843700 3 452599 ysuzuki 2022-02-18 16:16:29 -0800 Created attachment 452599 Patch 1843766 4 ysuzuki 2022-02-18 19:53:20 -0800 Committed r290194 (247522@trunk): <https://commits.webkit.org/247522@trunk> 1843767 5 webkit-bug-importer 2022-02-18 19:54:36 -0800 <rdar://problem/89178074> 1843864 6 ysuzuki 2022-02-19 09:52:10 -0800 Committed r290210 (?): <https://commits.webkit.org/r290210> 1843893 7 commit-queue 2022-02-19 13:13:23 -0800 Re-opened since this is blocked by bug 236890 1878020 8 bfulgham 2022-06-23 16:54:48 -0700 Closing this bug, as the optimization approach seemed to have some drawbacks. 452598 2022-02-18 16:13:09 -0800 2022-02-18 16:16:27 -0800 Patch bug-236869-20220218161308.patch text/plain 3415 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MmM3YzBlZTEyYmFmMGUwOTFhOGIzOGFjYzc0YTE2YjcwNDRmYTcyLi4zMWRiYWZmYzJkMDk1YTY0 MTgwZjY3MjhhOGI1MDhmNWY1OTEwZTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMi0wMi0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIE1ha2UgQXJyYXlQcm90b3R5cGUganVzdCBhbiBhcnJheQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2ODY5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3JpZ2luYWxseSwg QXJyYXlQcm90b3R5cGUgaGFzIHNsaWdodGx5IGRpZmZlcmVudCBtZW1vcnkgbGF5b3V0ICYgZGlm ZmVyZW50IGxvZ2ljIGV0Yy4KKyAgICAgICAgQnV0IG5vdywgaXQgaXMganVzdCBhbiBhcnJheSB3 aXRoIGEgbG90IG9mIHByb3BlcnRpZXMuIFdlIHNob3VsZCBqdXN0IG1ha2UgaXQgYW4gYXJyYXku CisKKyAgICAgICAgKiBydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6 QXJyYXlQcm90b3R5cGU6OmZpbmlzaENyZWF0aW9uKToKKyAgICAgICAgKiBydW50aW1lL0FycmF5 UHJvdG90eXBlLmg6CisKIDIwMjItMDItMTggIEJyYW5kb24gU3Rld2FydCAgPGJyYW5kb25zdGV3 YXJ0QGFwcGxlLmNvbT4KIAogICAgICAgICBHZW5lcmF0ZSBjb21waWxlX2NvbW1hbmRzLmpzb24g b24gbWFjT1MgQnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9BcnJheVByb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJh eVByb3RvdHlwZS5jcHAKaW5kZXggYmQ2NTY0YzZiNGM4ZjMxNzMzOGM5OTA4ODU0NDc2NTYwMWJm ZmE5NC4uMTJjODJlNmViZDRkYmE5NTU4NzVmNDU5NjI2N2YwZjlhODZmOGRlNCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcApAQCAtNTcs OCArNTcsNiBAQCBzdGF0aWMgSlNDX0RFQ0xBUkVfSE9TVF9GVU5DVElPTihhcnJheVByb3RvRnVu Y0xhc3RJbmRleE9mKTsKIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIEFycmF5 UHJvdG90eXBlIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotY29uc3QgQ2xhc3NJbmZv IEFycmF5UHJvdG90eXBlOjpzX2luZm8gPSB7IkFycmF5IiwgJkpTQXJyYXk6OnNfaW5mbywgbnVs bHB0ciwgbnVsbHB0ciwgQ1JFQVRFX01FVEhPRF9UQUJMRShBcnJheVByb3RvdHlwZSl9OwotCiBB cnJheVByb3RvdHlwZSogQXJyYXlQcm90b3R5cGU6OmNyZWF0ZShWTSYgdm0sIEpTR2xvYmFsT2Jq ZWN0KiBnbG9iYWxPYmplY3QsIFN0cnVjdHVyZSogc3RydWN0dXJlKQogewogICAgIEFycmF5UHJv dG90eXBlKiBwcm90b3R5cGUgPSBuZXcgKE5vdE51bGwsIGFsbG9jYXRlQ2VsbDxBcnJheVByb3Rv dHlwZT4odm0pKSBBcnJheVByb3RvdHlwZSh2bSwgc3RydWN0dXJlKTsKQEAgLTc2LDYgKzc0LDgg QEAgdm9pZCBBcnJheVByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtLCBKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0KQogewogICAgIEJhc2U6OmZpbmlzaENyZWF0aW9uKHZtKTsKICAg ICBBU1NFUlQoaW5oZXJpdHModm0sIGluZm8oKSkpOworICAgIEFTU0VSVChpbmZvKCkgPT0gSlNB cnJheTo6aW5mbygpKTsKKyAgICBBU1NFUlQodHlwZSgpID09IEFycmF5VHlwZSk7CiAKICAgICBw dXREaXJlY3RXaXRob3V0VHJhbnNpdGlvbih2bSwgdm0ucHJvcGVydHlOYW1lcy0+dG9TdHJpbmcs IGdsb2JhbE9iamVjdC0+YXJyYXlQcm90b1RvU3RyaW5nRnVuY3Rpb24oKSwgc3RhdGljX2Nhc3Q8 dW5zaWduZWQ+KFByb3BlcnR5QXR0cmlidXRlOjpEb250RW51bSkpOwogICAgIHB1dERpcmVjdFdp dGhvdXRUcmFuc2l0aW9uKHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5idWlsdGluTmFtZXMoKS52YWx1 ZXNQdWJsaWNOYW1lKCksIGdsb2JhbE9iamVjdC0+YXJyYXlQcm90b1ZhbHVlc0Z1bmN0aW9uKCks IHN0YXRpY19jYXN0PHVuc2lnbmVkPihQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udEVudW0pKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5oCmluZGV4IGQ2 ZDA4MTQ2MjQ5YjdhYzM3ZmRmODRmMTIyOGFmZDhlMjg5ZTNmMTguLmI5ODMzMDViYjgwYzNjZjc0 ZmVkZDE2YTJhNWZiYzMzMjEyMjc3OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvQXJyYXlQcm90b3R5cGUuaApAQCAtMjQsNiArMjQsOCBAQAogCiBuYW1lc3BhY2UgSlND IHsKIAorLy8gVGhpcyBpcyBhIHNpbXBsZSBKU0FycmF5LCBvbmx5IGluY2x1ZGluZyBzb21lIHNw ZWNpYWwgaW5pdGlhbGl6YXRpb24gc2VxdWVuY2UuCisvLyBXZSBtdXN0IG5vdCBoYXZlIHNwZWNp YWwgQXJyYXlQcm90b3R5cGU6OmluZm8uCiBjbGFzcyBBcnJheVByb3RvdHlwZSBmaW5hbCA6IHB1 YmxpYyBKU0FycmF5IHsKIHB1YmxpYzoKICAgICB1c2luZyBCYXNlID0gSlNBcnJheTsKQEAgLTM1 LDEyICszNywxMCBAQCBjbGFzcyBBcnJheVByb3RvdHlwZSBmaW5hbCA6IHB1YmxpYyBKU0FycmF5 IHsKICAgICB9OwogCiAgICAgc3RhdGljIEFycmF5UHJvdG90eXBlKiBjcmVhdGUoVk0mLCBKU0ds b2JhbE9iamVjdCosIFN0cnVjdHVyZSopOwotICAgICAgICAKLSAgICBERUNMQVJFX0VYUE9SVF9J TkZPOwogCiAgICAgc3RhdGljIFN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJlKFZNJiB2bSwgSlNH bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNWYWx1ZSBwcm90b3R5cGUpCiAgICAgewotICAg ICAgICByZXR1cm4gU3RydWN0dXJlOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCwgcHJvdG90eXBl LCBUeXBlSW5mbyhEZXJpdmVkQXJyYXlUeXBlLCBTdHJ1Y3R1cmVGbGFncyksIGluZm8oKSwgQXJy YXlDbGFzcyk7CisgICAgICAgIHJldHVybiBCYXNlOjpjcmVhdGVTdHJ1Y3R1cmUodm0sIGdsb2Jh bE9iamVjdCwgcHJvdG90eXBlLCBBcnJheUNsYXNzKTsKICAgICB9CiAKIHByaXZhdGU6Cg== 452599 2022-02-18 16:16:29 -0800 2022-02-22 21:08:20 -0800 Patch bug-236869-20220218161628.patch text/plain 3456 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MmM3YzBlZTEyYmFmMGUwOTFhOGIzOGFjYzc0YTE2YjcwNDRmYTcyLi4zMWRiYWZmYzJkMDk1YTY0 MTgwZjY3MjhhOGI1MDhmNWY1OTEwZTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMi0wMi0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIE1ha2UgQXJyYXlQcm90b3R5cGUganVzdCBhbiBhcnJheQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2ODY5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3JpZ2luYWxseSwg QXJyYXlQcm90b3R5cGUgaGFzIHNsaWdodGx5IGRpZmZlcmVudCBtZW1vcnkgbGF5b3V0ICYgZGlm ZmVyZW50IGxvZ2ljIGV0Yy4KKyAgICAgICAgQnV0IG5vdywgaXQgaXMganVzdCBhbiBhcnJheSB3 aXRoIGEgbG90IG9mIHByb3BlcnRpZXMuIFdlIHNob3VsZCBqdXN0IG1ha2UgaXQgYW4gYXJyYXku CisKKyAgICAgICAgKiBydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6 QXJyYXlQcm90b3R5cGU6OmZpbmlzaENyZWF0aW9uKToKKyAgICAgICAgKiBydW50aW1lL0FycmF5 UHJvdG90eXBlLmg6CisKIDIwMjItMDItMTggIEJyYW5kb24gU3Rld2FydCAgPGJyYW5kb25zdGV3 YXJ0QGFwcGxlLmNvbT4KIAogICAgICAgICBHZW5lcmF0ZSBjb21waWxlX2NvbW1hbmRzLmpzb24g b24gbWFjT1MgQnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9BcnJheVByb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJh eVByb3RvdHlwZS5jcHAKaW5kZXggYmQ2NTY0YzZiNGM4ZjMxNzMzOGM5OTA4ODU0NDc2NTYwMWJm ZmE5NC4uMTJjODJlNmViZDRkYmE5NTU4NzVmNDU5NjI2N2YwZjlhODZmOGRlNCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcApAQCAtNTcs OCArNTcsNiBAQCBzdGF0aWMgSlNDX0RFQ0xBUkVfSE9TVF9GVU5DVElPTihhcnJheVByb3RvRnVu Y0xhc3RJbmRleE9mKTsKIAogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIEFycmF5 UHJvdG90eXBlIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotY29uc3QgQ2xhc3NJbmZv IEFycmF5UHJvdG90eXBlOjpzX2luZm8gPSB7IkFycmF5IiwgJkpTQXJyYXk6OnNfaW5mbywgbnVs bHB0ciwgbnVsbHB0ciwgQ1JFQVRFX01FVEhPRF9UQUJMRShBcnJheVByb3RvdHlwZSl9OwotCiBB cnJheVByb3RvdHlwZSogQXJyYXlQcm90b3R5cGU6OmNyZWF0ZShWTSYgdm0sIEpTR2xvYmFsT2Jq ZWN0KiBnbG9iYWxPYmplY3QsIFN0cnVjdHVyZSogc3RydWN0dXJlKQogewogICAgIEFycmF5UHJv dG90eXBlKiBwcm90b3R5cGUgPSBuZXcgKE5vdE51bGwsIGFsbG9jYXRlQ2VsbDxBcnJheVByb3Rv dHlwZT4odm0pKSBBcnJheVByb3RvdHlwZSh2bSwgc3RydWN0dXJlKTsKQEAgLTc2LDYgKzc0LDgg QEAgdm9pZCBBcnJheVByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtLCBKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0KQogewogICAgIEJhc2U6OmZpbmlzaENyZWF0aW9uKHZtKTsKICAg ICBBU1NFUlQoaW5oZXJpdHModm0sIGluZm8oKSkpOworICAgIEFTU0VSVChpbmZvKCkgPT0gSlNB cnJheTo6aW5mbygpKTsKKyAgICBBU1NFUlQodHlwZSgpID09IEFycmF5VHlwZSk7CiAKICAgICBw dXREaXJlY3RXaXRob3V0VHJhbnNpdGlvbih2bSwgdm0ucHJvcGVydHlOYW1lcy0+dG9TdHJpbmcs IGdsb2JhbE9iamVjdC0+YXJyYXlQcm90b1RvU3RyaW5nRnVuY3Rpb24oKSwgc3RhdGljX2Nhc3Q8 dW5zaWduZWQ+KFByb3BlcnR5QXR0cmlidXRlOjpEb250RW51bSkpOwogICAgIHB1dERpcmVjdFdp dGhvdXRUcmFuc2l0aW9uKHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5idWlsdGluTmFtZXMoKS52YWx1 ZXNQdWJsaWNOYW1lKCksIGdsb2JhbE9iamVjdC0+YXJyYXlQcm90b1ZhbHVlc0Z1bmN0aW9uKCks IHN0YXRpY19jYXN0PHVuc2lnbmVkPihQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udEVudW0pKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5oCmluZGV4IGQ2 ZDA4MTQ2MjQ5YjdhYzM3ZmRmODRmMTIyOGFmZDhlMjg5ZTNmMTguLjg3Njk3MzVhZTczZGZkOTZh M2Y5NTk3ZGI2YTVlMzYyNTM2MTg5NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvQXJyYXlQcm90b3R5cGUuaApAQCAtMjQsMjMgKzI0LDE3IEBACiAKIG5hbWVzcGFjZSBK U0MgewogCisvLyBUaGlzIGlzIGEgc2ltcGxlIEpTQXJyYXksIG9ubHkgaW5jbHVkaW5nIHNvbWUg c3BlY2lhbCBpbml0aWFsaXphdGlvbiBzZXF1ZW5jZS4KKy8vIFdlIG11c3Qgbm90IGhhdmUgc3Bl Y2lhbCBBcnJheVByb3RvdHlwZTo6aW5mby4KIGNsYXNzIEFycmF5UHJvdG90eXBlIGZpbmFsIDog cHVibGljIEpTQXJyYXkgewogcHVibGljOgogICAgIHVzaW5nIEJhc2UgPSBKU0FycmF5OwogCi0g ICAgZW51bSBjbGFzcyBTcGVjaWVzV2F0Y2hwb2ludFN0YXR1cyB7Ci0gICAgICAgIFVuaW5pdGlh bGl6ZWQsCi0gICAgICAgIEluaXRpYWxpemVkLAotICAgICAgICBGaXJlZAotICAgIH07Ci0KICAg ICBzdGF0aWMgQXJyYXlQcm90b3R5cGUqIGNyZWF0ZShWTSYsIEpTR2xvYmFsT2JqZWN0KiwgU3Ry dWN0dXJlKik7Ci0gICAgICAgIAotICAgIERFQ0xBUkVfRVhQT1JUX0lORk87CiAKICAgICBzdGF0 aWMgU3RydWN0dXJlKiBjcmVhdGVTdHJ1Y3R1cmUoVk0mIHZtLCBKU0dsb2JhbE9iamVjdCogZ2xv YmFsT2JqZWN0LCBKU1ZhbHVlIHByb3RvdHlwZSkKICAgICB7Ci0gICAgICAgIHJldHVybiBTdHJ1 Y3R1cmU6OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0LCBwcm90b3R5cGUsIFR5cGVJbmZvKERlcml2 ZWRBcnJheVR5cGUsIFN0cnVjdHVyZUZsYWdzKSwgaW5mbygpLCBBcnJheUNsYXNzKTsKKyAgICAg ICAgcmV0dXJuIEJhc2U6OmNyZWF0ZVN0cnVjdHVyZSh2bSwgZ2xvYmFsT2JqZWN0LCBwcm90b3R5 cGUsIEFycmF5Q2xhc3MpOwogICAgIH0KIAogcHJpdmF0ZToK