236859 2022-02-18 13:03:44 -0800 [Tools] Sanitizer builds should obey `set-webkit-configuration --force-optimization-level` 2022-02-18 23:20:53 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 205787 1 ddkilzer ddkilzer aakash_jain bfulgham emw ews-watchlist jbedard mark.lam saam tuomas.webkit webkit-bug-importer oldest_to_newest 1843590 0 ddkilzer 2022-02-18 13:03:44 -0800 Sanitizer builds should obey `set-webkit-configuration --force-optimization-level` when set. The reason it doesn't currently work that a command-line Xcode variable won't override the same variable from an xcconfig file specified on the command-line. 1843591 1 webkit-bug-importer 2022-02-18 13:04:17 -0800 <rdar://problem/89161649> 1843611 2 452571 ddkilzer 2022-02-18 13:24:24 -0800 Created attachment 452571 Patch v1 1843613 3 452571 ddkilzer 2022-02-18 13:27:45 -0800 Comment on attachment 452571 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=452571&action=review > Tools/sanitizer/sanitizer.xcconfig:12 > +WK_OVERRIDE_OPTIMIZATION_LEVEL = $(WK_NOT_$(WK_EMPTY_$(WK_FORCE_OPTIMIZATION_LEVEL))); > + > +GCC_OPTIMIZATION_LEVEL = $(GCC_OPTIMIZATION_LEVEL_OVERRIDE_$(WK_OVERRIDE_OPTIMIZATION_LEVEL)); > +GCC_OPTIMIZATION_LEVEL_OVERRIDE_YES = $(WK_FORCE_OPTIMIZATION_LEVEL); > +GCC_OPTIMIZATION_LEVEL_OVERRIDE_NO = $(GCC_OPTIMIZATION_LEVEL_OVERRIDE_NO_$(CONFIGURATION)); > +GCC_OPTIMIZATION_LEVEL_OVERRIDE_NO_Debug = 0; > +GCC_OPTIMIZATION_LEVEL_OVERRIDE_NO_Production = 1; > +GCC_OPTIMIZATION_LEVEL_OVERRIDE_NO_Release = 1; I could copy this code into every `Base.xcconfig` file if we wanted to simplify the the `webkitdirs.pm` change to only set `WK_FORCE_OPTIMIZATION_LEVEL`, but I wasn't sure it was worth the extra complexity. One advantage to making that change is that it makes it slightly clearer when the optimization level is being overridden, though you can still tell by noticing when `GCC_OPTIMIZATION_LEVEL` is set on the xcodebuild command-line. 1843716 4 452571 bfulgham 2022-02-18 16:40:52 -0800 Comment on attachment 452571 Patch v1 I think this looks good as-is. We can consider moving things to Base.xcconfig if we need to do this elsewhere. 1843730 5 aakash_jain 2022-02-18 16:56:40 -0800 Cancelled https://ews-build.webkit.org/#/builders/70/builds/736 to speed up mac-wk2 queue. It already finished running layout-tests and the failures were pre-existing. 1843807 6 ews-feeder 2022-02-18 23:20:50 -0800 Committed r290199 (247527@main): <https://commits.webkit.org/247527@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452571. 452571 2022-02-18 13:24:24 -0800 2022-02-18 23:20:52 -0800 Patch v1 bug-236859-20220218132423.patch text/plain 5139 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMTUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTQ4MTg5MjY4MWQ4NzZlM2IyMTEyZTY4NjJiYjRjMGVk N2ZkNmU5Ni4uZTc4ZWM5MTkwYzJmOWM3ZWFlNmY5MTBiNTM2YWI4MmViNmUxOGJkZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQw IEBACisyMDIyLTAyLTE4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgW1Rvb2xzXSBTYW5pdGl6ZXIgYnVpbGRzIHNob3VsZCBvYmV5IGBzZXQtd2Via2l0LWNv bmZpZ3VyYXRpb24gLS1mb3JjZS1vcHRpbWl6YXRpb24tbGV2ZWxgCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8yMzY4NTk+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTE2MTY0OT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKFhjb2RlT3B0aW9ucyk6CisgICAgICAgIC0gUGFz cyBXS19GT1JDRV9PUFRJTUlaQVRJT05fTEVWRUwgaW5zdGVhZCBvZgorICAgICAgICAgIEdDQ19P UFRJTUlaQVRJT05fTEVWRUwgaWYgc2FuaXRpemVycyBhcmUgZW5hYmxlZCBzbyB0aGUKKyAgICAg ICAgICBvcHRpbWl6YXRpb24gbGV2ZWwgY2FuIGJlIG92ZXJyaWRkZW4gaW4gc2FuaXRpemVyLnhj Y29uZmlnLgorCisgICAgICAgICogc2FuaXRpemVyL2FzYW4ueGNjb25maWc6CisgICAgICAgIChX S19OT1RfKTogUmVtb3ZlLgorICAgICAgICAoV0tfTk9UX1lFUyk6IFJlbW92ZS4KKyAgICAgICAg LSBNb3ZlIHZhcmlhYmxlcyB0byBzYW5pdGl6ZXIueGNjb25maWcuCisKKyAgICAgICAgKiBzYW5p dGl6ZXIvc2FuaXRpemVyLnhjY29uZmlnOgorICAgICAgICAoV0tfRU1QVFlfKTogQWRkLgorICAg ICAgICAoV0tfTk9UXyk6IEFkZC4KKyAgICAgICAgKFdLX05PVF9ZRVMpOiBBZGQuCisgICAgICAg IC0gQWRkIHV0aWxpdHkgdmFyaWFibGVzIG9yaWdpbmFsbHkgZnJvbSBTREtWYXJpYW50LnhjY29u ZmlnLgorICAgICAgICAoV0tfT1ZFUlJJREVfT1BUSU1JWkFUSU9OX0xFVkVMKTogQWRkLgorICAg ICAgICAtIFNldCB0byBZRVMvTk8gZGVwZW5kaW5nIG9uIHdoZXRoZXIgV0tfRk9SQ0VfT1BUSU1J WkFUSU9OX0xFVkVMCisgICAgICAgICAgaXMgc2V0LgorICAgICAgICAoR0NDX09QVElNSVpBVElP Tl9MRVZFTCk6CisgICAgICAgIChHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMX09WRVJSSURFX1lFUyk6 IEFkZC4KKyAgICAgICAgKEdDQ19PUFRJTUlaQVRJT05fTEVWRUxfT1ZFUlJJREVfTk8pOiBBZGQu CisgICAgICAgIChHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMX09WRVJSSURFX05PX0RlYnVnKTogUmVu YW1lIGZyb20gR0NDX09QVElNSVpBVElPTl9MRVZFTF9EZWJ1Zy4KKyAgICAgICAgKEdDQ19PUFRJ TUlaQVRJT05fTEVWRUxfT1ZFUlJJREVfTk9fUHJvZHVjdGlvbik6IFJlbmFtZSBmcm9tIEdDQ19P UFRJTUlaQVRJT05fTEVWRUxfUHJvZHVjdGlvbi4KKyAgICAgICAgKEdDQ19PUFRJTUlaQVRJT05f TEVWRUxfT1ZFUlJJREVfTk9fUmVsZWFzZSk6IFJlbmFtZSBmcm9tIEdDQ19PUFRJTUlaQVRJT05f TEVWRUxfUmVsZWFzZS4KKyAgICAgICAgLSBNYWtlIHVzZSBvZiBXS19PVkVSUklERV9PUFRJTUla QVRJT05fTEVWRUwgYW5kCisgICAgICAgICAgV0tfRk9SQ0VfT1BUSU1JWkFUSU9OX0xFVkVMIHRv IGFsbG93IG92ZXJyaWRpbmcgdGhlIGRlZmF1bHQKKyAgICAgICAgICBvcHRpbWl6YXRpb24gbGV2 ZWwgZm9yIHNhbml0aXplciBidWlsZHMuCisKIDIwMjItMDItMTggIEJyYW5kb24gU3Rld2FydCAg PGJyYW5kb25zdGV3YXJ0QGFwcGxlLmNvbT4KIAogICAgICAgICBHZW5lcmF0ZSBjb21waWxlX2Nv bW1hbmRzLmpzb24gb24gbWFjT1MgQnVpbGRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZDU2MDRiMzg0 NGY2ZTYwMWE4MGM0NzMzZGNiNGE2NTkxNGQwNzMyMC4uYzQzMTdlMjllOGI4M2JhNWE0OWJmYjNh YTA3ZTkwOTU4YWE5NTM1NyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTAzMiw3ICsxMDMyLDE0IEBA IHN1YiBYY29kZU9wdGlvbnMKICAgICAgICAgcHVzaCBAb3B0aW9ucywgKCIteGNjb25maWciLCBG aWxlOjpTcGVjLT5jYXRmaWxlKHNvdXJjZURpcigpLCAiVG9vbHMiLCAic2FuaXRpemVyIiwgInVi c2FuLnhjY29uZmlnIikpOwogICAgIH0KICAgICBwdXNoIEBvcHRpb25zLCBYY29kZUNvdmVyYWdl U3VwcG9ydE9wdGlvbnMoKSBpZiAkY292ZXJhZ2VJc0VuYWJsZWQ7Ci0gICAgcHVzaCBAb3B0aW9u cywgKCJHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMPSRmb3JjZU9wdGltaXphdGlvbkxldmVsIikgaWYg JGZvcmNlT3B0aW1pemF0aW9uTGV2ZWw7CisgICAgaWYgKCRmb3JjZU9wdGltaXphdGlvbkxldmVs KSB7CisgICAgICAgIGlmICgkYXNhbklzRW5hYmxlZCB8fCAkdHNhbklzRW5hYmxlZCB8fCAkdWJz YW5Jc0VuYWJsZWQpIHsKKyAgICAgICAgICAgICMgQ29tbWFuZC1saW5lIFhjb2RlIHZhcmlhYmxl IHdvbid0IG92ZXJyaWRlIHRoYXQgc2FtZSB2YXJpYmxlIHNldCBpbiBhIGNvbW1hbmQtbGluZSB4 Y2NvbmZpZyBmaWxlLgorICAgICAgICAgICAgcHVzaCBAb3B0aW9ucywgIldLX0ZPUkNFX09QVElN SVpBVElPTl9MRVZFTD0kZm9yY2VPcHRpbWl6YXRpb25MZXZlbCI7CisgICAgICAgIH0gZWxzZSB7 CisgICAgICAgICAgICBwdXNoIEBvcHRpb25zLCAiR0NDX09QVElNSVpBVElPTl9MRVZFTD0kZm9y Y2VPcHRpbWl6YXRpb25MZXZlbCI7CisgICAgICAgIH0KKyAgICB9CiAgICAgcHVzaCBAb3B0aW9u cywgIldLX0xUT19NT0RFPSRsdG9Nb2RlIiBpZiAkbHRvTW9kZTsKICAgICBwdXNoIEBvcHRpb25z LCBAYmFzZVByb2R1Y3REaXJPcHRpb247CiAgICAgcHVzaCBAb3B0aW9ucywgIkFSQ0hTPSRhcmNo aXRlY3R1cmUiIGlmICRhcmNoaXRlY3R1cmU7CmRpZmYgLS1naXQgYS9Ub29scy9zYW5pdGl6ZXIv YXNhbi54Y2NvbmZpZyBiL1Rvb2xzL3Nhbml0aXplci9hc2FuLnhjY29uZmlnCmluZGV4IDk5YmU4 ZjFiZThjMmRjYzRlNTUyOTM3MDA3M2ZhMDdhMTExOTcwZTEuLjZkNjA1ZGM1ODIzNWQyNDgwYzM4 NTdhOWUxYWJmMWY2ZWQwZjQ4MDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3Nhbml0aXplci9hc2FuLnhj Y29uZmlnCisrKyBiL1Rvb2xzL3Nhbml0aXplci9hc2FuLnhjY29uZmlnCkBAIC0xMyw5ICsxMyw2 IEBAIFdLX0FERFJFU1NfU0FOSVRJWkVSX09USEVSX0NQTFVTUExVU0ZMQUdTX1lFUyA9IC1VX0xJ QkNQUF9IQVNfTk9fQVNBTjsKIC8vIFVwZGF0ZSBhZnRlciA8cmRhcjovLzg3NjEzOTA4PiBpcyBm aXhlZC4KIFdLX05FRURTX0FTQU5fVVNFX0FGVEVSX1NDT1BFX1dPUktBUk9VTkRfRk9SX2JtYWxs b2NfWUVTID0gLURXS19XT1JLQVJPVU5EX1JEQVJfODc2MTM5MDhfQVNBTl9TVEFDS19VU0VfQUZU RVJfU0NPUEU7CiAKLVdLX05PVF8gPSBZRVM7Ci1XS19OT1RfWUVTID0gTk87Ci0KIFdLX05FRURT X0FTQU5fVVNFX0FGVEVSX1NDT1BFX1dPUktBUk9VTkQgPSAkKFdLX05PVF8kKFdLX1hDT0RFX1ZF UlNJT05fQkVGT1JFXzEzXzNfJChYQ09ERV9WRVJTSU9OX01BSk9SKSkpOwogCiBXS19YQ09ERV9W RVJTSU9OX0JFRk9SRV8xM18zXzA4MDAgPSBZRVM7CmRpZmYgLS1naXQgYS9Ub29scy9zYW5pdGl6 ZXIvc2FuaXRpemVyLnhjY29uZmlnIGIvVG9vbHMvc2FuaXRpemVyL3Nhbml0aXplci54Y2NvbmZp ZwppbmRleCAyMTE3MjJkYzJhNGVkNzdhNmI0NmU2OWM0NWRmMGM3NjA4OWIyODc1Li5hZGVmZWYz Nzg3YzgxMjg5YjZhN2E4MzA2MWJiNzFkNmM0YTczZDJjIDEwMDY0NAotLS0gYS9Ub29scy9zYW5p dGl6ZXIvc2FuaXRpemVyLnhjY29uZmlnCisrKyBiL1Rvb2xzL3Nhbml0aXplci9zYW5pdGl6ZXIu eGNjb25maWcKQEAgLTEsNyArMSwxNSBAQAotR0NDX09QVElNSVpBVElPTl9MRVZFTCA9ICQoR0ND X09QVElNSVpBVElPTl9MRVZFTF8kKENPTkZJR1VSQVRJT04pKTsKLUdDQ19PUFRJTUlaQVRJT05f TEVWRUxfRGVidWcgPSAwOwotR0NDX09QVElNSVpBVElPTl9MRVZFTF9Qcm9kdWN0aW9uID0gMTsK LUdDQ19PUFRJTUlaQVRJT05fTEVWRUxfUmVsZWFzZSA9IDE7CitXS19FTVBUWV8gPSBZRVM7CitX S19OT1RfID0gWUVTOworV0tfTk9UX1lFUyA9IE5POworCitXS19PVkVSUklERV9PUFRJTUlaQVRJ T05fTEVWRUwgPSAkKFdLX05PVF8kKFdLX0VNUFRZXyQoV0tfRk9SQ0VfT1BUSU1JWkFUSU9OX0xF VkVMKSkpOworCitHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMID0gJChHQ0NfT1BUSU1JWkFUSU9OX0xF VkVMX09WRVJSSURFXyQoV0tfT1ZFUlJJREVfT1BUSU1JWkFUSU9OX0xFVkVMKSk7CitHQ0NfT1BU SU1JWkFUSU9OX0xFVkVMX09WRVJSSURFX1lFUyA9ICQoV0tfRk9SQ0VfT1BUSU1JWkFUSU9OX0xF VkVMKTsKK0dDQ19PUFRJTUlaQVRJT05fTEVWRUxfT1ZFUlJJREVfTk8gPSAkKEdDQ19PUFRJTUla QVRJT05fTEVWRUxfT1ZFUlJJREVfTk9fJChDT05GSUdVUkFUSU9OKSk7CitHQ0NfT1BUSU1JWkFU SU9OX0xFVkVMX09WRVJSSURFX05PX0RlYnVnID0gMDsKK0dDQ19PUFRJTUlaQVRJT05fTEVWRUxf T1ZFUlJJREVfTk9fUHJvZHVjdGlvbiA9IDE7CitHQ0NfT1BUSU1JWkFUSU9OX0xFVkVMX09WRVJS SURFX05PX1JlbGVhc2UgPSAxOwogCiBPVEhFUl9DRkxBR1MgPSAkKGluaGVyaXRlZCkgLWZuby1v bWl0LWZyYW1lLXBvaW50ZXIgLWcgJChXS19BRERSRVNTX1NBTklUSVpFUl9PVEhFUl9DRkxBR1Nf JChXS19FTkFCTEVfQUREUkVTU19TQU5JVElaRVIpKSAkKFdLX1VOREVGSU5FRF9CRUhBVklPUl9T QU5JVElaRVJfT1RIRVJfQ0ZMQUdTXyQoV0tfRU5BQkxFX1VOREVGSU5FRF9CRUhBVklPUl9TQU5J VElaRVIpKTsKIE9USEVSX0NQTFVTUExVU0ZMQUdTID0gJChpbmhlcml0ZWQpICQoV0tfQUREUkVT U19TQU5JVElaRVJfT1RIRVJfQ1BMVVNQTFVTRkxBR1NfJChXS19FTkFCTEVfQUREUkVTU19TQU5J VElaRVIpKTsK