236858 2022-02-18 12:58:28 -0800 Ensure layer has backing during traversal 2023-03-24 14:02:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=253503 InRadar P2 Normal --- 1 brandonstewart webkit-unassigned bfulgham changseok esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1843583 0 brandonstewart 2022-02-18 12:58:28 -0800 <rdar://88329753> 1843593 1 452568 brandonstewart 2022-02-18 13:05:51 -0800 Created attachment 452568 Patch 1844312 2 452568 simon.fraser 2022-02-21 12:05:24 -0800 Comment on attachment 452568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452568&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3462 > + if (!ancestorLayer.backing()) This should test isComposited(). 1844318 3 452754 brandonstewart 2022-02-21 12:19:06 -0800 Created attachment 452754 Patch 1844527 4 ews-feeder 2022-02-21 19:58:59 -0800 Committed r290285 (247609@main): <https://commits.webkit.org/247609@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452754. 452568 2022-02-18 13:05:51 -0800 2022-02-21 12:19:03 -0800 Patch bug-236858-20220218130550.patch text/plain 1594 brandonstewart U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI2YjRhMGMzNGJlODRl MzI4ZTQwZDI1NjBiYjg2MzQzOTkwODQ1Yi4uYzEwOGNkNDE5NzdjNTg3NjA4OTEwYWE5ZjI2YzI5 MWRhNmYxN2MzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTE4ICBCcmFu ZG9uIFN0ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJl IGxheWVyIGhhcyBiYWNraW5nIGR1cmluZyB0cmF2ZXJzYWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjg1OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3VyZSB0aGUgbGF5ZXIgaGFzIGEgYmFja2lu ZyBhdHRhY2hlZCB0byBpdCBiZWZvcmUgdHJ5aW5nIHRvIGFwcGVuZAorICAgICAgICB0aGUgbm9k ZSBpZC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y29sbGVjdFN0YXRpb25hcnlMYXllclJlbGF0ZWRPdmVyZmxvd05v ZGVzKToKKwogMjAyMi0wMi0xNyAgTWF0dCBXb29kcm93ICA8bWF0dHdvb2Ryb3dAYXBwbGUuY29t PgogCiAgICAgICAgIEZpeCBhYnMtcG9zIGJyZWFkdGggaXNzdWUgd2hlbiB1c2luZyAnYXV0bycK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0 b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAKaW5kZXggMGJlMDM5YTBmMjNkNTdmZjdmNTdkOTkwOWI2NTM3NWEwMjQyNDNiNC4uZDVjZjZi Yjc4ZTlhODQ0MmI0YjAyOTY3ZDM5OTlmZTBkZTJhZTYyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTM0NTksNiArMzQ1 OSw5IEBAIHN0YXRpYyB2b2lkIGNvbGxlY3RTdGF0aW9uYXJ5TGF5ZXJSZWxhdGVkT3ZlcmZsb3dO b2Rlcyhjb25zdCBSZW5kZXJMYXllciYgbGF5ZXIsCiAgICAgICAgIGlmIChpc0NvbnRhaW5pbmdC bG9ja0NoYWluICYmIGlzUGFpbnRPcmRlckFuY2VzdG9yKQogICAgICAgICAgICAgcmV0dXJuIEFu Y2VzdG9yVHJhdmVyc2FsOjpTdG9wOwogCisgICAgICAgIGlmICghYW5jZXN0b3JMYXllci5iYWNr aW5nKCkpCisgICAgICAgICAgICByZXR1cm4gQW5jZXN0b3JUcmF2ZXJzYWw6OlN0b3A7CisKICAg ICAgICAgaWYgKHNlZW5QYWludE9yZGVyQW5jZXN0b3IgJiYgIWlzQ29udGFpbmluZ0Jsb2NrQ2hh aW4gJiYgYW5jZXN0b3JMYXllci5oYXNDb21wb3NpdGVkU2Nyb2xsYWJsZU92ZXJmbG93KCkpCiAg ICAgICAgICAgICBhcHBlbmRPdmVyZmxvd0xheWVyTm9kZUlEKGFuY2VzdG9yTGF5ZXIpOwogCg== 452754 2022-02-21 12:19:06 -0800 2022-02-21 19:59:02 -0800 Patch bug-236858-20220221121906.patch text/plain 2224 brandonstewart U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRhMzc3MmNkM2E2MjI1 MDZkMTY5NzY0Y2VjNDNjZjJhZjE3Yzc4Yi4uMzI0YjVjYzFlYzhiN2VhODVhYmE5ZDlhNTllOThh NjUxMzc5YWI3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTIxICBCcmFu ZG9uIFN0ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJl IGxheWVyIGhhcyBiYWNraW5nIGR1cmluZyB0cmF2ZXJzYWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjg1OAorCisgICAgICAgIFJldmlld2VkIGJ5 IFNpbW9uIEZyYXNlci4KKworICAgICAgICBFbnN1cmUgdGhlIGxheWVyIGhhcyBhIGJhY2tpbmcg YXR0YWNoZWQgdG8gaXQgYmVmb3JlIHRyeWluZyB0byBhcHBlbmQKKyAgICAgICAgdGhlIG5vZGUg aWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmNvbGxlY3RTdGF0aW9uYXJ5TGF5ZXJSZWxhdGVkT3ZlcmZsb3dOb2Rl cyk6CisKIDIwMjItMDItMjEgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtJRkNdW0ludGVncmF0aW9uXSBUYWtlIHZlcnRpY2FsLXJsIHdyaXRpbmcgbW9kZSB2YWx1 ZSBpbnRvIGFjY291bnQgd2hlbiBjb252ZXJ0aW5nIHZpc3VhbCBtYXJnaW4vYm9yZGVyL3BhZGRp bmcgdmFsdWUgdG8gbG9naWNhbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCAwYmUwMzlhMGYyM2Q1N2ZmN2Y1N2Q5OTA5YjY1 Mzc1YTAyNDI0M2I0Li40MDg3YTM2OGY5ZmQ3ZmRjYTllMjhhNjMyOTJjNmMyZGU3NGMyYzM2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmNwcApAQCAtMzQ0Miw3ICszNDQyLDcgQEAgU2Nyb2xsUG9zaXRpb25pbmdCZWhhdmlvciBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OmxheWVyU2Nyb2xsQmVoYWhhdmlvclJlbGF0aXZlVG8KIHN0YXRp YyB2b2lkIGNvbGxlY3RTdGF0aW9uYXJ5TGF5ZXJSZWxhdGVkT3ZlcmZsb3dOb2Rlcyhjb25zdCBS ZW5kZXJMYXllciYgbGF5ZXIsIGNvbnN0IFJlbmRlckxheWVyJiwgVmVjdG9yPFNjcm9sbGluZ05v ZGVJRD4mIHNjcm9sbGluZ05vZGVzKQogewogICAgIEFTU0VSVChsYXllci5pc0NvbXBvc2l0ZWQo KSk7Ci0gICAgCisKICAgICBhdXRvIGFwcGVuZE92ZXJmbG93TGF5ZXJOb2RlSUQgPSBbJnNjcm9s bGluZ05vZGVzXSAoY29uc3QgUmVuZGVyTGF5ZXImIG92ZXJmbG93TGF5ZXIpIHsKICAgICAgICAg QVNTRVJUKG92ZXJmbG93TGF5ZXIuaXNDb21wb3NpdGVkKCkpOwogICAgICAgICBhdXRvIHNjcm9s bGluZ05vZGVJRCA9IG92ZXJmbG93TGF5ZXIuYmFja2luZygpLT5zY3JvbGxpbmdOb2RlSURGb3JS b2xlKFNjcm9sbENvb3JkaW5hdGlvblJvbGU6OlNjcm9sbGluZyk7CkBAIC0zNDU5LDYgKzM0NTks OSBAQCBzdGF0aWMgdm9pZCBjb2xsZWN0U3RhdGlvbmFyeUxheWVyUmVsYXRlZE92ZXJmbG93Tm9k ZXMoY29uc3QgUmVuZGVyTGF5ZXImIGxheWVyLAogICAgICAgICBpZiAoaXNDb250YWluaW5nQmxv Y2tDaGFpbiAmJiBpc1BhaW50T3JkZXJBbmNlc3RvcikKICAgICAgICAgICAgIHJldHVybiBBbmNl c3RvclRyYXZlcnNhbDo6U3RvcDsKIAorICAgICAgICBpZiAoIWFuY2VzdG9yTGF5ZXIuaXNDb21w b3NpdGVkKCkpCisgICAgICAgICAgICByZXR1cm4gQW5jZXN0b3JUcmF2ZXJzYWw6OlN0b3A7CisK ICAgICAgICAgaWYgKHNlZW5QYWludE9yZGVyQW5jZXN0b3IgJiYgIWlzQ29udGFpbmluZ0Jsb2Nr Q2hhaW4gJiYgYW5jZXN0b3JMYXllci5oYXNDb21wb3NpdGVkU2Nyb2xsYWJsZU92ZXJmbG93KCkp CiAgICAgICAgICAgICBhcHBlbmRPdmVyZmxvd0xheWVyTm9kZUlEKGFuY2VzdG9yTGF5ZXIpOwog Cg==