<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>236846</bug_id>
          
          <creation_ts>2022-02-18 10:42:12 -0800</creation_ts>
          <short_desc>onpush/onpushsubscriptionchange exposed in Service Workers when Push API is disabled</short_desc>
          <delta_ts>2022-02-18 18:31:01 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Service Workers</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=236874</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Sneddon [:gsnedders]">gsnedders</reporter>
          <assigned_to name="Sam Sneddon [:gsnedders]">gsnedders</assigned_to>
          <cc>beidson</cc>
    
    <cc>cdumez</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>nham</cc>
    
    <cc>ntim</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1843491</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2022-02-18 10:42:12 -0800</bug_when>
    <thetext>This will be because:

[
    EnabledAtRuntime=ServiceWorkerEnabled
] partial interface ServiceWorkerGlobalScope {
    attribute EventHandler onpush;
    attribute EventHandler onpushsubscriptionchange;
};

This isn&apos;t gated on Push API being enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1843492</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-02-18 10:42:46 -0800</bug_when>
    <thetext>&lt;rdar://problem/89154452&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1843536</commentid>
    <comment_count>2</comment_count>
      <attachid>452554</attachid>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2022-02-18 11:46:32 -0800</bug_when>
    <thetext>Created attachment 452554
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1843540</commentid>
    <comment_count>3</comment_count>
      <attachid>452554</attachid>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2022-02-18 11:56:59 -0800</bug_when>
    <thetext>Comment on attachment 452554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452554&amp;action=review

&gt; LayoutTests/http/wpt/push-api/onpush-disabled-expected.txt:3
&gt; +PASS onpush
&gt; +PASS onpushsubscriptionchange

Can you use more descriptive PASS messages like &quot;onpush is not exposed when pref is disabled&quot;?

&gt; LayoutTests/http/wpt/push-api/onpush-enabled-expected.txt:3
&gt; +PASS onpush
&gt; +PASS onpushsubscriptionchange

ditto</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1843541</commentid>
    <comment_count>4</comment_count>
      <attachid>452554</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-18 11:59:30 -0800</bug_when>
    <thetext>Comment on attachment 452554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452554&amp;action=review

&gt; Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:28
&gt; +    EnabledAtRuntime=PushAPIEnabled

Shouldn&apos;t this be `EnabledAtRuntime=ServiceWorkerEnabled&amp;PushAPIEnabled` ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1843544</commentid>
    <comment_count>5</comment_count>
      <attachid>452556</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-18 12:05:17 -0800</bug_when>
    <thetext>Created attachment 452556
[fast-cq] Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1843584</commentid>
    <comment_count>6</comment_count>
      <attachid>452556</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-18 12:58:59 -0800</bug_when>
    <thetext>Comment on attachment 452556
[fast-cq] Patch

Clearing flags on attachment: 452556

Committed r290156 (247495@trunk): &lt;https://commits.webkit.org/247495@trunk&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1843585</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2022-02-18 12:59:02 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>452554</attachid>
            <date>2022-02-18 11:46:32 -0800</date>
            <delta_ts>2022-02-18 12:05:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-236846-20220218194631.patch</filename>
            <type>text/plain</type>
            <size>5916</size>
            <attacher name="Sam Sneddon [:gsnedders]">gsnedders</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTliZTFmYWY2Zjg0OGVk
MTE2YzgxY2FmMmVjNGQzNjA5OGM4M2U0MC4uM2E1NTMyYWM0OTdmYWZhNWY1MTcwZmJmYWJhMWRm
YTExODIxYjBlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTE4ICBTYW0g
U25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlckds
b2JhbFNjb3BlK1B1c2hBUEkgcmVxdWlyZXMgUHVzaEFQSUVuYWJsZWQKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjg0NgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzOiBodHRwL3dwdC9wdXNoLWFw
aS9vbnB1c2gtZGlzYWJsZWQuaHRtbAorICAgICAgICAgICAgICAgaHR0cC93cHQvcHVzaC1hcGkv
b25wdXNoLWVuYWJsZWQuaHRtbAorCisgICAgICAgICogTW9kdWxlcy9wdXNoLWFwaS9TZXJ2aWNl
V29ya2VyR2xvYmFsU2NvcGUrUHVzaEFQSS5pZGw6CisKIDIwMjItMDItMTggIEFkcmlhbiBQZXJl
eiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIENhbm5v
dCBmaW5kIE9wZW5HTCB3aGVuIHN5c3RlbSBwcm92aWRlcyBvcGVuZ2wucGMgaW5zdGVhZCBvZiBn
bC5wYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wdXNoLWFwaS9TZXJ2aWNl
V29ya2VyR2xvYmFsU2NvcGUrUHVzaEFQSS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3B1
c2gtYXBpL1NlcnZpY2VXb3JrZXJHbG9iYWxTY29wZStQdXNoQVBJLmlkbAppbmRleCBhYTA1MDE4
YmM3YzZiZjc3ZDgxZWU1MzZjNTkzOGMzNDY5YzhhMWUxLi4yOWZlNGQwYjIxOThjZDUxODU2NmRl
MTkxOWFmNjllMmI3ZjgwMzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3B1
c2gtYXBpL1NlcnZpY2VXb3JrZXJHbG9iYWxTY29wZStQdXNoQVBJLmlkbAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9Nb2R1bGVzL3B1c2gtYXBpL1NlcnZpY2VXb3JrZXJHbG9iYWxTY29wZStQdXNoQVBJ
LmlkbApAQCAtMjQsNyArMjQsOCBAQAogICovCiAKIFsKLSAgICBFbmFibGVkQXRSdW50aW1lPVNl
cnZpY2VXb3JrZXJFbmFibGVkCisgICAgQ29uZGl0aW9uYWw9U0VSVklDRV9XT1JLRVIsCisgICAg
RW5hYmxlZEF0UnVudGltZT1QdXNoQVBJRW5hYmxlZAogXSBwYXJ0aWFsIGludGVyZmFjZSBTZXJ2
aWNlV29ya2VyR2xvYmFsU2NvcGUgewogICAgIGF0dHJpYnV0ZSBFdmVudEhhbmRsZXIgb25wdXNo
OwogICAgIGF0dHJpYnV0ZSBFdmVudEhhbmRsZXIgb25wdXNoc3Vic2NyaXB0aW9uY2hhbmdlOwpk
aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
CmluZGV4IDM5MTA3ZGE0NjVkYWZlNTMyNzU3ZDYxMWNiYmJjODljNjllMjVjYWEuLmRmYTNlYTQ0
ODFkNDU1MTZmM2UyNjkyZTEzYjQzMDNmZGUwMzNiNjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz
L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAor
MjAyMi0wMi0xOCAgU2FtIFNuZWRkb24gIDxnc25lZGRlcnNAYXBwbGUuY29tPgorCisgICAgICAg
IFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZStQdXNoQVBJIHJlcXVpcmVzIFB1c2hBUElFbmFibGVk
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY4NDYK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAv
d3B0L3B1c2gtYXBpL29ucHVzaC1kaXNhYmxlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg
ICAqIGh0dHAvd3B0L3B1c2gtYXBpL29ucHVzaC1kaXNhYmxlZC5odG1sOiBBZGRlZC4KKyAgICAg
ICAgKiBodHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQuanM6IEFkZGVkLgorICAgICAg
ICAodGVzdCk6CisgICAgICAgICogaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQtZXhw
ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5h
YmxlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5h
YmxlZC5qczogQWRkZWQuCisgICAgICAgICh0ZXN0KToKKwogMjAyMi0wMi0xOCAgSm9uIExlZSAg
PGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBnYXJkZW5pbmcgZm9yIEdQ
VSBQcm9jZXNzIGJvdC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L3B1c2gtYXBp
L29ucHVzaC1kaXNhYmxlZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9wdXNo
LWFwaS9vbnB1c2gtZGlzYWJsZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu
ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJiMWM2OWM0MjJl
ZGQxNWYwMjJkZjE4NjhjMmE3MDM1ZWFlMzg3M2IKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU
ZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQtZXhwZWN0ZWQudHh0CkBAIC0w
LDAgKzEsNCBAQAorCitQQVNTIG9ucHVzaAorUEFTUyBvbnB1c2hzdWJzY3JpcHRpb25jaGFuZ2UK
KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWRpc2Fi
bGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQu
aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwLi43NTEyMWZhYjA2YmI2MmJhMjdjZGZmNTZhNmVlNmNiM2Q1MjkzMDBk
Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNo
LWRpc2FibGVkLmh0bWwKQEAgLTAsMCArMSwxNiBAQAorPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIg
WyBQdXNoQVBJRW5hYmxlZD1mYWxzZSBdIC0tPgorPCFkb2N0eXBlIGh0bWw+Cis8bWV0YSBjaGFy
c2V0PXV0Zi04PgorCis8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9z
Y3JpcHQ+Cis8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9z
Y3JpcHQ+Cis8ZGl2IGlkPWxvZz48L2Rpdj4KKzxzY3JpcHQ+CisoYXN5bmMgZnVuY3Rpb24oKSB7
CisgIGNvbnN0IHNjb3BlID0gJ2RvZXMvbm90L2V4aXN0JzsKKyAgbGV0IHJlZyA9IGF3YWl0IG5h
dmlnYXRvci5zZXJ2aWNlV29ya2VyLmdldFJlZ2lzdHJhdGlvbihzY29wZSk7CisgIGlmIChyZWcp
IGF3YWl0IHJlZy51bnJlZ2lzdGVyKCk7CisgIHJlZyA9IGF3YWl0IG5hdmlnYXRvci5zZXJ2aWNl
V29ya2VyLnJlZ2lzdGVyKCJvbnB1c2gtZGlzYWJsZWQuanMiLCB7c2NvcGV9KTsKKyAgZmV0Y2hf
dGVzdHNfZnJvbV93b3JrZXIocmVnLmluc3RhbGxpbmcpOworfSkoKTsKKzwvc2NyaXB0PgpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWRpc2FibGVkLmpz
IGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWRpc2FibGVkLmpzCm5ldyBm
aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAuLjAwYmJkNTZhZDFkNjJhNWI0Yjg1MjBjYjY5N2FjNmJiMTk0NTlmNGIKLS0tIC9kZXYv
bnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQu
anMKQEAgLTAsMCArMSw5IEBACitpbXBvcnRTY3JpcHRzKCIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNz
LmpzIik7CisKK3Rlc3QoKCkgPT4geworICAgIGFzc2VydF9mYWxzZSgib25wdXNoIiBpbiBzZWxm
KTsKK30sICJvbnB1c2giKTsKKwordGVzdCgoKSA9PiB7CisgICAgYXNzZXJ0X2ZhbHNlKCJvbnB1
c2hzdWJzY3JpcHRpb25jaGFuZ2UiIGluIHNlbGYpOworfSwgIm9ucHVzaHN1YnNjcmlwdGlvbmNo
YW5nZSIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNo
LWVuYWJsZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25w
dXNoLWVuYWJsZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJiMWM2OWM0MjJlZGQxNWYwMjJk
ZjE4NjhjMmE3MDM1ZWFlMzg3M2IKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRw
L3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBA
CisKK1BBU1Mgb25wdXNoCitQQVNTIG9ucHVzaHN1YnNjcmlwdGlvbmNoYW5nZQorCmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5odG1sIGIv
TGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQuaHRtbApuZXcgZmls
ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwLi5hNTJlZjE2MzU2NzAzYTIxZDZkMzlmNGRhNTgzMTNiNTdhMWFjOTA1Ci0tLSAvZGV2L251
bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQuaHRt
bApAQCAtMCwwICsxLDE2IEBACis8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIFB1c2hBUElFbmFi
bGVkPXRydWUgXSAtLT4KKzwhZG9jdHlwZSBodG1sPgorPG1ldGEgY2hhcnNldD11dGYtOD4KKwor
PHNjcmlwdCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5lc3MuanMiPjwvc2NyaXB0PgorPHNjcmlw
dCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5lc3NyZXBvcnQuanMiPjwvc2NyaXB0PgorPGRpdiBp
ZD1sb2c+PC9kaXY+Cis8c2NyaXB0PgorKGFzeW5jIGZ1bmN0aW9uKCkgeworICBjb25zdCBzY29w
ZSA9ICdkb2VzL25vdC9leGlzdCc7CisgIGxldCByZWcgPSBhd2FpdCBuYXZpZ2F0b3Iuc2Vydmlj
ZVdvcmtlci5nZXRSZWdpc3RyYXRpb24oc2NvcGUpOworICBpZiAocmVnKSBhd2FpdCByZWcudW5y
ZWdpc3RlcigpOworICByZWcgPSBhd2FpdCBuYXZpZ2F0b3Iuc2VydmljZVdvcmtlci5yZWdpc3Rl
cigib25wdXNoLWVuYWJsZWQuanMiLCB7c2NvcGV9KTsKKyAgZmV0Y2hfdGVzdHNfZnJvbV93b3Jr
ZXIocmVnLmluc3RhbGxpbmcpOworfSkoKTsKKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQuanMgYi9MYXlvdXRUZXN0cy9o
dHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NApp
bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xODg2MTIwYzY4
OThiMzRjNzk1OTA4MTIyOTAwMDY3MDI4MWNjMjJiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0
VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQuanMKQEAgLTAsMCArMSw5IEBA
CitpbXBvcnRTY3JpcHRzKCIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzLmpzIik7CisKK3Rlc3QoKCkg
PT4geworICAgIGFzc2VydF90cnVlKCJvbnB1c2giIGluIHNlbGYpOworfSwgIm9ucHVzaCIpOwor
Cit0ZXN0KCgpID0+IHsKKyAgICBhc3NlcnRfdHJ1ZSgib25wdXNoc3Vic2NyaXB0aW9uY2hhbmdl
IiBpbiBzZWxmKTsKK30sICJvbnB1c2hzdWJzY3JpcHRpb25jaGFuZ2UiKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>452556</attachid>
            <date>2022-02-18 12:05:17 -0800</date>
            <delta_ts>2022-02-18 12:58:59 -0800</delta_ts>
            <desc>[fast-cq] Patch</desc>
            <filename>bug-236846-20220218120516.patch</filename>
            <type>text/plain</type>
            <size>6406</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ3OTAzMTI4NGUyNjNh
ZTViYmM2NWNmNzkzN2IwYzIyNzRiNjkxMS4uZDRiYjI3ODBiYTZhOWYwMWQyMmRmODQzZWZjNWMw
YjU3ODg4MGVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTE4ICBTYW0g
U25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlckds
b2JhbFNjb3BlK1B1c2hBUEkgcmVxdWlyZXMgUHVzaEFQSUVuYWJsZWQKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjg0NgorCisgICAgICAgIFJldmll
d2VkIGJ5IENocmlzIER1bWV6LgorCisgICAgICAgIFRlc3RzOiBodHRwL3dwdC9wdXNoLWFwaS9v
bnB1c2gtZGlzYWJsZWQuaHRtbAorICAgICAgICAgICAgICAgaHR0cC93cHQvcHVzaC1hcGkvb25w
dXNoLWVuYWJsZWQuaHRtbAorCisgICAgICAgICogTW9kdWxlcy9wdXNoLWFwaS9TZXJ2aWNlV29y
a2VyR2xvYmFsU2NvcGUrUHVzaEFQSS5pZGw6CisKIDIwMjItMDItMTggIEFudG9pbmUgUXVpbnQg
IDxncmFvdXRzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2ZyYW1lLXJhdGVdIFtjdXN0b20tZWZm
ZWN0XSBhbGxvdyBzZXR0aW5nIGZyYW1lUmF0ZSBhcyBhbiBvcHRpb24gcGFzc2VkIHRvIGRvY3Vt
ZW50LnRpbWVsaW5lLmFuaW1hdGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl
cy9wdXNoLWFwaS9TZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUrUHVzaEFQSS5pZGwgYi9Tb3VyY2Uv
V2ViQ29yZS9Nb2R1bGVzL3B1c2gtYXBpL1NlcnZpY2VXb3JrZXJHbG9iYWxTY29wZStQdXNoQVBJ
LmlkbAppbmRleCBhYTA1MDE4YmM3YzZiZjc3ZDgxZWU1MzZjNTkzOGMzNDY5YzhhMWUxLi4zOTQy
MmRlOWE2NzYzZWM0OTM0NjA0NjUwY2QxZGVmYTljYzMzZjkzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9Nb2R1bGVzL3B1c2gtYXBpL1NlcnZpY2VXb3JrZXJHbG9iYWxTY29wZStQdXNoQVBJ
LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3B1c2gtYXBpL1NlcnZpY2VXb3JrZXJH
bG9iYWxTY29wZStQdXNoQVBJLmlkbApAQCAtMjQsNyArMjQsOCBAQAogICovCiAKIFsKLSAgICBF
bmFibGVkQXRSdW50aW1lPVNlcnZpY2VXb3JrZXJFbmFibGVkCisgICAgQ29uZGl0aW9uYWw9U0VS
VklDRV9XT1JLRVIsCisgICAgRW5hYmxlZEF0UnVudGltZT1TZXJ2aWNlV29ya2VyRW5hYmxlZCZQ
dXNoQVBJRW5hYmxlZAogXSBwYXJ0aWFsIGludGVyZmFjZSBTZXJ2aWNlV29ya2VyR2xvYmFsU2Nv
cGUgewogICAgIGF0dHJpYnV0ZSBFdmVudEhhbmRsZXIgb25wdXNoOwogICAgIGF0dHJpYnV0ZSBF
dmVudEhhbmRsZXIgb25wdXNoc3Vic2NyaXB0aW9uY2hhbmdlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY1NzA3ZGExNmI2
ZWZjOTU5YWQyODVmNzNmYjM1YjQwZjBkMDNjZDcuLmRhOTJjZWU1N2VmM2IyMTRlMGRhZjI0YmY5
ZmM0MDRlODZiYTkzZmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M
YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAyMi0wMi0xOCAgU2FtIFNu
ZWRkb24gIDxnc25lZGRlcnNAYXBwbGUuY29tPgorCisgICAgICAgIFNlcnZpY2VXb3JrZXJHbG9i
YWxTY29wZStQdXNoQVBJIHJlcXVpcmVzIFB1c2hBUElFbmFibGVkCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY4NDYKKworICAgICAgICBSZXZpZXdl
ZCBieSBDaHJpcyBEdW1lei4KKworICAgICAgICAqIGh0dHAvd3B0L3B1c2gtYXBpL29ucHVzaC1k
aXNhYmxlZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvd3B0L3B1c2gtYXBp
L29ucHVzaC1kaXNhYmxlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3dwdC9wdXNoLWFw
aS9vbnB1c2gtZGlzYWJsZWQuanM6IEFkZGVkLgorICAgICAgICAodGVzdCk6CisgICAgICAgICog
aHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg
ICAgICAgKiBodHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5odG1sOiBBZGRlZC4KKyAg
ICAgICAgKiBodHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5qczogQWRkZWQuCisgICAg
ICAgICh0ZXN0KToKKwogMjAyMi0wMi0xOCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0
Lm9yZz4KIAogICAgICAgICBbZnJhbWUtcmF0ZV0gW2N1c3RvbS1lZmZlY3RdIGFsbG93IHNldHRp
bmcgZnJhbWVSYXRlIGFzIGFuIG9wdGlvbiBwYXNzZWQgdG8gZG9jdW1lbnQudGltZWxpbmUuYW5p
bWF0ZSgpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gt
ZGlzYWJsZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvcHVzaC1hcGkvb25w
dXNoLWRpc2FibGVkLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40MzRlMGIyMDVmMzc0NGJlNDdk
MmJmNmYyZTBjMzBhODAxNzY0NGUzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0
cC93cHQvcHVzaC1hcGkvb25wdXNoLWRpc2FibGVkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQg
QEAKKworUEFTUyBvbnB1c2ggc2hvdWxkIG5vdCBiZSBleHBvc2VkIG9uIFNlcnZpY2VXb3JrZXJH
bG9iYWxTY29wZQorUEFTUyBvbnB1c2hzdWJzY3JpcHRpb25jaGFuZ2Ugc2hvdWxkIG5vdCBiZSBl
eHBvc2VkIG9uIFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZQorCmRpZmYgLS1naXQgYS9MYXlvdXRU
ZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQuaHRtbCBiL0xheW91dFRlc3Rz
L2h0dHAvd3B0L3B1c2gtYXBpL29ucHVzaC1kaXNhYmxlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw
NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc1MTIx
ZmFiMDZiYjYyYmEyN2NkZmY1NmE2ZWU2Y2IzZDUyOTMwMGQKLS0tIC9kZXYvbnVsbAorKysgYi9M
YXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQuaHRtbApAQCAtMCww
ICsxLDE2IEBACis8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIFB1c2hBUElFbmFibGVkPWZhbHNl
IF0gLS0+Cis8IWRvY3R5cGUgaHRtbD4KKzxtZXRhIGNoYXJzZXQ9dXRmLTg+CisKKzxzY3JpcHQg
c3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIv
cmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4KKzxkaXYgaWQ9bG9nPjwv
ZGl2PgorPHNjcmlwdD4KKyhhc3luYyBmdW5jdGlvbigpIHsKKyAgY29uc3Qgc2NvcGUgPSAnZG9l
cy9ub3QvZXhpc3QnOworICBsZXQgcmVnID0gYXdhaXQgbmF2aWdhdG9yLnNlcnZpY2VXb3JrZXIu
Z2V0UmVnaXN0cmF0aW9uKHNjb3BlKTsKKyAgaWYgKHJlZykgYXdhaXQgcmVnLnVucmVnaXN0ZXIo
KTsKKyAgcmVnID0gYXdhaXQgbmF2aWdhdG9yLnNlcnZpY2VXb3JrZXIucmVnaXN0ZXIoIm9ucHVz
aC1kaXNhYmxlZC5qcyIsIHtzY29wZX0pOworICBmZXRjaF90ZXN0c19mcm9tX3dvcmtlcihyZWcu
aW5zdGFsbGluZyk7Cit9KSgpOworPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o
dHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQuanMgYi9MYXlvdXRUZXN0cy9odHRwL3dw
dC9wdXNoLWFwaS9vbnB1c2gtZGlzYWJsZWQuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYThiOGY3N2MyNTA5NTBk
ODQ3NDcyOGFlMzNhM2UxMzUyYzJlNWM3NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz
L2h0dHAvd3B0L3B1c2gtYXBpL29ucHVzaC1kaXNhYmxlZC5qcwpAQCAtMCwwICsxLDkgQEAKK2lt
cG9ydFNjcmlwdHMoIi9yZXNvdXJjZXMvdGVzdGhhcm5lc3MuanMiKTsKKwordGVzdCgoKSA9PiB7
CisgICAgYXNzZXJ0X2ZhbHNlKCJvbnB1c2giIGluIHNlbGYpOworfSwgIm9ucHVzaCBzaG91bGQg
bm90IGJlIGV4cG9zZWQgb24gU2VydmljZVdvcmtlckdsb2JhbFNjb3BlIik7CisKK3Rlc3QoKCkg
PT4geworICAgIGFzc2VydF9mYWxzZSgib25wdXNoc3Vic2NyaXB0aW9uY2hhbmdlIiBpbiBzZWxm
KTsKK30sICJvbnB1c2hzdWJzY3JpcHRpb25jaGFuZ2Ugc2hvdWxkIG5vdCBiZSBleHBvc2VkIG9u
IFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZSIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0
cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv
aHR0cC93cHQvcHVzaC1hcGkvb25wdXNoLWVuYWJsZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v
ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu
LmI0MDMwMTU5ZTdjNWEyYzlhZWViM2QwNmIxNTY5NGQ0NmRjMWRhNDUKLS0tIC9kZXYvbnVsbAor
KysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC1leHBlY3Rl
ZC50eHQKQEAgLTAsMCArMSw0IEBACisKK1BBU1Mgb25wdXNoIHNob3VsZCBiZSBleHBvc2VkIG9u
IFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZQorUEFTUyBvbnB1c2hzdWJzY3JpcHRpb25jaGFuZ2Ug
c2hvdWxkIGJlIGV4cG9zZWQgb24gU2VydmljZVdvcmtlckdsb2JhbFNjb3BlCisKZGlmZiAtLWdp
dCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L3B1c2gtYXBpL29ucHVzaC1lbmFibGVkLmh0bWwgYi9M
YXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5odG1sCm5ldyBmaWxl
IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAuLmE1MmVmMTYzNTY3MDNhMjFkNmQzOWY0ZGE1ODMxM2I1N2ExYWM5MDUKLS0tIC9kZXYvbnVs
bAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5odG1s
CkBAIC0wLDAgKzEsMTYgQEAKKzwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgUHVzaEFQSUVuYWJs
ZWQ9dHJ1ZSBdIC0tPgorPCFkb2N0eXBlIGh0bWw+Cis8bWV0YSBjaGFyc2V0PXV0Zi04PgorCis8
c2NyaXB0IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0
IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlk
PWxvZz48L2Rpdj4KKzxzY3JpcHQ+CisoYXN5bmMgZnVuY3Rpb24oKSB7CisgIGNvbnN0IHNjb3Bl
ID0gJ2RvZXMvbm90L2V4aXN0JzsKKyAgbGV0IHJlZyA9IGF3YWl0IG5hdmlnYXRvci5zZXJ2aWNl
V29ya2VyLmdldFJlZ2lzdHJhdGlvbihzY29wZSk7CisgIGlmIChyZWcpIGF3YWl0IHJlZy51bnJl
Z2lzdGVyKCk7CisgIHJlZyA9IGF3YWl0IG5hdmlnYXRvci5zZXJ2aWNlV29ya2VyLnJlZ2lzdGVy
KCJvbnB1c2gtZW5hYmxlZC5qcyIsIHtzY29wZX0pOworICBmZXRjaF90ZXN0c19mcm9tX3dvcmtl
cihyZWcuaW5zdGFsbGluZyk7Cit9KSgpOworPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRU
ZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5qcyBiL0xheW91dFRlc3RzL2h0
dHAvd3B0L3B1c2gtYXBpL29ucHVzaC1lbmFibGVkLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu
ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNjNDBlYmEzMzQ3
NmZjNzY5OTUzNTY2MTEyYTJmNmYxNzZjYWRhYWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU
ZXN0cy9odHRwL3dwdC9wdXNoLWFwaS9vbnB1c2gtZW5hYmxlZC5qcwpAQCAtMCwwICsxLDkgQEAK
K2ltcG9ydFNjcmlwdHMoIi9yZXNvdXJjZXMvdGVzdGhhcm5lc3MuanMiKTsKKwordGVzdCgoKSA9
PiB7CisgICAgYXNzZXJ0X3RydWUoIm9ucHVzaCIgaW4gc2VsZik7Cit9LCAib25wdXNoIHNob3Vs
ZCBiZSBleHBvc2VkIG9uIFNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZSIpOworCit0ZXN0KCgpID0+
IHsKKyAgICBhc3NlcnRfdHJ1ZSgib25wdXNoc3Vic2NyaXB0aW9uY2hhbmdlIiBpbiBzZWxmKTsK
K30sICJvbnB1c2hzdWJzY3JpcHRpb25jaGFuZ2Ugc2hvdWxkIGJlIGV4cG9zZWQgb24gU2Vydmlj
ZVdvcmtlckdsb2JhbFNjb3BlIik7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>