236828 2022-02-18 00:17:47 -0800 [custom-effect] Animations associated with a custom effect should appear in document.getAnimations() result 2022-02-18 07:37:18 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts cdumez dino esprehn+autocc ews-watchlist graouts kangil.han webkit-bug-importer oldest_to_newest 1843309 0 graouts 2022-02-18 00:17:47 -0800 [custom-effect] Animations associated with a custom effect should appear in document.getAnimations() result 1843311 1 452492 graouts 2022-02-18 00:18:15 -0800 Created attachment 452492 Patch 1843353 2 452492 dino 2022-02-18 04:20:19 -0800 Comment on attachment 452492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452492&action=review > LayoutTests/ChangeLog:9 > + * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added. > + * webanimations/custom-effect/custom-effect-get-animations.html: Added. Shouldn't this be in a WPT directory so we can contribute it back? What will track that effort? 1843354 3 graouts 2022-02-18 04:22:57 -0800 (In reply to Dean Jackson from comment #2) > Comment on attachment 452492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452492&action=review > > > LayoutTests/ChangeLog:9 > > + * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added. > > + * webanimations/custom-effect/custom-effect-get-animations.html: Added. > > Shouldn't this be in a WPT directory so we can contribute it back? What will > track that effort? I'm writing all of those custom-effect tests with testharness so we may contribute them back, but I don't think we should upstream them until there are approved pull requests for the changes suggested. 1843398 4 graouts 2022-02-18 07:36:13 -0800 Committed r290122 (?): <https://commits.webkit.org/r290122> 1843399 5 webkit-bug-importer 2022-02-18 07:37:18 -0800 <rdar://problem/89144597> 452492 2022-02-18 00:18:15 -0800 2022-02-18 07:32:57 -0800 Patch bug-236828-20220218091813.patch text/plain 4630 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUzNzVkNGRhMjA2ZGIy MTdiNjBkN2RlMjJhOTRkZGMwNGQyZDU1MS4uZjI1NDQzYjFjYTJlMzQ3OTcxZDgxOTYzZjcyMzE3 NmZhMzI0YjM1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTE4ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtjdXN0b20tZWZmZWN0 XSBBbmltYXRpb25zIGFzc29jaWF0ZWQgd2l0aCBhIGN1c3RvbSBlZmZlY3Qgc2hvdWxkIGFwcGVh ciBpbiBkb2N1bWVudC5nZXRBbmltYXRpb25zKCkgcmVzdWx0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY4MjgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiB3ZWJhbmltYXRpb25zL2N1c3RvbS1l ZmZlY3QvY3VzdG9tLWVmZmVjdC1nZXQtYW5pbWF0aW9ucy5odG1sCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Om1hdGNoaW5nQW5pbWF0 aW9ucyk6CisKIDIwMjItMDItMTYgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVXNlIHRoZSBhbmltYXRpb24gZnJhbWUgcmF0ZSBkdXJpbmcgYW5pbWF0aW9u IHJlc29sdXRpb24gYW5kIHNjaGVkdWxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGE2 YTZhZGM2ZDhkN2YxOGMyZjRhOWZjYjUyOTA5NGYxNWYyY2IwMmMuLjRlNTMxNTk0ZTFlYTBmM2M5 N2EzYmU5MTM3MjJiOTlmNjcxOGRhYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNTMs NiArNTMsNyBAQAogI2luY2x1ZGUgIkNvbnRlbnRTZWN1cml0eVBvbGljeS5oIgogI2luY2x1ZGUg IkNvbnRlbnRmdWxQYWludENoZWNrZXIuaCIKICNpbmNsdWRlICJDb29raWVKYXIuaCIKKyNpbmNs dWRlICJDdXN0b21FZmZlY3QuaCIKICNpbmNsdWRlICJDdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1 ZS5oIgogI2luY2x1ZGUgIkN1c3RvbUVsZW1lbnRSZWdpc3RyeS5oIgogI2luY2x1ZGUgIkN1c3Rv bUV2ZW50LmgiCkBAIC04NTA4LDEyICs4NTA5LDIxIEBAIFZlY3RvcjxSZWZQdHI8V2ViQW5pbWF0 aW9uPj4gRG9jdW1lbnQ6Om1hdGNoaW5nQW5pbWF0aW9ucyhjb25zdCBGdW5jdGlvbjxib29sKEVs CiAgICAgdXBkYXRlU3R5bGVJZk5lZWRlZCgpOwogCiAgICAgVmVjdG9yPFJlZlB0cjxXZWJBbmlt YXRpb24+PiBhbmltYXRpb25zOwotICAgIGZvciAoYXV0byogYW5pbWF0aW9uIDogV2ViQW5pbWF0 aW9uOjppbnN0YW5jZXMoKSkgewotICAgICAgICBpZiAoIWFuaW1hdGlvbi0+aXNSZWxldmFudCgp IHx8ICFpczxLZXlmcmFtZUVmZmVjdD4oYW5pbWF0aW9uLT5lZmZlY3QoKSkpCi0gICAgICAgICAg ICBjb250aW51ZTsKIAotICAgICAgICBhdXRvKiB0YXJnZXQgPSBkb3duY2FzdDxLZXlmcmFtZUVm ZmVjdD4oKmFuaW1hdGlvbi0+ZWZmZWN0KCkpLnRhcmdldCgpOwotICAgICAgICBpZiAodGFyZ2V0 ICYmIHRhcmdldC0+aXNDb25uZWN0ZWQoKSAmJiAmdGFyZ2V0LT5kb2N1bWVudCgpID09IHRoaXMg JiYgZnVuY3Rpb24oKnRhcmdldCkpCisgICAgYXV0byBlZmZlY3RDYW5CZUxpc3RlZCA9IFsmXShB bmltYXRpb25FZmZlY3QqIGVmZmVjdCkgeworICAgICAgICBpZiAoaXM8Q3VzdG9tRWZmZWN0Pihl ZmZlY3QpKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICAgICAgaWYgKGF1dG8qIGtl eWZyYW1lRWZmZWN0ID0gZHluYW1pY0Rvd25jYXN0PEtleWZyYW1lRWZmZWN0PihlZmZlY3QpKSB7 CisgICAgICAgICAgICBhdXRvKiB0YXJnZXQgPSBrZXlmcmFtZUVmZmVjdC0+dGFyZ2V0KCk7Cisg ICAgICAgICAgICByZXR1cm4gdGFyZ2V0ICYmIHRhcmdldC0+aXNDb25uZWN0ZWQoKSAmJiAmdGFy Z2V0LT5kb2N1bWVudCgpID09IHRoaXMgJiYgZnVuY3Rpb24oKnRhcmdldCk7CisgICAgICAgIH0K KworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfTsKKworICAgIGZvciAoYXV0byogYW5pbWF0 aW9uIDogV2ViQW5pbWF0aW9uOjppbnN0YW5jZXMoKSkgeworICAgICAgICBpZiAoYW5pbWF0aW9u LT5pc1JlbGV2YW50KCkgJiYgZWZmZWN0Q2FuQmVMaXN0ZWQoYW5pbWF0aW9uLT5lZmZlY3QoKSkp CiAgICAgICAgICAgICBhbmltYXRpb25zLmFwcGVuZChhbmltYXRpb24pOwogICAgIH0KIApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDhhNzc1MTQ1NzBmZDg2OWI2YzMxYWVmOGYxMzIyMzlhNTdiY2EwN2EuLjJkNTQ0Yzc4Nzdl MzJmNmUzYjFlMDMwMzcyYmM2NGJkMmE3MWY2MzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAy Mi0wMi0xOCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KKworICAgICAgICBb Y3VzdG9tLWVmZmVjdF0gQW5pbWF0aW9ucyBhc3NvY2lhdGVkIHdpdGggYSBjdXN0b20gZWZmZWN0 IHNob3VsZCBhcHBlYXIgaW4gZG9jdW1lbnQuZ2V0QW5pbWF0aW9ucygpIHJlc3VsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2ODI4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJhbmltYXRpb25z L2N1c3RvbS1lZmZlY3QvY3VzdG9tLWVmZmVjdC1nZXQtYW5pbWF0aW9ucy1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIHdlYmFuaW1hdGlvbnMvY3VzdG9tLWVmZmVjdC9jdXN0b20tZWZm ZWN0LWdldC1hbmltYXRpb25zLmh0bWw6IEFkZGVkLgorCiAyMDIyLTAyLTE2ICBBbnRvaW5lIFF1 aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSB0aGUgYW5pbWF0aW9uIGZy YW1lIHJhdGUgZHVyaW5nIGFuaW1hdGlvbiByZXNvbHV0aW9uIGFuZCBzY2hlZHVsaW5nCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhbmltYXRpb25zL2N1c3RvbS1lZmZlY3QvY3VzdG9tLWVm ZmVjdC1nZXQtYW5pbWF0aW9ucy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJhbmltYXRp b25zL2N1c3RvbS1lZmZlY3QvY3VzdG9tLWVmZmVjdC1nZXQtYW5pbWF0aW9ucy1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMDgxODc3M2JmYmU1YmZmNGYyNWIyMGVlNTY0ZTEwZmM2M2NkNmMxMAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3dlYmFuaW1hdGlvbnMvY3VzdG9tLWVmZmVj dC9jdXN0b20tZWZmZWN0LWdldC1hbmltYXRpb25zLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMg QEAKKworUEFTUyBBbmltYXRpb24gY3JlYXRlZCB3aXRoIGRvY3VtZW50LnRpbWVsaW5lLmFuaW1h dGUoKSBhcHBlYXJzIGluIGdldEFuaW1hdGlvbnMoKSByZXN1bHQuCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3dlYmFuaW1hdGlvbnMvY3VzdG9tLWVmZmVjdC9jdXN0b20tZWZmZWN0LWdldC1h bmltYXRpb25zLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJhbmltYXRpb25zL2N1c3RvbS1lZmZlY3Qv Y3VzdG9tLWVmZmVjdC1nZXQtYW5pbWF0aW9ucy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZjOWM2Njg5MmVl MDc2OTdhMWJjZjFlODg4ZTE2MGM2ZmIwNjE5YjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy93ZWJhbmltYXRpb25zL2N1c3RvbS1lZmZlY3QvY3VzdG9tLWVmZmVjdC1nZXQtYW5pbWF0 aW9ucy5odG1sCkBAIC0wLDAgKzEsMTYgQEAKKzwhZG9jdHlwZSBodG1sPgorPG1ldGEgY2hhcnNl dD11dGYtOD4KKzx0aXRsZT5DdXN0b21FZmZlY3Q8L3RpdGxlPgorPHNjcmlwdCBzcmM9Ii4uLy4u L3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v cmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4KKzxib2R5PgorPHNjcmlw dD4KKyd1c2Ugc3RyaWN0JzsKKwordGVzdCh0ID0+IHsKKyAgICBjb25zdCBhbmltYXRpb24gPSBk b2N1bWVudC50aW1lbGluZS5hbmltYXRlKHByb2dyZXNzID0+IHsgfSwgeyBkdXJhdGlvbjogMSB9 KTsKKyAgICBhc3NlcnRfYXJyYXlfZXF1YWxzKGRvY3VtZW50LmdldEFuaW1hdGlvbnMoKSwgW2Fu aW1hdGlvbl0pOworfSwgIkFuaW1hdGlvbiBjcmVhdGVkIHdpdGggZG9jdW1lbnQudGltZWxpbmUu YW5pbWF0ZSgpIGFwcGVhcnMgaW4gZ2V0QW5pbWF0aW9ucygpIHJlc3VsdC4iKTsKKworPC9zY3Jp cHQ+Cis8L2JvZHk+Cg==