236823 2022-02-17 21:06:05 -0800 Use async NSSharingServicePicker menu if available 2022-02-18 14:41:57 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney akeerthi dino hi megan_gardner thorton wenson_hsieh oldest_to_newest 1843269 0 katherine_cheney 2022-02-17 21:06:05 -0800 Use async sharingServicePicker menu if available 1843270 1 452477 katherine_cheney 2022-02-17 21:08:41 -0800 Created attachment 452477 Patch 1843272 2 katherine_cheney 2022-02-17 21:13:43 -0800 rdar://88858606 1843425 3 452477 dino 2022-02-18 08:41:11 -0800 Comment on attachment 452477 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452477&action=review > Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:45 > +- (void)showPickerAsync:(NSSharingServicePicker *)picker showRelativeToRect:(NSRect)presentationRect ofView:(WKWebView *)webView completion:(void (^)(void))completionHandler; > @property (nonatomic, weak) id <WKShareSheetDelegate> delegate; Nit: I think we usually put a blank line between the methods and the @property(s). 1843427 4 452477 dino 2022-02-18 08:42:14 -0800 Comment on attachment 452477 Patch It seems NSSharingServicePicker is an unknown type. 1843447 5 katherine_cheney 2022-02-18 09:19:31 -0800 (In reply to Dean Jackson from comment #4) > Comment on attachment 452477 [details] > Patch > > It seems NSSharingServicePicker is an unknown type. Oops, I think the SPI is Mac only, need to add some #if PLATFORM(MAC) tags. And then mac failures are because I changed the function but didn't update the non-internal-sdk declarations. New patch coming 1843448 6 katherine_cheney 2022-02-18 09:19:40 -0800 (In reply to Dean Jackson from comment #3) > Comment on attachment 452477 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452477&action=review > > > Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:45 > > +- (void)showPickerAsync:(NSSharingServicePicker *)picker showRelativeToRect:(NSRect)presentationRect ofView:(WKWebView *)webView completion:(void (^)(void))completionHandler; > > @property (nonatomic, weak) id <WKShareSheetDelegate> delegate; > > Nit: I think we usually put a blank line between the methods and the > @property(s). Will fix in new patch! 1843464 7 452530 katherine_cheney 2022-02-18 09:43:43 -0800 Created attachment 452530 Patch 1843469 8 452533 katherine_cheney 2022-02-18 09:57:51 -0800 Created attachment 452533 Patch 1843655 9 ews-feeder 2022-02-18 14:41:50 -0800 Committed r290173 (247504@main): <https://commits.webkit.org/247504@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452533. 452477 2022-02-17 21:08:41 -0800 2022-02-18 09:43:40 -0800 Patch bug-236823-20220217210840.patch text/plain 3767 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5OTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjNTk4OTJiYTIxN2I1OTEz M2U4ZDFkYzczYTQ2NTBlZmQzNjRjMGYuLmRlODJhZmQ4NmYwYWVmZjU2ZDZiOWRhNTYxMWEwNWI4 MjQ5YmQzNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDItMTcgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGFzeW5jIE5T U2hhcmluZ1NlcnZpY2VQaWNrZXIgbWVudSBpZiBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjgyMworICAgICAgICA8cmRhcjovL3By b2JsZW0vODg4NTg2MDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV0tTaGFyZVNoZWV0Lmg6CisgICAgICAgICogVUlQ cm9jZXNzL0NvY29hL1dLU2hhcmVTaGVldC5tbToKKyAgICAgICAgKC1bV0tTaGFyZVNoZWV0IHBy ZXNlbnRXaXRoU2hhcmVEYXRhQXJyYXk6aW5SZWN0Ol0pOgorICAgICAgICAoLVtXS1NoYXJlU2hl ZXQgY2FuU2hvd1BpY2tlckFzeW5jOl0pOgorICAgICAgICAoLVtXS1NoYXJlU2hlZXQgc2hvd1Bp Y2tlckFzeW5jOmNvbXBsZXRpb25IYW5kbGVyOl0pOgorCiAyMDIyLTAyLTE1ICBNeWxlcyBDLiBN YXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkdQVV0gVXBkYXRl IElETHMgYW5kIHN0dWJzIHRvIGxhdGVzdCB2ZXJzaW9uIG9mIHRoZSBzcGVjCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQuaCBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2hhcmVTaGVldC5oCmluZGV4IDFkNWVjMjk2MmJkZmUz Y2JkNjk4Y2QwMjM0OTBiYjk5ZTZhM2IzNzYuLmU3NTA2ZGY5ZGFmODVhNjdkOGNlNTAwYWY3NDJi NzY4Njg0YzI4OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dL U2hhcmVTaGVldC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2hhcmVT aGVldC5oCkBAIC00MCw3ICs0MCw4IEBAIHN0cnVjdCBTaGFyZURhdGFXaXRoUGFyc2VkVVJMOwog CiAtICh2b2lkKXByZXNlbnRXaXRoUGFyYW1ldGVyczooY29uc3QgV2ViQ29yZTo6U2hhcmVEYXRh V2l0aFBhcnNlZFVSTCYpZGF0YSBpblJlY3Q6KHN0ZDo6b3B0aW9uYWw8V2ViQ29yZTo6RmxvYXRS ZWN0PilyZWN0IGNvbXBsZXRpb25IYW5kbGVyOihXVEY6OkNvbXBsZXRpb25IYW5kbGVyPHZvaWQo Ym9vbCk+JiYpY29tcGxldGlvbkhhbmRsZXI7CiAtICh2b2lkKWRpc21pc3M7Ci0KKy0gKEJPT0wp Y2FuU2hvd1BpY2tlckFzeW5jOihOU1NoYXJpbmdTZXJ2aWNlUGlja2VyICopcGlja2VyOworLSAo dm9pZClzaG93UGlja2VyQXN5bmM6KE5TU2hhcmluZ1NlcnZpY2VQaWNrZXIgKilwaWNrZXIgc2hv d1JlbGF0aXZlVG9SZWN0OihOU1JlY3QpcHJlc2VudGF0aW9uUmVjdCBvZlZpZXc6KFdLV2ViVmll dyAqKXdlYlZpZXcgY29tcGxldGlvbjoodm9pZCAoXikodm9pZCkpY29tcGxldGlvbkhhbmRsZXI7 CiBAcHJvcGVydHkgKG5vbmF0b21pYywgd2VhaykgaWQgPFdLU2hhcmVTaGVldERlbGVnYXRlPiBk ZWxlZ2F0ZTsKIEBlbmQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j b2EvV0tTaGFyZVNoZWV0Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTaGFy ZVNoZWV0Lm1tCmluZGV4IGUzNGQ1NzBhNTliZWMyNmZiZjZiZTNhNmRmNjQ2ZTUwOWFlZjE2MzMu LjUzMDgwZjVmOTBjZTVkOTIzZDE0MzQ5MWMzOWQ2ZDRmM2I5ODFkNzYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2hhcmVTaGVldC5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQubW0KQEAgLTQ2LDYgKzQ2LDEwIEBA CiAjaW1wb3J0IDxwYWwvc3BpL21hYy9OU1NoYXJpbmdTZXJ2aWNlUGlja2VyU1BJLmg+CiAjZW5k aWYKIAorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIFBMQVRGT1JNKE1BQykKKyNpbXBv cnQgPFdlYktpdEFkZGl0aW9ucy9XS1NoYXJlU2hlZXRBZGRpdGlvbnNCZWZvcmUubW0+CisjZW5k aWYKKwogI2lmIFBMQVRGT1JNKE1BQykKIEBpbnRlcmZhY2UgV0tTaGFyZVNoZWV0ICgpIDxOU1No YXJpbmdTZXJ2aWNlRGVsZWdhdGUsIE5TU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0ZT4KIEBl bmQKQEAgLTE3OCw3ICsxODIsMTEgQEAgc3RhdGljIHZvaWQgYXBwZW5kRmlsZXNBc1NoYXJlYWJs ZVVSTHMoUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PiYmIHNoYXJlRGF0YUFycmEKICAgICAgICAg TlNSZWN0IG1vdXNlTG9jYXRpb25JbldpbmRvdyA9IFt3ZWJWaWV3LndpbmRvdyBjb252ZXJ0UmVj dEZyb21TY3JlZW46bW91c2VMb2NhdGlvblJlY3RdOwogICAgICAgICBwcmVzZW50YXRpb25SZWN0 ID0gW3dlYlZpZXcgY29udmVydFJlY3Q6bW91c2VMb2NhdGlvbkluV2luZG93IGZyb21WaWV3Om5p bF07CiAgICAgfQotICAgIFtfc2hhcmluZ1NlcnZpY2VQaWNrZXIgc2hvd1JlbGF0aXZlVG9SZWN0 OnByZXNlbnRhdGlvblJlY3Qgb2ZWaWV3OndlYlZpZXcgcHJlZmVycmVkRWRnZTpOU01pbllFZGdl XTsKKworICAgIGlmIChbc2VsZiBjYW5TaG93UGlja2VyQXN5bmM6X3NoYXJpbmdTZXJ2aWNlUGlj a2VyLmdldCgpXSkKKyAgICAgICAgW3NlbGYgc2hvd1BpY2tlckFzeW5jOl9zaGFyaW5nU2Vydmlj ZVBpY2tlci5nZXQoKSBzaG93UmVsYXRpdmVUb1JlY3Q6cHJlc2VudGF0aW9uUmVjdCBvZlZpZXc6 d2ViVmlldyBjb21wbGV0aW9uOl57IH1dOworICAgIGVsc2UKKyAgICAgICAgW19zaGFyaW5nU2Vy dmljZVBpY2tlciBzaG93UmVsYXRpdmVUb1JlY3Q6cHJlc2VudGF0aW9uUmVjdCBvZlZpZXc6d2Vi VmlldyBwcmVmZXJyZWRFZGdlOk5TTWluWUVkZ2VdOwogI2Vsc2UKICAgICBfc2hhcmVTaGVldFZp ZXdDb250cm9sbGVyID0gYWRvcHROUyhbW1VJQWN0aXZpdHlWaWV3Q29udHJvbGxlciBhbGxvY10g aW5pdFdpdGhBY3Rpdml0eUl0ZW1zOnNoYXJpbmdJdGVtcyBhcHBsaWNhdGlvbkFjdGl2aXRpZXM6 bmlsXSk7CiAKQEAgLTM2Miw2ICszNzAsMTkgQEAgc3RhdGljIHZvaWQgYXBwZW5kRmlsZXNBc1No YXJlYWJsZVVSTHMoUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PiYmIHNoYXJlRGF0YUFycmEKICAg ICByZXR1cm4gZmlsZVVSTDsKIH0KIAorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIFBM QVRGT1JNKE1BQykKKyNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9XS1NoYXJlU2hlZXRBZGRpdGlv bnMubW0+CisjZWxzZQorLSAoQk9PTCljYW5TaG93UGlja2VyQXN5bmM6KE5TU2hhcmluZ1NlcnZp Y2VQaWNrZXIgKilwaWNrZXIKK3sKKworfQorLSAodm9pZClzaG93UGlja2VyQXN5bmM6KE5TU2hh cmluZ1NlcnZpY2VQaWNrZXIgKilwaWNrZXIgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKHZv aWQpKWNvbXBsZXRpb25IYW5kbGVyCit7CisKK30KKyNlbmRpZgorCiBAZW5kCiAKICNlbmRpZiAv LyBQTEFURk9STShDT0NPQSkgJiYgIVBMQVRGT1JNKFdBVENIT1MpICYmICFQTEFURk9STShBUFBM RVRWKQo= 452530 2022-02-18 09:43:43 -0800 2022-02-18 10:10:25 -0800 Patch bug-236823-20220218094342.patch text/plain 3868 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5OTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjNTk4OTJiYTIxN2I1OTEz M2U4ZDFkYzczYTQ2NTBlZmQzNjRjMGYuLjFjN2M5ZDJiY2M2YzcyY2EwZWNhYjI3YjNmMWI0NzFm ZTE2NjFkNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDItMTcgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGFzeW5jIE5T U2hhcmluZ1NlcnZpY2VQaWNrZXIgbWVudSBpZiBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjgyMworICAgICAgICA8cmRhcjovL3By b2JsZW0vODg4NTg2MDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGVhbiBKYWNrc29uLgorCisg ICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dLU2hhcmVTaGVldC5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQubW06CisgICAgICAgICgtW1dLU2hhcmVTaGVldCBwcmVz ZW50V2l0aFNoYXJlRGF0YUFycmF5OmluUmVjdDpdKToKKyAgICAgICAgKC1bV0tTaGFyZVNoZWV0 IGNhblNob3dQaWNrZXJBc3luYzpdKToKKyAgICAgICAgKC1bV0tTaGFyZVNoZWV0IHNob3dQaWNr ZXJBc3luYzpjb21wbGV0aW9uSGFuZGxlcjpdKToKKwogMjAyMi0wMi0xNSAgTXlsZXMgQy4gTWF4 ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHUFVdIFVwZGF0ZSBJ RExzIGFuZCBzdHVicyB0byBsYXRlc3QgdmVyc2lvbiBvZiB0aGUgc3BlYwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTaGFyZVNoZWV0LmggYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQuaAppbmRleCAxZDVlYzI5NjJiZGZlM2Ni ZDY5OGNkMDIzNDkwYmI5OWU2YTNiMzc2Li5mYzUwOTEzMTcxZmJiNDNjZTRiMzU2ODZmNjM4ZjEx MzkzMWYyNzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1No YXJlU2hlZXQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hl ZXQuaApAQCAtNDEsNiArNDEsMTEgQEAgc3RydWN0IFNoYXJlRGF0YVdpdGhQYXJzZWRVUkw7CiAt ICh2b2lkKXByZXNlbnRXaXRoUGFyYW1ldGVyczooY29uc3QgV2ViQ29yZTo6U2hhcmVEYXRhV2l0 aFBhcnNlZFVSTCYpZGF0YSBpblJlY3Q6KHN0ZDo6b3B0aW9uYWw8V2ViQ29yZTo6RmxvYXRSZWN0 PilyZWN0IGNvbXBsZXRpb25IYW5kbGVyOihXVEY6OkNvbXBsZXRpb25IYW5kbGVyPHZvaWQoYm9v bCk+JiYpY29tcGxldGlvbkhhbmRsZXI7CiAtICh2b2lkKWRpc21pc3M7CiAKKyNpZiBQTEFURk9S TShNQUMpCistIChCT09MKWNhblNob3dQaWNrZXJBc3luYzooTlNTaGFyaW5nU2VydmljZVBpY2tl ciAqKXBpY2tlcjsKKy0gKHZvaWQpc2hvd1BpY2tlckFzeW5jOihOU1NoYXJpbmdTZXJ2aWNlUGlj a2VyICopcGlja2VyIHNob3dSZWxhdGl2ZVRvUmVjdDooTlNSZWN0KXByZXNlbnRhdGlvblJlY3Qg b2ZWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGNvbXBsZXRpb246KHZvaWQgKF4pKHZvaWQpKWNv bXBsZXRpb25IYW5kbGVyOworI2VuZGlmCisKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCB3ZWFrKSBp ZCA8V0tTaGFyZVNoZWV0RGVsZWdhdGU+IGRlbGVnYXRlOwogQGVuZAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQubW0gYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQubW0KaW5kZXggZTM0ZDU3MGE1OWJlYzI2 ZmJmNmJlM2E2ZGY2NDZlNTA5YWVmMTYzMy4uMTFmZjQ1NGNiZmQ0ODFhODRjYWYwZTFlMmUwOWE0 YmEwMGNiZTExYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tT aGFyZVNoZWV0Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2hhcmVT aGVldC5tbQpAQCAtNDYsNiArNDYsMTAgQEAKICNpbXBvcnQgPHBhbC9zcGkvbWFjL05TU2hhcmlu Z1NlcnZpY2VQaWNrZXJTUEkuaD4KICNlbmRpZgogCisjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NE SykgJiYgUExBVEZPUk0oTUFDKQorI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL1dLU2hhcmVTaGVl dEFkZGl0aW9uc0JlZm9yZS5tbT4KKyNlbmRpZgorCiAjaWYgUExBVEZPUk0oTUFDKQogQGludGVy ZmFjZSBXS1NoYXJlU2hlZXQgKCkgPE5TU2hhcmluZ1NlcnZpY2VEZWxlZ2F0ZSwgTlNTaGFyaW5n U2VydmljZVBpY2tlckRlbGVnYXRlPgogQGVuZApAQCAtMTc4LDcgKzE4MiwxMSBAQCBzdGF0aWMg dm9pZCBhcHBlbmRGaWxlc0FzU2hhcmVhYmxlVVJMcyhSZXRhaW5QdHI8TlNNdXRhYmxlQXJyYXk+ JiYgc2hhcmVEYXRhQXJyYQogICAgICAgICBOU1JlY3QgbW91c2VMb2NhdGlvbkluV2luZG93ID0g W3dlYlZpZXcud2luZG93IGNvbnZlcnRSZWN0RnJvbVNjcmVlbjptb3VzZUxvY2F0aW9uUmVjdF07 CiAgICAgICAgIHByZXNlbnRhdGlvblJlY3QgPSBbd2ViVmlldyBjb252ZXJ0UmVjdDptb3VzZUxv Y2F0aW9uSW5XaW5kb3cgZnJvbVZpZXc6bmlsXTsKICAgICB9Ci0gICAgW19zaGFyaW5nU2Vydmlj ZVBpY2tlciBzaG93UmVsYXRpdmVUb1JlY3Q6cHJlc2VudGF0aW9uUmVjdCBvZlZpZXc6d2ViVmll dyBwcmVmZXJyZWRFZGdlOk5TTWluWUVkZ2VdOworCisgICAgaWYgKFtzZWxmIGNhblNob3dQaWNr ZXJBc3luYzpfc2hhcmluZ1NlcnZpY2VQaWNrZXIuZ2V0KCldKQorICAgICAgICBbc2VsZiBzaG93 UGlja2VyQXN5bmM6X3NoYXJpbmdTZXJ2aWNlUGlja2VyLmdldCgpIHNob3dSZWxhdGl2ZVRvUmVj dDpwcmVzZW50YXRpb25SZWN0IG9mVmlldzp3ZWJWaWV3IGNvbXBsZXRpb246XnsgfV07CisgICAg ZWxzZQorICAgICAgICBbX3NoYXJpbmdTZXJ2aWNlUGlja2VyIHNob3dSZWxhdGl2ZVRvUmVjdDpw cmVzZW50YXRpb25SZWN0IG9mVmlldzp3ZWJWaWV3IHByZWZlcnJlZEVkZ2U6TlNNaW5ZRWRnZV07 CiAjZWxzZQogICAgIF9zaGFyZVNoZWV0Vmlld0NvbnRyb2xsZXIgPSBhZG9wdE5TKFtbVUlBY3Rp dml0eVZpZXdDb250cm9sbGVyIGFsbG9jXSBpbml0V2l0aEFjdGl2aXR5SXRlbXM6c2hhcmluZ0l0 ZW1zIGFwcGxpY2F0aW9uQWN0aXZpdGllczpuaWxdKTsKIApAQCAtMzYyLDYgKzM3MCwyMSBAQCBz dGF0aWMgdm9pZCBhcHBlbmRGaWxlc0FzU2hhcmVhYmxlVVJMcyhSZXRhaW5QdHI8TlNNdXRhYmxl QXJyYXk+JiYgc2hhcmVEYXRhQXJyYQogICAgIHJldHVybiBmaWxlVVJMOwogfQogCisjaWYgUExB VEZPUk0oTUFDKQorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisjaW1wb3J0IDxXZWJLaXRB ZGRpdGlvbnMvV0tTaGFyZVNoZWV0QWRkaXRpb25zLm1tPgorI2Vsc2UKKy0gKEJPT0wpY2FuU2hv d1BpY2tlckFzeW5jOihOU1NoYXJpbmdTZXJ2aWNlUGlja2VyICopcGlja2VyCit7CisKK30KKy0g KHZvaWQpc2hvd1BpY2tlckFzeW5jOihOU1NoYXJpbmdTZXJ2aWNlUGlja2VyICopcGlja2VyIHNo b3dSZWxhdGl2ZVRvUmVjdDooTlNSZWN0KXByZXNlbnRhdGlvblJlY3Qgb2ZWaWV3OihXS1dlYlZp ZXcgKil3ZWJWaWV3IGNvbXBsZXRpb246KHZvaWQgKF4pKHZvaWQpKWNvbXBsZXRpb25IYW5kbGVy Cit7CisKK30KKyNlbmRpZgorI2VuZGlmCisKIEBlbmQKIAogI2VuZGlmIC8vIFBMQVRGT1JNKENP Q09BKSAmJiAhUExBVEZPUk0oV0FUQ0hPUykgJiYgIVBMQVRGT1JNKEFQUExFVFYpCg== 452533 2022-02-18 09:57:51 -0800 2022-02-18 14:41:54 -0800 Patch bug-236823-20220218095750.patch text/plain 3885 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5OTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjNTk4OTJiYTIxN2I1OTEz M2U4ZDFkYzczYTQ2NTBlZmQzNjRjMGYuLjFjN2M5ZDJiY2M2YzcyY2EwZWNhYjI3YjNmMWI0NzFm ZTE2NjFkNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDItMTcgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGFzeW5jIE5T U2hhcmluZ1NlcnZpY2VQaWNrZXIgbWVudSBpZiBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjgyMworICAgICAgICA8cmRhcjovL3By b2JsZW0vODg4NTg2MDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGVhbiBKYWNrc29uLgorCisg ICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dLU2hhcmVTaGVldC5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQubW06CisgICAgICAgICgtW1dLU2hhcmVTaGVldCBwcmVz ZW50V2l0aFNoYXJlRGF0YUFycmF5OmluUmVjdDpdKToKKyAgICAgICAgKC1bV0tTaGFyZVNoZWV0 IGNhblNob3dQaWNrZXJBc3luYzpdKToKKyAgICAgICAgKC1bV0tTaGFyZVNoZWV0IHNob3dQaWNr ZXJBc3luYzpjb21wbGV0aW9uSGFuZGxlcjpdKToKKwogMjAyMi0wMi0xNSAgTXlsZXMgQy4gTWF4 ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHUFVdIFVwZGF0ZSBJ RExzIGFuZCBzdHVicyB0byBsYXRlc3QgdmVyc2lvbiBvZiB0aGUgc3BlYwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTaGFyZVNoZWV0LmggYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQuaAppbmRleCAxZDVlYzI5NjJiZGZlM2Ni ZDY5OGNkMDIzNDkwYmI5OWU2YTNiMzc2Li5mYzUwOTEzMTcxZmJiNDNjZTRiMzU2ODZmNjM4ZjEx MzkzMWYyNzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1No YXJlU2hlZXQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hl ZXQuaApAQCAtNDEsNiArNDEsMTEgQEAgc3RydWN0IFNoYXJlRGF0YVdpdGhQYXJzZWRVUkw7CiAt ICh2b2lkKXByZXNlbnRXaXRoUGFyYW1ldGVyczooY29uc3QgV2ViQ29yZTo6U2hhcmVEYXRhV2l0 aFBhcnNlZFVSTCYpZGF0YSBpblJlY3Q6KHN0ZDo6b3B0aW9uYWw8V2ViQ29yZTo6RmxvYXRSZWN0 PilyZWN0IGNvbXBsZXRpb25IYW5kbGVyOihXVEY6OkNvbXBsZXRpb25IYW5kbGVyPHZvaWQoYm9v bCk+JiYpY29tcGxldGlvbkhhbmRsZXI7CiAtICh2b2lkKWRpc21pc3M7CiAKKyNpZiBQTEFURk9S TShNQUMpCistIChCT09MKWNhblNob3dQaWNrZXJBc3luYzooTlNTaGFyaW5nU2VydmljZVBpY2tl ciAqKXBpY2tlcjsKKy0gKHZvaWQpc2hvd1BpY2tlckFzeW5jOihOU1NoYXJpbmdTZXJ2aWNlUGlj a2VyICopcGlja2VyIHNob3dSZWxhdGl2ZVRvUmVjdDooTlNSZWN0KXByZXNlbnRhdGlvblJlY3Qg b2ZWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGNvbXBsZXRpb246KHZvaWQgKF4pKHZvaWQpKWNv bXBsZXRpb25IYW5kbGVyOworI2VuZGlmCisKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCB3ZWFrKSBp ZCA8V0tTaGFyZVNoZWV0RGVsZWdhdGU+IGRlbGVnYXRlOwogQGVuZAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQubW0gYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1NoYXJlU2hlZXQubW0KaW5kZXggZTM0ZDU3MGE1OWJlYzI2 ZmJmNmJlM2E2ZGY2NDZlNTA5YWVmMTYzMy4uNTU0YWI4MDY0MjdlY2I5Y2U4MzBhY2E5N2ZjN2Rk Y2RjOTg1M2UxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tT aGFyZVNoZWV0Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2hhcmVT aGVldC5tbQpAQCAtNDYsNiArNDYsMTAgQEAKICNpbXBvcnQgPHBhbC9zcGkvbWFjL05TU2hhcmlu Z1NlcnZpY2VQaWNrZXJTUEkuaD4KICNlbmRpZgogCisjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NE SykgJiYgUExBVEZPUk0oTUFDKQorI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL1dLU2hhcmVTaGVl dEFkZGl0aW9uc0JlZm9yZS5tbT4KKyNlbmRpZgorCiAjaWYgUExBVEZPUk0oTUFDKQogQGludGVy ZmFjZSBXS1NoYXJlU2hlZXQgKCkgPE5TU2hhcmluZ1NlcnZpY2VEZWxlZ2F0ZSwgTlNTaGFyaW5n U2VydmljZVBpY2tlckRlbGVnYXRlPgogQGVuZApAQCAtMTc4LDcgKzE4MiwxMSBAQCBzdGF0aWMg dm9pZCBhcHBlbmRGaWxlc0FzU2hhcmVhYmxlVVJMcyhSZXRhaW5QdHI8TlNNdXRhYmxlQXJyYXk+ JiYgc2hhcmVEYXRhQXJyYQogICAgICAgICBOU1JlY3QgbW91c2VMb2NhdGlvbkluV2luZG93ID0g W3dlYlZpZXcud2luZG93IGNvbnZlcnRSZWN0RnJvbVNjcmVlbjptb3VzZUxvY2F0aW9uUmVjdF07 CiAgICAgICAgIHByZXNlbnRhdGlvblJlY3QgPSBbd2ViVmlldyBjb252ZXJ0UmVjdDptb3VzZUxv Y2F0aW9uSW5XaW5kb3cgZnJvbVZpZXc6bmlsXTsKICAgICB9Ci0gICAgW19zaGFyaW5nU2Vydmlj ZVBpY2tlciBzaG93UmVsYXRpdmVUb1JlY3Q6cHJlc2VudGF0aW9uUmVjdCBvZlZpZXc6d2ViVmll dyBwcmVmZXJyZWRFZGdlOk5TTWluWUVkZ2VdOworCisgICAgaWYgKFtzZWxmIGNhblNob3dQaWNr ZXJBc3luYzpfc2hhcmluZ1NlcnZpY2VQaWNrZXIuZ2V0KCldKQorICAgICAgICBbc2VsZiBzaG93 UGlja2VyQXN5bmM6X3NoYXJpbmdTZXJ2aWNlUGlja2VyLmdldCgpIHNob3dSZWxhdGl2ZVRvUmVj dDpwcmVzZW50YXRpb25SZWN0IG9mVmlldzp3ZWJWaWV3IGNvbXBsZXRpb246XnsgfV07CisgICAg ZWxzZQorICAgICAgICBbX3NoYXJpbmdTZXJ2aWNlUGlja2VyIHNob3dSZWxhdGl2ZVRvUmVjdDpw cmVzZW50YXRpb25SZWN0IG9mVmlldzp3ZWJWaWV3IHByZWZlcnJlZEVkZ2U6TlNNaW5ZRWRnZV07 CiAjZWxzZQogICAgIF9zaGFyZVNoZWV0Vmlld0NvbnRyb2xsZXIgPSBhZG9wdE5TKFtbVUlBY3Rp dml0eVZpZXdDb250cm9sbGVyIGFsbG9jXSBpbml0V2l0aEFjdGl2aXR5SXRlbXM6c2hhcmluZ0l0 ZW1zIGFwcGxpY2F0aW9uQWN0aXZpdGllczpuaWxdKTsKIApAQCAtMzYyLDYgKzM3MCwyMSBAQCBz dGF0aWMgdm9pZCBhcHBlbmRGaWxlc0FzU2hhcmVhYmxlVVJMcyhSZXRhaW5QdHI8TlNNdXRhYmxl QXJyYXk+JiYgc2hhcmVEYXRhQXJyYQogICAgIHJldHVybiBmaWxlVVJMOwogfQogCisjaWYgUExB VEZPUk0oTUFDKQorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisjaW1wb3J0IDxXZWJLaXRB ZGRpdGlvbnMvV0tTaGFyZVNoZWV0QWRkaXRpb25zLm1tPgorI2Vsc2UKKy0gKEJPT0wpY2FuU2hv d1BpY2tlckFzeW5jOihOU1NoYXJpbmdTZXJ2aWNlUGlja2VyICopcGlja2VyCit7CisgICAgcmV0 dXJuIGZhbHNlOworfQorLSAodm9pZClzaG93UGlja2VyQXN5bmM6KE5TU2hhcmluZ1NlcnZpY2VQ aWNrZXIgKilwaWNrZXIgc2hvd1JlbGF0aXZlVG9SZWN0OihOU1JlY3QpcHJlc2VudGF0aW9uUmVj dCBvZlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgY29tcGxldGlvbjoodm9pZCAoXikodm9pZCkp Y29tcGxldGlvbkhhbmRsZXIKK3sKKworfQorI2VuZGlmCisjZW5kaWYKKwogQGVuZAogCiAjZW5k aWYgLy8gUExBVEZPUk0oQ09DT0EpICYmICFQTEFURk9STShXQVRDSE9TKSAmJiAhUExBVEZPUk0o QVBQTEVUVikK