236799 2022-02-17 12:31:03 -0800 REGRESSION(r290052): Broke the Mac Catalina build 2022-02-17 12:35:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 236753 1 commit-queue commit-queue akeerthi webkit-bug-importer wenson_hsieh oldest_to_newest 1843052 0 commit-queue 2022-02-17 12:31:03 -0800 https://commits.webkit.org/r290052 introduced a regression: Broke the Mac Catalina build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1843054 1 452411 commit-queue 2022-02-17 12:31:11 -0800 Created attachment 452411 REVERT of r290052 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1843061 2 ews-feeder 2022-02-17 12:34:58 -0800 Committed r290053 (247423@main): <https://commits.webkit.org/247423@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452411. 1843062 3 webkit-bug-importer 2022-02-17 12:35:26 -0800 <rdar://problem/89102818> 452411 2022-02-17 12:31:11 -0800 2022-02-17 12:35:00 -0800 REVERT of r290052 bug-236799-20220217123111.patch text/plain 5218 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJiN2UyYWRlMTg0MmQy MzU5OTdkYTY1MGFiY2I4YWQ1NmZhOTM5My4uMjMwYWI4YWRjZjExYjM1YjRlMTlmYzFjYjY0MTY1 OTMyNDQ4NGU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTE3ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI5MDA1Mi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzNjc5OQorCisgICAgICAgIEJyb2tlIHRoZSBNYWMgQ2F0YWxpbmEgYnVp bGQKKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIlttYWNPU10gTGln aHQgYXBwZWFyYW5jZSB0ZXh0IGZpZWxkcyBhcmUgaW52aXNpYmxlIGluCisgICAgICAgIEluY3Jl YXNlZCBDb250cmFzdCBtb2RlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM2NzUzCisgICAgICAgIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnL3Iy OTAwNTIKKwogMjAyMi0wMi0xNyAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+ CiAKICAgICAgICAgW21hY09TXSBMaWdodCBhcHBlYXJhbmNlIHRleHQgZmllbGRzIGFyZSBpbnZp c2libGUgaW4gSW5jcmVhc2VkIENvbnRyYXN0IG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lTWFjLmgKaW5kZXggNWZlYTVhYTdkNTEyZDc0MTdhOGYyZGJkOTczYWJkNGRj YzNjNDYwYS4uMGUyZDFhOThlMGNhYWU0ODExOTNmMGIwMmM1NDlkNjQxM2JmYmJkOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgKQEAgLTE2NSw4ICsxNjUsNiBA QCBwcml2YXRlOgogcHJpdmF0ZToKICAgICBTdHJpbmcgZmlsZUxpc3ROYW1lRm9yV2lkdGgoY29u c3QgRmlsZUxpc3QqLCBjb25zdCBGb250Q2FzY2FkZSYsIGludCB3aWR0aCwgYm9vbCBtdWx0aXBs ZUZpbGVzQWxsb3dlZCkgY29uc3QgZmluYWw7CiAKLSAgICBib29sIHNob3VsZFBhaW50Q3VzdG9t VGV4dEZpZWxkKGNvbnN0IFJlbmRlck9iamVjdCYpIGNvbnN0OwotCiAgICAgQ29sb3Igc3lzdGVt Q29sb3IoQ1NTVmFsdWVJRCwgT3B0aW9uU2V0PFN0eWxlQ29sb3JPcHRpb25zPikgY29uc3QgZmlu YWw7CiAKICAgICAvLyBHZXQgdGhlIGNvbnRyb2wgc2l6ZSBiYXNlZCBvZmYgdGhlIGZvbnQuIFVz ZWQgYnkgc29tZSBvZiB0aGUgY29udHJvbHMgKGxpa2UgYnV0dG9ucykuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0gYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KaW5kZXggY2RhOTMxZDNmOWQyMjZiY2RjMzcw MDgxYzViN2ZmNWIzYjU2MmQ1Mi4uMGYzOTE2NjdkNzIxNGE2ODRiYjUzMjQzYTM1MTIyMmU0ZTM0 OWY2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQpAQCAt MTA5NSw1MiArMTA5NSwyNyBAQCB2b2lkIFJlbmRlclRoZW1lTWFjOjphZGp1c3RJbWFnZUNvbnRy b2xzQnV0dG9uU3R5bGUoUmVuZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBFbAogfQogI2VuZGlmCiAK LWJvb2wgUmVuZGVyVGhlbWVNYWM6OnNob3VsZFBhaW50Q3VzdG9tVGV4dEZpZWxkKGNvbnN0IFJl bmRlck9iamVjdCYgcmVuZGVyZXIpIGNvbnN0Ci17Ci0gICAgLy8gPHJkYXI6Ly9wcm9ibGVtLzg4 OTQ4NjQ2PiBQcmV2ZW50IEFwcEtpdCBmcm9tIHBhaW50aW5nIHRleHQgZmllbGRzIGluIHRoZSBs aWdodCBhcHBlYXJhbmNlCi0gICAgLy8gd2l0aCBpbmNyZWFzZWQgY29udHJhc3QsIGFzIHRoZSBi b3JkZXIgaXMgbm90IHBhaW50ZWQsIHJlbmRlcmluZyB0aGUgY29udHJvbCBpbnZpc2libGUuCi0j aWYgSEFWRV9MQVJHRV9DT05UUk9MX1NJWkUKLSAgICByZXR1cm4gVGhlbWU6OnNpbmdsZXRvbigp LnVzZXJQcmVmZXJzQ29udHJhc3QoKSAmJiAhcmVuZGVyZXIudXNlRGFya0FwcGVhcmFuY2UoKTsK LSNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKHJlbmRlcmVyKTsKLSAgICByZXR1cm4gZmFsc2U7Ci0j ZW5kaWYKLX0KLQogYm9vbCBSZW5kZXJUaGVtZU1hYzo6cGFpbnRUZXh0RmllbGQoY29uc3QgUmVu ZGVyT2JqZWN0JiBvLCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgRmxvYXRSZWN0 JiByKQogewotICAgIEZsb2F0UmVjdCBwYWludFJlY3Qocik7Ci0gICAgYXV0byYgY29udGV4dCA9 IHBhaW50SW5mby5jb250ZXh0KCk7CisgICAgTG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0IGxv Y2FsQ29udGV4dChwYWludEluZm8uY29udGV4dCgpKTsKIAotICAgIExvY2FsQ3VycmVudEdyYXBo aWNzQ29udGV4dCBsb2NhbENvbnRleHQoY29udGV4dCk7Ci0gICAgR3JhcGhpY3NDb250ZXh0U3Rh dGVTYXZlciBzdGF0ZVNhdmVyKGNvbnRleHQpOworICAgIC8vIDxyZGFyOi8vcHJvYmxlbS8yMjg5 Njk3Nz4gV2UgYWRqdXN0IHRoZSBwYWludCByZWN0IGhlcmUgdG8gYWNjb3VudCBmb3IgaG93IEFw cEtpdCBkcmF3cyB0aGUgdGV4dAorICAgIC8vIGZpZWxkIGNlbGwgc2xpZ2h0bHkgc21hbGxlciB0 aGFuIHRoZSByZWN0IHdlIHBhc3MgdG8gZHJhd1dpdGhGcmFtZS4KKyAgICBGbG9hdFJlY3QgYWRq dXN0ZWRQYWludFJlY3Qocik7CisgICAgQWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybSA9IHBhaW50 SW5mby5jb250ZXh0KCkuZ2V0Q1RNKCk7CisgICAgaWYgKHRyYW5zZm9ybS54U2NhbGUoKSA+IDEg fHwgdHJhbnNmb3JtLnlTY2FsZSgpID4gMSkgeworICAgICAgICBhZGp1c3RlZFBhaW50UmVjdC5p bmZsYXRlWCgxIC8gdHJhbnNmb3JtLnhTY2FsZSgpKTsKKyAgICAgICAgYWRqdXN0ZWRQYWludFJl Y3QuaW5mbGF0ZVkoMiAvIHRyYW5zZm9ybS55U2NhbGUoKSk7CisgICAgICAgIGFkanVzdGVkUGFp bnRSZWN0Lm1vdmUoMCwgLTEgLyB0cmFuc2Zvcm0ueVNjYWxlKCkpOworICAgIH0KKyAgICBOU1Rl eHRGaWVsZENlbGwgKnRleHRGaWVsZCA9IHRoaXMtPnRleHRGaWVsZCgpOwogCi0gICAgYXV0byBl bmFibGVkID0gaXNFbmFibGVkKG8pICYmICFpc1JlYWRPbmx5Q29udHJvbChvKTsKLQotICAgIGlm IChzaG91bGRQYWludEN1c3RvbVRleHRGaWVsZChvKSkgewotICAgICAgICBjb25zdGV4cHIgaW50 IHN0cm9rZVRoaWNrbmVzcyA9IDE7Ci0KLSAgICAgICAgRmxvYXRSZWN0IHN0cm9rZVJlY3QocGFp bnRSZWN0KTsKLSAgICAgICAgc3Ryb2tlUmVjdC5pbmZsYXRlKC1zdHJva2VUaGlja25lc3MgLyAy LjBmKTsKLQotICAgICAgICBjb250ZXh0LnNldFN0cm9rZUNvbG9yKGVuYWJsZWQgPyBDb2xvcjo6 YmxhY2sgOiBDb2xvcjo6ZGFya0dyYXkpOwotICAgICAgICBjb250ZXh0LnNldFN0cm9rZVN0eWxl KFNvbGlkU3Ryb2tlKTsKLSAgICAgICAgY29udGV4dC5zdHJva2VSZWN0KHN0cm9rZVJlY3QsIHN0 cm9rZVRoaWNrbmVzcyk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgLy8gPHJkYXI6Ly9wcm9ibGVt LzIyODk2OTc3PiBXZSBhZGp1c3QgdGhlIHBhaW50IHJlY3QgaGVyZSB0byBhY2NvdW50IGZvciBo b3cgQXBwS2l0IGRyYXdzIHRoZSB0ZXh0Ci0gICAgICAgIC8vIGZpZWxkIGNlbGwgc2xpZ2h0bHkg c21hbGxlciB0aGFuIHRoZSByZWN0IHdlIHBhc3MgdG8gZHJhd1dpdGhGcmFtZS4KLSAgICAgICAg QWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybSA9IGNvbnRleHQuZ2V0Q1RNKCk7Ci0gICAgICAgIGlm ICh0cmFuc2Zvcm0ueFNjYWxlKCkgPiAxIHx8IHRyYW5zZm9ybS55U2NhbGUoKSA+IDEpIHsKLSAg ICAgICAgICAgIHBhaW50UmVjdC5pbmZsYXRlWCgxIC8gdHJhbnNmb3JtLnhTY2FsZSgpKTsKLSAg ICAgICAgICAgIHBhaW50UmVjdC5pbmZsYXRlWSgyIC8gdHJhbnNmb3JtLnlTY2FsZSgpKTsKLSAg ICAgICAgICAgIHBhaW50UmVjdC5tb3ZlKDAsIC0xIC8gdHJhbnNmb3JtLnlTY2FsZSgpKTsKLSAg ICAgICAgfQorICAgIEdyYXBoaWNzQ29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcihwYWludElu Zm8uY29udGV4dCgpKTsKIAotICAgICAgICBOU1RleHRGaWVsZENlbGwgKnRleHRGaWVsZCA9IHRo aXMtPnRleHRGaWVsZCgpOwotICAgICAgICBbdGV4dEZpZWxkIHNldEVuYWJsZWQ6ZW5hYmxlZF07 Ci0gICAgICAgIFt0ZXh0RmllbGQgZHJhd1dpdGhGcmFtZTpOU1JlY3QocGFpbnRSZWN0KSBpblZp ZXc6ZG9jdW1lbnRWaWV3Rm9yKG8pXTsKLSAgICAgICAgW3RleHRGaWVsZCBzZXRDb250cm9sVmll dzpuaWxdOwotICAgIH0KKyAgICBbdGV4dEZpZWxkIHNldEVuYWJsZWQ6KGlzRW5hYmxlZChvKSAm JiAhaXNSZWFkT25seUNvbnRyb2wobykpXTsKKyAgICBbdGV4dEZpZWxkIGRyYXdXaXRoRnJhbWU6 TlNSZWN0KGFkanVzdGVkUGFpbnRSZWN0KSBpblZpZXc6ZG9jdW1lbnRWaWV3Rm9yKG8pXTsKKwor ICAgIFt0ZXh0RmllbGQgc2V0Q29udHJvbFZpZXc6bmlsXTsKIAogI2lmIEVOQUJMRShEQVRBTElT VF9FTEVNRU5UKQogICAgIGlmICghaXM8SFRNTElucHV0RWxlbWVudD4oby5nZW5lcmF0aW5nTm9k ZSgpKSkKQEAgLTExNDgsNyArMTEyMyw3IEBAIGJvb2wgUmVuZGVyVGhlbWVNYWM6OnBhaW50VGV4 dEZpZWxkKGNvbnN0IFJlbmRlck9iamVjdCYgbywgY29uc3QgUGFpbnRJbmZvJiBwYWluCiAKICAg ICBjb25zdCBhdXRvJiBpbnB1dCA9IGRvd25jYXN0PEhUTUxJbnB1dEVsZW1lbnQ+KCooby5nZW5l cmF0aW5nTm9kZSgpKSk7CiAgICAgaWYgKGlucHV0Lmxpc3QoKSkKLSAgICAgICAgcGFpbnRMaXN0 QnV0dG9uRm9ySW5wdXQobywgY29udGV4dCwgcGFpbnRSZWN0KTsKKyAgICAgICAgcGFpbnRMaXN0 QnV0dG9uRm9ySW5wdXQobywgcGFpbnRJbmZvLmNvbnRleHQoKSwgYWRqdXN0ZWRQYWludFJlY3Qp OwogI2VuZGlmCiAKICAgICByZXR1cm4gZmFsc2U7Cg==