236797 2022-02-17 12:16:51 -0800 REGRESSION(r290046): Broke the macOS build 2022-02-17 12:24:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 236753 1 commit-queue commit-queue aakash_jain akeerthi webkit-bug-importer wenson_hsieh oldest_to_newest 1843031 0 commit-queue 2022-02-17 12:16:51 -0800 https://commits.webkit.org/r290046 introduced a regression: Broke the macOS build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1843033 1 452405 commit-queue 2022-02-17 12:16:59 -0800 Created attachment 452405 [fast-cq] REVERT of r290046 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1843040 2 ews-feeder 2022-02-17 12:23:02 -0800 Committed r290050 (247420@main): <https://commits.webkit.org/247420@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452405. 1843045 3 webkit-bug-importer 2022-02-17 12:24:18 -0800 <rdar://problem/89102303> 452405 2022-02-17 12:16:59 -0800 2022-02-17 12:23:04 -0800 [fast-cq] REVERT of r290046 bug-236797-20220217121659.patch text/plain 5229 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZkZDk4YjAxM2ZmNjE1 MzA0MTA5ODM1MzAyZDM3YmQzMTU1MGZjMi4uOWVlMWI4ZDMwY2NmMmEwMTMzMGFlODJkYWI1ZTI3 MDY0MDYyMzRiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTE3ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI5MDA0Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzNjc5NworCisgICAgICAgIEJyb2tlIHRoZSBtYWNPUyBidWlsZAorCisg ICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAgICAiW21hY09TXSBMaWdodCBhcHBl YXJhbmNlIHRleHQgZmllbGRzIGFyZSBpbnZpc2libGUgaW4KKyAgICAgICAgSW5jcmVhc2VkIENv bnRyYXN0IG1vZGUiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzY3NTMKKyAgICAgICAgaHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvcjI5MDA0Ngor CiAyMDIyLTAyLTE3ICBQYXRyaWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBbRmxleGJveF0gR2FwcyBhbmQgZnJlZSBzcGFjZSBkbyBub3QgaGF2 ZSBwYXR0ZXJuIGZpbGxzIHdoZW4gbmF2aWdhdGluZyB0byBhIHBhZ2Ugd2l0aCBXZWIgSW5zcGVj dG9yIGFscmVhZHkgb3BlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lTWFjLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMu aAppbmRleCA1ZmVhNWFhN2Q1MTJkNzQxN2E4ZjJkYmQ5NzNhYmQ0ZGNjM2M0NjBhLi4wZTJkMWE5 OGUwY2FhZTQ4MTE5M2YwYjAyYzU0OWQ2NDEzYmZiYmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWVNYWMuaApAQCAtMTY1LDggKzE2NSw2IEBAIHByaXZhdGU6CiBwcml2 YXRlOgogICAgIFN0cmluZyBmaWxlTGlzdE5hbWVGb3JXaWR0aChjb25zdCBGaWxlTGlzdCosIGNv bnN0IEZvbnRDYXNjYWRlJiwgaW50IHdpZHRoLCBib29sIG11bHRpcGxlRmlsZXNBbGxvd2VkKSBj b25zdCBmaW5hbDsKIAotICAgIGJvb2wgc2hvdWxkUGFpbnRDdXN0b21UZXh0RmllbGQoY29uc3Qg UmVuZGVyT2JqZWN0JikgY29uc3Q7Ci0KICAgICBDb2xvciBzeXN0ZW1Db2xvcihDU1NWYWx1ZUlE LCBPcHRpb25TZXQ8U3R5bGVDb2xvck9wdGlvbnM+KSBjb25zdCBmaW5hbDsKIAogICAgIC8vIEdl dCB0aGUgY29udHJvbCBzaXplIGJhc2VkIG9mZiB0aGUgZm9udC4gVXNlZCBieSBzb21lIG9mIHRo ZSBjb250cm9scyAobGlrZSBidXR0b25zKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZU1hYy5tbQppbmRleCBjZGE3NmRjNzkwNmYzZDk4NTQ2OGMwMWYwOGZjZmMyZGRhM2Q5 MTZjLi4wZjM5MTY2N2Q3MjE0YTY4NGJiNTMyNDNhMzUxMjIyZTRlMzQ5ZjY4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCkBAIC0xMDk1LDUxICsxMDk1LDI3 IEBAIHZvaWQgUmVuZGVyVGhlbWVNYWM6OmFkanVzdEltYWdlQ29udHJvbHNCdXR0b25TdHlsZShS ZW5kZXJTdHlsZSYgc3R5bGUsIGNvbnN0IEVsCiB9CiAjZW5kaWYKIAotYm9vbCBSZW5kZXJUaGVt ZU1hYzo6c2hvdWxkUGFpbnRDdXN0b21UZXh0RmllbGQoY29uc3QgUmVuZGVyT2JqZWN0JiByZW5k ZXJlcikgY29uc3QKLXsKLSAgICAvLyA8cmRhcjovL3Byb2JsZW0vODg5NDg2NDY+IFByZXZlbnQg QXBwS2l0IGZyb20gcGFpbnRpbmcgdGV4dGZpZWxkcyBpbiB0aGUgbGlnaHQgYXBwZWFyYW5jZQot ICAgIC8vIHdpdGggaW5jcmVhc2VkIGNvbnRyYXN0LCBhcyB0aGUgYm9yZGVyIGlzIG5vdCBwYWlu dGVkLCByZW5kZXJpbmcgdGhlIGNvbnRyb2wgaW52aXNpYmxlLgotI2lmIEhBVkVfTEFSR0VfQ09O VFJPTF9TSVpFCi0gICAgcmV0dXJuIFRoZW1lOjpzaW5nbGV0b24oKS51c2VyUHJlZmVyc0NvbnRy YXN0KCkgJiYgIXJlbmRlcmVyLnVzZURhcmtBcHBlYXJhbmNlKCk7Ci0jZWxzZQotICAgIHJldHVy biBmYWxzZTsKLSNlbmRpZgotfQotCiBib29sIFJlbmRlclRoZW1lTWFjOjpwYWludFRleHRGaWVs ZChjb25zdCBSZW5kZXJPYmplY3QmIG8sIGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25z dCBGbG9hdFJlY3QmIHIpCiB7Ci0gICAgRmxvYXRSZWN0IHBhaW50UmVjdChyKTsKLSAgICBhdXRv JiBjb250ZXh0ID0gcGFpbnRJbmZvLmNvbnRleHQoKTsKKyAgICBMb2NhbEN1cnJlbnRHcmFwaGlj c0NvbnRleHQgbG9jYWxDb250ZXh0KHBhaW50SW5mby5jb250ZXh0KCkpOwogCi0gICAgTG9jYWxD dXJyZW50R3JhcGhpY3NDb250ZXh0IGxvY2FsQ29udGV4dChjb250ZXh0KTsKLSAgICBHcmFwaGlj c0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoY29udGV4dCk7CisgICAgLy8gPHJkYXI6Ly9w cm9ibGVtLzIyODk2OTc3PiBXZSBhZGp1c3QgdGhlIHBhaW50IHJlY3QgaGVyZSB0byBhY2NvdW50 IGZvciBob3cgQXBwS2l0IGRyYXdzIHRoZSB0ZXh0CisgICAgLy8gZmllbGQgY2VsbCBzbGlnaHRs eSBzbWFsbGVyIHRoYW4gdGhlIHJlY3Qgd2UgcGFzcyB0byBkcmF3V2l0aEZyYW1lLgorICAgIEZs b2F0UmVjdCBhZGp1c3RlZFBhaW50UmVjdChyKTsKKyAgICBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNm b3JtID0gcGFpbnRJbmZvLmNvbnRleHQoKS5nZXRDVE0oKTsKKyAgICBpZiAodHJhbnNmb3JtLnhT Y2FsZSgpID4gMSB8fCB0cmFuc2Zvcm0ueVNjYWxlKCkgPiAxKSB7CisgICAgICAgIGFkanVzdGVk UGFpbnRSZWN0LmluZmxhdGVYKDEgLyB0cmFuc2Zvcm0ueFNjYWxlKCkpOworICAgICAgICBhZGp1 c3RlZFBhaW50UmVjdC5pbmZsYXRlWSgyIC8gdHJhbnNmb3JtLnlTY2FsZSgpKTsKKyAgICAgICAg YWRqdXN0ZWRQYWludFJlY3QubW92ZSgwLCAtMSAvIHRyYW5zZm9ybS55U2NhbGUoKSk7CisgICAg fQorICAgIE5TVGV4dEZpZWxkQ2VsbCAqdGV4dEZpZWxkID0gdGhpcy0+dGV4dEZpZWxkKCk7CiAK LSAgICBhdXRvIGVuYWJsZWQgPSBpc0VuYWJsZWQobykgJiYgIWlzUmVhZE9ubHlDb250cm9sKG8p OwotCi0gICAgaWYgKHNob3VsZFBhaW50Q3VzdG9tVGV4dEZpZWxkKG8pKSB7Ci0gICAgICAgIGNv bnN0ZXhwciBpbnQgc3Ryb2tlVGhpY2tuZXNzID0gMTsKLQotICAgICAgICBGbG9hdFJlY3Qgc3Ry b2tlUmVjdChwYWludFJlY3QpOwotICAgICAgICBzdHJva2VSZWN0LmluZmxhdGUoLXN0cm9rZVRo aWNrbmVzcyAvIDIuMGYpOwotCi0gICAgICAgIGNvbnRleHQuc2V0U3Ryb2tlQ29sb3IoZW5hYmxl ZCA/IENvbG9yOjpibGFjayA6IENvbG9yOjpkYXJrR3JheSk7Ci0gICAgICAgIGNvbnRleHQuc2V0 U3Ryb2tlU3R5bGUoU29saWRTdHJva2UpOwotICAgICAgICBjb250ZXh0LnN0cm9rZVJlY3Qoc3Ry b2tlUmVjdCwgc3Ryb2tlVGhpY2tuZXNzKTsKLSAgICB9IGVsc2UgewotICAgICAgICAvLyA8cmRh cjovL3Byb2JsZW0vMjI4OTY5Nzc+IFdlIGFkanVzdCB0aGUgcGFpbnQgcmVjdCBoZXJlIHRvIGFj Y291bnQgZm9yIGhvdyBBcHBLaXQgZHJhd3MgdGhlIHRleHQKLSAgICAgICAgLy8gZmllbGQgY2Vs bCBzbGlnaHRseSBzbWFsbGVyIHRoYW4gdGhlIHJlY3Qgd2UgcGFzcyB0byBkcmF3V2l0aEZyYW1l LgotICAgICAgICBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtID0gY29udGV4dC5nZXRDVE0oKTsK LSAgICAgICAgaWYgKHRyYW5zZm9ybS54U2NhbGUoKSA+IDEgfHwgdHJhbnNmb3JtLnlTY2FsZSgp ID4gMSkgewotICAgICAgICAgICAgcGFpbnRSZWN0LmluZmxhdGVYKDEgLyB0cmFuc2Zvcm0ueFNj YWxlKCkpOwotICAgICAgICAgICAgcGFpbnRSZWN0LmluZmxhdGVZKDIgLyB0cmFuc2Zvcm0ueVNj YWxlKCkpOwotICAgICAgICAgICAgcGFpbnRSZWN0Lm1vdmUoMCwgLTEgLyB0cmFuc2Zvcm0ueVNj YWxlKCkpOwotICAgICAgICB9CisgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNh dmVyKHBhaW50SW5mby5jb250ZXh0KCkpOwogCi0gICAgICAgIE5TVGV4dEZpZWxkQ2VsbCAqdGV4 dEZpZWxkID0gdGhpcy0+dGV4dEZpZWxkKCk7Ci0gICAgICAgIFt0ZXh0RmllbGQgc2V0RW5hYmxl ZDplbmFibGVkXTsKLSAgICAgICAgW3RleHRGaWVsZCBkcmF3V2l0aEZyYW1lOk5TUmVjdChwYWlu dFJlY3QpIGluVmlldzpkb2N1bWVudFZpZXdGb3IobyldOwotICAgICAgICBbdGV4dEZpZWxkIHNl dENvbnRyb2xWaWV3Om5pbF07Ci0gICAgfQorICAgIFt0ZXh0RmllbGQgc2V0RW5hYmxlZDooaXNF bmFibGVkKG8pICYmICFpc1JlYWRPbmx5Q29udHJvbChvKSldOworICAgIFt0ZXh0RmllbGQgZHJh d1dpdGhGcmFtZTpOU1JlY3QoYWRqdXN0ZWRQYWludFJlY3QpIGluVmlldzpkb2N1bWVudFZpZXdG b3IobyldOworCisgICAgW3RleHRGaWVsZCBzZXRDb250cm9sVmlldzpuaWxdOwogCiAjaWYgRU5B QkxFKERBVEFMSVNUX0VMRU1FTlQpCiAgICAgaWYgKCFpczxIVE1MSW5wdXRFbGVtZW50PihvLmdl bmVyYXRpbmdOb2RlKCkpKQpAQCAtMTE0Nyw3ICsxMTIzLDcgQEAgYm9vbCBSZW5kZXJUaGVtZU1h Yzo6cGFpbnRUZXh0RmllbGQoY29uc3QgUmVuZGVyT2JqZWN0JiBvLCBjb25zdCBQYWludEluZm8m IHBhaW4KIAogICAgIGNvbnN0IGF1dG8mIGlucHV0ID0gZG93bmNhc3Q8SFRNTElucHV0RWxlbWVu dD4oKihvLmdlbmVyYXRpbmdOb2RlKCkpKTsKICAgICBpZiAoaW5wdXQubGlzdCgpKQotICAgICAg ICBwYWludExpc3RCdXR0b25Gb3JJbnB1dChvLCBjb250ZXh0LCBwYWludFJlY3QpOworICAgICAg ICBwYWludExpc3RCdXR0b25Gb3JJbnB1dChvLCBwYWludEluZm8uY29udGV4dCgpLCBhZGp1c3Rl ZFBhaW50UmVjdCk7CiAjZW5kaWYKIAogICAgIHJldHVybiBmYWxzZTsK