236789 2022-02-17 10:23:07 -0800 AX: isAXAuthenticatedCallback must be handled on the main runloop 2022-02-18 08:42:59 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w andresg_22 cfleizach webkit-bug-importer oldest_to_newest 1842959 0 tyler_w 2022-02-17 10:23:07 -0800 isAXAuthenticatedCallback in WebProcess Cocoa performs IPC to the UI process to determine if the given auditToken is valid. This causes a crash with isolated tree mode enabled as IPC must be performed on the main thread / runloop. We should dispatch to the main runloop in this function. 1842960 1 webkit-bug-importer 2022-02-17 10:23:20 -0800 <rdar://problem/89094972> 1842964 2 452385 tyler_w 2022-02-17 10:26:04 -0800 Created attachment 452385 Patch 1842973 3 452385 cfleizach 2022-02-17 10:50:41 -0800 Comment on attachment 452385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452385&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:229 > + WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::IsAXAuthenticated(auditToken), Messages::WebProcessProxy::IsAXAuthenticated::Reply(authenticated), 0); can we cache this? why do we need to keep checking this? 1842985 4 tyler_w 2022-02-17 11:14:01 -0800 (In reply to chris fleizach from comment #3) > Comment on attachment 452385 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452385&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:229 > > + WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::IsAXAuthenticated(auditToken), Messages::WebProcessProxy::IsAXAuthenticated::Reply(authenticated), 0); > > can we cache this? why do we need to keep checking this? It's requested very infrequently, once per AX client that tries to talk to the web process, so I don't think caching would be beneficial. 1843429 5 ews-feeder 2022-02-18 08:42:57 -0800 Committed r290128 (247472@main): <https://commits.webkit.org/247472@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452385. 452385 2022-02-17 10:26:04 -0800 2022-02-18 08:42:58 -0800 Patch bug-236789-20220217122603.patch text/plain 2202 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJlODJjNmEyZGMxZmQ3NGZh ZDBmYmViNGNlY2U1MTY0YjJmNjQwNjUuLmU0YjkwMGZkMjRiZGU5MjViMWU3ZTgzYTkwYWE5ZGQx MTg5MjUwMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjItMDItMTcgIFR5bGVyIFdp bGNvY2sgIDx0eWxlcl93QGFwcGxlLmNvbT4KKworICAgICAgICBBWDogaXNBWEF1dGhlbnRpY2F0 ZWRDYWxsYmFjayBtdXN0IGJlIGhhbmRsZWQgb24gdGhlIG1haW4gcnVubG9vcAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2Nzg5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaXNBWEF1dGhlbnRpY2F0ZWRD YWxsYmFjayBpbiBXZWJQcm9jZXNzQ29jb2EubW0gcGVyZm9ybXMgSVBDIHRvIHRoZSBVSSBwcm9j ZXNzCisgICAgICAgIHRvIGRldGVybWluZSBpZiB0aGUgZ2l2ZW4gYXVkaXRUb2tlbiBpcyB2YWxp ZC4gVGhpcyBjYXVzZXMgYSBjcmFzaCB3aXRoIGlzb2xhdGVkCisgICAgICAgIHRyZWUgbW9kZSBl bmFibGVkIGFzIElQQyBtdXN0IGJlIHBlcmZvcm1lZCBvbiB0aGUgbWFpbiB0aHJlYWQgLyBydW5s b29wLgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGlzIGZ1bmN0aW9uIHRvIGRpc3Bh dGNoIHRvIHRoZSBtYWluIHJ1bmxvb3AuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dl YlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6aXNBWEF1dGhlbnRpY2F0ZWRDYWxs YmFjayk6CisKIDIwMjItMDItMTYgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNv bT4KIAogICAgICAgICBSZW1vdGVWaWRlb0ZyYW1lUHJveHkgaXMgbWlzc2luZyByZWZlcmVuY2Ug ZmllbGQgZW5jb2RlLCBkZWNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29j b2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4IDNjZGY1ZGQ1NzExMjI1NzBlZDZlZjUxNzE5OWE3 N2NkZmE4MGNmZjcuLmFhYWU5OTRmMzI5YWYxYzczNDU3OGRlODY5ZTM5ZWQ4MDY1MTEyYjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5t bQpAQCAtMjI0LDcgKzIyNCwxMCBAQCBzdGF0aWMgdm9pZCBwcmV2ZW50QXBwS2l0RnJvbUNvbnRh Y3RpbmdMYXVuY2hTZXJ2aWNlcyhOU0FwcGxpY2F0aW9uKiwgU0VMKQogc3RhdGljIEJvb2xlYW4g aXNBWEF1dGhlbnRpY2F0ZWRDYWxsYmFjayhhdWRpdF90b2tlbl90IGF1ZGl0VG9rZW4pCiB7CiAg ICAgYm9vbCBhdXRoZW50aWNhdGVkID0gZmFsc2U7Ci0gICAgV2ViUHJvY2Vzczo6c2luZ2xldG9u KCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlByb2Nl c3NQcm94eTo6SXNBWEF1dGhlbnRpY2F0ZWQoYXVkaXRUb2tlbiksIE1lc3NhZ2VzOjpXZWJQcm9j ZXNzUHJveHk6OklzQVhBdXRoZW50aWNhdGVkOjpSZXBseShhdXRoZW50aWNhdGVkKSwgMCk7Cisg ICAgLy8gSVBDIG11c3QgYmUgZG9uZSBvbiB0aGUgbWFpbiBydW5sb29wLCBzbyBkaXNwYXRjaCBp dCB0byBhdm9pZCBjcmFzaGVzIHdoZW4gdGhlIHNlY29uZGFyeSBBWCB0aHJlYWQgaGFuZGxlcyB0 aGlzIGNhbGxiYWNrLgorICAgIGNhbGxPbk1haW5SdW5Mb29wQW5kV2FpdChbJmF1dGhlbnRpY2F0 ZWQsIGF1ZGl0VG9rZW5dIHsKKyAgICAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50 UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlByb2Nlc3NQcm94eTo6 SXNBWEF1dGhlbnRpY2F0ZWQoYXVkaXRUb2tlbiksIE1lc3NhZ2VzOjpXZWJQcm9jZXNzUHJveHk6 OklzQVhBdXRoZW50aWNhdGVkOjpSZXBseShhdXRoZW50aWNhdGVkKSwgMCk7CisgICAgfSk7CiAg ICAgcmV0dXJuIGF1dGhlbnRpY2F0ZWQ7CiB9CiAjZW5kaWYK