236782 2022-02-17 07:48:34 -0800 [macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button) 2022-06-02 16:13:40 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/33510 https://bugs.webkit.org/show_bug.cgi?id=240582 BrowserCompat, InRadar P2 Normal --- 185859 1 rego rego akeerthi cdumez clopez esprehn+autocc ews-watchlist kai.hollberg kangil.han koivisto me simon.fraser webkit-bug-importer youennf oldest_to_newest 1842898 0 rego 2022-02-17 07:48:34 -0800 Bug report from Twitter: https://twitter.com/LegendOfMI/status/1494110668424892416 Test case: https://codepen.io/Blondebeard/pen/JjOOgEE Clicking on the first button moves the focus to the 2nd button, we shouldn't see an outline on the 2nd button (shouldn't match :focus-visible). This is a MacOS specific issue, as it doesn't happen on WebKitGTK. Maybe the fact that buttons are not click focusable on MacOS might be the reason why this is failing, I'd need to debug this on a Mac machine to understand what's going on. 1843096 1 rego 2022-02-17 13:23:48 -0800 So this is kind of tricky, there's a test that is testing this behavior explicitly: https://wpt.fyi/results/css/selectors/focus-visible-script-focus-006.tentative.html Test title is "CSS Test (Selectors): Script focus after mouse click on a NOT focusable element does match :focus-visible". The test is marked as tentative, as it reflects current browser behavior, but might be not the intended behavior from the users POV. There's not a clear spec text about all this, the text in https://drafts.csswg.org/selectors/#the-focus-visible-pseudo is just an example: > If the previously-focused element indicated focus, and a script causes focus to move elsewhere, the newly focused element should indicate focus. Like the previous element, the button in Mac, hasn't been actually focused (even when we clicked it), then the browser indicates focus in the next element. There was an attempt to have a spec text about when to draw the focus indicator, but at the end it was discarded: https://github.com/whatwg/html/pull/6523 So I don't know what should we do regarding this issue. As usual the root issue is that buttons on Safari are not mouse focusable (see bug #229895), otherwise this would be working as expected. 1845366 2 webkit-bug-importer 2022-02-23 15:40:04 -0800 <rdar://problem/89382543> 1855970 3 kai.hollberg 2022-03-29 03:31:19 -0700 This issue is also happening on iOS (15.4) and not limited to macOS: https://twitter.com/schweinepriestr/status/1508748936252698626 In the video, https://codepen.io/Blondebeard/pen/JjOOgEE showing the outline is imho incorrect, or, to put it neutral, different from other browsers. Additionally the mentioned test https://wpt.fyi/results/css/selectors/focus-visible-script-focus-006.tentative.html?label=experimental&label=master&aligned= or rather http://wpt.live/css/selectors/focus-visible-script-focus-006.tentative.html doesn't appear to cover this issue fully, as it PASSes but clearly the behavior is different. If I understand correctly this is not speced behavior, but I would strongly urge WebKit/Safari to match the other browsers. --- Because imho the current behavior, esp. because of mobile, blocks the usage of `:focus-visible`. Out of nowhere you have all those focus indicators showing up on mobile because previously using .focus() wasn't an issue but is now after switching to `:focus-visible`, so you'd have for example - wrap `:focus-visible` in a media query only targeting a certain min-with (potentially excluding iPads or small width devices using keyboards) - not use .focus() on mobile, checking everywhere, potentially rewriting your whole application - not use `:focus-visible` All of which are unfavorable options. 1858310 4 koivisto 2022-04-05 02:38:54 -0700 Seems pretty clear we shouldn't be matching :focus-visible in this case. Maybe button click should also set wasLastFocusByClick state (even though button doesn't get focused) that prevents visible programmatic focus? 1858342 5 456693 rego 2022-04-05 04:57:34 -0700 Created attachment 456693 Patch 1858343 6 ews-watchlist 2022-04-05 04:59:14 -0700 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1858344 7 rego 2022-04-05 05:05:17 -0700 I've uploaded a workaround to fix this issue. (In reply to Kai from comment #3) > This issue is also happening on iOS (15.4) and not limited to macOS: > https://twitter.com/schweinepriestr/status/1508748936252698626 > > In the video, https://codepen.io/Blondebeard/pen/JjOOgEE showing the outline > is imho incorrect, or, to put it neutral, different from other browsers. > > Additionally the mentioned test > https://wpt.fyi/results/css/selectors/focus-visible-script-focus-006. > tentative.html?label=experimental&label=master&aligned= > or rather > http://wpt.live/css/selectors/focus-visible-script-focus-006.tentative.html > doesn't appear to cover this issue fully, as it PASSes but clearly the > behavior is different. > > If I understand correctly this is not speced behavior, but I would strongly > urge WebKit/Safari to match the other browsers. There's actually not a clear spec for all this. But this is what all browsers do when you click on a non focusable element and move focus afterwards. The key here is that buttons are not click focusable on Safari while they're in the other browsers. (In reply to Antti Koivisto from comment #4) > Seems pretty clear we shouldn't be matching :focus-visible in this case. > Maybe button click should also set wasLastFocusByClick state (even though > button doesn't get focused) that prevents visible programmatic focus? It seems clear we don't want this behavior for :focus-visible, so I provided a workaround. Still I'm not sure if the current behavior of buttons on Safari is also what we want, as other interop issues appear due to that (e.g. you click a button, you later use spacebar to click it again, and that doesn't happen as it hasn't been focused). 1858348 8 456693 koivisto 2022-04-05 05:12:46 -0700 Comment on attachment 456693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456693&action=review > Source/WebCore/page/EventHandler.cpp:2798 > +#if (!PLATFORM(GTK) && !PLATFORM(WPE)) Maybe better to say #if PLATFORM(COCOA) if we assume other platforms don't need this behavior. > Source/WebCore/page/EventHandler.cpp:2800 > + // Form control elements are not mouse focusable on some platforms (see HTMLFormControlElement::isMouseFocusable()) Could just say "Apple platforms", no need to be coy. 1858355 9 rego 2022-04-05 05:49:50 -0700 (In reply to Antti Koivisto from comment #8) > Comment on attachment 456693 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456693&action=review > > > Source/WebCore/page/EventHandler.cpp:2798 > > +#if (!PLATFORM(GTK) && !PLATFORM(WPE)) > > Maybe better to say #if PLATFORM(COCOA) if we assume other platforms don't > need this behavior. WIN port also needs this, because of the #if in HTMLFormControlElement::isMouseFocusable(). See bug #221036. That's why I preferred to put the same condition than in the other method. > > Source/WebCore/page/EventHandler.cpp:2800 > > + // Form control elements are not mouse focusable on some platforms (see HTMLFormControlElement::isMouseFocusable()) > > Could just say "Apple platforms", no need to be coy. As mentioned before it's not just Apple platforms. Win port (probably not on purpose) does the same. 1858358 10 koivisto 2022-04-05 06:06:27 -0700 > Still I'm not sure if the current behavior of buttons on Safari is also what > we want, as other interop issues appear due to that (e.g. you click a > button, you later use spacebar to click it again, and that doesn't happen as > it hasn't been focused). The right place to discuss that is bug 22261. https://bugs.webkit.org/show_bug.cgi?id=22261#c73 gives the full rationale for the current behavior. 1858361 11 rego 2022-04-05 06:20:26 -0700 (In reply to Antti Koivisto from comment #10) > > Still I'm not sure if the current behavior of buttons on Safari is also what > > we want, as other interop issues appear due to that (e.g. you click a > > button, you later use spacebar to click it again, and that doesn't happen as > > it hasn't been focused). > > The right place to discuss that is bug 22261. > https://bugs.webkit.org/show_bug.cgi?id=22261#c73 gives the full rationale > for the current behavior. Yeah I know the rationale and I've followed that discussion. Anyway that bug is now closed and the discussion has moved to https://bugs.webkit.org/show_bug.cgi?id=229895 these days. 1858423 12 ews-feeder 2022-04-05 10:06:07 -0700 Committed r292400 (249263@main): <https://commits.webkit.org/249263@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456693. 1869465 13 gsnedders 2022-05-16 15:38:43 -0700 Just to let everyone know, the fix for this has shipped in Safari 15.5. 456693 2022-04-05 04:57:34 -0700 2022-04-05 10:06:10 -0700 Patch bug-236782-20220405135732.patch text/plain 8780 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyMzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzU5YjQ5NTVlMjQ4MjJm M2VmMzhmYWJkMTA3MTEyMDFjMTI2YTFmOC4uMDU5YjJmYjc4NDk5MTg5NGQ5ZWQ4MzZhYTEzYTcz NDkzZjJiMTg3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIyLTA0LTA1ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFttYWNPU11b c2VsZWN0b3JzXSA6Zm9jdXMtdmlzaWJsZSBtYXRjaGluZyBvbiBidXR0b24gZm9jdXNlZCB2aWEg c2NyaXB0IChhZnRlciBjbGlja2luZyBvbiBhIGRpZmZlcmVudCBidXR0b24pCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY3ODIKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzg5MzgyNTQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvY3VtZW50OjptX2xhdGVzdEZvY3VzVHJpZ2dlciB3YXMgbm90IGJl aW5nIHVwZGF0ZWQgYWZ0ZXIgY2xpY2tpbmcgb24gYSBidXR0b24gKG9yIG90aGVyIGZvcm0gY29u dHJvbHMpCisgICAgICAgIG9uIHBsYXRmb3JtcyBkaWZmZXJlbnQgdGhhbiBHVEsgYW5kIFdQRS4K KyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzTW91c2VG b2N1c2FibGUoKSByZXR1cm5zIGZhbHNlIG9uIHN1Y2ggcGxhdGZvcm1zLgorCisgICAgICAgIFRo aXMgaXNzdWUgaXMgY2F1c2luZyBwcm9ibGVtcyB3aXRoIDpmb2N1cy12aXNpYmxlLCBhcyB0aGUg YnV0dG9uIGlzIG5vdCBhY3R1YWxseSBmb2N1c2VkIHZpYSBtb3VzZSBjbGljaywKKyAgICAgICAg aWYgeW91IG1vdmUgdGhlIGZvY3VzIHZpYSBzY3JpcHQgYWZ0ZXJ3YXJkcywgdGhlIG5ldyBmb2N1 c2VkIGVsZW1lbnQgYWx3YXlzIG1hdGNoIDpmb2N1cy12aXNpYmxlLgorCisgICAgICAgIFRoaXMg cGF0Y2ggaXMgYSB3b3JrYXJvdW5kIHRvIHNvbHZlIHRoYXQgaXNzdWUsIGJ5IHVwZGF0aW5nIG1f bGF0ZXN0Rm9jdXNUcmlnZ2VyIG9uIERvY3VtZW50CisgICAgICAgIGV2ZW4gaWYgdGhlIGVsZW1l bnQgaXMgbm90IGFjdHVhbGx5IGZvY3VzZWQuCisgICAgICAgIFRoYXQgd2F5IDpmb2N1cy12aXNp YmxlIGRvZXNuJ3QgbWF0Y2ggaWYgdGhlcmUncyBhIHNjcmlwdCBmb2N1cyBhZnRlcndhcmRzLgor CisgICAgICAgIEZpeCA6Zm9jdXMtdmlzaWJsZSBhZnRlciBjbGlja2luZyBvbiBhIGJ1dHRvbiBv biBNYWMKKworICAgICAgICBUZXN0OiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nz cy9zZWxlY3RvcnMvZm9jdXMtdmlzaWJsZS1zY3JpcHQtZm9jdXMtMDA4LWIuaHRtbAorCisgICAg ICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0TGF0 ZXN0Rm9jdXNUcmlnZ2VyKToKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmRpc3BhdGNoTW91c2VFdmVudCk6CisKIDIwMjIt MDQtMDUgIE5pa29sYW9zIE1vdWNodGFyaXMgIDxubW91Y2h0YXJpc0BhcHBsZS5jb20+CiAKICAg ICAgICAgU3VwcG9ydCByZW5kZXJpbmcgdXJsKCksIENTUyBiYXNpYyBzaGFwZXMgb3RoZXIgdGhh biBwYXRoKCksIGFuZCBjb29yZC1ib3ggZm9yIG9mZnNldC1wYXRoCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o CmluZGV4IDk1ZGRiNmRkYWIyMTU2NzQ4YTA0YjI5MmNmNjk3OTQ3ZDdmZmU1NTUuLjRjMjM2NDE3 ZWY1ZWVlN2Y1MWNiMTRiYjg5ZWFlMjNjOGIxNzk1MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBA IC03OTcsNiArNzk3LDcgQEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIGJvb2wgc2V0Rm9j dXNlZEVsZW1lbnQoRWxlbWVudCosIGNvbnN0IEZvY3VzT3B0aW9ucyYgPSB7IH0pOwogICAgIEVs ZW1lbnQqIGZvY3VzZWRFbGVtZW50KCkgY29uc3QgeyByZXR1cm4gbV9mb2N1c2VkRWxlbWVudC5n ZXQoKTsgfQogICAgIGJvb2wgd2FzTGFzdEZvY3VzQnlDbGljaygpIGNvbnN0IHsgcmV0dXJuIG1f bGF0ZXN0Rm9jdXNUcmlnZ2VyID09IEZvY3VzVHJpZ2dlcjo6Q2xpY2s7IH0KKyAgICB2b2lkIHNl dExhdGVzdEZvY3VzVHJpZ2dlcihGb2N1c1RyaWdnZXIgdHJpZ2dlcikgeyBtX2xhdGVzdEZvY3Vz VHJpZ2dlciA9IHRyaWdnZXI7IH0KICAgICBVc2VyQWN0aW9uRWxlbWVudFNldCYgdXNlckFjdGlv bkVsZW1lbnRzKCkgIHsgcmV0dXJuIG1fdXNlckFjdGlvbkVsZW1lbnRzOyB9CiAgICAgY29uc3Qg VXNlckFjdGlvbkVsZW1lbnRTZXQmIHVzZXJBY3Rpb25FbGVtZW50cygpIGNvbnN0IHsgcmV0dXJu IG1fdXNlckFjdGlvbkVsZW1lbnRzOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw cAppbmRleCBmMmM0ZjZjMzcxN2Y4MjQ5ZGI1MGQxY2JiZmU4NjY0ODQ0NmJjOThkLi42YWE1NDkx MmVlMjgxN2IyNjM3Y2JlZmMxZDI4NzViNTAyZmNkN2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwCkBAIC0yNzk1LDYgKzI3OTUsMTUgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmRp c3BhdGNoTW91c2VFdmVudChjb25zdCBBdG9tU3RyaW5nJiBldmVudFR5cGUsIE5vZGUqIHRhcmdl dE4KICAgICBpZiAoIWVsZW1lbnQgJiYgaXNJbnNpZGVTY3JvbGxiYXIocGxhdGZvcm1Nb3VzZUV2 ZW50LnBvc2l0aW9uKCkpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyNpZiAoIVBMQVRGT1JN KEdUSykgJiYgIVBMQVRGT1JNKFdQRSkpCisgICAgLy8gVGhpcyBpcyBhIHdvcmthcm91bmQgcmVs YXRlZCB0byA6Zm9jdXMtdmlzaWJsZSAoc2VlIHdlYmtpdC5vcmcvYi8yMzY3ODIpLgorICAgIC8v IEZvcm0gY29udHJvbCBlbGVtZW50cyBhcmUgbm90IG1vdXNlIGZvY3VzYWJsZSBvbiBzb21lIHBs YXRmb3JtcyAoc2VlIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUoKSkK KyAgICAvLyB3aGljaCBtYWtlcyB1cyBiZWhhdmUgZGlmZmVyZW50bHkgdGhhbiBvdGhlciBicm93 c2VycyB3aGVuIGEgYnV0dG9uIGlzIGNsaWNrZWQsCisgICAgLy8gYmVjYXVzZSB0aGUgYnV0dG9u IGlzIG5vdCBhY3R1YWxseSBmb2N1c2VkIHNvIHdlIGRvbid0IHNldCB0aGUgbGF0ZXN0IEZvY3Vz VHJpZ2dlci4KKyAgICBpZiAobV9lbGVtZW50VW5kZXJNb3VzZSAmJiAhbV9lbGVtZW50VW5kZXJN b3VzZS0+aXNNb3VzZUZvY3VzYWJsZSgpICYmIGlzPEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ+KG1f ZWxlbWVudFVuZGVyTW91c2UpKQorICAgICAgICBtX2ZyYW1lLmRvY3VtZW50KCktPnNldExhdGVz dEZvY3VzVHJpZ2dlcihGb2N1c1RyaWdnZXI6OkNsaWNrKTsKKyNlbmRpZgorCiAgICAgLy8gSWYg Zm9jdXMgc2hpZnQgaXMgYmxvY2tlZCwgd2UgZWF0IHRoZSBldmVudC4KICAgICBhdXRvKiBwYWdl ID0gbV9mcmFtZS5wYWdlKCk7CiAgICAgaWYgKHBhZ2UgJiYgIUNoZWNrZWRSZWYocGFnZS0+Zm9j dXNDb250cm9sbGVyKCkpLT5zZXRGb2N1c2VkRWxlbWVudChlbGVtZW50LmdldCgpLCBtX2ZyYW1l LCB7IHsgfSwgeyB9LCB7IH0sIEZvY3VzVHJpZ2dlcjo6Q2xpY2ssIHsgfSB9KSkKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDEwNmY1OWUyNTFjMDI2MGU1MWMyNDc3NDJkMmIzNTFi MDA4NjU0YjAuLjRkZjcxOWRiNWI3M2E3ZGYwZTEwZWZlOWIyYWNkNWJjYTQ3MjJhN2MgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTA0LTA1ICBN YW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFttYWNP U11bc2VsZWN0b3JzXSA6Zm9jdXMtdmlzaWJsZSBtYXRjaGluZyBvbiBidXR0b24gZm9jdXNlZCB2 aWEgc2NyaXB0IChhZnRlciBjbGlja2luZyBvbiBhIGRpZmZlcmVudCBidXR0b24pCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY3ODIKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzg5MzgyNTQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBzcGVjaWZpYyB0ZXN0IGZvciA8YnV0dG9uPiBlbGVtZW50 LgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9zZWxlY3RvcnMvZm9jdXMtdmlz aWJsZS1zY3JpcHQtZm9jdXMtMDA4LWItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB3 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL3NlbGVjdG9ycy9mb2N1cy12aXNpYmxlLXNjcmlwdC1mb2N1 cy0wMDgtYi5odG1sOiBBZGRlZC4KKwogMjAyMi0wNC0wNSAgTmlrb2xhb3MgTW91Y2h0YXJpcyAg PG5tb3VjaHRhcmlzQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IHJlbmRlcmluZyB1cmwo KSwgQ1NTIGJhc2ljIHNoYXBlcyBvdGhlciB0aGFuIHBhdGgoKSwgYW5kIGNvb3JkLWJveCBmb3Ig b2Zmc2V0LXBhdGgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvY3NzL3NlbGVjdG9ycy9mb2N1cy12aXNpYmxlLXNjcmlwdC1mb2N1cy0wMDgt Yi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9zZWxlY3RvcnMvZm9jdXMtdmlzaWJsZS1zY3JpcHQtZm9jdXMtMDA4LWItZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLmIzZGU4MjFmMjkxNzM1MDM4OWUyMjkzODk4ZmNkMDA3NTE3Njg4 YWUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2Nzcy9zZWxlY3RvcnMvZm9jdXMtdmlzaWJsZS1zY3JpcHQtZm9jdXMtMDA4LWIt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK1RoaXMgdGVzdCBjaGVja3MgdGhhdCBhIHNj cmlwdCBmb2N1cyBhZnRlciBhIG1vdXNlIGNsaWNrIG9uIGEgYnV0dG9uIHRoYXQgZG9lcyBub3Qg bWF0Y2ggOmZvY3VzIHZpc2libGUsIGRvZXMgTk9UIG1hdGNoIDpmb2N1cy12aXNpYmxlLgorCitD bGljayBvbiB0aGUgYnV0dG9uIHRoYXQgc2F5cyAiQ2xpY2sgbWUiLgorSWYgdGhlIGVsZW1lbnQg dGhhdCBzYXlzICJGb2N1c2VkIiBoYXMgYSByZWQgb3V0bGluZSB0aGVuIHRoZSB0ZXN0IHJlc3Vs dCBpcyBGQUlMVVJFLCBpZiBpdCBoYXMgYSBncmVlbiBiYWNrZ3JvdW5kIHRoZW4gdGhlIHRlc3Qg cmVzdWx0IGlzIFNVQ0NFU1MuCitDbGljayBtZQorRm9jdXNlZAorCitQQVNTICI6Zm9jdXMtdmlz aWJsZSIgc2hvdWxkIGJlIGEgdmFsaWQgc2VsZWN0b3IKK1BBU1MgU2NyaXB0IGZvY3VzIGFmdGVy IG1vdXNlIGNsaWNrIG9uIGEgYnV0dG9uIHRoYXQgZG9lcyBub3QgbWF0Y2ggOmZvY3VzLXZpc2li bGUsIGRvZXMgTk9UIG1hdGNoIDpmb2N1cy12aXNpYmxlCisKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL3NlbGVjdG9ycy9mb2N1cy12 aXNpYmxlLXNjcmlwdC1mb2N1cy0wMDgtYi5odG1sIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3Mvc2VsZWN0b3JzL2ZvY3VzLXZpc2libGUtc2NyaXB0LWZv Y3VzLTAwOC1iLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGVhNDE0ZjM0M2FhMDQyMDhiZmJmNjQzMmViNGNh ZDMwZmNjNzMyNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL3NlbGVjdG9ycy9mb2N1cy12aXNpYmxlLXNjcmlwdC1mb2N1 cy0wMDgtYi5odG1sCkBAIC0wLDAgKzEsNjQgQEAKKzwhRE9DVFlQRSBodG1sPgorPG1ldGEgY2hh cnNldD0idXRmLTgiIC8+Cis8dGl0bGU+Q1NTIFRlc3QgKFNlbGVjdG9ycyk6IFNjcmlwdCBmb2N1 cyBhZnRlciBtb3VzZSBjbGljayBvbiBhIGJ1dHRvbiB0aGF0IGRvZXMgbm90IG1hdGNoIDpmb2N1 cy12aXNpYmxlLCBkb2VzIE5PVCBtYXRjaCA6Zm9jdXMtdmlzaWJsZTwvdGl0bGU+Cis8bGluayBy ZWw9ImF1dGhvciIgdGl0bGU9Ik1hbnVlbCBSZWdvIENhc2Fzbm92YXMiIGhyZWY9Im1haWx0bzpy ZWdvQGlnYWxpYS5jb20iPgorPGxpbmsgcmVsPSJoZWxwIiBocmVmPSJodHRwczovL2RyYWZ0cy5j c3N3Zy5vcmcvc2VsZWN0b3JzLTQvI3RoZS1mb2N1cy12aXNpYmxlLXBzZXVkbyIgLz4KKzxzY3Jp cHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3Jj PSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3Jj PSIvcmVzb3VyY2VzL3Rlc3Rkcml2ZXIuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii9yZXNv dXJjZXMvdGVzdGRyaXZlci12ZW5kb3IuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii9jc3Mv c3VwcG9ydC9wYXJzaW5nLXRlc3Rjb21tb24uanMiPjwvc2NyaXB0PgorPHN0eWxlPgorICAjd2Fy bmluZyB7CisgICAgZGlzcGxheTogbm9uZTsKKyAgICBiYWNrZ3JvdW5kOiByZWQ7CisgIH0KKwor ICBAc3VwcG9ydHMgbm90IHNlbGVjdG9yKDpmb2N1cy12aXNpYmxlKSB7CisgICAgI2luc3RydWN0 aW9ucyB7CisgICAgICBkaXNwbGF5OiBub25lOworICAgIH0KKworICAgICN3YXJuaW5nIHsKKyAg ICAgIGRpc3BsYXk6IGJsb2NrOworICAgIH0KKyAgfQorCisgIDpmb2N1cy12aXNpYmxlIHsKKyAg ICBvdXRsaW5lOiBzb2xpZCB0aGljayByZWQ7CisgIH0KKworICA6Zm9jdXM6bm90KDpmb2N1cy12 aXNpYmxlKSB7CisgICAgYmFja2dyb3VuZC1jb2xvcjogbGltZTsKKyAgfQorPC9zdHlsZT4KKwor PHA+VGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGEgc2NyaXB0IGZvY3VzIGFmdGVyIGEgbW91c2UgY2xp Y2sgb24gYSBidXR0b24gdGhhdCBkb2VzIG5vdCBtYXRjaCA8Y29kZT46Zm9jdXMgdmlzaWJsZTwv Y29kZT4sIGRvZXMgTk9UIG1hdGNoIDxjb2RlPjpmb2N1cy12aXNpYmxlPC9jb2RlPi48L3A+Cis8 b2wgaWQ9Imluc3RydWN0aW9ucyI+CisgIDxsaT5DbGljayBvbiB0aGUgYnV0dG9uIHRoYXQgc2F5 cyAiQ2xpY2sgbWUiLjwvbGk+CisgIDxsaT5JZiB0aGUgZWxlbWVudCB0aGF0IHNheXMgIkZvY3Vz ZWQiIGhhcyBhIHJlZCBvdXRsaW5lIHRoZW4gdGhlIHRlc3QgcmVzdWx0IGlzIEZBSUxVUkUsIGlm IGl0IGhhcyBhIGdyZWVuIGJhY2tncm91bmQgdGhlbiB0aGUgdGVzdCByZXN1bHQgaXMgU1VDQ0VT Uy48L2xpPgorPC9vbD4KKzxwIGlkPSJ3YXJuaW5nIj5Zb3VyIHVzZXItYWdlbnQgZG9lcyBub3Qg c3VwcG9ydCA8Y29kZT46Zm9jdXMtdmlzaWJsZTwvY29kZT4gcHNldWRvLWNsYXNzLCBwbGVhc2Ug U0tJUCB0aGlzIHRlc3QuPC9wPgorCis8YnV0dG9uIGlkPSJpbml0aWFsIj5DbGljayBtZTwvYnV0 dG9uPgorPGRpdiBpZD0idGFyZ2V0IiB0YWJpbmRleD0iMCI+Rm9jdXNlZDwvZGl2PgorCis8c2Ny aXB0PgorICBzZXR1cCh7IGV4cGxpY2l0X2RvbmU6IHRydWUgfSk7CisKKyAgLy8gQ2hlY2sgdGhh dCA6Zm9jdXMtdmlzaWJsZSBpcyBzdXBwb3J0ZWQuCisgIHRlc3RfdmFsaWRfc2VsZWN0b3IoJzpm b2N1cy12aXNpYmxlJyk7CisKKyAgaW5pdGlhbC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsICgp ID0+IHsKKyAgICB0YXJnZXQuZm9jdXMoKTsKKyAgfSk7CisKKyAgYXN5bmNfdGVzdChmdW5jdGlv bih0KSB7CisgICAgdGFyZ2V0LmFkZEV2ZW50TGlzdGVuZXIoImZvY3VzIiwgdC5zdGVwX2Z1bmNf ZG9uZShmdW5jdGlvbigpIHsKKyAgICAgIGFzc2VydF9lcXVhbHMoZ2V0Q29tcHV0ZWRTdHlsZSh0 YXJnZXQpLmJhY2tncm91bmRDb2xvciwgInJnYigwLCAyNTUsIDApIiwgYGJhY2tncm91bmRDb2xv ciBmb3IgJHt0YXJnZXQudGFnTmFtZX0jJHt0YXJnZXQuaWR9IHNob3VsZCBiZSBsaW1lYCk7Cisg ICAgICBhc3NlcnRfbm90X2VxdWFscyhnZXRDb21wdXRlZFN0eWxlKHRhcmdldCkub3V0bGluZUNv bG9yLCAicmdiKDI1NSwgMCwgMCkiLCBgb3V0bGluZUNvbG9yIGZvciAke3RhcmdldC50YWdOYW1l fSMke3RhcmdldC5pZH0gc2hvdWxkIE5PVCBiZSByZWRgKTsKKyAgICB9KSk7CisKKyAgICB0ZXN0 X2RyaXZlci5jbGljayhpbml0aWFsKS50aGVuKCgpID0+IGRvbmUoKSk7CisgIH0sICJTY3JpcHQg Zm9jdXMgYWZ0ZXIgbW91c2UgY2xpY2sgb24gYSBidXR0b24gdGhhdCBkb2VzIG5vdCBtYXRjaCA6 Zm9jdXMtdmlzaWJsZSwgZG9lcyBOT1QgbWF0Y2ggOmZvY3VzLXZpc2libGUiKTsKKzwvc2NyaXB0 Pgo=