236770 2022-02-17 04:22:36 -0800 [GTK] Build broken with ENABLE_X11_TARGET=OFF and no X11 headers present 2022-02-17 09:20:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez alex annulen aperez cgarcia clopez clord dino don.olmstead ews-watchlist gyuyoung.kim kbr kondapallykalyan ryuan.choi sergio webkit-bug-importer oldest_to_newest 1842816 0 aperez 2022-02-17 04:22:36 -0800 In file included from ../Source/ThirdParty/ANGLE/include/EGL/egl.h:39, from ../Source/ThirdParty/ANGLE/src/common/PackedEGLEnums_autogen.h, from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.h:12, from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.cpp:9: ../Source/ThirdParty/ANGLE/include/EGL/eglplatform.h:128:10: fatal error: X11/Xlib.h: No such file or directory 128 | #include <X11/Xlib.h> | ^~~~~~~~~~~~ 1842817 1 aperez 2022-02-17 04:24:24 -0800 There's the same issue in the 2.34.x releases, tested with the current state of the stable release branch. 1842819 2 452350 aperez 2022-02-17 04:37:29 -0800 Created attachment 452350 Patch 1842821 3 ews-watchlist 2022-02-17 04:39:21 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1842829 4 452350 alex 2022-02-17 04:55:58 -0800 Comment on attachment 452350 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452350&action=review LGTM! Thanks! > Source/ThirdParty/ANGLE/ChangeLog:8 > + * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions I guess 'makes' is a leftover. 1842833 5 aperez 2022-02-17 05:01:35 -0800 (In reply to Alejandro G. Castro from comment #4) > Comment on attachment 452350 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452350&action=review > > LGTM! Thanks! > > > Source/ThirdParty/ANGLE/ChangeLog:8 > > + * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions > > I guess 'makes' is a leftover. Indeed it's a grammar mistake. I'll fix this before landing the patch, thanks! 1842886 6 452363 aperez 2022-02-17 07:12:08 -0800 Created attachment 452363 Patch for landing 1842931 7 ews-feeder 2022-02-17 09:19:24 -0800 Committed r290027 (247407@main): <https://commits.webkit.org/247407@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452363. 1842932 8 webkit-bug-importer 2022-02-17 09:20:18 -0800 <rdar://problem/89090769> 452350 2022-02-17 04:37:29 -0800 2022-02-17 07:12:03 -0800 Patch bug-236770-20220217143728.patch text/plain 1997 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZWY5MTQxYjViODRjNjczNzdmODU1NWZlN2U0MTY3Mjg0ZTU4OGYyZS4uY2ExMWVjM2M1NmFm NmFlYjA5ZWVkZmE1NGFkMmQwZGZiNDAyNTJhMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTE3ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8 YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQnVpbGQgYnJva2VuIHdpdGggRU5B QkxFX1gxMV9UQVJHRVQ9T0ZGIGFuZCBubyBYMTEgaGVhZGVycyBwcmVzZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY3NzAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtl OiBUaGUgVVNFX1NZU1RFTV9FR0wgZGVmaW5pdGlvbiBtYWtlcyBkZXRhY2hlcyB0aGUgdHlwZSBk ZWZpbml0aW9ucworICAgICAgICBmcm9tIHRoZSBFR0wgaGVhZGVycyBnZW5lcmljIGFuZCBwcmV2 ZW50cyBBTkdMRSdzIGhlYWRlcnMgZnJvbSBpbmNsdWRpbmcgc3lzdGVtIFgxMQorICAgICAgICBv ciBXYXlsYW5kIGhlYWRlcnMgZnJvbSB0aGUgc3lzdGVtLCBzbyBhcHBseSBpdCBhbHdheXMgaW5k ZXBlbmRlbnRseSBvZiB3aGV0aGVyIHRoZQorICAgICAgICBVU0VfQU5HTEVfe0VHTCxXRUJHTH0g b3B0aW9ucyBhcmUgZW5hYmxlZC4gV2hpbGUgYXQgaXQsIGZpeCBhIG1pc3NpbmcgZG9sbGFyIHNp Z24gaW4KKyAgICAgICAgdGhlIGV4cGFuc2lvbiBvZiB0aGUgJHtHQk1fSU5DTFVERV9ESVJ9IHZh cmlhYmxlLgorCiAyMDIyLTAyLTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI4OTk0OS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggMzk5ZDE1OWUxZWM5NTRhNGM2 MGQzZjAyNTU3NGI1MWRiMmI1NDQzYS4uMjdkNDRmNzY1MjYyYTJjM2ZlNWViYzlkOTM1MGNjNmU3 MGMxZTEzMyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvUGxhdGZvcm1HVEsu Y21ha2UKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvUGxhdGZvcm1HVEsuY21ha2UKQEAg LTEsNCArMSw0IEBACi1saXN0KEFQUEVORCBBTkdMRV9ERUZJTklUSU9OUyBBTkdMRV9QTEFURk9S TV9MSU5VWCkKK2xpc3QoQVBQRU5EIEFOR0xFX0RFRklOSVRJT05TIEFOR0xFX1BMQVRGT1JNX0xJ TlVYIFVTRV9TWVNURU1fRUdMKQogaW5jbHVkZShsaW51eC5jbWFrZSkKIAogaWYgKFVTRV9PUEVO R0wpCkBAIC0yNiw3ICsyNiw2IEBAIGlmIChVU0VfQU5HTEVfRUdMIE9SIFVTRV9BTkdMRV9XRUJH TCkKICAgICBsaXN0KEFQUEVORCBBTkdMRV9ERUZJTklUSU9OUwogICAgICAgICBBTkdMRV9FTkFC TEVfT1BFTkdMCiAgICAgICAgIEFOR0xFX1VTRV9HQk0KLSAgICAgICAgVVNFX1NZU1RFTV9FR0wK ICAgICApCiAKICAgICBmaW5kX3BhY2thZ2UoTGliRFJNIFJFUVVJUkVEKQpAQCAtMzQsNyArMzMs NyBAQCBpZiAoVVNFX0FOR0xFX0VHTCBPUiBVU0VfQU5HTEVfV0VCR0wpCiAKICAgICBsaXN0KEFQ UEVORCBBTkdMRV9QUklWQVRFX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAgICAgJHtMSUJEUk1f SU5DTFVERV9ESVJ9Ci0gICAgICAgIHtHQk1fSU5DTFVERV9ESVJ9CisgICAgICAgICR7R0JNX0lO Q0xVREVfRElSfQogICAgICkKIAogICAgIGxpc3QoQVBQRU5EIEFOR0xFR0xFU3YyX0xJQlJBUklF Uwo= 452363 2022-02-17 07:12:08 -0800 2022-02-17 09:19:27 -0800 Patch for landing bug-236770-20220217171207.patch text/plain 2059 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMjQ5ZWRmMDdlZTU0ZTYzOWEwOWU4Y2I3ZDYxZjdkYTM1YTQzMWRjMi4uYjI3MmU5YWJlNWJj N2EyZTY1ODBkYTBjNDUxYzc5ZTE3OWNjOGY5MSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTE3ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8 YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQnVpbGQgYnJva2VuIHdpdGggRU5B QkxFX1gxMV9UQVJHRVQ9T0ZGIGFuZCBubyBYMTEgaGVhZGVycyBwcmVzZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY3NzAKKworICAgICAgICBS ZXZpZXdlZCBieSBBbGVqYW5kcm8gRy4gQ2FzdHJvLgorCisgICAgICAgICogUGxhdGZvcm1HVEsu Y21ha2U6IFRoZSBVU0VfU1lTVEVNX0VHTCBkZWZpbml0aW9uIGRldGFjaGVzIHRoZSB0eXBlIGRl ZmluaXRpb25zCisgICAgICAgIGZyb20gdGhlIEVHTCBoZWFkZXJzIGdlbmVyaWMgYW5kIHByZXZl bnRzIEFOR0xFJ3MgaGVhZGVycyBmcm9tIGluY2x1ZGluZyBzeXN0ZW0gWDExCisgICAgICAgIG9y IFdheWxhbmQgaGVhZGVycyBmcm9tIHRoZSBzeXN0ZW0sIHNvIGFwcGx5IGl0IGFsd2F5cyBpbmRl cGVuZGVudGx5IG9mIHdoZXRoZXIgdGhlCisgICAgICAgIFVTRV9BTkdMRV97RUdMLFdFQkdMfSBv cHRpb25zIGFyZSBlbmFibGVkLiBXaGlsZSBhdCBpdCwgZml4IGEgbWlzc2luZyBkb2xsYXIgc2ln biBpbgorICAgICAgICB0aGUgZXhwYW5zaW9uIG9mIHRoZSAke0dCTV9JTkNMVURFX0RJUn0gdmFy aWFibGUuCisKIDIwMjItMDItMTcgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OIChpT1MgMTUuNGIzKTogQ2F0YXN0cm9waGljICgyMHgp IHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb24gaW4gdGV4SW1hZ2UyRCBmcm9tIG1wNCB2aWRlbwpkaWZm IC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCAzOTlkMTU5ZTFlYzk1 NGE0YzYwZDNmMDI1NTc0YjUxZGIyYjU0NDNhLi4yN2Q0NGY3NjUyNjJhMmMzZmU1ZWJjOWQ5MzUw Y2M2ZTcwYzFlMTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9QbGF0Zm9y bUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9QbGF0Zm9ybUdUSy5jbWFr ZQpAQCAtMSw0ICsxLDQgQEAKLWxpc3QoQVBQRU5EIEFOR0xFX0RFRklOSVRJT05TIEFOR0xFX1BM QVRGT1JNX0xJTlVYKQorbGlzdChBUFBFTkQgQU5HTEVfREVGSU5JVElPTlMgQU5HTEVfUExBVEZP Uk1fTElOVVggVVNFX1NZU1RFTV9FR0wpCiBpbmNsdWRlKGxpbnV4LmNtYWtlKQogCiBpZiAoVVNF X09QRU5HTCkKQEAgLTI2LDcgKzI2LDYgQEAgaWYgKFVTRV9BTkdMRV9FR0wgT1IgVVNFX0FOR0xF X1dFQkdMKQogICAgIGxpc3QoQVBQRU5EIEFOR0xFX0RFRklOSVRJT05TCiAgICAgICAgIEFOR0xF X0VOQUJMRV9PUEVOR0wKICAgICAgICAgQU5HTEVfVVNFX0dCTQotICAgICAgICBVU0VfU1lTVEVN X0VHTAogICAgICkKIAogICAgIGZpbmRfcGFja2FnZShMaWJEUk0gUkVRVUlSRUQpCkBAIC0zNCw3 ICszMyw3IEBAIGlmIChVU0VfQU5HTEVfRUdMIE9SIFVTRV9BTkdMRV9XRUJHTCkKIAogICAgIGxp c3QoQVBQRU5EIEFOR0xFX1BSSVZBVEVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICAgICAke0xJ QkRSTV9JTkNMVURFX0RJUn0KLSAgICAgICAge0dCTV9JTkNMVURFX0RJUn0KKyAgICAgICAgJHtH Qk1fSU5DTFVERV9ESVJ9CiAgICAgKQogCiAgICAgbGlzdChBUFBFTkQgQU5HTEVHTEVTdjJfTElC UkFSSUVTCg==