236749 2022-02-16 20:21:00 -0800 Unnecessary copy/memory allocation 2022-02-17 15:27:07 -0800 1 1 1 Unclassified WebKit Page Loading Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard beidson dino webkit-bug-importer oldest_to_newest 1842677 0 jean-yves.avenard 2022-02-16 20:21:00 -0800 We see: Source/WebKitLegacy/mac/WebView/WebHTMLView.mm https://github.com/WebKit/WebKit/blob/f0427c65db487c75295c5bd757777cb5d9049030/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm#L3544-L3547 ``` if (auto* image = hitTestResult.image()) { if (RefPtr<WebCore::FragmentedSharedBuffer> buffer = image->data()) [items addObject:adoptNS([[NSImage alloc] initWithData:[NSData dataWithBytes:buffer->makeContiguous()->data() length:buffer->size()]]).get()]; } ``` we can create a NSData from the SharedBuffer directly, removing the need for the memory allocation and copy. 1842678 1 webkit-bug-importer 2022-02-16 20:21:50 -0800 <rdar://problem/89064893> 1842682 2 452300 jean-yves.avenard 2022-02-16 20:39:01 -0800 Created attachment 452300 Patch 1843149 3 ews-feeder 2022-02-17 15:27:03 -0800 Committed r290082 (247438@main): <https://commits.webkit.org/247438@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452300. 452300 2022-02-16 20:39:01 -0800 2022-02-17 15:27:05 -0800 Patch bug-236749-20220217153859.patch text/plain 1775 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5OTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNDNkZmEzOTZhNjM5MmJjZTJhMWI4MjJjNTlhMDE2YWZkOTgyYWNhMi4uMDkwM2E1MjZmN2Vl Yjc2M2U3YTkzOGMyYzM0YzJhOGEyZjc2YzVkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAyLTE2ICBKZWFuLVl2ZXMgQXZlbmFyZCAgPGp5YUBh cHBsZS5jb20+CisKKyAgICAgICAgVW5uZWNlc3NhcnkgY29weS9tZW1vcnkgYWxsb2NhdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NzQ5Cisg ICAgICAgIHJkYXI6Ly9wcm9ibGVtLzg5MDY0ODkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm1tOgorICAgICAg ICAoY3JlYXRlU2hhcmVNZW51SXRlbSk6IFNoYXJlZCBOU0RhdGEgY29uc3RydWN0ZWQgZnJvbSBh IFNoYXJlZEJ1ZmZlciBpbnN0ZWFkCisKIDIwMjItMDItMTYgIEplYW4tWXZlcyBBdmVuYXJkICA8 anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaFRyYWNlcjogY29tLmFwcGxlLldlYktpdC5X ZWJDb250ZW50IGF0IEphdmFTY3JpcHRDb3JlOiBibWFsbG9jX2FsbG9jYXRlX2ltcGxfaW1wbF9z bG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhUTUxW aWV3Lm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQpp bmRleCAyNTFmMTdhNTUyZjNkYzliYjBmOGIyODFiNWQ3OTYyZjAyYTg1MjU4Li40ZWIzZjgzZDdk NmE5YzZkZjE5ZGJmNTM3OTI2OTFkOWU2NzE0ZDQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KQEAgLTM1NDIsOCArMzU0Miw4IEBAIHN0YXRp YyBSZXRhaW5QdHI8TlNNZW51SXRlbT4gY3JlYXRlU2hhcmVNZW51SXRlbShjb25zdCBXZWJDb3Jl OjpIaXRUZXN0UmVzdWx0JiBoCiAgICAgfQogCiAgICAgaWYgKGF1dG8qIGltYWdlID0gaGl0VGVz dFJlc3VsdC5pbWFnZSgpKSB7Ci0gICAgICAgIGlmIChSZWZQdHI8V2ViQ29yZTo6RnJhZ21lbnRl ZFNoYXJlZEJ1ZmZlcj4gYnVmZmVyID0gaW1hZ2UtPmRhdGEoKSkKLSAgICAgICAgICAgIFtpdGVt cyBhZGRPYmplY3Q6YWRvcHROUyhbW05TSW1hZ2UgYWxsb2NdIGluaXRXaXRoRGF0YTpbTlNEYXRh IGRhdGFXaXRoQnl0ZXM6YnVmZmVyLT5tYWtlQ29udGlndW91cygpLT5kYXRhKCkgbGVuZ3RoOmJ1 ZmZlci0+c2l6ZSgpXV0pLmdldCgpXTsKKyAgICAgICAgaWYgKFJlZlB0cjxjb25zdCBXZWJDb3Jl OjpGcmFnbWVudGVkU2hhcmVkQnVmZmVyPiBidWZmZXIgPSBpbWFnZS0+ZGF0YSgpKQorICAgICAg ICAgICAgW2l0ZW1zIGFkZE9iamVjdDphZG9wdE5TKFtbTlNJbWFnZSBhbGxvY10gaW5pdFdpdGhE YXRhOmJ1ZmZlci0+bWFrZUNvbnRpZ3VvdXMoKS0+Y3JlYXRlTlNEYXRhKCkuZ2V0KCldKS5nZXQo KV07CiAgICAgfQogCiAgICAgaWYgKCFoaXRUZXN0UmVzdWx0LnNlbGVjdGVkVGV4dCgpLmlzRW1w dHkoKSkgewo=