236746 2022-02-16 18:03:54 -0800 WPEQtView is missing most features 2022-04-01 14:40:12 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build PC Linux RESOLVED FIXED P2 Normal --- 1 tusooa webkit-unassigned aperez bugs-noreply jbedard pnormand oldest_to_newest 1842637 0 tusooa 2022-02-16 18:03:54 -0800 If using WPEQtView, it seems that ( https://github.com/WebKit/WebKit/blob/main/Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h ) only a handful of methods/properties are available, comparing to WebKitWebView ( https://github.com/WebKit/WebKit/blob/main/Source/WebKit/UIProcess/API/wpe/WebKitWebView.h ). To make things worse, there is no way to retrieve the inner WebKitWebView either. This means I cannot use most of the features in WebKitWebView if I want to use WPEQtView. Ideally, I should be able to use any WebKit public API within QML (meaning wrapping all the classes into QObjects). If that is unfeasible, we should at least provide API to construct with a user-provided WebKitWebView, and retrieve the one stored. 1853862 1 455417 tusooa 2022-03-22 13:03:56 -0700 Created attachment 455417 Expose WebKitWebView in WPEQtView 1853898 2 pnormand 2022-03-22 14:23:06 -0700 LGTM but a ChangeLog is needed, see https://webkit.org/contributing-code/#changelog-files 1854491 3 455583 tusooa 2022-03-23 16:40:58 -0700 Created attachment 455583 Expose WebKitWebView from WPEQtView (with changelog) 1857021 4 jbedard 2022-03-31 15:08:06 -0700 Marked the patch as "r?", since it seems that was Tusooa's intent. 1857024 5 455583 aperez 2022-03-31 15:15:57 -0700 Comment on attachment 455583 Expose WebKitWebView from WPEQtView (with changelog) I think we could merge this, but could you please make the style bot happy? If you want to check your commit locally, you can use “Tools/Scripts/check-webkit-style -g @” View in context: https://bugs.webkit.org/attachment.cgi?id=455583&action=review > Source/WebKit/ChangeLog:11 > + No new tests (OOPS!). You need to remove this line, or rewrite it as “No new tests needed.” 1857026 6 456292 tusooa 2022-03-31 15:35:23 -0700 Created attachment 456292 Expose WebKitWebView from WPEQtView 1857027 7 tusooa 2022-03-31 15:36:42 -0700 (In reply to Adrian Perez from comment #5) > Comment on attachment 455583 [details] > Expose WebKitWebView from WPEQtView (with changelog) > > I think we could merge this, but could you please make the style > bot happy? If you want to check your commit locally, you can use > “Tools/Scripts/check-webkit-style -g @” > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455583&action=review > > > Source/WebKit/ChangeLog:11 > > + No new tests (OOPS!). > > You need to remove this line, or rewrite it as “No new tests needed.” Thank you for suggesting the tool. It no longer complains with the patch I added just now. 1857197 8 aperez 2022-04-01 01:54:20 -0700 (In reply to tusooa from comment #7) > (In reply to Adrian Perez from comment #5) > > Comment on attachment 455583 [details] > > Expose WebKitWebView from WPEQtView (with changelog) > > > > I think we could merge this, but could you please make the style > > bot happy? If you want to check your commit locally, you can use > > “Tools/Scripts/check-webkit-style -g @” > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=455583&action=review > > > > > Source/WebKit/ChangeLog:11 > > > + No new tests (OOPS!). > > > > You need to remove this line, or rewrite it as “No new tests needed.” > > Thank you for suggesting the tool. It no longer complains with the patch I > added just now. Thanks, patch approved. I'll wait that the bots are green before sending it to the commit queue :) 1857262 9 ews-feeder 2022-04-01 07:48:13 -0700 ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. 1857402 10 ews-feeder 2022-04-01 14:40:08 -0700 Committed r292236 (249137@main): <https://commits.webkit.org/249137@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456292. 455417 2022-03-22 13:03:56 -0700 2022-03-31 15:35:23 -0700 Expose WebKitWebView in WPEQtView 0001-Expose-WebKitWebView-from-WPEQtView.patch text/plain 1337 tusooa RnJvbSBlYmM1MGI0OTM5NDY0NGY3MGQ3NzVjZGNiZWM5OWVlMWE0MGNkMjEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUdXNvb2EgWmh1IDx0dXNvb2FAa2F6di5tb2U+CkRhdGU6IEZy aSwgMTEgTWFyIDIwMjIgMTA6NTA6NTIgLTA1MDAKU3ViamVjdDogW1BBVENIXSBFeHBvc2UgV2Vi S2l0V2ViVmlldyBmcm9tIFdQRVF0VmlldwoKQ0NCVUc6IGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzY3NDYKLS0tCiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv d3BlL3F0L1dQRVF0Vmlldy5jcHAgfCA1ICsrKysrCiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvd3BlL3F0L1dQRVF0Vmlldy5oICAgfCAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQv V1BFUXRWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRW aWV3LmNwcAppbmRleCAxZjFkZTE3NjhlNDMuLjk1NDEwZjExODgxMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmNwcApAQCAtNTEzLDMgKzUx Myw4IEBAIHZvaWQgV1BFUXRWaWV3Ojp0b3VjaEV2ZW50KFFUb3VjaEV2ZW50KiBldmVudCkKICAg ICBpZiAobV9iYWNrZW5kKQogICAgICAgICBtX2JhY2tlbmQtPmRpc3BhdGNoVG91Y2hFdmVudChl dmVudCk7CiB9CisKK1dlYktpdFdlYlZpZXcqIFdQRVF0Vmlldzo6d2ViVmlldygpIGNvbnN0Cit7 CisgICAgcmV0dXJuIG1fd2ViVmlldzsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvd3BlL3F0L1dQRVF0Vmlldy5oCmluZGV4IDNmZDVhNGMyZTNiZC4uYzg3YzdlYmVmYmQwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmgKQEAg LTYyLDYgKzYyLDggQEAgcHVibGljOgogICAgIGJvb2wgaXNMb2FkaW5nKCkgY29uc3Q7CiAgICAg Ym9vbCBjYW5Hb0ZvcndhcmQoKSBjb25zdDsKIAorICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXco KSBjb25zdDsKKwogcHVibGljIFFfU0xPVFM6CiAgICAgdm9pZCBnb0JhY2soKTsKICAgICB2b2lk IGdvRm9yd2FyZCgpOwotLSAKMi4zNC4xCgo= 455583 2022-03-23 16:40:58 -0700 2022-03-31 15:35:23 -0700 Expose WebKitWebView from WPEQtView (with changelog) 0001-Expose-WebKitWebView-from-WPEQtView.patch text/plain 2370 tusooa RnJvbSA4OWFmMTE0NTEwYzRmMWY3ZmE0YWY2Yzk4YzBjMjI3OTE1ZTU0NDkxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUdXNvb2EgWmh1IDx0dXNvb2FAa2F6di5tb2U+CkRhdGU6IFdl ZCwgMjMgTWFyIDIwMjIgMTk6Mzk6NDcgLTA0MDAKU3ViamVjdDogW1BBVENIXSBFeHBvc2UgV2Vi S2l0V2ViVmlldyBmcm9tIFdQRVF0VmlldwoKTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMgKE9PUFMhKS4KKiBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHA6CihXUEVRdFZpZXc6Ondl YlZpZXcgY29uc3QpOgoqIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRW aWV3Lmg6Ci0tLQogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgMTYgKysrKysrKysrKysrKysrKwogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dw ZS9xdC9XUEVRdFZpZXcuY3BwIHwgIDUgKysrKysKIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS93cGUvcXQvV1BFUXRWaWV3LmggICB8ICAyICsrCiAzIGZpbGVzIGNoYW5nZWQsIDIzIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBkYTBhMzQyNGY4NS4uNmE2NTQyOGY1NjZkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAzLTIzICBUdXNvb2EgWmh1ICA8dHVzb29hQGthenYu bW9lPgorCisgICAgICAgIEV4cG9zZSBXZWJLaXRXZWJWaWV3IGZyb20gV1BFUXRWaWV3CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY3NDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXUEVRdFZpZXcgY3Vy cmVudGx5IGRvZXMgbm90IGFsbG93IG1hbmlwdWxhdGluZyB0aGUgdW5kZXJseWluZyBXZWJLaXRX ZWJWaWV3LgorICAgICAgICBUaGlzIHBhdGNoIGFsbG93cyByZXRyaWV2aW5nIHRoZSBXZWJLaXRX ZWJWaWV3IGZyb20gdGhlIFdQRVF0Vmlldy4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHA6CisgICAg ICAgIChXUEVRdFZpZXc6OndlYlZpZXcgY29uc3QpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv d3BlL3F0L1dQRVF0Vmlldy5oOgorCiAyMDIyLTAzLTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KIAogICAgICAgICBEbyBjYXB0dXJlIHZpZGVvIGZyYW1lIGRvd25zYW1wbGlu ZyBpbiBHUFVQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv d3BlL3F0L1dQRVF0Vmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0 L1dQRVF0Vmlldy5jcHAKaW5kZXggMWYxZGUxNzY4ZTQzLi45NTQxMGYxMTg4MTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHAKQEAgLTUx MywzICs1MTMsOCBAQCB2b2lkIFdQRVF0Vmlldzo6dG91Y2hFdmVudChRVG91Y2hFdmVudCogZXZl bnQpCiAgICAgaWYgKG1fYmFja2VuZCkKICAgICAgICAgbV9iYWNrZW5kLT5kaXNwYXRjaFRvdWNo RXZlbnQoZXZlbnQpOwogfQorCitXZWJLaXRXZWJWaWV3KiBXUEVRdFZpZXc6OndlYlZpZXcoKSBj b25zdAoreworICAgIHJldHVybiBtX3dlYlZpZXc7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5oIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuaAppbmRleCAzZmQ1YTRjMmUzYmQuLmM4N2M3ZWJl ZmJkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVR dFZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmll dy5oCkBAIC02Miw2ICs2Miw4IEBAIHB1YmxpYzoKICAgICBib29sIGlzTG9hZGluZygpIGNvbnN0 OwogICAgIGJvb2wgY2FuR29Gb3J3YXJkKCkgY29uc3Q7CiAKKyAgICBXZWJLaXRXZWJWaWV3KiB3 ZWJWaWV3KCkgY29uc3Q7CisKIHB1YmxpYyBRX1NMT1RTOgogICAgIHZvaWQgZ29CYWNrKCk7CiAg ICAgdm9pZCBnb0ZvcndhcmQoKTsKLS0gCjIuMzQuMQoK 456292 2022-03-31 15:35:23 -0700 2022-04-01 14:40:10 -0700 Expose WebKitWebView from WPEQtView 0001-Expose-WebKitWebView-from-WPEQtView.patch text/plain 2407 tusooa RnJvbSBkNTNlZGExN2VhNWE4MmRlZTk3MDQ0YmNjZGY2NThmODdiN2E2ZDYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUdXNvb2EgWmh1IDx0dXNvb2FAa2F6di5tb2U+CkRhdGU6IFdl ZCwgMjMgTWFyIDIwMjIgMTk6Mzk6NDcgLTA0MDAKU3ViamVjdDogW1BBVENIXSBFeHBvc2UgV2Vi S2l0V2ViVmlldyBmcm9tIFdQRVF0VmlldwoKTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMgKE9PUFMhKS4KKiBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHA6CihXUEVRdFZpZXc6Ondl YlZpZXcgY29uc3QpOgoqIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRW aWV3Lmg6Ci0tLQogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgMTYgKysrKysrKysrKysrKysrKwogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dw ZS9xdC9XUEVRdFZpZXcuY3BwIHwgIDUgKysrKysKIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS93cGUvcXQvV1BFUXRWaWV3LmggICB8ICAyICsrCiAzIGZpbGVzIGNoYW5nZWQsIDIzIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBkYTBhMzQyNGY4NS4uZjNhNDE3NTQzMjI3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAzLTIzICBUdXNvb2EgWmh1ICA8dHVzb29hQGthenYu bW9lPgorCisgICAgICAgIEV4cG9zZSBXZWJLaXRXZWJWaWV3IGZyb20gV1BFUXRWaWV3CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY3NDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXUEVRdFZpZXcgY3Vy cmVudGx5IGRvZXMgbm90IGFsbG93IG1hbmlwdWxhdGluZyB0aGUgdW5kZXJseWluZyBXZWJLaXRX ZWJWaWV3LgorICAgICAgICBUaGlzIHBhdGNoIGFsbG93cyByZXRyaWV2aW5nIHRoZSBXZWJLaXRX ZWJWaWV3IGZyb20gdGhlIFdQRVF0Vmlldy4KKworICAgICAgICBObyB0ZXN0cyBuZWVkZWQsIGFz IHRoaXMgcGF0Y2ggb25seSBhZGRzIGEgdHJpdmlhbCBnZXR0ZXIuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwOgorICAgICAgICAoV1BFUXRWaWV3Ojp3ZWJW aWV3IGNvbnN0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuaDoK KwogMjAyMi0wMy0xMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgRG8gY2FwdHVyZSB2aWRlbyBmcmFtZSBkb3duc2FtcGxpbmcgaW4gR1BVUHJvY2VzcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwCmluZGV4 IDFmMWRlMTc2OGU0My4uOTU0MTBmMTE4ODEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuY3BwCkBAIC01MTMsMyArNTEzLDggQEAgdm9pZCBX UEVRdFZpZXc6OnRvdWNoRXZlbnQoUVRvdWNoRXZlbnQqIGV2ZW50KQogICAgIGlmIChtX2JhY2tl bmQpCiAgICAgICAgIG1fYmFja2VuZC0+ZGlzcGF0Y2hUb3VjaEV2ZW50KGV2ZW50KTsKIH0KKwor V2ViS2l0V2ViVmlldyogV1BFUXRWaWV3Ojp3ZWJWaWV3KCkgY29uc3QKK3sKKyAgICByZXR1cm4g bV93ZWJWaWV3OworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dw ZS9xdC9XUEVRdFZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BF UXRWaWV3LmgKaW5kZXggM2ZkNWE0YzJlM2JkLi5jODdjN2ViZWZiZDAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3LmgKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXcuaApAQCAtNjIsNiArNjIsOCBA QCBwdWJsaWM6CiAgICAgYm9vbCBpc0xvYWRpbmcoKSBjb25zdDsKICAgICBib29sIGNhbkdvRm9y d2FyZCgpIGNvbnN0OwogCisgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldygpIGNvbnN0OworCiBw dWJsaWMgUV9TTE9UUzoKICAgICB2b2lkIGdvQmFjaygpOwogICAgIHZvaWQgZ29Gb3J3YXJkKCk7 Ci0tIAoyLjM1LjEKCg==