236732 2022-02-16 14:28:25 -0800 REGRESSION(r285885) Unable to exit Trip Details in Amtrak app 2022-02-17 06:12:49 -0800 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr rbuis simon.fraser zalan oldest_to_newest 1842523 0 zalan 2022-02-16 14:28:25 -0800 <rdar://87462825> 1842547 1 452252 zalan 2022-02-16 15:08:31 -0800 Created attachment 452252 Patch 1842656 2 zalan 2022-02-16 19:23:28 -0800 @Rob, do you remember if there was any particular reason for adding this? I can't find anything related in the Changelog entry. 1842680 3 ews-feeder 2022-02-16 20:24:49 -0800 Committed r289995 (247381@main): <https://commits.webkit.org/247381@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452252. 1842764 4 rbuis 2022-02-17 00:22:12 -0800 (In reply to zalan from comment #2) > @Rob, do you remember if there was any particular reason for adding this? I > can't find anything related in the Changelog entry. Not in particular, I made a judgment call on all overflowX/Y call sites and likely got this one wrong. Since this change has no regressions this part of the original patch was probably wrong. 1842858 5 zalan 2022-02-17 06:12:49 -0800 (In reply to Rob Buis from comment #4) > (In reply to zalan from comment #2) > > @Rob, do you remember if there was any particular reason for adding this? I > > can't find anything related in the Changelog entry. > > Not in particular, I made a judgment call on all overflowX/Y call sites and > likely got this one wrong. Thanks for confirming it. 452252 2022-02-16 15:08:31 -0800 2022-02-16 20:24:52 -0800 Patch bug-236732-20220216150830.patch text/plain 5329 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQ5Zjg1ZTliNGRkZmMy ODdjZDViODNmY2YzM2IyMzNlN2YzZTQxNi4uZWZjMDdkOTBlYjAyZjY1YTRiMjIxZGNhYjhjN2Rj Yjg3OWVjY2FlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIyLTAyLTE2ICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyODU4ODUp IFVuYWJsZSB0byBleGl0IFRyaXAgRGV0YWlscyBpbiBBbXRyYWsgYXBwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY3MzIKKyAgICAgICAgPHJkYXI6 Ly84NzQ2MjgyNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTdGFydGluZyBmcm9tIHIyODU4ODUgYW4gKGVmZmVjdGl2ZSnigJ1vdmVyZmxvdzogY2xp cOKAnSB2YWx1ZSBpcyBzZXQgb24gYW55IGJsb2NrIGJveCB3aXRoIOKAnGNvbnRhaW46IHBhaW50 4oCdLgorICAgICAgICBJdCBpcyBzdXBwb3NlZCB0byBlbnN1cmUgd2UgZG9u4oCZdCBwYWludCBv dXRzaWRlIG9mIHRoZSBib3jigJlzIGJvcmRlciBib3ggKG5vdGUgdGhhdCAiY29udGFpbjogcGFp bnQiLCBhcyB0aGUgbmFtZSBpbXBsaWVzLCBzaG91bGQgb25seSBhZmZlY3QgcGFpbnRpbmcpLgor CisgICAgICAgIEhvd2V2ZXIgdGhpcyBlZmZlY3RpdmUgdmFsdWUgdHJpY2tsZXMgaW4gdG8gbGF5 b3V0IGFmZmVjdGluZyBjZXJ0YWluIGxheW91dCBjb25zdHJhaW50cy4KKyAgICAgICAgSW4gY2Fz ZSBvZiBmbGV4LCBpdCBtYWtlcyB0aGUgZmxleCBsYXlvdXQgdGhpbmsgdGhhdCB0aGUgYm94IGlz IHJlYWxseSBhIGNsaXBwZWQgYm94IGFuZCBpdCBzdGFydHMgZmxleGluZyBpdCBhY2NvcmRpbmds eSBwcm9kdWNpbmcgaW5jb3JyZWN0IHNpemUuCisgICAgICAgIFdoYXQgaXQgbWVhbnMgaXMgdGhh dCB0aGUgbWluaW11bSBwcmVmZXJyZWQgc2l6ZSBlbmRzIHVwIGJlaW5nIDBweCBiZWNhdXNlIG5v dyB3aXRoICJsZXQncyBjbGlwIGFsbCB0aGUgb3ZlcmZsb3cgY29udGVudCIKKyAgICAgICAgMHB4 IGlzIGluZGVlZCB0aGUgc21hbGxlc3Qgc2l6ZSBhIGJveCBjb3VsZCB0YWtlIHRoYXQgZG9lcyBu b3QgcHJvZHVjZSBvdmVyZmxvdyAod2hpbGUgd2l0aCB0aGUgaW5pdGlhbCwg4oCcb3ZlcmZsb3c6 IHZpc2libGXigJ0gdmFsdWUsCisgICAgICAgIGl0cyBtaW5pbXVtIHdpZHRoIHdvdWxkIGxpa2Vs eSBiZSA+IDBweCAtcHJvdmlkZWQgaXQgaGFzIHNvbWUgY29udGVudC4gQWxzbyBub3RlIHRoYXQg c2V0dGluZyDigJxvdmVyZmxvdzogY2xpcOKAnSBvbiB0aGUgYm94IGluIHRoZSBtYXJrdXAKKyAg ICAgICAgKHNvIGl0IGJlY29tZXMgYW4gZXhwbGljaXQgY2xpcCB2YWx1ZSBhbmQgbm90IGp1c3Qg YW4g4oCcZWZmZWN0aXZl4oCdIGltcGxpY2l0IGNsaXAgdGhyb3VnaCDigJxjb250YWluOiBwYWlu dOKAnSkgcHJvZHVjZXMKKyAgICAgICAgdGhlIGV4YWN0IHNhbWUgcmVuZGVyaW5nIG1lYW5pbmcg dGhhdCB0aGlzIGVmZmVjdGl2ZSBwcm9wZXJ0eSB2YWx1ZSBkb2VzIGFmZmVjdCBsYXlvdXQpLgor CisgICAgICAgIFRoaXMgaXMgYSBwYXJ0aWFsIHJldmVydCBvZiByMjg1ODg1IChmb2N1c2luZyBv biB3aGVyZSB0aGUgZmxleCBhbGdvcml0aG0gY29uc3VsdHMgd2l0aCB0aGUgZmxleCBpdGVtcycg b3ZlcmZsb3cgdmFsdWVzKS4KKworICAgICAgICBUZXN0OiBmYXN0L2ZsZXhib3gvaW5jb3JyZWN0 LW1pbi1zaXplLXdpdGgtcGFpbnQtY29udGFpbi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVC b3g6Om1haW5BeGlzT3ZlcmZsb3dGb3JDaGlsZCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJGbGV4aWJsZUJveDo6Y3Jvc3NBeGlzT3ZlcmZsb3dGb3JDaGlsZCBjb25zdCk6CisKIDIw MjItMDItMTYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtD U1MgQ29udGFpbmVyIFF1ZXJpZXNdIFNlcmlhbGl6ZSBjb250YWluZXIgc2hvcnRoYW5kIGluIFN0 eWxlUHJvcGVydGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJs ZUJveC5jcHAKaW5kZXggYTViN2M0NWUzNmUzZTY1MzlkOGQxNzE3ZTA1N2NhNGU1ZDc0MTRjMS4u NTk2N2UyZTg5MGQ1NjZkZDAxZDE0NjNlMzRmMmExOGJkYzBmZDVhMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC0xOTE2LDE1ICsxOTE2 LDE1IEBAIGJvb2wgUmVuZGVyRmxleGlibGVCb3g6OmNoaWxkSGFzSW50cmluc2ljTWFpbkF4aXNT aXplKGNvbnN0IFJlbmRlckJveCYgY2hpbGQpCiBPdmVyZmxvdyBSZW5kZXJGbGV4aWJsZUJveDo6 bWFpbkF4aXNPdmVyZmxvd0ZvckNoaWxkKGNvbnN0IFJlbmRlckJveCYgY2hpbGQpIGNvbnN0CiB7 CiAgICAgaWYgKGlzSG9yaXpvbnRhbEZsb3coKSkKLSAgICAgICAgcmV0dXJuIGNoaWxkLmVmZmVj dGl2ZU92ZXJmbG93WCgpOwotICAgIHJldHVybiBjaGlsZC5lZmZlY3RpdmVPdmVyZmxvd1koKTsK KyAgICAgICAgcmV0dXJuIGNoaWxkLnN0eWxlKCkub3ZlcmZsb3dYKCk7CisgICAgcmV0dXJuIGNo aWxkLnN0eWxlKCkub3ZlcmZsb3dZKCk7CiB9CiAKIE92ZXJmbG93IFJlbmRlckZsZXhpYmxlQm94 Ojpjcm9zc0F4aXNPdmVyZmxvd0ZvckNoaWxkKGNvbnN0IFJlbmRlckJveCYgY2hpbGQpIGNvbnN0 CiB7CiAgICAgaWYgKGlzSG9yaXpvbnRhbEZsb3coKSkKLSAgICAgICAgcmV0dXJuIGNoaWxkLmVm ZmVjdGl2ZU92ZXJmbG93WSgpOwotICAgIHJldHVybiBjaGlsZC5lZmZlY3RpdmVPdmVyZmxvd1go KTsKKyAgICAgICAgcmV0dXJuIGNoaWxkLnN0eWxlKCkub3ZlcmZsb3dZKCk7CisgICAgcmV0dXJu IGNoaWxkLnN0eWxlKCkub3ZlcmZsb3dYKCk7CiB9CiAKIGJvb2wgUmVuZGVyRmxleGlibGVCb3g6 OmNoaWxkSGFzUGVyY2VudEhlaWdodERlc2NlbmRhbnRzKGNvbnN0IFJlbmRlckJveCYgcmVuZGVy ZXIpIGNvbnN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggOWIzNzQ4MGQ0NzI4ZDU0MzM0NDJhMTJjMmVhZTFjZmI5MzAzMjA5 Ny4uODk0MWJlOGFiNGJmYWQ2YzlmYzE3MDE5NGNmNGMxNGQ4MjY2ZGVjZCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDIyLTAyLTE2ICBBbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OKHIyODU4ODUpIFVuYWJsZSB0byBleGl0IFRyaXAgRGV0YWlscyBp biBBbXRyYWsgYXBwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzY3MzIKKyAgICAgICAgPHJkYXI6Ly84NzQ2MjgyNT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZmxleGJveC9pbmNvcnJlY3Qt bWluLXNpemUtd2l0aC1wYWludC1jb250YWluLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZmxleGJveC9pbmNvcnJlY3QtbWluLXNpemUtd2l0aC1wYWludC1jb250YWluLmh0 bWw6IEFkZGVkLgorCiAyMDIyLTAyLTE2ICBBbGkgSnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4K IAogICAgICAgICBGbG9hdGluZyBwb2ludCBleGNlcHRpb24gaW4gUmVuZGVyTGlzdEJveDo6bnVt VmlzaWJsZUl0ZW1zCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvaW5jb3Jy ZWN0LW1pbi1zaXplLXdpdGgtcGFpbnQtY29udGFpbi1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9mbGV4Ym94L2luY29ycmVjdC1taW4tc2l6ZS13aXRoLXBhaW50LWNvbnRhaW4tZXhw ZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jZDhmNGYzY2RlMjU3NTIzZGRmYmRkNzlkMjEzMGZjMmRm Mjk4OGM1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mbGV4Ym94L2luY29y cmVjdC1taW4tc2l6ZS13aXRoLXBhaW50LWNvbnRhaW4tZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsx LDkgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgorZGl2IHsKKyAgaGVpZ2h0OiAxMDBweDsK KyAgd2lkdGg6IDEwMHB4OworICBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKK30KKzwvc3R5bGU+ Cis8ZGl2PjwvZGl2PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZmxleGJveC9pbmNvcnJlY3QtbWluLXNpemUtd2l0aC1wYWludC1jb250 YWluLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvaW5jb3JyZWN0LW1pbi1zaXplLXdp dGgtcGFpbnQtY29udGFpbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk0YjRlY2U1ZTgzN2JmOGE3Y2M2ZmFk MGVkNDMzMjIzMzg2NDhlNWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zs ZXhib3gvaW5jb3JyZWN0LW1pbi1zaXplLXdpdGgtcGFpbnQtY29udGFpbi5odG1sCkBAIC0wLDAg KzEsMTggQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgorZGl2IHsKKyAgaGVpZ2h0OiAxMDBw eDsKKyAgd2lkdGg6IDEwMHB4OworfQorLmNvbnRhaW5lciB7CisgIGRpc3BsYXk6IGZsZXg7Cit9 CisucGFpbnRjb250YWluIHsKKyAgY29udGFpbjogcGFpbnQ7Cit9Cis8L3N0eWxlPgorPCEtLSBQ QVNTIGlmIHRoZSBncmVlbiBib3ggaXMgdmlzaWJsZSAtLT4KKzxkaXYgY2xhc3M9Y29udGFpbmVy PgorICA8ZGl2IGNsYXNzPXBhaW50Y29udGFpbj48ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9y OiBncmVlbjsiPjwvZGl2PjwvZGl2PgorICA8ZGl2PjxkaXY+PC9kaXY+PC9kaXY+Cis8L2Rpdj4K XCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==