236718 2022-02-16 10:40:09 -0800 REGRESSION: TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled is failing 2022-02-16 18:21:08 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell megan_gardner megan_gardner Morningstar thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1842376 0 tsavell 2022-02-16 10:40:09 -0800 TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled According to history, it looks like the changes in https://trac.webkit.org/changeset/289818/webkit broke this test. History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled Diff; TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDisableSelection.mm:59 Expected equality of these values: "" selectedText2 Which is: "Hello" 1842379 1 webkit-bug-importer 2022-02-16 10:40:54 -0800 <rdar://problem/89034665> 1842553 2 452253 megan_gardner 2022-02-16 15:12:36 -0800 Created attachment 452253 Patch 1842556 3 wenson_hsieh 2022-02-16 15:15:16 -0800 *** Bug 236737 has been marked as a duplicate of this bug. *** 1842559 4 452253 wenson_hsieh 2022-02-16 15:18:51 -0800 Comment on attachment 452253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452253&action=review r=mews > Source/WebCore/ChangeLog:6 > + A check got missed when refactoring code for 289818. Nit - description goes after Reviewed by line. 1842560 5 452255 megan_gardner 2022-02-16 15:20:06 -0800 Created attachment 452255 Patch for landing 1842642 6 ews-feeder 2022-02-16 18:21:05 -0800 Committed r289989 (247375@main): <https://commits.webkit.org/247375@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452255. 452253 2022-02-16 15:12:36 -0800 2022-02-16 15:20:04 -0800 Patch bug-236718-20220216151235.patch text/plain 1573 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY4NWRjNjVlNzljNWVk NzE1NTljODRkOTZmZWM3Yjk5YWYxODFhZi4uNjI2M2RmMTg1ZTQyM2I4NWQ5YzQzMGNlZWQyZmJj ODgyZjA0ZjA5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTE2ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TjogVGVzdFdlYktpdEFQSS5XS1dlYlZpZXdEaXNhYmxlU2VsZWN0aW9uLkRvdWJsZUNsaWNrRG9l c05vdFNlbGVjdFdoZW5UZXh0SW50ZXJhY3Rpb25zQXJlRGlzYWJsZWQgaXMgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NzE4CisKKyAg ICAgICAgQSBjaGVjayBnb3QgbWlzc2VkIHdoZW4gcmVmYWN0b3JpbmcgY29kZSBmb3IgMjg5ODE4 LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFn ZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5k bGVNb3VzZVByZXNzRXZlbnREb3VibGVDbGljayk6CisKIDIwMjItMDItMTUgIE5pa29sYW9zIE1v dWNodGFyaXMgIDxubW91Y2h0YXJpc0BhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IHBh cnNpbmcgYW5kIGFuaW1hdGlvbiBzdXBwb3J0IGZvciBvZmZzZXQgc2hvcnRoYW5kCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggY2NjMzNkMGUyODI0YWYwZTFkMjI3MTE2MThh MDBiYjllNzRlYmY2Zi4uMzE1NTdkYTVkYTU0MjY4ZWIyN2VmMGRkZGZmNTZmNzQzMGUwMjMzYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtNjAxLDcgKzYwMSw3IEBAIGJv b2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnREb3VibGVDbGljayhjb25zdCBN b3VzZUV2ZW50V2l0aEhpdFRlc3RSCiAgICAgICAgIC8vIG1fYmVnYW5TZWxlY3RpbmdUZXh0IHRv IHByZXZlbnQgaGFuZGxlTW91c2VSZWxlYXNlRXZlbnQKICAgICAgICAgLy8gZnJvbSBzZXR0aW5n IGNhcmV0IHNlbGVjdGlvbi4KICAgICAgICAgbV9zZWxlY3Rpb25Jbml0aWF0aW9uU3RhdGUgPSBF eHRlbmRlZFNlbGVjdGlvbjsKLSAgICBlbHNlCisgICAgZWxzZSBpZiAobW91c2VEb3duTWF5U3Rh cnRTZWxlY3QoKSkKICAgICAgICAgc2VsZWN0Q2xvc2VzdFdvcmRGcm9tSGl0VGVzdFJlc3VsdChl dmVudC5oaXRUZXN0UmVzdWx0KCksIHNob3VsZEFwcGVuZFRyYWlsaW5nV2hpdGVzcGFjZShldmVu dCwgbV9mcmFtZSkpOwogCiAgICAgcmV0dXJuIHRydWU7Cg== 452255 2022-02-16 15:20:06 -0800 2022-02-16 18:21:07 -0800 Patch for landing bug-236718-20220216152005.patch text/plain 1571 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY4NWRjNjVlNzljNWVk NzE1NTljODRkOTZmZWM3Yjk5YWYxODFhZi4uYjIxOGYwODYzNjNkNmJkYWU3ZWQ0YzIxMzdmMjAw ZjE1MmI4ZWJiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTE2ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TjogVGVzdFdlYktpdEFQSS5XS1dlYlZpZXdEaXNhYmxlU2VsZWN0aW9uLkRvdWJsZUNsaWNrRG9l c05vdFNlbGVjdFdoZW5UZXh0SW50ZXJhY3Rpb25zQXJlRGlzYWJsZWQgaXMgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NzE4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgV2Vuc29uIEhzaWVoLgorCisgICAgICAgIEEgY2hlY2sgZ290IG1p c3NlZCB3aGVuIHJlZmFjdG9yaW5nIGNvZGUgZm9yIDI4OTgxOC4KKworICAgICAgICAqIHBhZ2Uv RXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxl TW91c2VQcmVzc0V2ZW50RG91YmxlQ2xpY2spOgorCiAyMDIyLTAyLTE1ICBOaWtvbGFvcyBNb3Vj aHRhcmlzICA8bm1vdWNodGFyaXNAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBwYXJz aW5nIGFuZCBhbmltYXRpb24gc3VwcG9ydCBmb3Igb2Zmc2V0IHNob3J0aGFuZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IGNjYzMzZDBlMjgyNGFmMGUxZDIyNzExNjE4YTAw YmI5ZTc0ZWJmNmYuLjMxNTU3ZGE1ZGE1NDI2OGViMjdlZjBkZGRmZjU2Zjc0MzBlMDIzM2IgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTYwMSw3ICs2MDEsNyBAQCBib29s IEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVzc0V2ZW50RG91YmxlQ2xpY2soY29uc3QgTW91 c2VFdmVudFdpdGhIaXRUZXN0UgogICAgICAgICAvLyBtX2JlZ2FuU2VsZWN0aW5nVGV4dCB0byBw cmV2ZW50IGhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50CiAgICAgICAgIC8vIGZyb20gc2V0dGluZyBj YXJldCBzZWxlY3Rpb24uCiAgICAgICAgIG1fc2VsZWN0aW9uSW5pdGlhdGlvblN0YXRlID0gRXh0 ZW5kZWRTZWxlY3Rpb247Ci0gICAgZWxzZQorICAgIGVsc2UgaWYgKG1vdXNlRG93bk1heVN0YXJ0 U2VsZWN0KCkpCiAgICAgICAgIHNlbGVjdENsb3Nlc3RXb3JkRnJvbUhpdFRlc3RSZXN1bHQoZXZl bnQuaGl0VGVzdFJlc3VsdCgpLCBzaG91bGRBcHBlbmRUcmFpbGluZ1doaXRlc3BhY2UoZXZlbnQs IG1fZnJhbWUpKTsKIAogICAgIHJldHVybiB0cnVlOwo=