236684 2022-02-15 18:24:27 -0800 GeneratePreferences.rb: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated 2022-03-01 16:07:11 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=237237 InRadar P2 Normal --- 1 fujii fujii don.olmstead sam webkit-bug-importer ysuzuki oldest_to_newest 1842084 0 fujii 2022-02-15 18:24:27 -0800 Since Ruby 3.1.0, GeneratePreferences.rb reports the following warnings. [5602/6320] Generating ../../WebKit/DerivedSources/WebPageUpdatePreferences.cpp, ../../WebKit/DerivedSources/WebPreferencesDefinitions.h, ../../WebKit/DerivedSources/WebPreferencesExperimentalFeatures.cpp, ../../WebKit/DerivedSources/WebPreferencesGetterSetters.cpp, ../../WebKit/DerivedSources/WebPreferencesInternalDebugFeatures.cpp, ../../WebKit/DerivedSources/WebPreferencesKeys.cpp, ../../WebKit/DerivedSources/WebPreferencesKeys.h, ../../WebKit/DerivedSources/WebPreferencesStoreDefaultsMap.cpp C:/home/webkit/gc/WebKitBuild/Debug/WTF/Scripts/GeneratePreferences.rb:235: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. C:/home/webkit/gc/WebKitBuild/Debug/WTF/Scripts/GeneratePreferences.rb:235: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. 1842086 1 452122 fujii 2022-02-15 18:36:12 -0800 Created attachment 452122 Patch 1843224 2 452122 ysuzuki 2022-02-17 18:26:05 -0800 Comment on attachment 452122 Patch r=me 1843233 3 ews-feeder 2022-02-17 18:47:38 -0800 Committed r290104 (247450@main): <https://commits.webkit.org/247450@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452122. 1843234 4 webkit-bug-importer 2022-02-17 18:48:21 -0800 <rdar://problem/89121381> 1846470 5 fujii 2022-02-27 12:00:21 -0800 *** Bug 237237 has been marked as a duplicate of this bug. *** 452122 2022-02-15 18:36:12 -0800 2022-02-17 18:47:41 -0800 Patch bug-236684-20220216113611.patch text/plain 1854 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY2MDY5ODliY2RhNjQyMTdkZTJlNzcw ODM4NmYzNzA2N2ExYThkZTQuLjc2MThkNzI1MTcwYzU4NGU0YzliYmEyZGEyZTc2Nzk2NGJjNTBi ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDItMTUgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgR2VuZXJhdGVQcmVmZXJlbmNlcy5yYjog d2FybmluZzogUGFzc2luZyBzYWZlX2xldmVsIHdpdGggdGhlIDJuZCBhcmd1bWVudCBvZiBFUkIu bmV3IGlzIGRlcHJlY2F0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzNjY4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdpdGggUnVieSAzLjEuMCwgR2VuZXJhdGVQcmVmZXJlbmNlcy5yYiByZXBvcnRl ZCB0aGUgZm9sbG93aW5nIHdhcm5pbmdzLgorICAgICAgICA+IEdlbmVyYXRlUHJlZmVyZW5jZXMu cmI6MjM1OiB3YXJuaW5nOiBQYXNzaW5nIHNhZmVfbGV2ZWwgd2l0aCB0aGUgMm5kIGFyZ3VtZW50 IG9mIEVSQi5uZXcgaXMgZGVwcmVjYXRlZC4gRG8gbm90IHVzZSBpdCwgYW5kIHNwZWNpZnkgb3Ro ZXIgYXJndW1lbnRzIGFzIGtleXdvcmQgYXJndW1lbnRzLgorICAgICAgICA+IEdlbmVyYXRlUHJl ZmVyZW5jZXMucmI6MjM1OiB3YXJuaW5nOiBQYXNzaW5nIHRyaW1fbW9kZSB3aXRoIHRoZSAzcmQg YXJndW1lbnQgb2YgRVJCLm5ldyBpcyBkZXByZWNhdGVkLiBVc2Uga2V5d29yZCBhcmd1bWVudCBs aWtlIEVSQi5uZXcoc3RyLCB0cmltX21vZGU6IC4uLikgaW5zdGVhZC4KKworICAgICAgICAqIFNj cmlwdHMvR2VuZXJhdGVQcmVmZXJlbmNlcy5yYjogQ2hhbmdlZCB0byB1c2UgdGhlIGtleXdvcmQg YXJndW1lbnQgZm9yIEVSQi5uZXcuCisKIDIwMjItMDItMTUgIFJvYmluIE1vcmlzc2V0ICA8cm1v cmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0dTTF0gSW1wbGVtZW50IGVub3VnaCBvZiB0 aGUgbGV4ZXIgZm9yIHRoZSBzaW1wbGVzdCBzaGFkZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L1NjcmlwdHMvR2VuZXJhdGVQcmVmZXJlbmNlcy5yYiBiL1NvdXJjZS9XVEYvU2NyaXB0cy9HZW5l cmF0ZVByZWZlcmVuY2VzLnJiCmluZGV4IDAyNzFmMDdiNmM1NjBlYmQ4OWRlOGI0N2NiMzIyYWRl ZGZhZDVhYjQuLmRlMGYyMjY4YjE3OGNkMjY3MjQwOGQyMWFiMTg2NTlkMDkzMjA4ZTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvU2NyaXB0cy9HZW5lcmF0ZVByZWZlcmVuY2VzLnJiCisrKyBiL1Nv dXJjZS9XVEYvU2NyaXB0cy9HZW5lcmF0ZVByZWZlcmVuY2VzLnJiCkBAIC0yMzIsNyArMjMyLDcg QEAgY2xhc3MgUHJlZmVyZW5jZXMKICAgICByZXN1bHRGaWxlID0gRmlsZS5qb2luKG91dHB1dERp cmVjdG9yeSwgRmlsZS5iYXNlbmFtZSh0ZW1wbGF0ZUZpbGUsICIuZXJiIikpCiAgICAgdGVtcFJl c3VsdEZpbGUgPSByZXN1bHRGaWxlICsgIi50bXAiCiAKLSAgICBvdXRwdXQgPSBFUkIubmV3KEZp bGUucmVhZCh0ZW1wbGF0ZUZpbGUpLCAwLCAiLSIpLnJlc3VsdChiaW5kaW5nKQorICAgIG91dHB1 dCA9IEVSQi5uZXcoRmlsZS5yZWFkKHRlbXBsYXRlRmlsZSksIHRyaW1fbW9kZToiLSIpLnJlc3Vs dChiaW5kaW5nKQogICAgIEZpbGUub3Blbih0ZW1wUmVzdWx0RmlsZSwgIncrIikgZG8gfGZ8CiAg ICAgICBmLndyaXRlKG91dHB1dCkKICAgICBlbmQK