236669 2022-02-15 14:17:26 -0800 [Cocoa] Clean up some unused context menu identifier SPI constants 2022-02-16 10:18:06 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh dino megan_gardner thorton webkit-bug-importer oldest_to_newest 1841942 0 wenson_hsieh 2022-02-15 14:17:26 -0800 rdar://88924479 1841953 1 452092 wenson_hsieh 2022-02-15 14:46:26 -0800 Created attachment 452092 Patch 1842285 2 452092 wenson_hsieh 2022-02-16 07:48:42 -0800 Comment on attachment 452092 Patch Thanks for the review! 1842363 3 ews-feeder 2022-02-16 10:18:00 -0800 Committed r289908 (247338@main): <https://commits.webkit.org/247338@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452092. 452092 2022-02-15 14:46:26 -0800 2022-02-16 10:18:03 -0800 Patch bug-236669-20220215144625.patch text/plain 4690 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE3MDMwYjI0NWU4MzNmNjM1 NTRkNTcxNjI4ZGMyZmE3ZDMxNzkwYTUuLmJkNzc3YzUzMzRlZmQxZWZmNDVmYzVjMDE1OTQwYWQw YmU0NWE5ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjItMDItMTUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBDbGVhbiB1 cCBzb21lIHVudXNlZCBjb250ZXh0IG1lbnUgaWRlbnRpZmllciBTUEkgY29uc3RhbnRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY2NjkKKyAgICAg ICAgcmRhcjovLzg4OTI0NDc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVtb3ZlIGEgY291cGxlIG9mIHVudXNlZCBjb250ZXh0IG1lbnUgaXRlbSBp ZGVudGlmaWVyIGNvbnN0YW50cyBmb3IgUXVpY2sgTm90ZSwgYW5kIGFkZCBhIG5ldyBjb25zdGFu dCB0bworICAgICAgICByZXByZXNlbnQgdGhlICJDb3B5IENyb3BwZWQgSW1hZ2UiIGl0ZW0gYWRk ZWQgaW4gcjI4OTg1MS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tNZW51SXRl bUlkZW50aWZpZXJzLm1tOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tNZW51SXRl bUlkZW50aWZpZXJzUHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29udGV4 dE1lbnVQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6bWVudUl0ZW1JZGVudGlmaWVyKToK KwogMjAyMi0wMi0xNSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog ICAgICAgICBbbWFjT1NdIEFkZCBhbiAiTWFya3VwIEltYWdlIiBpdGVtIHRvIHRoZSBzaGFyaW5n IHNlcnZpY2VzIHBpY2tlciBjb250ZXh0IG1lbnUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS01lbnVJdGVtSWRlbnRpZmllcnMubW0gYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tNZW51SXRlbUlkZW50aWZpZXJzLm1tCmluZGV4IDc1 NGE5NWNjYWNkMGU3ZWU4MmQ0NGYxOWRlY2M5Y2EyOTcyOTFmNTIuLmQ0MmMyYmE2NmU1YTUwM2Nl ODcxZmJmZTIzZjRiY2U0MWQwMjc1YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS01lbnVJdGVtSWRlbnRpZmllcnMubW0KKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLTWVudUl0ZW1JZGVudGlmaWVycy5tbQpAQCAtMzksOSAr MzksNiBAQCBOU1N0cmluZyAqIGNvbnN0IF9XS01lbnVJdGVtSWRlbnRpZmllckluc3BlY3RFbGVt ZW50ID0gQCJXS01lbnVJdGVtSWRlbnRpZmllcklucwogTlNTdHJpbmcgKiBjb25zdCBfV0tNZW51 SXRlbUlkZW50aWZpZXJMb29rVXAgPSBAIldLTWVudUl0ZW1JZGVudGlmaWVyTG9va1VwIjsKIE5T U3RyaW5nICogY29uc3QgX1dLTWVudUl0ZW1JZGVudGlmaWVyQWRkSGlnaGxpZ2h0VG9DdXJyZW50 UXVpY2tOb3RlID0gQCJXS01lbnVJdGVtSWRlbnRpZmllckFkZEhpZ2hsaWdodFRvQ3VycmVudFF1 aWNrTm90ZSI7CiBOU1N0cmluZyAqIGNvbnN0IF9XS01lbnVJdGVtSWRlbnRpZmllckFkZEhpZ2hs aWdodFRvTmV3UXVpY2tOb3RlID0gQCJXS01lbnVJdGVtSWRlbnRpZmllckFkZEhpZ2hsaWdodFRv TmV3UXVpY2tOb3RlIjsKLS8vIEZJWE1FOiBSZW1vdmUgYmVsb3cgYWZ0ZXIgc3RhZ2luZyBjb21w bGV0ZQotTlNTdHJpbmcgKiBjb25zdCBfV0tNZW51SXRlbUlkZW50aWZpZXJBZGRIaWdobGlnaHRU b0N1cnJlbnRHcm91cCA9IEAiV0tNZW51SXRlbUlkZW50aWZpZXJBZGRIaWdobGlnaHRUb0N1cnJl bnRHcm91cCI7Ci1OU1N0cmluZyAqIGNvbnN0IF9XS01lbnVJdGVtSWRlbnRpZmllckFkZEhpZ2hs aWdodFRvTmV3R3JvdXAgPSBAIldLTWVudUl0ZW1JZGVudGlmaWVyQWRkSGlnaGxpZ2h0VG9OZXdH cm91cCI7CiAKIE5TU3RyaW5nICogY29uc3QgX1dLTWVudUl0ZW1JZGVudGlmaWVyT3BlbkZyYW1l SW5OZXdXaW5kb3cgPSBAIldLTWVudUl0ZW1JZGVudGlmaWVyT3BlbkZyYW1lSW5OZXdXaW5kb3ci OwogTlNTdHJpbmcgKiBjb25zdCBfV0tNZW51SXRlbUlkZW50aWZpZXJPcGVuSW1hZ2VJbk5ld1dp bmRvdyA9IEAiV0tNZW51SXRlbUlkZW50aWZpZXJPcGVuSW1hZ2VJbk5ld1dpbmRvdyI7CkBAIC02 MCwzICs1Nyw0IEBAIE5TU3RyaW5nICogY29uc3QgX1dLTWVudUl0ZW1JZGVudGlmaWVyU2hhcmVN ZW51ID0gQCJXS01lbnVJdGVtSWRlbnRpZmllclNoYXJlTWVuCiBOU1N0cmluZyAqIGNvbnN0IF9X S01lbnVJdGVtSWRlbnRpZmllclNwZWVjaE1lbnUgPSBAIldLTWVudUl0ZW1JZGVudGlmaWVyU3Bl ZWNoTWVudSI7CiAKIE5TU3RyaW5nICogY29uc3QgX1dLTWVudUl0ZW1JZGVudGlmaWVyVHJhbnNs YXRlID0gQCJXS01lbnVJdGVtSWRlbnRpZmllclRyYW5zbGF0ZSI7CitOU1N0cmluZyAqIGNvbnN0 IF9XS01lbnVJdGVtSWRlbnRpZmllckNvcHlDcm9wcGVkSW1hZ2UgPSBAIldLTWVudUl0ZW1JZGVu dGlmaWVyQ29weUNyb3BwZWRJbWFnZSI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tNZW51SXRlbUlkZW50aWZpZXJzUHJpdmF0ZS5oIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLTWVudUl0ZW1JZGVudGlmaWVyc1ByaXZhdGUuaApp bmRleCBiNjUzNWY5NDBiMmJiMmRjMDA2MDQ2YmQ1MTliYmQyYjJkNGU5Y2FiLi44Nzk5MzgzNDQ4 ZjU1ZjI1MzhiYzY4Njg4ZWVhYTc0NTNjYTg5ZmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tNZW51SXRlbUlkZW50aWZpZXJzUHJpdmF0ZS5oCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS01lbnVJdGVtSWRlbnRpZmllcnNQ cml2YXRlLmgKQEAgLTU4LDggKzU4LDUgQEAgV0tfRVhQT1JUIGV4dGVybiBOU1N0cmluZyAqIGNv bnN0IF9XS01lbnVJdGVtSWRlbnRpZmllclNwZWVjaE1lbnUgV0tfQVBJX0FWQUlMQUIKIFdLX0VY UE9SVCBleHRlcm4gTlNTdHJpbmcgKiBjb25zdCBfV0tNZW51SXRlbUlkZW50aWZpZXJBZGRIaWdo bGlnaHRUb0N1cnJlbnRRdWlja05vdGUgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygxMi4wKSwgaW9z KDE1LjApKTsKIFdLX0VYUE9SVCBleHRlcm4gTlNTdHJpbmcgKiBjb25zdCBfV0tNZW51SXRlbUlk ZW50aWZpZXJBZGRIaWdobGlnaHRUb05ld1F1aWNrTm90ZSBXS19BUElfQVZBSUxBQkxFKG1hY29z KDEyLjApLCBpb3MoMTUuMCkpOwogCi0vLyBGSVhNRTogcmVtb3ZlIGJlbG93IGFmdGVyIHN0YWdp bmcgY29tcGxldGUuCi1XS19FWFBPUlQgZXh0ZXJuIE5TU3RyaW5nICogY29uc3QgX1dLTWVudUl0 ZW1JZGVudGlmaWVyQWRkSGlnaGxpZ2h0VG9DdXJyZW50R3JvdXAgV0tfQVBJX0FWQUlMQUJMRSht YWNvcygxMi4wKSwgaW9zKDE1LjApKTsKLVdLX0VYUE9SVCBleHRlcm4gTlNTdHJpbmcgKiBjb25z dCBfV0tNZW51SXRlbUlkZW50aWZpZXJBZGRIaWdobGlnaHRUb05ld0dyb3VwIFdLX0FQSV9BVkFJ TEFCTEUobWFjb3MoMTIuMCksIGlvcygxNS4wKSk7Ci0KIFdLX0VYUE9SVCBleHRlcm4gTlNTdHJp bmcgKiBjb25zdCBfV0tNZW51SXRlbUlkZW50aWZpZXJUcmFuc2xhdGUgV0tfQVBJX0FWQUlMQUJM RShtYWNvcygxMi4wKSwgaW9zKDE1LjApKTsKK1dLX0VYUE9SVCBleHRlcm4gTlNTdHJpbmcgKiBj b25zdCBfV0tNZW51SXRlbUlkZW50aWZpZXJDb3B5Q3JvcHBlZEltYWdlIFdLX0FQSV9BVkFJTEFC TEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCmluZGV4IGE2 NTM5YWY1YzkwNjg4MDA2NTJlZWRjZmFhYTY0MDZlYWRjYzQxYjguLjA5YmM1ZDMyMjhhZTNjZGY3 ODg5MjM1NjFlZWFmMDFkNmQ3OTE2OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCkBAIC01MjAsNiArNTIwLDkgQEAg c3RhdGljIE5TU3RyaW5nICptZW51SXRlbUlkZW50aWZpZXIoY29uc3QgV2ViQ29yZTo6Q29udGV4 dE1lbnVBY3Rpb24gYWN0aW9uKQogICAgIGNhc2UgQ29udGV4dE1lbnVJdGVtVGFnVHJhbnNsYXRl OgogICAgICAgICByZXR1cm4gX1dLTWVudUl0ZW1JZGVudGlmaWVyVHJhbnNsYXRlOwogCisgICAg Y2FzZSBDb250ZXh0TWVudUl0ZW1UYWdDb3B5Q3JvcHBlZEltYWdlOgorICAgICAgICByZXR1cm4g X1dLTWVudUl0ZW1JZGVudGlmaWVyQ29weUNyb3BwZWRJbWFnZTsKKwogICAgIGNhc2UgQ29udGV4 dE1lbnVJdGVtVGFnU2hhcmVNZW51OgogICAgICAgICByZXR1cm4gX1dLTWVudUl0ZW1JZGVudGlm aWVyU2hhcmVNZW51OwogCg==