236663 2022-02-15 13:02:39 -0800 [WebKitLegacy] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings 2022-02-16 10:22:30 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen darin dino webkit-bug-importer oldest_to_newest 1841890 0 ddkilzer 2022-02-15 13:02:39 -0800 Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WebKitLegacy. Found by clang static analyzer. Only one issue remaining after WTF fixes in Source/WebKitLegacy/mac/Misc/WebDownload.mm. 1841891 1 webkit-bug-importer 2022-02-15 13:02:54 -0800 <rdar://problem/88982792> 1841927 2 452088 ddkilzer 2022-02-15 13:52:24 -0800 Created attachment 452088 Patch v1 1842283 3 452088 ddkilzer 2022-02-16 07:36:11 -0800 Comment on attachment 452088 Patch v1 Adding cq+ since mac-wk1 tests passed. 1842366 4 ews-feeder 2022-02-16 10:22:25 -0800 Committed r289909 (247339@main): <https://commits.webkit.org/247339@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452088. 452088 2022-02-15 13:52:24 -0800 2022-02-16 10:22:28 -0800 Patch v1 bug-236663-20220215135223.patch text/plain 1485 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggYjY3ZGJjY2IzMTY2ZGU2NzM4MTgwNTg3ZTI4ODE5MzgxZTVlZDhkNi4uMDU1ZjhmMTM0MjMw NTFmODEwZDIwM2JiYmU3NmFmNmUyN2NhODUzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CisKKyAgICAgICAgW1dlYktpdExlZ2FjeV0gRml4IGNsYW5nIHRpZHkgYnVncHJv bmUtbW92ZS1mb3J3YXJkaW5nLXJlZmVyZW5jZSBzdGF0aWMgYW5hbHl6ZXIgd2FybmluZ3MKKyAg ICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIzNjY2Mz4KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzg4OTgyNzkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogTWlzYy9XZWJEb3dubG9hZC5tbToKKyAgICAgICAgKGNhbGxPbkRlbGVnYXRlVGhy ZWFkQW5kV2FpdCk6CisgICAgICAgIC0gUmVwbGFjZSBXVEZNb3ZlKCkgd2l0aCBzdGQ6OmZvcndh cmQ8PigpLgorCiAyMDIyLTAyLTA2ICBUeWxlciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+ CiAKICAgICAgICAgQVg6IEFkZCBpbnRlcm5hbC1vbmx5IGZsYWcgdG8gZW5hYmxlIFdJUCBkaXNw bGF5OiBjb250ZW50cyBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21h Yy9NaXNjL1dlYkRvd25sb2FkLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvTWlzYy9XZWJE b3dubG9hZC5tbQppbmRleCAxMjA1OGIxZmIxYWFmZDQ0NzhmNDE1NmYzYWFjMTgxZDgwMDMwYmM1 Li5lMjQ3YThlMmQ1NmQwZTY3NjA5ZDk4OGFmMTI3OWM4ZTIzNzU3ZWJiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9NaXNjL1dlYkRvd25sb2FkLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXRMZWdhY3kvbWFjL01pc2MvV2ViRG93bmxvYWQubW0KQEAgLTY3LDcgKzY3LDcgQEAgc3Rh dGljIHZvaWQgY2FsbE9uRGVsZWdhdGVUaHJlYWRBbmRXYWl0KENhbGxhYmxlJiYgd29yaykKICAg ICBpZiAoc2hvdWxkQ2FsbE9uTmV0d29ya1RocmVhZCgpIHx8IGlzTWFpblRocmVhZCgpKQogICAg ICAgICB3b3JrKCk7CiAgICAgZWxzZSB7Ci0gICAgICAgIFdvcmtRdWV1ZTo6bWFpbigpLmRpc3Bh dGNoU3luYyhbd29yayA9IFdURk1vdmUod29yayldKCkgbXV0YWJsZSB7CisgICAgICAgIFdvcmtR dWV1ZTo6bWFpbigpLmRpc3BhdGNoU3luYyhbd29yayA9IHN0ZDo6Zm9yd2FyZDxDYWxsYWJsZT4o d29yayldKCkgbXV0YWJsZSB7CiAgICAgICAgICAgICB3b3JrKCk7CiAgICAgICAgIH0pOwogICAg IH0K