236654 2022-02-15 10:36:19 -0800 [EWS] Support PRs when sending layout test failure emails 2022-02-16 12:55:48 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234847 https://bugs.webkit.org/show_bug.cgi?id=235926 https://bugs.webkit.org/show_bug.cgi?id=236705 InRadar P2 Normal --- 1 jbedard webkit-unassigned clopez webkit-bug-importer oldest_to_newest 1841795 0 jbedard 2022-02-15 10:36:19 -0800 AnalyzeLayoutTestsResults emails change authors when their change fails EWS. We should support pull-requests in this step. 1841796 1 webkit-bug-importer 2022-02-15 10:36:35 -0800 <rdar://problem/88974170> 1841800 2 jbedard 2022-02-15 10:39:56 -0800 Pull request: https://github.com/WebKit/WebKit/pull/147 1842269 3 jbedard 2022-02-16 06:48:30 -0800 Landed 247326@main (r289888) 1842456 4 clopez 2022-02-16 12:40:58 -0800 (In reply to Jonathan Bedard from comment #3) > Landed 247326@main (r289888) there are a few issues with this patch: a few _addToLog() calls miss the two parameters needed and there is one variable undefined. I detected this meanwhile working on bug 236705 which adds unit tests to test the send_email() calls This would be the fix: http://sprunge.us/BNhsG4 I can include it as part of bug 236705 1842469 5 clopez 2022-02-16 12:55:33 -0800 (In reply to Carlos Alberto Lopez Perez from comment #4) > (In reply to Jonathan Bedard from comment #3) > > Landed 247326@main (r289888) > > there are a few issues with this patch: > > a few _addToLog() calls miss the two parameters needed and there is one > variable undefined. > > I detected this meanwhile working on bug 236705 which adds unit tests to > test the send_email() calls > > This would be the fix: http://sprunge.us/BNhsG4 > > I can include it as part of bug 236705 I landed 289947 that includes also those fixes. Now the unit tests exercise the code for the send_email_* functions so this should be easier to detect in the future 1842470 6 clopez 2022-02-16 12:55:48 -0800 (In reply to Carlos Alberto Lopez Perez from comment #5) > (In reply to Carlos Alberto Lopez Perez from comment #4) > > (In reply to Jonathan Bedard from comment #3) > > > Landed 247326@main (r289888) > > > > there are a few issues with this patch: > > > > a few _addToLog() calls miss the two parameters needed and there is one > > variable undefined. > > > > I detected this meanwhile working on bug 236705 which adds unit tests to > > test the send_email() calls > > > > This would be the fix: http://sprunge.us/BNhsG4 > > > > I can include it as part of bug 236705 > > I landed 289947 that includes also those fixes. > > Now the unit tests exercise the code for the send_email_* functions so this > should be easier to detect in the future r289947