236643 2022-02-15 06:09:31 -0800 [JSC] Guard against dead remotes in numberOfProcessors 2022-02-22 02:27:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 angelos angelos aperez fujii jbedard mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1841672 0 angelos 2022-02-15 06:09:31 -0800 [JSC] Guard against dead remotes in numberOfProcessors 1841674 1 452014 angelos 2022-02-15 06:11:13 -0800 Created attachment 452014 Patch 1844149 2 452720 angelos 2022-02-21 01:49:09 -0800 Created attachment 452720 Patch 1844604 3 452720 aperez 2022-02-22 01:47:34 -0800 Comment on attachment 452720 Patch r=me View in context: https://bugs.webkit.org/attachment.cgi?id=452720&action=review > Tools/Scripts/run-jsc-stress-tests:2585 > + numProcessors = runCommandOnTester("sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null").to_i I wonder if it would be better/good to use “getconf _NPROCESSORS_ONLN“ or have it as yet another fallback 🤔️ Anyway, just a thought, no need to update the patch for it. 1844607 4 angelos 2022-02-22 01:52:49 -0800 (In reply to Adrian Perez from comment #3) > Comment on attachment 452720 [details] > Patch > > r=me > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452720&action=review > > > Tools/Scripts/run-jsc-stress-tests:2585 > > + numProcessors = runCommandOnTester("sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null").to_i > > I wonder if it would be better/good to use “getconf _NPROCESSORS_ONLN“ or > have > it as yet another fallback 🤔️ That's probably a good idea. And since you mention _NPROCESSORS_ONLN, it'd probably make sense to remove the --all argument from the nproc invocation too. 1844616 5 ews-feeder 2022-02-22 02:26:53 -0800 Committed r290298 (247621@main): <https://commits.webkit.org/247621@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452720. 1844617 6 webkit-bug-importer 2022-02-22 02:27:16 -0800 <rdar://problem/89283653> 452014 2022-02-15 06:11:13 -0800 2022-02-21 01:48:57 -0800 Patch bug-236643-20220215141112.patch text/plain 2487 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDhiY2RhMWU4Yzk4NWNlZDgyOTI3MTlkZWE2OGI4Yjc5 MzFkNGY5MC4uNDBjNmZjMDg0Y2RkZDBhMGZlNWY3ZGYwNTIwNWFlNzlmZmI0YjA1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIyLTAyLTE1ICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFtKU0NdIEd1YXJkIGFnYWluc3QgZGVhZCByZW1vdGVzIGluIG51bWJl ck9mUHJvY2Vzc29ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM2NjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5zdGVhZCBvZiB1c2luZyBvbmx5IHRoZSBmaXJzdCByZW1vdGUgKGFuZCB0aGVuIGRl ZmF1bHRpbmcgdG8gMSB3aGVuCisgICAgICAgIGl0IGhhcHBlbnMgdG8gbm90IHJlc3BvbmQpLCB0 cnkgYWxsIHRoZSByZW1vdGVzIGluIHNlcXVlbmNlLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0czoKKwogMjAyMi0wMi0xNCAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVu ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEV4dGVuc2lvbnNHTCBpcyBub3QgdXNlZnVsIGNsYXNz LCBpdCBzaG91bGQgYmUgcmVtb3ZlZApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tanNj LXN0cmVzcy10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKaW5kZXgg ZWMwY2NjN2UwNGFiNGZiMjcwN2U2Y2EyMjM5ZDZmMGNhOWZmOWJjOS4uNTZlOTRiZWQwYzkwY2Rl MzM5MjczZDQyZmQwYWUwMTllNzY4ZGY0MyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3Rz CkBAIC0yNTYzLDEwICsyNTYzLDE4IEBAIGVuZAogCiBkZWYgcnVuQ29tbWFuZE9uVGVzdGVyKGNt ZCkKICAgICBpZiAkcmVtb3RlCi0gICAgICAgIHJlc3VsdCA9IHNzaFJlYWQoY21kLCAkcmVtb3Rl SG9zdHNbMF0pCi0gICAgZWxzZQotICAgICAgICByZXN1bHQgPSBgI3tjbWR9YAorICAgICAgICAk cmVtb3RlSG9zdHMuZWFjaCB7IHxyZW1vdGVIb3N0fAorICAgICAgICAgICAgYmVnaW4KKyAgICAg ICAgICAgICAgICAjIFJldHVybiBmaXJzdCBzdWNjZXNzZnVsIHZhbHVlLiBPYnZpb3VzbHksIHRo aXMKKyAgICAgICAgICAgICAgICAjIGFzc3VtZXMgdGhlIHJlbW90ZXMgYXJlIGhvbW9nZW5lb3Vz LgorICAgICAgICAgICAgICAgIHJldHVybiBzc2hSZWFkKGNtZCwgcmVtb3RlSG9zdCkKKyAgICAg ICAgICAgIHJlc2N1ZSBFeGNlcHRpb24gPT4gZQorICAgICAgICAgICAgICAgICRzdGRlcnIucHV0 cygiRXJyb3IgcnVubmluZyBgI3tjbWR9YCBvbiAje3JlbW90ZUhvc3QuaG9zdH06ICN7ZX0iKQor ICAgICAgICAgICAgZW5kCisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuICIwIgogICAgIGVuZAor ICAgIGAje2NtZH1gCiBlbmQKIAogZGVmIG51bWJlck9mUHJvY2Vzc29ycwpAQCAtMjU3NCwyMSAr MjU4MiwxNCBAQCBkZWYgbnVtYmVyT2ZQcm9jZXNzb3JzCiAgICAgICAgIG51bVByb2Nlc3NvcnMg PSBydW5Db21tYW5kT25UZXN0ZXIoImNtZCAvYyBlY2hvICVOVU1CRVJfT0ZfUFJPQ0VTU09SUyUi KS50b19pCiAgICAgZWxzZQogICAgICAgICBiZWdpbgotICAgICAgICAgICAgbnVtUHJvY2Vzc29y cyA9IHJ1bkNvbW1hbmRPblRlc3Rlcigic3lzY3RsIC1uIGh3LmFjdGl2ZWNwdSAyPi9kZXYvbnVs bCIpLnRvX2kKKyAgICAgICAgICAgIG51bVByb2Nlc3NvcnMgPSBydW5Db21tYW5kT25UZXN0ZXIo InN5c2N0bCAtbiBody5hY3RpdmVjcHUgMj4vZGV2L251bGwgfHwgbnByb2MgLS1hbGwgMj4vZGV2 L251bGwiKS50b19pCiAgICAgICAgIHJlc2N1ZQogICAgICAgICAgICAgbnVtUHJvY2Vzc29ycyA9 IDAKICAgICAgICAgZW5kCi0KLSAgICAgICAgaWYgbnVtUHJvY2Vzc29ycyA9PSAwCi0gICAgICAg ICAgICBiZWdpbgotICAgICAgICAgICAgICAgIG51bVByb2Nlc3NvcnMgPSBydW5Db21tYW5kT25U ZXN0ZXIoIm5wcm9jIC0tYWxsIDI+L2Rldi9udWxsIikudG9faQotICAgICAgICAgICAgcmVzY3Vl Ci0gICAgICAgICAgICAgICAgbnVtUHJvY2Vzc29ycyA9PSAwCi0gICAgICAgICAgICBlbmQKLSAg ICAgICAgZW5kCiAgICAgZW5kCiAKICAgICBpZiBudW1Qcm9jZXNzb3JzID09IDAKKyAgICAgICAg JHN0ZGVyci5wdXRzKCJXYXJuaW5nOiBjb3VsZCBub3QgZGV0ZXJtaW5lIHRoZSBudW1iZXIgb2Yg cmVtb3RlIENQVXMsIGRlZmF1bHRpbmcgdG8gMSIpCiAgICAgICAgIG51bVByb2Nlc3NvcnMgPSAx CiAgICAgZW5kCiAgICAgcmV0dXJuIG51bVByb2Nlc3NvcnMK 452720 2022-02-21 01:49:09 -0800 2022-02-22 02:26:56 -0800 Patch bug-236643-20220221094908.patch text/plain 2824 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjkwMjM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzFhNTFkODNlMjJiYmZiNzBlZThlNjg1NDk2MjRjOTgx ZWY1YTk4NS4uYzAzM2Y0NzQxMTIxMjY4OTNiZjNjNTMxYTUzY2IxMzcwM2JkMGM0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIyLTAyLTIxICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFtKU0NdIEd1YXJkIGFnYWluc3QgZGVhZCByZW1vdGVzIGluIG51bWJl ck9mUHJvY2Vzc29ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM2NjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5zdGVhZCBvZiB1c2luZyBvbmx5IHRoZSBmaXJzdCByZW1vdGUgKGFuZCB0aGVuIGRl ZmF1bHRpbmcgdG8gMSB3aGVuCisgICAgICAgIGl0IGhhcHBlbnMgdG8gbm90IHJlc3BvbmQpLCB0 cnkgYWxsIHRoZSByZW1vdGVzIGluIHNlcXVlbmNlLgorCisgICAgICAgIEFsc28sIGluc3RlYWQg b2YgdHJ5aW5nIHRoZSBzeXNjdGwgdmVyc2lvbiBvbiBhbGwgaG9zdHMgZmlyc3QgYW5kCisgICAg ICAgIG9ubHkgdHJ5IG5wcm9jIGFmdGVyIHN5c2N0bCBoYXMgZmFpbGVkIG9uIGFsbCBob3N0cywg Y29tYmluZQorICAgICAgICBzeXNjdGwgYW5kIG5wcm9jIGluIG9uZSBjb21tYW5kIHRvIHNwZWVk IHRoaW5ncyBhbG9uZy4KKworICAgICAgICBUaGlzIGNoYW5nZSBhbHNvIHJlbW92ZXMgdGhlIG51 bVByb2Nlc3NvcnMgPT0gMCB0eXBvIGluIHRoZSByZXNjdWUKKyAgICAgICAgcGF0aC4KKworICAg ICAgICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6CisKIDIwMjItMDItMjEgIFNpaHVp IExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgRmV0Y2hpbmcgd2Vic2l0ZSBk YXRhIG1heSBnZXQgd3JvbmcgcmVjb3JkIGFmdGVyIG1pZ3JhdGluZyBkYXRhIHRvIGdlbmVyYWwg c3RvcmFnZSBkaXJlY3RvcnkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJl c3MtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IDFmNjA4 OTU4MjA3YWJlNTU2YjAzNjdmODE2MzhjOTFlYWZjYWYyMzQuLjNkNmFkMzFkMmI0MTY0ODg5NDE2 MzYyZGUzZWU5NTcyOTUxMTMzMGEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1z dHJlc3MtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwpAQCAt MjU2MywxMCArMjU2MywxOCBAQCBlbmQKIAogZGVmIHJ1bkNvbW1hbmRPblRlc3RlcihjbWQpCiAg ICAgaWYgJHJlbW90ZQotICAgICAgICByZXN1bHQgPSBzc2hSZWFkKGNtZCwgJHJlbW90ZUhvc3Rz WzBdKQotICAgIGVsc2UKLSAgICAgICAgcmVzdWx0ID0gYCN7Y21kfWAKKyAgICAgICAgJHJlbW90 ZUhvc3RzLmVhY2ggeyB8cmVtb3RlSG9zdHwKKyAgICAgICAgICAgIGJlZ2luCisgICAgICAgICAg ICAgICAgIyBSZXR1cm4gZmlyc3Qgc3VjY2Vzc2Z1bCB2YWx1ZS4gT2J2aW91c2x5LCB0aGlzCisg ICAgICAgICAgICAgICAgIyBhc3N1bWVzIHRoZSByZW1vdGVzIGFyZSBob21vZ2VuZW91cy4KKyAg ICAgICAgICAgICAgICByZXR1cm4gc3NoUmVhZChjbWQsIHJlbW90ZUhvc3QpCisgICAgICAgICAg ICByZXNjdWUgRXhjZXB0aW9uID0+IGUKKyAgICAgICAgICAgICAgICAkc3RkZXJyLnB1dHMoIkVy cm9yIHJ1bm5pbmcgYCN7Y21kfWAgb24gI3tyZW1vdGVIb3N0Lmhvc3R9OiAje2V9IikKKyAgICAg ICAgICAgIGVuZAorICAgICAgICB9CisgICAgICAgIHJldHVybiAiMCIKICAgICBlbmQKKyAgICBg I3tjbWR9YAogZW5kCiAKIGRlZiBudW1iZXJPZlByb2Nlc3NvcnMKQEAgLTI1NzQsMjEgKzI1ODIs MTQgQEAgZGVmIG51bWJlck9mUHJvY2Vzc29ycwogICAgICAgICBudW1Qcm9jZXNzb3JzID0gcnVu Q29tbWFuZE9uVGVzdGVyKCJjbWQgL2MgZWNobyAlTlVNQkVSX09GX1BST0NFU1NPUlMlIikudG9f aQogICAgIGVsc2UKICAgICAgICAgYmVnaW4KLSAgICAgICAgICAgIG51bVByb2Nlc3NvcnMgPSBy dW5Db21tYW5kT25UZXN0ZXIoInN5c2N0bCAtbiBody5hY3RpdmVjcHUgMj4vZGV2L251bGwiKS50 b19pCisgICAgICAgICAgICBudW1Qcm9jZXNzb3JzID0gcnVuQ29tbWFuZE9uVGVzdGVyKCJzeXNj dGwgLW4gaHcuYWN0aXZlY3B1IDI+L2Rldi9udWxsIHx8IG5wcm9jIC0tYWxsIDI+L2Rldi9udWxs IikudG9faQogICAgICAgICByZXNjdWUKICAgICAgICAgICAgIG51bVByb2Nlc3NvcnMgPSAwCiAg ICAgICAgIGVuZAotCi0gICAgICAgIGlmIG51bVByb2Nlc3NvcnMgPT0gMAotICAgICAgICAgICAg YmVnaW4KLSAgICAgICAgICAgICAgICBudW1Qcm9jZXNzb3JzID0gcnVuQ29tbWFuZE9uVGVzdGVy KCJucHJvYyAtLWFsbCAyPi9kZXYvbnVsbCIpLnRvX2kKLSAgICAgICAgICAgIHJlc2N1ZQotICAg ICAgICAgICAgICAgIG51bVByb2Nlc3NvcnMgPT0gMAotICAgICAgICAgICAgZW5kCi0gICAgICAg IGVuZAogICAgIGVuZAogCiAgICAgaWYgbnVtUHJvY2Vzc29ycyA9PSAwCisgICAgICAgICRzdGRl cnIucHV0cygiV2FybmluZzogY291bGQgbm90IGRldGVybWluZSB0aGUgbnVtYmVyIG9mIHJlbW90 ZSBDUFVzLCBkZWZhdWx0aW5nIHRvIDEiKQogICAgICAgICBudW1Qcm9jZXNzb3JzID0gMQogICAg IGVuZAogICAgIHJldHVybiBudW1Qcm9jZXNzb3JzCg==