23663 2009-01-31 08:26:14 -0800 Should add void toRenderBox method to catch unnecessary casts 2009-01-31 10:08:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 manyoso webkit-unassigned oldest_to_newest 107843 0 manyoso 2009-01-31 08:26:14 -0800 RenderBox should add a void toRenderBox method to catch unnecessary casts much like David Hyatt has added for other RenderFoo classes. 107844 1 27217 manyoso 2009-01-31 08:27:59 -0800 Created attachment 27217 Add void toRenderBox casting method Adds the check and also fixes four cases of unnecessary toRenderBox casts. 107846 2 27217 darin 2009-01-31 08:55:33 -0800 Comment on attachment 27217 Add void toRenderBox casting method > +// This will catch anyone doing an unnecessary cast. > +void toRenderBox(const RenderBox* o); We should leave out the "o" here. r=me 107849 3 manyoso 2009-01-31 10:08:27 -0800 Fixed with r40452. 27217 2009-01-31 08:27:59 -0800 2009-01-31 08:55:33 -0800 Add void toRenderBox casting method toRenderBox_void.patch text/plain 4284 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDcyNTNhYS4uMGE5ODE4YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wMS0zMSAgQWRhbSBUcmVhdCAg PGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHZvaWQgdG9SZW5kZXJCb3goKSBtZXRob2Qgd2hp Y2ggY2F0Y2hlcyB1bm5lY2Vzc2FyeSBjYXN0cyBhdCBjb21waWxlCisgICAgICAgIHRpbWUgYW5k IGFsc28gZml4IHRoZSBmb3VyIGNhc2VzIHdoZXJlIHRoaXMgd2FzIGhhcHBlbmluZy4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCbG9jazo6ZGV0ZXJtaW5lSG9yaXpvbnRhbFBvc2l0aW9uKToKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyQm94Lmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94OjpsYXlvdXRIb3Jpem9udGFs Qm94KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlcklubGluZTo6dXBkYXRlSGl0VGVzdFJlc3VsdCk6CisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1 cGRhdGVMYXllclBvc2l0aW9uKToKKwogMjAwOS0wMS0zMCAgQWRhbSBUcmVhdCAgPGFkYW0udHJl YXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIEZpeCBRdCBidWlsZCB0byBpbmNsdWRlIG5l dyBjbGFzcyBJZGVudGlmaWVyUmVwIGludHJvZHVjZWQgaW4gcmV2aXNpb24gNDA0MTIuCmRpZmYg LS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggYjg0NDExMC4uMTdmZjM4OCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcApAQCAtMTE4MCw3ICsxMTgwLDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6 ZGV0ZXJtaW5lSG9yaXpvbnRhbFBvc2l0aW9uKFJlbmRlckJveCogY2hpbGQpCiAgICAgICAgICAg ICAgICAgLy8gd2lkdGggY29tcHV0YXRpb24gd2lsbCB0YWtlIGludG8gYWNjb3VudCB0aGUgZGVs dGEgYmV0d2VlbiB8cmlnaHRPZmZ8IGFuZCB8eFBvc3wKICAgICAgICAgICAgICAgICAvLyBzbyB0 aGF0IHdlIGNhbiBqdXN0IHBhc3MgdGhlIGNvbnRlbnQgd2lkdGggaW4gZGlyZWN0bHkgdG8gdGhl IHxjYWxjSG9yaXpvbnRhbE1hcmdpbnN8CiAgICAgICAgICAgICAgICAgLy8gZnVuY3Rpb24uCi0g ICAgICAgICAgICAgICAgdG9SZW5kZXJCb3goY2hpbGQpLT5jYWxjSG9yaXpvbnRhbE1hcmdpbnMo Y2hpbGQtPnN0eWxlKCktPm1hcmdpbkxlZnQoKSwgY2hpbGQtPnN0eWxlKCktPm1hcmdpblJpZ2h0 KCksIGxpbmVXaWR0aChjaGlsZC0+eSgpLCBmYWxzZSkpOworICAgICAgICAgICAgICAgIGNoaWxk LT5jYWxjSG9yaXpvbnRhbE1hcmdpbnMoY2hpbGQtPnN0eWxlKCktPm1hcmdpbkxlZnQoKSwgY2hp bGQtPnN0eWxlKCktPm1hcmdpblJpZ2h0KCksIGxpbmVXaWR0aChjaGlsZC0+eSgpLCBmYWxzZSkp OwogICAgICAgICAgICAgICAgIGNoUG9zID0gcmlnaHRPZmYgLSBjaGlsZC0+bWFyZ2luUmlnaHQo KSAtIGNoaWxkLT53aWR0aCgpOwogICAgICAgICAgICAgfQogICAgICAgICB9CmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveC5oCmluZGV4IDJmYTBhMDAuLmZhZDgwZjEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJveC5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCkBAIC0z OTEsNiArMzkxLDkgQEAgaW5saW5lIGNvbnN0IFJlbmRlckJveCogdG9SZW5kZXJCb3goY29uc3Qg UmVuZGVyT2JqZWN0KiBvKQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxjb25zdCBSZW5kZXJCb3gq PihvKTsKIH0KIAorLy8gVGhpcyB3aWxsIGNhdGNoIGFueW9uZSBkb2luZyBhbiB1bm5lY2Vzc2Fy eSBjYXN0Lgordm9pZCB0b1JlbmRlckJveChjb25zdCBSZW5kZXJCb3gqIG8pOworCiBpbmxpbmUg UmVuZGVyQm94KiBSZW5kZXJCb3g6OnByZXZpb3VzU2libGluZ0JveCgpIGNvbnN0CiB7CiAgICAg cmV0dXJuIHRvUmVuZGVyQm94KHByZXZpb3VzU2libGluZygpKTsKZGlmZiAtLWdpdCBhL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckZsZXhpYmxlQm94LmNwcAppbmRleCA3ODFlZDY0Li5hNDBkOGI0IDEwMDY0NAotLS0gYS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC00MjUsNyArNDI1LDcgQEAgdm9pZCBSZW5k ZXJGbGV4aWJsZUJveDo6bGF5b3V0SG9yaXpvbnRhbEJveChib29sIHJlbGF5b3V0Q2hpbGRyZW4p CiAgICAgICAgICAgICAvLyBmaWxsIHRoZSBoZWlnaHQgb2YgYSBjb250YWluaW5nIGJveCBieSBk ZWZhdWx0LgogICAgICAgICAgICAgLy8gTm93IGRvIGEgbGF5b3V0LgogICAgICAgICAgICAgaW50 IG9sZENoaWxkSGVpZ2h0ID0gY2hpbGQtPmhlaWdodCgpOwotICAgICAgICAgICAgdG9SZW5kZXJC b3goY2hpbGQpLT5jYWxjSGVpZ2h0KCk7CisgICAgICAgICAgICBjaGlsZC0+Y2FsY0hlaWdodCgp OwogICAgICAgICAgICAgaWYgKG9sZENoaWxkSGVpZ2h0ICE9IGNoaWxkLT5oZWlnaHQoKSkKICAg ICAgICAgICAgICAgICBjaGlsZC0+c2V0Q2hpbGROZWVkc0xheW91dCh0cnVlLCBmYWxzZSk7CiAg ICAgICAgICAgICBjaGlsZC0+bGF5b3V0SWZOZWVkZWQoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmxp bmUuY3BwCmluZGV4IGFiZThiMmEuLmUxMmNiYWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlcklubGluZS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5l LmNwcApAQCAtNjIwLDcgKzYyMCw3IEBAIHZvaWQgUmVuZGVySW5saW5lOjp1cGRhdGVIaXRUZXN0 UmVzdWx0KEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgSW50UG9pbnQmIHBvCiAgICAgICAg ICAgICBSZW5kZXJCbG9jayogZmlyc3RCbG9jayA9IG5vZGUtPnJlbmRlcmVyKCktPmNvbnRhaW5p bmdCbG9jaygpOwogICAgICAgICAgICAgCiAgICAgICAgICAgICAvLyBHZXQgb3VyIGNvbnRhaW5p bmcgYmxvY2suCi0gICAgICAgICAgICBSZW5kZXJCb3gqIGJsb2NrID0gdG9SZW5kZXJCb3godGhp cyk7CisgICAgICAgICAgICBSZW5kZXJCb3gqIGJsb2NrID0gdGhpczsKICAgICAgICAgICAgIGlm IChpc0lubGluZSgpKQogICAgICAgICAgICAgICAgIGJsb2NrID0gY29udGFpbmluZ0Jsb2NrKCk7 CiAgICAgICAgIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGY2MmRhNjQuLjk4Yjlm NGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTQwNCw4ICs0MDQsOCBAQCB2b2lk IFJlbmRlckxheWVyOjp1cGRhdGVMYXllclBvc2l0aW9uKCkKIAogICAgIG1fcmVsWCA9IG1fcmVs WSA9IDA7CiAgICAgaWYgKHJlbmRlcmVyKCktPmlzUmVsUG9zaXRpb25lZCgpKSB7Ci0gICAgICAg IG1fcmVsWCA9IHRvUmVuZGVyQm94KHJlbmRlcmVyKCkpLT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0 WCgpOwotICAgICAgICBtX3JlbFkgPSB0b1JlbmRlckJveChyZW5kZXJlcigpKS0+cmVsYXRpdmVQ b3NpdGlvbk9mZnNldFkoKTsKKyAgICAgICAgbV9yZWxYID0gcmVuZGVyZXIoKS0+cmVsYXRpdmVQ b3NpdGlvbk9mZnNldFgoKTsKKyAgICAgICAgbV9yZWxZID0gcmVuZGVyZXIoKS0+cmVsYXRpdmVQ b3NpdGlvbk9mZnNldFkoKTsKICAgICAgICAgeCArPSBtX3JlbFg7IHkgKz0gbV9yZWxZOwogICAg IH0KICAgICAK