236626 2022-02-14 18:01:48 -0800 [css-grid] Absolutely positioned children using 'auto' placement don't cover margin correctly when using RTL 2022-02-17 10:00:38 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/32850 InRadar P2 Normal --- 236694 1 mattwoodrow mattwoodrow changseok clopez dino esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr rego svillar webkit-bug-importer youennf oldest_to_newest 1841511 0 mattwoodrow 2022-02-14 18:01:48 -0800 It looks like our array of column positions is ordered logically (column 0 is the physical right-edge when using RTL), but is always shifted by the physical left border and padding. When computing the breadth of an abs-pos item that covers the padding area (using 'auto'), we need to account for this, since the auto lines are purely in logical coords. 1841512 1 451974 mattwoodrow 2022-02-14 18:05:01 -0800 Created attachment 451974 Patch 1841513 2 ews-watchlist 2022-02-14 18:06:49 -0800 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1842946 3 ews-feeder 2022-02-17 09:59:06 -0800 Committed r290032 (247412@main): <https://commits.webkit.org/247412@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451974. 1842947 4 webkit-bug-importer 2022-02-17 10:00:38 -0800 <rdar://problem/89093512> 451974 2022-02-14 18:05:01 -0800 2022-02-17 09:59:09 -0800 Patch bug-236626-20220215150459.patch text/plain 5603 mattwoodrow U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmM2MjUxMWFlZDlmZWJi ZDg5N2ZiM2I2MTI2MDk4NTk1ZTBkNWFhNi4uN2EwNzMxMjJkODY5N2RhYzg5NzAzOGVjZWZlNzYw ZGI4M2ZjZmJhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIyLTAyLTE0ICBNYXR0 IFdvb2Ryb3cgIDxtYXR0d29vZHJvd0BhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGFicy1wb3Mg YnJlYWR0aCBpc3N1ZSB3aGVuIHVzaW5nICdhdXRvJworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHZhbHVlIHJldHVybmVkIHdoZW4gcmVzb2x2aW5n IGFuICdhdXRvJyBzdGFydC9lbmQgaXMgaW4gbG9naWNhbCBjb29yZHMsIGJ1dCB0aGUgbGluZQor ICAgICAgICBwb3NpdGlvbnMgYXJlIGluIGEgaHlicmlkIHNwYWNlIHVzaW5nIGxvZ2ljYWwgY29s dW1uIHNpemVzLCBidXQgcGh5c2ljYWwgYm9yZGVyL3BhZGRpbmcgb2Zmc2V0LgorICAgICAgICBU aGlzIGFkanVzdHMgZm9yIHRoaXMsIHNvIHRoYXQgd2UgY2FuIGNvbXB1dGUgdGhlIGJyZWFkdGgg Y29ycmVjdGx5LgorCisgICAgICAgIEFkZHMgbmV3IHRlc3QgdGhhdCB1c2VzIFJUTCBhbmQgYWJz LXBvcyBpdGVtcyBvdmVyIHRoZSBwYWRkaW5nIGFyZWEsIHdpdGgKKyAgICAgICAgcGFkZGluZyBk ZWZpbmVkIGluIHBoeXNpY2FsIGNvb3Jkcy4KKworICAgICAgICBUZXN0OiBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hYnNwb3MvcG9zaXRpb25lZC1ncmlkLWl0 ZW1zLTAyNS5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpncmlkQXJlYUJyZWFkdGhGb3JPdXRPZkZsb3dDaGls ZCk6CisKIDIwMjItMDItMDkgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtMRkNdW0lGQ10gVmVydGljYWwgd3JpdGluZyBtb2RlIHdpdGggUlRMIHRleHQgY29udGVu dCBoYXMgaW5jb3JyZWN0IGFkdmFuY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3Jp ZC5jcHAKaW5kZXggN2ZmYjYyMzc0OGYwMGY2NmZiN2JlODVmYjllOTUzM2U1NzQxMWVmMS4uZmE5 MjRjOWM4N2JkNTcyN2RlYWJmMmEyMTI4OTU2ODI4NTg4YWRjMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJHcmlkLmNwcApAQCAtMTY0MSw2ICsxNjQxLDEwIEBAIExheW91dFVuaXQg UmVuZGVyR3JpZDo6Z3JpZEFyZWFCcmVhZHRoRm9yT3V0T2ZGbG93Q2hpbGQoY29uc3QgUmVuZGVy Qm94JiBjaGlsZCwKICAgICBlbHNlIHsKICAgICAgICAgb3V0T2ZGbG93SXRlbUxpbmUuc2V0KCZj aGlsZCwgc3RhcnRMaW5lKTsKICAgICAgICAgc3RhcnQgPSBwb3NpdGlvbnNbc3RhcnRMaW5lXTsK KyAgICAgICAgaWYgKGlzUm93QXhpcyAmJiAhc3R5bGUoKS5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9u KCkpIHsKKyAgICAgICAgICAgIHN0YXJ0IC09IGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsTGVmdCgp OworICAgICAgICAgICAgc3RhcnQgKz0gYm9yZGVyTG9naWNhbFJpZ2h0KCkgKyBwYWRkaW5nTG9n aWNhbFJpZ2h0KCk7CisgICAgICAgIH0KICAgICB9CiAgICAgaWYgKGVuZElzQXV0bykKICAgICAg ICAgZW5kID0gcmVzb2x2ZUF1dG9FbmRHcmlkUG9zaXRpb24oZGlyZWN0aW9uKSArIGJvcmRlckVk Z2U7CkBAIC0xNjUzLDYgKzE2NTcsMTEgQEAgTGF5b3V0VW5pdCBSZW5kZXJHcmlkOjpncmlkQXJl YUJyZWFkdGhGb3JPdXRPZkZsb3dDaGlsZChjb25zdCBSZW5kZXJCb3gmIGNoaWxkLAogICAgICAg ICAgICAgZW5kIC09IGd1dHRlcnNTaXplKG1fZ3JpZCwgZGlyZWN0aW9uLCBlbmRMaW5lIC0gMSwg MiwgYXZhaWxhYmxlU2l6ZUZvckd1dHRlcnMpOwogICAgICAgICAgICAgZW5kIC09IGlzUm93QXhp cyA/IG1fb2Zmc2V0QmV0d2VlbkNvbHVtbnMuZGlzdHJpYnV0aW9uT2Zmc2V0IDogbV9vZmZzZXRC ZXR3ZWVuUm93cy5kaXN0cmlidXRpb25PZmZzZXQ7CiAgICAgICAgIH0KKworICAgICAgICBpZiAo aXNSb3dBeGlzICYmICFzdHlsZSgpLmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSkgeworICAgICAg ICAgICAgZW5kIC09IGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsTGVmdCgpOworICAgICAgICAgICAg ZW5kICs9IGJvcmRlckxvZ2ljYWxSaWdodCgpICsgcGFkZGluZ0xvZ2ljYWxSaWdodCgpOworICAg ICAgICB9CiAgICAgfQogICAgIHJldHVybiBzdGQ6Om1heChlbmQgLSBzdGFydCwgMF9sdSk7CiB9 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA0Njg4MDRmMzQ1ODA2ZTRmMWNhYWMx Yzk1ZjdiZTk1YzNmNDRmMGRkLi4wYzc4NjMzNDNkZjcyZWIxNmJlYTA3MTk3ZDg0YTJhZWM2MDRj Y2I5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAy Mi0wMi0xNCAgTWF0dCBXb29kcm93ICA8bWF0dHdvb2Ryb3dAYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBhYnMtcG9zIGJyZWFkdGggaXNzdWUgd2hlbiB1c2luZyAnYXV0bycKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjYyNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgbmV3IHRlc3QgdGhhdCB1 c2VzIFJUTCBhbmQgYWJzLXBvcyBpdGVtcyBvdmVyIHRoZSBwYWRkaW5nIGFyZWEsIHdpdGgKKyAg ICAgICAgcGFkZGluZyBkZWZpbmVkIGluIHBoeXNpY2FsIGNvb3Jkcy4KKworICAgICAgICAqIHdl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvYWJzcG9zL3Bvc2l0aW9uZWQtZ3JpZC1pdGVt cy0wMjUtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3Rz L2Nzcy9jc3MtZ3JpZC9hYnNwb3MvcG9zaXRpb25lZC1ncmlkLWl0ZW1zLTAyNS5odG1sOiBBZGRl ZC4KKwogMjAyMi0wMi0wOSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBEaWFsb2cgZWxlbWVudCBvbmx5IGFuaW1hdGVzIG9uY2UKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2Fi c3Bvcy9wb3NpdGlvbmVkLWdyaWQtaXRlbXMtMDI1LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hYnNwb3MvcG9z aXRpb25lZC1ncmlkLWl0ZW1zLTAyNS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjgwMzUzOWEw NjljMjFmMzk3OTgyMTk4NDE4ODE4NzQxMjAwMmM4YTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hYnNw b3MvcG9zaXRpb25lZC1ncmlkLWl0ZW1zLTAyNS1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMTAg QEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0iYXV0aG9yIiB0 aXRsZT0iTWF0dCBXb29kcm93IiBocmVmPSJtd29vZHJvd0BhcHBsZS5jb20iPgorPC9oZWFkPgor PGJvZHk+CisgICAgPGRpdiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjpibHVlOyBoZWlnaHQ6IDEw MHB4OyB3aWR0aDogNTBweDtkaXNwbGF5OiBpbmxpbmUtYmxvY2s7Ij48L2Rpdj4KKyAgICA8ZGl2 IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOmJsdWU7IGhlaWdodDogMTAwcHg7IHdpZHRoOiA4MHB4 O3Bvc2l0aW9uOiByZWxhdGl2ZTtkaXNwbGF5OiBpbmxpbmUtYmxvY2s7bGVmdDogMTQ2cHg7Ij48 L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2Fic3Bvcy9wb3NpdGlvbmVkLWdy aWQtaXRlbXMtMDI1Lmh0bWwgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3MtZ3JpZC9hYnNwb3MvcG9zaXRpb25lZC1ncmlkLWl0ZW1zLTAyNS5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmU3NWUyOWEyMDUxZTQ5M2JlYjE4ODkwZGNjYjE4NWQ3ODk2ZTY4YjgKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3MtZ3JpZC9hYnNwb3MvcG9zaXRpb25lZC1ncmlkLWl0ZW1zLTAyNS5odG1sCkBA IC0wLDAgKzEsMzQgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5D U1MgR3JpZCBMYXlvdXQgVGVzdDogUG9zaXRpb25lZCBncmlkIGl0ZW1zPC90aXRsZT4KKzxsaW5r IHJlbD0iaGVscCIgaHJlZj0iaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy1ncmlkLTIvI2Fi c3BvcyI+Cis8bGluayByZWw9Im1hdGNoIiBocmVmPSJwb3NpdGlvbmVkLWdyaWQtaXRlbXMtMDI1 LWV4cGVjdGVkLmh0bWwiPgorPG1ldGEgbmFtZT0iYXNzZXJ0IiBjb250ZW50PSJDaGVja3MgdGhh dCBhYnNvbHV0ZWx5IHBvc2l0aW9uZWQgaXRlbXMgYXJlIHByb3Blcmx5IHBsYWNlZCBhbmQgc2l6 ZWQuIj4KKzxzdHlsZT4KKyAgI2dyaWQgeworICAgIGRpc3BsYXk6IGdyaWQ7CisgICAgZ3JpZC10 ZW1wbGF0ZS1jb2x1bW5zOiA1MHB4IDEwMHB4OworICAgIGhlaWdodDogMTAwcHg7CisgICAgd2lk dGg6IDE1MHB4OworICAgIGRpcmVjdGlvbjogcnRsOworICAgIHBhZGRpbmctbGVmdDogNTBweDsK KyAgICBwYWRkaW5nLXJpZ2h0OiA4MHB4OworICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgfQor CisgICNncmlkID4gZGl2IHsKKyAgICB0b3A6IDBweDsKKyAgICByaWdodDogMHB4OworICAgIGJv dHRvbTogMHB4OworICAgIGxlZnQ6IDBweDsKKyAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAg YmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKKyAgfQorPC9zdHlsZT4KKworPC9oZWFkPjxib2R5Pjxk aXYgaWQ9ImdyaWQiPgorICA8ZGl2IHN0eWxlPSJncmlkLWNvbHVtbjogYXV0byAvIDE7Ij48L2Rp dj4KKyAgPGRpdiBzdHlsZT0iZ3JpZC1jb2x1bW46IC0xIC8gYXV0bzsiPjwvZGl2PgorPC9kaXY+ Cis8L2JvZHk+PC9odG1sPgo=