<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>23661</bug_id>
          
          <creation_ts>2009-01-30 23:38:23 -0800</creation_ts>
          <short_desc>Fix the Chromium Win build</short_desc>
          <delta_ts>2009-02-02 20:24:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dmitry Titov">dimich</reporter>
          <assigned_to name="Dmitry Titov">dimich</assigned_to>
          <cc>eric</cc>
    
    <cc>fishd</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>107823</commentid>
    <comment_count>0</comment_count>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2009-01-30 23:38:23 -0800</bug_when>
    <thetext>This fixes the Chromium build after merge with r40409 of WebKit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107824</commentid>
    <comment_count>1</comment_count>
      <attachid>27212</attachid>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2009-01-30 23:46:12 -0800</bug_when>
    <thetext>Created attachment 27212
Proposed patch

Reflects changes in Chromium that had to be made to accomidate Apple plans.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107840</commentid>
    <comment_count>2</comment_count>
      <attachid>27212</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-01-31 07:29:08 -0800</bug_when>
    <thetext>Comment on attachment 27212
Proposed patch

I don&apos;t understand the &quot;Apple plans&quot; comment here. Torch Mobile is doing a major refactoring of form elements to make WML work, but this is not sponsored by Apple.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107842</commentid>
    <comment_count>3</comment_count>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2009-01-31 08:11:57 -0800</bug_when>
    <thetext>Sorry about that, I don&apos;t know myself what I was thinking here :-( long day. Meant to say &quot;to fix the the Chromium build after recent changes in WebKit&quot;. I was doing the merge of WebKit sources into Chromium tree yesterday and since we don&apos;t yet have Chromium buildbot in WebKit, there are often build breaks so we fix them and then post fixed files back into WebKit to avoid &apos;forked&apos; state. 
I guess I was too sleepy typing the comment, please ignore it. :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107845</commentid>
    <comment_count>4</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-01-31 08:41:25 -0800</bug_when>
    <thetext>Need a log entry?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107847</commentid>
    <comment_count>5</comment_count>
      <attachid>27218</attachid>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2009-01-31 08:58:25 -0800</bug_when>
    <thetext>Created attachment 27218
Added ChangeLog entry</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107848</commentid>
    <comment_count>6</comment_count>
      <attachid>27218</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-01-31 09:07:31 -0800</bug_when>
    <thetext>Comment on attachment 27218
Added ChangeLog entry

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>108076</commentid>
    <comment_count>7</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-02 20:24:46 -0800</bug_when>
    <thetext>Landed as http://trac.webkit.org/changeset/40517</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27212</attachid>
            <date>2009-01-30 23:46:12 -0800</date>
            <delta_ts>2009-01-31 08:58:25 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>upstr.txt</filename>
            <type>text/plain</type>
            <size>1227</size>
            <attacher name="Dmitry Titov">dimich</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaGlzdG9yeS9IaXN0b3J5SXRlbS5oIGIvV2ViQ29yZS9oaXN0
b3J5L0hpc3RvcnlJdGVtLmgKaW5kZXggYzg3YzAyMS4uM2U4OTEwMiAxMDA2NDQKLS0tIGEvV2Vi
Q29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmgKKysrIGIvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJ
dGVtLmgKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgIkludFBvaW50LmgiCiAjaW5jbHVk
ZSAiUGxhdGZvcm1TdHJpbmcuaCIKKyNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAKICNpZiBQTEFU
Rk9STShNQUMpCiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CmRpZmYgLS1naXQgYS9XZWJDb3Jl
L3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tIGIvV2ViQ29yZS9yZW5kZXJpbmcv
UmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5tbQppbmRleCAxN2MxZTFkLi4zYmI3ZDg3IDEwMDY0NAot
LS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tCisrKyBiL1dl
YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0KQEAgLTEzMTYsNyArMTMx
NiwxMSBAQCB2b2lkIFJlbmRlclRoZW1lQ2hyb21pdW1NYWM6OmFkanVzdE1lbnVMaXN0U3R5bGUo
Q1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3IsIFJlbgogCiAgICAgLy8gU2V0IHRoZSBmb3JlZ3Jv
dW5kIGNvbG9yIHRvIGJsYWNrIG9yIGdyYXkgd2hlbiB3ZSBoYXZlIHRoZSBhcXVhIGxvb2suCiAg
ICAgLy8gQ2FzdCB0byBSR0IzMiBpcyB0byB3b3JrIGFyb3VuZCBhIGNvbXBpbGVyIGJ1Zy4KLSAg
ICBzdHlsZS0+c2V0Q29sb3IoZS0+aXNFbmFibGVkKCkgPyBzdGF0aWNfY2FzdDxSR0JBMzI+KENv
bG9yOjpibGFjaykgOiBDb2xvcjo6ZGFya0dyYXkpOworICAgIGJvb2wgaXNFbmFibGVkID0gdHJ1
ZTsKKyAgICBpZiAoRm9ybUNvbnRyb2xFbGVtZW50KiBmb3JtQ29udHJvbEVsZW1lbnQgPSB0b0Zv
cm1Db250cm9sRWxlbWVudChlKSkKKyAgICAgICAgaXNFbmFibGVkID0gZm9ybUNvbnRyb2xFbGVt
ZW50LT5pc0VuYWJsZWQoKTsKKworICAgIHN0eWxlLT5zZXRDb2xvcihpc0VuYWJsZWQgPyBzdGF0
aWNfY2FzdDxSR0JBMzI+KENvbG9yOjpibGFjaykgOiBDb2xvcjo6ZGFya0dyYXkpOwogCiAgICAg
Ly8gU2V0IHRoZSBidXR0b24ncyB2ZXJ0aWNhbCBzaXplLgogICAgIHNldFNpemVGcm9tRm9udChz
dHlsZSwgbWVudUxpc3RCdXR0b25TaXplcygpKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27218</attachid>
            <date>2009-01-31 08:58:25 -0800</date>
            <delta_ts>2009-01-31 09:07:31 -0800</delta_ts>
            <desc>Added ChangeLog entry</desc>
            <filename>upstr_v2.txt</filename>
            <type>text/plain</type>
            <size>1859</size>
            <attacher name="Dmitry Titov">dimich</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MmQ0NGQyMy4uMWRkNjEwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMS0zMCAgRG1pdHJ5IFRpdG92
ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MjM2NjEKKyAgICAgICAgRml4IENocm9taXVtIGJ1aWxkLgorCisgICAgICAgICogaGlzdG9yeS9I
aXN0b3J5SXRlbS5oOiBuZWVkIHRvIGluY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKworICAgICAgICAq
IHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6
UmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6YWRqdXN0TWVudUxpc3RTdHlsZSk6IGlzRW5hYmxlZCgp
IGlzIG5vdyBvbiBGb3JtQ29udHJvbEVsZW1lbnQuCisKIDIwMDktMDEtMzAgIFNpbW9uIEZyYXNl
ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBI
eWF0dApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmggYi9XZWJDb3Jl
L2hpc3RvcnkvSGlzdG9yeUl0ZW0uaAppbmRleCBjODdjMDIxLi4zZTg5MTAyIDEwMDY0NAotLS0g
YS9XZWJDb3JlL2hpc3RvcnkvSGlzdG9yeUl0ZW0uaAorKysgYi9XZWJDb3JlL2hpc3RvcnkvSGlz
dG9yeUl0ZW0uaApAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSAiSW50UG9pbnQuaCIKICNp
bmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgorI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KIAogI2lm
IFBMQVRGT1JNKE1BQykKICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KZGlmZiAtLWdpdCBhL1dl
YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0gYi9XZWJDb3JlL3JlbmRl
cmluZy9SZW5kZXJUaGVtZUNocm9taXVtTWFjLm1tCmluZGV4IDE3YzFlMWQuLjNiYjdkODcgMTAw
NjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1NYWMubW0KKysr
IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bU1hYy5tbQpAQCAtMTMxNiw3
ICsxMzE2LDExIEBAIHZvaWQgUmVuZGVyVGhlbWVDaHJvbWl1bU1hYzo6YWRqdXN0TWVudUxpc3RT
dHlsZShDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3RvciwgUmVuCiAKICAgICAvLyBTZXQgdGhlIGZv
cmVncm91bmQgY29sb3IgdG8gYmxhY2sgb3IgZ3JheSB3aGVuIHdlIGhhdmUgdGhlIGFxdWEgbG9v
ay4KICAgICAvLyBDYXN0IHRvIFJHQjMyIGlzIHRvIHdvcmsgYXJvdW5kIGEgY29tcGlsZXIgYnVn
LgotICAgIHN0eWxlLT5zZXRDb2xvcihlLT5pc0VuYWJsZWQoKSA/IHN0YXRpY19jYXN0PFJHQkEz
Mj4oQ29sb3I6OmJsYWNrKSA6IENvbG9yOjpkYXJrR3JheSk7CisgICAgYm9vbCBpc0VuYWJsZWQg
PSB0cnVlOworICAgIGlmIChGb3JtQ29udHJvbEVsZW1lbnQqIGZvcm1Db250cm9sRWxlbWVudCA9
IHRvRm9ybUNvbnRyb2xFbGVtZW50KGUpKQorICAgICAgICBpc0VuYWJsZWQgPSBmb3JtQ29udHJv
bEVsZW1lbnQtPmlzRW5hYmxlZCgpOworCisgICAgc3R5bGUtPnNldENvbG9yKGlzRW5hYmxlZCA/
IHN0YXRpY19jYXN0PFJHQkEzMj4oQ29sb3I6OmJsYWNrKSA6IENvbG9yOjpkYXJrR3JheSk7CiAK
ICAgICAvLyBTZXQgdGhlIGJ1dHRvbidzIHZlcnRpY2FsIHNpemUuCiAgICAgc2V0U2l6ZUZyb21G
b250KHN0eWxlLCBtZW51TGlzdEJ1dHRvblNpemVzKCkpOwo=
</data>
<flag name="review"
          id="13103"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>