236607 2022-02-14 13:14:42 -0800 [GTK][WPE] Use drm render nodes in GbmDevice and make the fd global to the process 2022-03-09 04:25:57 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 237649 1 alex alex clord dino kbr kkinnunen webkit-bug-importer zan zdobersek oldest_to_newest 1841384 0 alex 2022-02-14 13:14:42 -0800 We just need to use render nodes from the library, we do not need the other apis of the primary device file. 1841388 1 451937 alex 2022-02-14 13:22:02 -0800 Created attachment 451937 Patch 1841585 2 451937 zan 2022-02-14 23:23:38 -0800 Comment on attachment 451937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451937&action=review > Source/WebCore/platform/graphics/gbm/GBMDevice.cpp:61 > + if (globalFd == -1) > + getDeviceFd(); This is now open to cross-thread race conditions. > Source/WebCore/platform/graphics/gbm/GBMDevice.cpp:75 > -int GBMDevice::getDeviceFd() > +void GBMDevice::getDeviceFd() This should be moved out into a standalone static function that internally uses std::call_once() to protect against separate threads racing to open the render node. 1841587 3 451937 zan 2022-02-14 23:32:49 -0800 Comment on attachment 451937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451937&action=review > Source/WebCore/platform/graphics/gbm/GBMDevice.cpp:81 > if (numDevices <=0) Poor spacing. > Source/WebCore/platform/graphics/gbm/GBMDevice.cpp:89 > + globalFd = open(device->nodes[DRM_NODE_RENDER], O_RDWR); O_CLOEXEC should also be used. 1841601 4 alex 2022-02-15 00:31:56 -0800 (In reply to Zan Dobersek from comment #2) > Comment on attachment 451937 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451937&action=review > > > Source/WebCore/platform/graphics/gbm/GBMDevice.cpp:61 > > + if (globalFd == -1) > > + getDeviceFd(); > > This is now open to cross-thread race conditions. > Good point, we need to protect the first access. > > Source/WebCore/platform/graphics/gbm/GBMDevice.cpp:75 > > -int GBMDevice::getDeviceFd() > > +void GBMDevice::getDeviceFd() > > This should be moved out into a standalone static function that internally > uses std::call_once() to protect against separate threads racing to open the > render node. Thanks for the comments! I'll update the patch. 1841829 5 452063 alex 2022-02-15 11:21:49 -0800 Created attachment 452063 Patch 1842129 6 452063 zdobersek 2022-02-15 21:57:55 -0800 Comment on attachment 452063 Patch Great, thanks. 1842208 7 ews-feeder 2022-02-16 02:57:13 -0800 Committed r289885 (247323@main): <https://commits.webkit.org/247323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452063. 1842209 8 webkit-bug-importer 2022-02-16 02:58:15 -0800 <rdar://problem/89016322> 451937 2022-02-14 13:22:02 -0800 2022-02-15 11:21:45 -0800 Patch bug-236607-20220214222201.patch text/plain 3443 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhlNzY1MzFlZjkzZWIw YzlmMWIxNmM1MzUwOTlkMWUwNzUxNjU4Zi4uZGZhZjViZTk0ZjExM2Q5MTE0MjZmMjYyN2Q1Njg4 YTczZGQ1ZDY4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAyLTE0ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0g VXNlIGRybSByZW5kZXIgbm9kZXMgaW4gR2JtRGV2aWNlIGFuZCBtYWtlIHRoZSBmZCBnbG9iYWwg dG8gdGhlIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNjYwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIGFyZSBjcmVhdGluZyBhIGdsb2JhbCBzdGF0aWMgdmFyaWFibGUgdG8gaGFuZGxl IHRoZSBmZCBvZiB0aGUKKyAgICAgICAgZGV2aWNlIGluIHRoZSBwcm9jZXNzLCB0byBtYWtlIHN1 cmUgd2Ugc2VhcmNoIGFuZCBvcGVuIG9uY2UgZm9yCisgICAgICAgIHRoZSBncmFwaGljcyBkZXZp Y2UuIEFsc28gd2UgYXJlIHVzaW5nIHRoZSBEUk1fTk9ERV9SRU5ERVIgYmVjYXVzZQorICAgICAg ICB3ZSBkbyBub3QgbmVlZCB0aGUgcHJpbWFyeSBkZXZpY2UgZm9yIHRoZSBvcGVyYXRpb25zIHdl IGV4cGVjdCB0bworICAgICAgICB1c2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5 IGNvdmVyZWQgaW4gdGhlIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ2Jt L0dCTURldmljZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHQk1EZXZpY2U6OkdCTURldmljZSk6 IFVzZSBhIG5ldyBnbG9iYWwgZmQuCisgICAgICAgIChXZWJDb3JlOjpHQk1EZXZpY2U6OmdldERl dmljZUZkKTogV2UgZG8gbm90IHJldHVybiB0aGUgZmlsZSBkZXNjcmlwdG9yLgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2dibS9HQk1EZXZpY2UuaDogRGl0dG8uCisKIDIwMjItMDItMTQg IEZyw6lkw6lyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgTnVsbHB0ciBj cmFzaCBpbiBDb21wb3NpdGVFZGl0Q29tbWFuZDo6c3BsaXRUcmVlVG9Ob2RlIHZpYSBJbnNlcnRQ YXJhZ3JhcGhTZXBhcmF0b3JDb21tYW5kOjpkb0FwcGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nYm0vR0JNRGV2aWNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dibS9HQk1EZXZpY2UuY3BwCmluZGV4IGQzZjZjMzFlMzBjNTU5 Yjk3ZTYzOWZlNDhjNzNhOTk2N2MzZWJjNTYuLjY2YWEwM2VkNzFmODZkMGFiOWFhOWVlOTUzODU2 ZjQ5YjVkZmNjOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dibS9HQk1EZXZpY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dibS9HQk1EZXZpY2UuY3BwCkBAIC01MywxMSArNTMsMTUgQEAgY29uc3QgR0JNRGV2aWNlJiBH Qk1EZXZpY2U6OmdldCgpCiAgICAgcmV0dXJuICp0aHJlYWRTcGVjaWZpY0RldmljZSgpOwogfQog CitzdGF0aWMgaW50IGdsb2JhbEZkIHsgLTEgfTsKKwogR0JNRGV2aWNlOjpHQk1EZXZpY2UoKQog ewotICAgIGludCBmZCA9IGdldERldmljZUZkKCk7Ci0gICAgaWYgKGZkID49IDApCi0gICAgICAg IG1fZGV2aWNlID0gZ2JtX2NyZWF0ZV9kZXZpY2UoZmQpOworICAgIGlmIChnbG9iYWxGZCA9PSAt MSkKKyAgICAgICAgZ2V0RGV2aWNlRmQoKTsKKworICAgIGlmIChnbG9iYWxGZCA+PSAwKQorICAg ICAgICBtX2RldmljZSA9IGdibV9jcmVhdGVfZGV2aWNlKGdsb2JhbEZkKTsKIH0KIAogR0JNRGV2 aWNlOjp+R0JNRGV2aWNlKCkKQEAgLTY4LDI3ICs3MiwyNiBAQCBHQk1EZXZpY2U6On5HQk1EZXZp Y2UoKQogICAgIH0KIH0KIAotaW50IEdCTURldmljZTo6Z2V0RGV2aWNlRmQoKQordm9pZCBHQk1E ZXZpY2U6OmdldERldmljZUZkKCkKIHsKICAgICBkcm1EZXZpY2VQdHIgZGV2aWNlc1s2NF07CiAg ICAgbWVtc2V0KGRldmljZXMsIDAsIHNpemVvZihkZXZpY2VzKSk7CiAKICAgICBpbnQgbnVtRGV2 aWNlcyA9IGRybUdldERldmljZXMyKDAsIGRldmljZXMsIFdURl9BUlJBWV9MRU5HVEgoZGV2aWNl cykpOwogICAgIGlmIChudW1EZXZpY2VzIDw9MCkKLSAgICAgICAgcmV0dXJuIC0xOworICAgICAg ICByZXR1cm47CiAKLSAgICBpbnQgZmQgPSAtMTsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG51 bURldmljZXM7ICsraSkgewogICAgICAgICBkcm1EZXZpY2UqIGRldmljZSA9IGRldmljZXNbaV07 Ci0gICAgICAgIGlmICghKGRldmljZS0+YXZhaWxhYmxlX25vZGVzICYgKDEgPDwgRFJNX05PREVf UFJJTUFSWSkpKQorICAgICAgICBpZiAoIShkZXZpY2UtPmF2YWlsYWJsZV9ub2RlcyAmICgxIDw8 IERSTV9OT0RFX1JFTkRFUikpKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgZmQg PSBvcGVuKGRldmljZS0+bm9kZXNbRFJNX05PREVfUFJJTUFSWV0sIE9fUkRXUik7Ci0gICAgICAg IGlmIChmZCA8IDApCi0gICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgZ2xvYmFsRmQgPSBv cGVuKGRldmljZS0+bm9kZXNbRFJNX05PREVfUkVOREVSXSwgT19SRFdSKTsKKyAgICAgICAgaWYg KGdsb2JhbEZkID49IDApCisgICAgICAgICAgICBicmVhazsKICAgICB9CiAKLSAgICByZXR1cm4g ZmQ7CisgICAgZHJtRnJlZURldmljZXMoZGV2aWNlcywgbnVtRGV2aWNlcyk7CiB9CiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dibS9HQk1EZXZpY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dibS9HQk1EZXZpY2UuaAppbmRleCA1Y2U1MmZlYTc2ODI1ZDNjN2EwNGIzZmIzMjM4M2RmNWNj NTRlYWU2Li41ZjVmYjY5YTc3OTc3ODJmNDRiN2M0OTJmNzIzZmRiODlkNDRmZDExIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nYm0vR0JNRGV2aWNlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2JtL0dCTURldmljZS5oCkBAIC00 NCw3ICs0NCw3IEBAIHB1YmxpYzoKICAgICBzdHJ1Y3QgZ2JtX2RldmljZSogZGV2aWNlKCkgY29u c3QgeyByZXR1cm4gbV9kZXZpY2U7IH0KIAogcHJpdmF0ZToKLSAgICBpbnQgZ2V0RGV2aWNlRmQo KTsKKyAgICB2b2lkIGdldERldmljZUZkKCk7CiAKICAgICBzdHJ1Y3QgZ2JtX2RldmljZSogbV9k ZXZpY2UgeyBudWxscHRyIH07CiB9Owo= 452063 2022-02-15 11:21:49 -0800 2022-02-16 02:57:15 -0800 Patch bug-236607-20220215202148.patch text/plain 3720 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhlNzY1MzFlZjkzZWIw YzlmMWIxNmM1MzUwOTlkMWUwNzUxNjU4Zi4uODRiNTViYjQ0MTQ2Y2ZhZjA0ZGRmNjc5NDg3ZjE2 YmNlMDQyMzNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIyLTAyLTE1ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0g VXNlIGRybSByZW5kZXIgbm9kZXMgaW4gR2JtRGV2aWNlIGFuZCBtYWtlIHRoZSBmZCBnbG9iYWwg dG8gdGhlIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNjYwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIGFyZSBjcmVhdGluZyBhIGdsb2JhbCBzdGF0aWMgdmFyaWFibGUgdG8gaGFuZGxl IHRoZSBmZCBvZiB0aGUKKyAgICAgICAgZGV2aWNlIGluIHRoZSBwcm9jZXNzLCB0byBtYWtlIHN1 cmUgd2Ugc2VhcmNoIGFuZCBvcGVuIG9uY2UgZm9yCisgICAgICAgIHRoZSBncmFwaGljcyBkZXZp Y2UuIEFsc28gd2UgYXJlIHVzaW5nIHRoZSBEUk1fTk9ERV9SRU5ERVIgYmVjYXVzZQorICAgICAg ICB3ZSBkbyBub3QgbmVlZCB0aGUgcHJpbWFyeSBkZXZpY2UgZm9yIHRoZSBvcGVyYXRpb25zIHdl IGV4cGVjdCB0bworICAgICAgICB1c2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5 IGNvdmVyZWQgaW4gdGhlIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ2Jt L0dCTURldmljZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHQk1EZXZpY2U6OkdCTURldmljZSk6 IFVzZSBhIG5ldyBnbG9iYWwgZmQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ2JtL0dC TURldmljZS5oOiBEaXR0by4KKwogMjAyMi0wMi0xNCAgRnLDqWTDqXJpYyBXYW5nICA8ZndhbmdA aWdhbGlhLmNvbT4KIAogICAgICAgICBOdWxscHRyIGNyYXNoIGluIENvbXBvc2l0ZUVkaXRDb21t YW5kOjpzcGxpdFRyZWVUb05vZGUgdmlhIEluc2VydFBhcmFncmFwaFNlcGFyYXRvckNvbW1hbmQ6 OmRvQXBwbHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2di bS9HQk1EZXZpY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2JtL0dC TURldmljZS5jcHAKaW5kZXggZDNmNmMzMWUzMGM1NTliOTdlNjM5ZmU0OGM3M2E5OTY3YzNlYmM1 Ni4uNTU5ZGJhMjQwZWYyYzM1ZDEzYWU4NmRjMDNmMjY4MjEyNTJiNjNkMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2JtL0dCTURldmljZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2JtL0dCTURldmljZS5jcHAKQEAgLTU1 LDkgKzU1LDMxIEBAIGNvbnN0IEdCTURldmljZSYgR0JNRGV2aWNlOjpnZXQoKQogCiBHQk1EZXZp Y2U6OkdCTURldmljZSgpCiB7Ci0gICAgaW50IGZkID0gZ2V0RGV2aWNlRmQoKTsKLSAgICBpZiAo ZmQgPj0gMCkKLSAgICAgICAgbV9kZXZpY2UgPSBnYm1fY3JlYXRlX2RldmljZShmZCk7CisgICAg c3RhdGljIGludCBzX2dsb2JhbEZkIHsgLTEgfTsKKyAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcg c19vbmNlRmxhZzsKKyAgICBzdGQ6OmNhbGxfb25jZShzX29uY2VGbGFnLCBbXSB7CisgICAgICAg IGRybURldmljZVB0ciBkZXZpY2VzWzY0XTsKKyAgICAgICAgbWVtc2V0KGRldmljZXMsIDAsIHNp emVvZihkZXZpY2VzKSk7CisKKyAgICAgICAgaW50IG51bURldmljZXMgPSBkcm1HZXREZXZpY2Vz MigwLCBkZXZpY2VzLCBXVEZfQVJSQVlfTEVOR1RIKGRldmljZXMpKTsKKyAgICAgICAgaWYgKG51 bURldmljZXMgPD0gMCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBmb3IgKGludCBp ID0gMDsgaSA8IG51bURldmljZXM7ICsraSkgeworICAgICAgICAgICAgZHJtRGV2aWNlKiBkZXZp Y2UgPSBkZXZpY2VzW2ldOworICAgICAgICAgICAgaWYgKCEoZGV2aWNlLT5hdmFpbGFibGVfbm9k ZXMgJiAoMSA8PCBEUk1fTk9ERV9SRU5ERVIpKSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsK KworICAgICAgICAgICAgc19nbG9iYWxGZCA9IG9wZW4oZGV2aWNlLT5ub2Rlc1tEUk1fTk9ERV9S RU5ERVJdLCBPX1JEV1IgfCBPX0NMT0VYRUMpOworICAgICAgICAgICAgaWYgKHNfZ2xvYmFsRmQg Pj0gMCkKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorCisgICAgICAgIGRybUZy ZWVEZXZpY2VzKGRldmljZXMsIG51bURldmljZXMpOworICAgIH0pOworCisgICAgaWYgKHNfZ2xv YmFsRmQgPj0gMCkKKyAgICAgICAgbV9kZXZpY2UgPSBnYm1fY3JlYXRlX2RldmljZShzX2dsb2Jh bEZkKTsKIH0KIAogR0JNRGV2aWNlOjp+R0JNRGV2aWNlKCkKQEAgLTY4LDI5ICs5MCw2IEBAIEdC TURldmljZTo6fkdCTURldmljZSgpCiAgICAgfQogfQogCi1pbnQgR0JNRGV2aWNlOjpnZXREZXZp Y2VGZCgpCi17Ci0gICAgZHJtRGV2aWNlUHRyIGRldmljZXNbNjRdOwotICAgIG1lbXNldChkZXZp Y2VzLCAwLCBzaXplb2YoZGV2aWNlcykpOwotCi0gICAgaW50IG51bURldmljZXMgPSBkcm1HZXRE ZXZpY2VzMigwLCBkZXZpY2VzLCBXVEZfQVJSQVlfTEVOR1RIKGRldmljZXMpKTsKLSAgICBpZiAo bnVtRGV2aWNlcyA8PTApCi0gICAgICAgIHJldHVybiAtMTsKLQotICAgIGludCBmZCA9IC0xOwot ICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtRGV2aWNlczsgKytpKSB7Ci0gICAgICAgIGRybURl dmljZSogZGV2aWNlID0gZGV2aWNlc1tpXTsKLSAgICAgICAgaWYgKCEoZGV2aWNlLT5hdmFpbGFi bGVfbm9kZXMgJiAoMSA8PCBEUk1fTk9ERV9QUklNQVJZKSkpCi0gICAgICAgICAgICBjb250aW51 ZTsKLQotICAgICAgICBmZCA9IG9wZW4oZGV2aWNlLT5ub2Rlc1tEUk1fTk9ERV9QUklNQVJZXSwg T19SRFdSKTsKLSAgICAgICAgaWYgKGZkIDwgMCkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAg IH0KLQotICAgIHJldHVybiBmZDsKLX0KLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5k aWYgLy8gVVNFKEFOR0xFKSAmJiBVU0UoTklDT1NJQSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dibS9HQk1EZXZpY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dibS9HQk1EZXZpY2UuaAppbmRleCA1Y2U1MmZlYTc2ODI1ZDNjN2Ew NGIzZmIzMjM4M2RmNWNjNTRlYWU2Li4yNTBlMDdmYzlkN2Q2MTZjODRjMWFjYzc4NjQ5N2ViZTk0 OWQ5NzZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nYm0v R0JNRGV2aWNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2JtL0dC TURldmljZS5oCkBAIC00NCw4ICs0NCw2IEBAIHB1YmxpYzoKICAgICBzdHJ1Y3QgZ2JtX2Rldmlj ZSogZGV2aWNlKCkgY29uc3QgeyByZXR1cm4gbV9kZXZpY2U7IH0KIAogcHJpdmF0ZToKLSAgICBp bnQgZ2V0RGV2aWNlRmQoKTsKLQogICAgIHN0cnVjdCBnYm1fZGV2aWNlKiBtX2RldmljZSB7IG51 bGxwdHIgfTsKIH07CiAK