236605 2022-02-14 12:59:53 -0800 [CMake] Remove uses of add_definitions in JavaScriptCore build 2022-02-14 16:10:31 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead annulen ews-watchlist gyuyoung.kim keith_miller mark.lam mcatanzaro msaboff ryuan.choi saam sergio tzagallo oldest_to_newest 1841369 0 don.olmstead 2022-02-14 12:59:53 -0800 Use modern CMake way of setting definitions. 1841387 1 451936 don.olmstead 2022-02-14 13:19:16 -0800 Created attachment 451936 Patch 1841467 2 ews-feeder 2022-02-14 16:10:23 -0800 Committed r289779 (247247@main): <https://commits.webkit.org/247247@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451936. 451936 2022-02-14 13:19:16 -0800 2022-02-14 16:10:28 -0800 Patch bug-236605.diff text/plain 2697 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDc1YzE1NWUyZTRkNy4uNDkwZDA1OTA0NmJkIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAyMi0wMi0xNCAgRG9u IE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0gUmVt b3ZlIHVzZXMgb2YgYWRkX2RlZmluaXRpb25zIGluIEphdmFTY3JpcHRDb3JlIGJ1aWxkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY2MDUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGFyZ2V0IHNw ZWNpZmljIGRlZmluaXRpb25zIHdoZW4gYnVpbGRpbmcgSmF2YVNjcmlwdENvcmUuIEluIHRoZSBj dXJyZW50IGNhc2VzIHRoZQorICAgICAgICBkZWZpbml0aW9ucyBkb24ndCBuZWVkIHRvIHByb3Bh Z2F0ZSB0byB0YXJnZXRzIHVzaW5nIEphdmFTY3JpcHRDb3JlIHNvCisgICAgICAgIEphdmFTY3Jp cHRDb3JlX1BSSVZBVEVfREVGSU5JVElPTlMgaXMgdXNlZC4KKworICAgICAgICAqIFBsYXRmb3Jt R1RLLmNtYWtlOgorICAgICAgICAqIFBsYXRmb3JtUGxheVN0YXRpb24uY21ha2U6CisgICAgICAg ICogUGxhdGZvcm1XUEUuY21ha2U6CisKIDIwMjItMDItMTQgIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIENhbGxMaW5rSW5mbzo6ZW1pdEZhc3RQYXRoSW1w bCgpIHNob3VsZCBhdm9pZCBleHRlcm5hbCBzY3JhdGNoIHJlZ2lzdGVyIHVzZSBvbiBSSVNDVjY0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggZWY3ODNkYjkzNjY4 Li4zN2MzNDNkZTM0YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9y bUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UK QEAgLTM2LDcgKzM2LDcgQEAgaWYgKEVOQUJMRV9JTlRST1NQRUNUSU9OKQogICAgICkKIGVuZGlm ICgpCiAKLWFkZF9kZWZpbml0aW9ucygtREpTQ19DT01QSUxBVElPTikKK2xpc3QoQVBQRU5EIEph dmFTY3JpcHRDb3JlX1BSSVZBVEVfREVGSU5JVElPTlMgSlNDX0NPTVBJTEFUSU9OKQogCiBsaXN0 KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVMKICAgICAke0dMSUJfTElCUkFSSUVTfQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtUGxheVN0YXRpb24uY21h a2UgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1QbGF5U3RhdGlvbi5jbWFrZQppbmRl eCBiYzM4YWRjODhlMDkuLjQ3ZWIwMGU3Mzc3ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL1BsYXRmb3JtUGxheVN0YXRpb24uY21ha2UKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL1BsYXRmb3JtUGxheVN0YXRpb24uY21ha2UKQEAgLTQwLDQgKzQwLDYgQEAgbGlzdChBUFBF TkQgSmF2YVNjcmlwdENvcmVfREVGSU5JVElPTlMKICkKIAogIyBUaGlzIG92ZXJyaWRlcyB0aGUg ZGVmYXVsdCB4NjQgdmFsdWUgb2YgMUdCIGZvciB0aGUgbWVtb3J5IHBvb2wgc2l6ZQotYWRkX2Rl ZmluaXRpb25zKC1ERklYRURfRVhFQ1VUQUJMRV9NRU1PUllfUE9PTF9TSVpFX0lOX01CPTY0KQor bGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfUFJJVkFURV9ERUZJTklUSU9OUworICAgIEZJWEVE X0VYRUNVVEFCTEVfTUVNT1JZX1BPT0xfU0laRV9JTl9NQj02NAorKQpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IDBmOGMxNzhhN2NhNS4uZjhmNzM5YmNjYmQ2IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtV1BFLmNtYWtlCkBAIC0xMCwxMCArMTAsMTIg QEAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMK ICAgICAke0dMSUJfSU5DTFVERV9ESVJTfQogKQogCitsaXN0KEFQUEVORCBKYXZhU2NyaXB0Q29y ZV9QUklWQVRFX0RFRklOSVRJT05TCisgICAgSlNDX0NPTVBJTEFUSU9OCisgICAgUEtHTElCRElS PSIke0NNQUtFX0lOU1RBTExfRlVMTF9MSUJESVJ9L3dwZS13ZWJraXQtJHtXUEVfQVBJX1ZFUlNJ T059IgorKQorCiBpbnN0YWxsKEZJTEVTICR7SmF2YVNjcmlwdENvcmVfSU5TVEFMTEVEX0hFQURF UlN9CiAgICAgREVTVElOQVRJT04gIiR7Q01BS0VfSU5TVEFMTF9JTkNMVURFRElSfS93cGUtd2Vi a2l0LSR7V1BFX0FQSV9WRVJTSU9OfS9qc2MiCiAgICAgQ09NUE9ORU5UICJEZXZlbG9wbWVudCIK ICkKLQotYWRkX2RlZmluaXRpb25zKC1ESlNDX0NPTVBJTEFUSU9OKQotYWRkX2RlZmluaXRpb25z KC1EUEtHTElCRElSPSIke0NNQUtFX0lOU1RBTExfRlVMTF9MSUJESVJ9L3dwZS13ZWJraXQtJHtX UEVfQVBJX1ZFUlNJT059IikK