236595 2022-02-14 09:20:43 -0800 testapi should handle a missing testapiScripts directory cleaner 2022-02-21 09:21:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1841278 0 keith_miller 2022-02-14 09:20:43 -0800 testapi should handle a missing testapiScripts directory cleaner 1841280 1 451912 keith_miller 2022-02-14 09:21:33 -0800 Created attachment 451912 Patch 1841299 2 451912 ysuzuki 2022-02-14 09:56:22 -0800 Comment on attachment 451912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451912&action=review r=me > Source/JavaScriptCore/API/tests/testapi.mm:2839 > + if (![resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]) { > + NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); > + checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", false); > + return; > + } > + How about always showing NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); and doing, checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", [resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]); 1841318 3 451912 keith_miller 2022-02-14 10:39:01 -0800 Comment on attachment 451912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451912&action=review >> Source/JavaScriptCore/API/tests/testapi.mm:2839 >> + > > How about always showing > > NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); > > and doing, > > checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", [resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]); Ok, sounds good. 1841320 4 451912 keith_miller 2022-02-14 10:41:08 -0800 Comment on attachment 451912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451912&action=review >>> Source/JavaScriptCore/API/tests/testapi.mm:2839 >>> + >> >> How about always showing >> >> NSLog(@"File URL to testapiScripts: %@", resolvePathToScripts()); >> >> and doing, >> >> checkResult(@"File URL to `testapiScripts` isn't reachable is the directory in place?", [resolvePathToScripts() checkResourceIsReachableAndReturnError:nil]); > > Ok, sounds good. Do you think we should return after finding the file is missing or just continue in case the test doesn't rely on that directory? 1844233 5 webkit-bug-importer 2022-02-21 09:21:18 -0800 <rdar://problem/89239279> 451912 2022-02-14 09:21:33 -0800 2022-02-14 09:56:22 -0800 Patch bug-236595-20220214122132.patch text/plain 1572 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YjhiNGQyZGJkYzZiOWZlOWJhZTE1NjY0ODUwMGRkNDYyZjg4NDMyLi5mNDRiMmQ1MDAwMGJhYTBj NmVhNzVjNTZlZTExNWZhYjMzZWFiZTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMi0wMi0xNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICB0ZXN0YXBpIHNob3VsZCBoYW5kbGUgYSBtaXNzaW5nIHRlc3RhcGlT Y3JpcHRzIGRpcmVjdG9yeSBjbGVhbmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzY1OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDdXJyZW50bHksIGl0IGp1c3QgY3Jhc2hlcyB3aXRoIGEgbnVsbHB0 ciBkZXJlZiBpbnNpZGUgU291cmNlQ29kZS4KKworICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBp Lm1tOgorICAgICAgICAodGVzdE9iamVjdGl2ZUNBUEkpOgorCiAyMDIyLTAyLTEzICBMYXVybyBN b3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIG5vbi11bmlm aWVkIGJ1aWxkIGZpeGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl c3RzL3Rlc3RhcGkubW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGku bW0KaW5kZXggMmUzMWNlODI2Njg5NDY0MmM1MjllZTA2YzZiNTU1N2VmYjY4YzMxOS4uODJkMDhi NzNiOWRhZTgzNTkxNjE1MjZkZmY1YzJkZmQwYmQwNGE3MiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQpAQCAtMjgzMSw2ICsyODMxLDEyIEBAIHZvaWQgdGVz dE9iamVjdGl2ZUNBUEkoY29uc3QgY2hhciogZmlsdGVyKQogewogICAgIE5TTG9nKEAiVGVzdGlu ZyBPYmplY3RpdmUtQyBBUEkiKTsKIAorICAgIGlmICghW3Jlc29sdmVQYXRoVG9TY3JpcHRzKCkg Y2hlY2tSZXNvdXJjZUlzUmVhY2hhYmxlQW5kUmV0dXJuRXJyb3I6bmlsXSkgeworICAgICAgICBO U0xvZyhAIkZpbGUgVVJMIHRvIHRlc3RhcGlTY3JpcHRzOiAlQCIsIHJlc29sdmVQYXRoVG9TY3Jp cHRzKCkpOworICAgICAgICBjaGVja1Jlc3VsdChAIkZpbGUgVVJMIHRvIGB0ZXN0YXBpU2NyaXB0 c2AgaXNuJ3QgcmVhY2hhYmxlIGlzIHRoZSBkaXJlY3RvcnkgaW4gcGxhY2U/IiwgZmFsc2UpOwor ICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgYXV0byBzaG91bGRSdW4gPSBbJl0gKGNvbnN0 IGNoYXIqIHRlc3QpIC0+IGJvb2wgewogICAgICAgICBpZiAoZmlsdGVyKQogICAgICAgICAgICAg cmV0dXJuIHN0cmNhc2VzdHIodGVzdCwgZmlsdGVyKTsK