236587 2022-02-14 04:41:36 -0800 [GTK][WPE] Crashing/weird behaviour when trying to use videos as textures with ANGLE WebGL enabled 2022-02-16 01:41:18 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 236635 236637 1 clord clord alex clord cmarcelo dino ews-watchlist kbr kkinnunen kondapallykalyan luiz simon.fraser webkit-bug-importer zdobersek oldest_to_newest 1841204 0 clord 2022-02-14 04:41:36 -0800 Currently, the fast-path for copying the video texture for the WebGL context assumes compatible contexts, but this isn't the case with ANGLE. This causes all sorts of weird behaviour and crashing. We need to disable this fast-path until we can replace it with a more suitable (dmabuf powered?) path. 1841205 1 451890 clord 2022-02-14 04:44:24 -0800 Created attachment 451890 Patch 1841480 2 451890 kbr 2022-02-14 16:50:04 -0800 Comment on attachment 451890 Patch While understanding there are no new tests - are there any WebGL conformance tests run under LayoutTests/ that can be enabled with this patch? Aside from that - if you've tested this locally it seems fine to me to move forward the GTK / WPE ports with it. r+ 1841599 3 alex 2022-02-15 00:29:14 -0800 Layoutests with video still crash for me with the patch, I have just tested it. Also it is probably a good idea to use UNUSED_PARAM to avoid all the warnings in the function. 1841605 4 alex 2022-02-15 00:38:32 -0800 I've got the backtrace of the crash and it seems a problem is that gstreamer is trying to use X? I've tested some demo with video and it works, so the crash in LayoutTests seems an extra problem with gstreamer integration. 1841609 5 clord 2022-02-15 00:49:56 -0800 I thought that the existing tests would be enough for this, but as alexg states, GStreamer is crashing elsewhere for him - I think it's worth landing this because it makes things usable in the browser, let's open two more bugs though; 1- Address the X-related GStreamer crash in LayoutTests 2- Add the dmabuf path to remove the software frame copy I'll update the patch with the unused parameter macros. 1841610 6 452000 clord 2022-02-15 00:53:12 -0800 Created attachment 452000 Patch 1842174 7 ews-feeder 2022-02-16 01:40:58 -0800 Committed r289884 (247322@main): <https://commits.webkit.org/247322@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452000. 1842175 8 webkit-bug-importer 2022-02-16 01:41:18 -0800 <rdar://problem/89014156> 451890 2022-02-14 04:44:24 -0800 2022-02-15 00:53:08 -0800 Patch bug-236587-20220214124423.patch text/plain 2103 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzgxYTkyNDBlMjRjN2M3 N2ViOTc3NTllZjdiY2I2YjExMTU1ZWJiMi4uZTZlZjc2NjJjMDk4NDBjYmM4ZmJmOTk0ZmQ2M2Qy M2Y1NDJjNDJhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTE0ICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIENyYXNoaW5n L3dlaXJkIGJlaGF2aW91ciB3aGVuIHRyeWluZyB0byB1c2UgdmlkZW9zIGFzIHRleHR1cmVzIHdp dGggQU5HTEUgV2ViR0wgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2NTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRGlzYWJsZSB0aGUgdGV4dHVyZS1zaGFyaW5nIGZhc3QtcGF0aCBmb3Ig R1N0cmVhbWVyIEdMIHdoZW4gQU5HTEUgaXMKKyAgICAgICAgYWxzbyBlbmFibGVkLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW91ci4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0NvbnRleHRHTFRleHR1cmVNYXBwZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0R0xUZXh0dXJlTWFwcGVyOjpjb3B5 VGV4dHVyZUZyb21NZWRpYSk6CisKIDIwMjItMDItMDggIENocmlzIExvcmQgIDxjbG9yZEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gRmFsbGJhY2sgcGF0aCBmb3IgV2ViR0wgcmVu ZGVyaW5nIHdpdGggQU5HTEUgaXMgaW5jb3JyZWN0bHkgc2NoZWR1bGluZyBvbiB0aGUgY29tcG9z aXRvciB0aHJlYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9HcmFwaGljc0NvbnRleHRHTFRleHR1cmVNYXBwZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzQ29udGV4dEdMVGV4dHVyZU1hcHBl ci5jcHAKaW5kZXggNzUwYTg0YWY2MzgyYzU0MTMwY2YzNmU4NmQ5YmM4Yzc2MDRjZmJjYi4uNGQ1 ZjkzYzJlNDQ0Mjg5MDMyOWY4NDM1YzhmMzIwZGY0YzcwMjBjYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzQ29udGV4dEdMVGV4dHVy ZU1hcHBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L0dyYXBoaWNzQ29udGV4dEdMVGV4dHVyZU1hcHBlci5jcHAKQEAgLTE3NCw3ICsxNzQsMTIgQEAg UmVmUHRyPE1lZGlhU2FtcGxlPiBHcmFwaGljc0NvbnRleHRHTFRleHR1cmVNYXBwZXI6OnBhaW50 Q29tcG9zaXRlZFJlc3VsdHNUb01lZGkKICNpZiBFTkFCTEUoVklERU8pCiBib29sIEdyYXBoaWNz Q29udGV4dEdMVGV4dHVyZU1hcHBlcjo6Y29weVRleHR1cmVGcm9tTWVkaWEoTWVkaWFQbGF5ZXIm IHBsYXllciwgUGxhdGZvcm1HTE9iamVjdCBvdXRwdXRUZXh0dXJlLCBHQ0dMZW51bSBvdXRwdXRU YXJnZXQsIEdDR0xpbnQgbGV2ZWwsIEdDR0xlbnVtIGludGVybmFsRm9ybWF0LCBHQ0dMZW51bSBm b3JtYXQsIEdDR0xlbnVtIHR5cGUsIGJvb2wgcHJlbXVsdGlwbHlBbHBoYSwgYm9vbCBmbGlwWSkK IHsKKyNpZiBVU0UoQU5HTEUpICYmIFVTRShHU1RSRUFNRVJfR0wpCisgICAgLy8gRklYTUU6IElt cGxlbWVudCBjb3B5LWZyZWUgKG9yIGF0IGxlYXN0LCBzb2Z0d2FyZSBjb3B5LWZyZWUpIHRleHR1 cmUgdHJhbnNmZXIgdmlhIGRtYWJ1Zi4KKyAgICByZXR1cm4gZmFsc2U7CisjZWxzZQogICAgIHJl dHVybiBwbGF5ZXIuY29weVZpZGVvVGV4dHVyZVRvUGxhdGZvcm1UZXh0dXJlKHRoaXMsIG91dHB1 dFRleHR1cmUsIG91dHB1dFRhcmdldCwgbGV2ZWwsIGludGVybmFsRm9ybWF0LCBmb3JtYXQsIHR5 cGUsIHByZW11bHRpcGx5QWxwaGEsIGZsaXBZKTsKKyNlbmRpZgogfQogI2VuZGlmCiAK 452000 2022-02-15 00:53:12 -0800 2022-02-16 01:41:00 -0800 Patch bug-236587-20220215085311.patch text/plain 2376 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzgxYTkyNDBlMjRjN2M3 N2ViOTc3NTllZjdiY2I2YjExMTU1ZWJiMi4uZjBjYzUxZWNjZjk0YjRkOTFkM2Y3MDdkMDY0YmJm YjdlYzFhMDdmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTE0ICBDaHJp cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIENyYXNoaW5n L3dlaXJkIGJlaGF2aW91ciB3aGVuIHRyeWluZyB0byB1c2UgdmlkZW9zIGFzIHRleHR1cmVzIHdp dGggQU5HTEUgV2ViR0wgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2NTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNz ZWxsLgorCisgICAgICAgIERpc2FibGUgdGhlIHRleHR1cmUtc2hhcmluZyBmYXN0LXBhdGggZm9y IEdTdHJlYW1lciBHTCB3aGVuIEFOR0xFIGlzCisgICAgICAgIGFsc28gZW5hYmxlZC4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBpbiBiZWhhdmlvdXIuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NDb250ZXh0R0xUZXh0dXJlTWFwcGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMVGV4dHVyZU1hcHBlcjo6Y29w eVRleHR1cmVGcm9tTWVkaWEpOgorCiAyMDIyLTAyLTA4ICBDaHJpcyBMb3JkICA8Y2xvcmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEZhbGxiYWNrIHBhdGggZm9yIFdlYkdMIHJl bmRlcmluZyB3aXRoIEFOR0xFIGlzIGluY29ycmVjdGx5IHNjaGVkdWxpbmcgb24gdGhlIGNvbXBv c2l0b3IgdGhyZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvR3JhcGhpY3NDb250ZXh0R0xUZXh0dXJlTWFwcGVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0NvbnRleHRHTFRleHR1cmVNYXBw ZXIuY3BwCmluZGV4IDc1MGE4NGFmNjM4MmM1NDEzMGNmMzZlODZkOWJjOGM3NjA0Y2ZiY2IuLmUx NTA4YTMyOTQ3ZWFjODcwZjQyMGM0NTBlMzVmOTJhODk0NWMyZmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0NvbnRleHRHTFRleHR1 cmVNYXBwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9HcmFwaGljc0NvbnRleHRHTFRleHR1cmVNYXBwZXIuY3BwCkBAIC0xNzQsNyArMTc0LDIyIEBA IFJlZlB0cjxNZWRpYVNhbXBsZT4gR3JhcGhpY3NDb250ZXh0R0xUZXh0dXJlTWFwcGVyOjpwYWlu dENvbXBvc2l0ZWRSZXN1bHRzVG9NZWRpCiAjaWYgRU5BQkxFKFZJREVPKQogYm9vbCBHcmFwaGlj c0NvbnRleHRHTFRleHR1cmVNYXBwZXI6OmNvcHlUZXh0dXJlRnJvbU1lZGlhKE1lZGlhUGxheWVy JiBwbGF5ZXIsIFBsYXRmb3JtR0xPYmplY3Qgb3V0cHV0VGV4dHVyZSwgR0NHTGVudW0gb3V0cHV0 VGFyZ2V0LCBHQ0dMaW50IGxldmVsLCBHQ0dMZW51bSBpbnRlcm5hbEZvcm1hdCwgR0NHTGVudW0g Zm9ybWF0LCBHQ0dMZW51bSB0eXBlLCBib29sIHByZW11bHRpcGx5QWxwaGEsIGJvb2wgZmxpcFkp CiB7CisjaWYgVVNFKEFOR0xFKSAmJiBVU0UoR1NUUkVBTUVSX0dMKQorICAgIFVOVVNFRF9QQVJB TShwbGF5ZXIpOworICAgIFVOVVNFRF9QQVJBTShvdXRwdXRUZXh0dXJlKTsKKyAgICBVTlVTRURf UEFSQU0ob3V0cHV0VGFyZ2V0KTsKKyAgICBVTlVTRURfUEFSQU0obGV2ZWwpOworICAgIFVOVVNF RF9QQVJBTShpbnRlcm5hbEZvcm1hdCk7CisgICAgVU5VU0VEX1BBUkFNKGZvcm1hdCk7CisgICAg VU5VU0VEX1BBUkFNKHR5cGUpOworICAgIFVOVVNFRF9QQVJBTShwcmVtdWx0aXBseUFscGhhKTsK KyAgICBVTlVTRURfUEFSQU0oZmxpcFkpOworCisgICAgLy8gRklYTUU6IEltcGxlbWVudCBjb3B5 LWZyZWUgKG9yIGF0IGxlYXN0LCBzb2Z0d2FyZSBjb3B5LWZyZWUpIHRleHR1cmUgdHJhbnNmZXIg dmlhIGRtYWJ1Zi4KKyAgICByZXR1cm4gZmFsc2U7CisjZWxzZQogICAgIHJldHVybiBwbGF5ZXIu Y29weVZpZGVvVGV4dHVyZVRvUGxhdGZvcm1UZXh0dXJlKHRoaXMsIG91dHB1dFRleHR1cmUsIG91 dHB1dFRhcmdldCwgbGV2ZWwsIGludGVybmFsRm9ybWF0LCBmb3JtYXQsIHR5cGUsIHByZW11bHRp cGx5QWxwaGEsIGZsaXBZKTsKKyNlbmRpZgogfQogI2VuZGlmCiAK