236575 2022-02-13 19:59:00 -0800 Add a centerControlsBar in InlineMediaControls 2022-02-14 12:14:05 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn hi jer.noble joepeck philipj sergio webkit-bug-importer oldest_to_newest 1841113 0 peng.liu6 2022-02-13 19:59:00 -0800 Add a centerControlsBar in the media-controls element 1841114 1 451852 peng.liu6 2022-02-13 20:05:11 -0800 Created attachment 451852 [fast-cq] Patch 1841116 2 webkit-bug-importer 2022-02-13 20:18:04 -0800 <rdar://problem/88884663> 1841117 3 webkit-bug-importer 2022-02-13 20:18:23 -0800 <rdar://problem/88884670> 1841353 4 ews-feeder 2022-02-14 12:14:03 -0800 Committed r289751 (247227@main): <https://commits.webkit.org/247227@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451852. 451852 2022-02-13 20:05:11 -0800 2022-02-14 12:14:04 -0800 [fast-cq] Patch bug-236575-20220213200510.patch text/plain 3832 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWUwZTA5OTMwNDFhNzhi OTFiYjkwYTMxMGZjN2I0Y2Q0NzlhOGJhYy4uZmU3MjgxNDc1ZDRkYTc1ZDlkMTBlNWI2NzM2YWI0 MzNkYTA0OWU0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTAyLTEzICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgY2VudGVyQ29udHJv bHNCYXIgaW4gSW5saW5lTWVkaWFDb250cm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBhIHN1YmNsYXNzIG9mIGBJbmxpbmVNZWRpYUNvbnRy b2xzYCBpbXBsZW1lbnRzIGBfY2VudGVyQ29udGFpbmVyQnV0dG9ucygpYAorICAgICAgICB0byBy ZXR1cm4gYSBsaXN0IG9mIGVsZW1lbnRzLCBhIGNvbnRyb2wgYmFyIHdpbGwgYmUgYWRkZWQgYXMg YSBjaGlsZCBvZiB0aGUKKyAgICAgICAgbWVkaWEtY29udHJvbHMgZWxlbWVudC4KKworICAgICAg ICBObyBiZWhhdmlvciBjaGFuZ2Ugc28gZmFyLgorCisgICAgICAgICogTW9kdWxlcy9tb2Rlcm4t bWVkaWEtY29udHJvbHMvY29udHJvbHMvaW5saW5lLW1lZGlhLWNvbnRyb2xzLmpzOgorICAgICAg ICAoSW5saW5lTWVkaWFDb250cm9scyk6CisgICAgICAgIChJbmxpbmVNZWRpYUNvbnRyb2xzLnBy b3RvdHlwZS5sYXlvdXQpOgorICAgICAgICAoSW5saW5lTWVkaWFDb250cm9scy5wcm90b3R5cGUu X2NlbnRlckNvbnRhaW5lckJ1dHRvbnMpOgorCiAyMDIyLTAyLTA5ICBTaWh1aSBMaXUgIDxzaWh1 aV9saXVAYXBwbGUuY29tPgogCiAgICAgICAgIE1hbmFnZSBJbmRleGVkREIgc3RvcmFnZSBieSBv cmlnaW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL2NvbnRyb2xzL2lubGluZS1tZWRpYS1jb250cm9scy5qcyBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL2lubGluZS1tZWRpYS1jb250 cm9scy5qcwppbmRleCBkM2YwOTkwMWVkYmI3YTI0OGM2NzE2MmQxNDY3NzY4OWU0OGE5OGFhLi40 YjEzMjQyZjgyYTQxNWFiZDgzOTJmNzBlZDIxYmYwYTBmYWYyZTNmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pbmxpbmUt bWVkaWEtY29udHJvbHMuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVk aWEtY29udHJvbHMvY29udHJvbHMvaW5saW5lLW1lZGlhLWNvbnRyb2xzLmpzCkBAIC00NCw2ICs0 NCw5IEBAIGNsYXNzIElubGluZU1lZGlhQ29udHJvbHMgZXh0ZW5kcyBNZWRpYUNvbnRyb2xzCiAg ICAgICAgIHRoaXMubGVmdENvbnRhaW5lciA9IG5ldyBCdXR0b25zQ29udGFpbmVyKHsgY3NzQ2xh c3NOYW1lOiAibGVmdCIgfSk7CiAgICAgICAgIHRoaXMucmlnaHRDb250YWluZXIgPSBuZXcgQnV0 dG9uc0NvbnRhaW5lcih7IGNzc0NsYXNzTmFtZTogInJpZ2h0IiB9KTsKIAorICAgICAgICB0aGlz LmNlbnRlckNvbnRyb2xzQmFyID0gbmV3IENvbnRyb2xzQmFyKCJjZW50ZXIiKTsKKyAgICAgICAg dGhpcy5fY2VudGVyQ29udHJvbHNCYXJDb250YWluZXIgPSB0aGlzLmNlbnRlckNvbnRyb2xzQmFy LmFkZENoaWxkKG5ldyBCdXR0b25zQ29udGFpbmVyKTsKKwogICAgICAgICB0aGlzLl9zaG91bGRV c2VBdWRpb0xheW91dCA9IGZhbHNlOwogICAgICAgICB0aGlzLl9zaG91bGRVc2VTaW5nbGVCYXJM YXlvdXQgPSBmYWxzZTsKICAgICAgICAgdGhpcy5zaG93c1N0YXJ0QnV0dG9uID0gZmFsc2U7CkBA IC0xMjksNiArMTMyLDExIEBAIGNsYXNzIElubGluZU1lZGlhQ29udHJvbHMgZXh0ZW5kcyBNZWRp YUNvbnRyb2xzCiAgICAgICAgIHRoaXMudG9wTGVmdENvbnRyb2xzQmFyLndpZHRoID0gdGhpcy5f dG9wTGVmdENvbnRyb2xzQmFyQ29udGFpbmVyLndpZHRoOwogICAgICAgICB0aGlzLnRvcExlZnRD b250cm9sc0Jhci52aXNpYmxlID0gdGhpcy5fdG9wTGVmdENvbnRyb2xzQmFyQ29udGFpbmVyLmNo aWxkcmVuLnNvbWUoYnV0dG9uID0+IGJ1dHRvbi52aXNpYmxlKTsKIAorICAgICAgICB0aGlzLl9j ZW50ZXJDb250cm9sc0JhckNvbnRhaW5lci5jaGlsZHJlbiA9IHRoaXMuX2NlbnRlckNvbnRhaW5l ckJ1dHRvbnMoKTsKKyAgICAgICAgdGhpcy5fY2VudGVyQ29udHJvbHNCYXJDb250YWluZXIubGF5 b3V0KCk7CisgICAgICAgIHRoaXMuY2VudGVyQ29udHJvbHNCYXIud2lkdGggPSB0aGlzLl9jZW50 ZXJDb250cm9sc0JhckNvbnRhaW5lci53aWR0aDsKKyAgICAgICAgdGhpcy5jZW50ZXJDb250cm9s c0Jhci52aXNpYmxlID0gdGhpcy5fY2VudGVyQ29udHJvbHNCYXJDb250YWluZXIuY2hpbGRyZW4u c29tZShidXR0b24gPT4gYnV0dG9uLnZpc2libGUpOworCiAgICAgICAgIC8vIENvbXB1dGUgdGhl IHZpc2libGUgc2l6ZSBmb3IgdGhlIGNvbnRyb2xzIGJhci4KICAgICAgICAgaWYgKCF0aGlzLl9p bmxpbmVJbnNpZGVNYXJnaW4pCiAgICAgICAgICAgICB0aGlzLl9pbmxpbmVJbnNpZGVNYXJnaW4g PSB0aGlzLmNvbXB1dGVkVmFsdWVGb3JTdHlsZVByb3BlcnR5SW5QeCgiLS1pbmxpbmUtY29udHJv bHMtaW5zaWRlLW1hcmdpbiIpOwpAQCAtMjI0LDYgKzIzMiw4IEBAIGNsYXNzIElubGluZU1lZGlh Q29udHJvbHMgZXh0ZW5kcyBNZWRpYUNvbnRyb2xzCiAgICAgICAgIHRoaXMuYm90dG9tQ29udHJv bHNCYXIuY2hpbGRyZW4gPSBjb250cm9sc0JhckNoaWxkcmVuOwogICAgICAgICBpZiAoIXRoaXMu X3Nob3VsZFVzZUF1ZGlvTGF5b3V0ICYmICF0aGlzLl9zaG91bGRVc2VTaW5nbGVCYXJMYXlvdXQp CiAgICAgICAgICAgICBjaGlsZHJlbi5wdXNoKHRoaXMudG9wTGVmdENvbnRyb2xzQmFyKTsKKyAg ICAgICAgaWYgKCF0aGlzLl9zaG91bGRVc2VBdWRpb0xheW91dCAmJiAhdGhpcy5fc2hvdWxkVXNl U2luZ2xlQmFyTGF5b3V0ICYmIHRoaXMuX2NlbnRlckNvbnRyb2xzQmFyQ29udGFpbmVyLmNoaWxk cmVuLmxlbmd0aCkKKyAgICAgICAgICAgIGNoaWxkcmVuLnB1c2godGhpcy5jZW50ZXJDb250cm9s c0Jhcik7CiAgICAgICAgIGNoaWxkcmVuLnB1c2godGhpcy5ib3R0b21Db250cm9sc0Jhcik7CiAg ICAgICAgIGlmICh0aGlzLm11dGVCdXR0b24uc3R5bGUgPT09IEJ1dHRvbi5TdHlsZXMuQ29ybmVy IHx8ICh0aGlzLm11dGVCdXR0b24uZHJvcHBlZCAmJiAhdGhpcy5fc2hvdWxkVXNlQXVkaW9MYXlv dXQgJiYgIXRoaXMuX3Nob3VsZFVzZVNpbmdsZUJhckxheW91dCkpCiAgICAgICAgICAgICB0aGlz Ll9hZGRUb3BSaWdodEJhcldpdGhNdXRlQnV0dG9uVG9DaGlsZHJlbihjaGlsZHJlbik7CkBAIC0y NjUsNiArMjc1LDEwIEBAIGNsYXNzIElubGluZU1lZGlhQ29udHJvbHMgZXh0ZW5kcyBNZWRpYUNv bnRyb2xzCiAgICAgICAgIHJldHVybiBbdGhpcy5za2lwQmFja0J1dHRvbiwgdGhpcy5wbGF5UGF1 c2VCdXR0b24sIHRoaXMuc2tpcEZvcndhcmRCdXR0b25dOwogICAgIH0KIAorICAgIF9jZW50ZXJD b250YWluZXJCdXR0b25zKCkgeworICAgICAgICByZXR1cm4gW107CisgICAgfQorCiAgICAgX3Jp Z2h0Q29udGFpbmVyQnV0dG9ucygpCiAgICAgewogICAgICAgICBpZiAodGhpcy5fc2hvdWxkVXNl QXVkaW9MYXlvdXQpCg==