236571 2022-02-13 14:16:06 -0800 Consistenly use hasTagName instead of is<> in HTMLStackItem testing functions 2022-02-14 16:02:17 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim sam webkit-bug-importer oldest_to_newest 1841074 0 heycam 2022-02-13 14:16:06 -0800 No reason to use is<> for a couple of element names but hasTagName for all others. 1841075 1 451843 heycam 2022-02-13 14:19:04 -0800 Created attachment 451843 Patch 1841391 2 451843 sam 2022-02-14 13:26:42 -0800 Comment on attachment 451843 Patch Looks like this was done intentionally way back in http://trac.webkit.org/changeset/152440/webkit, but also seems like it was not the right choice. 1841456 3 ews-feeder 2022-02-14 16:01:17 -0800 Committed r289777 (247245@main): <https://commits.webkit.org/247245@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451843. 1841458 4 webkit-bug-importer 2022-02-14 16:02:17 -0800 <rdar://problem/88933767> 451843 2022-02-13 14:19:04 -0800 2022-02-14 16:01:20 -0800 Patch bug-236571-20220214091903.patch text/plain 2254 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5Njg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjlhYjQ5MjZkZDcxMzg4 MWQzNjY1NGZjZTE5Yzk0N2UyOTNjMWI0MS4uNzk0NGU4NGY2OWM3Mzc3OGU4MDIxYTEzNTBkYzFl MDY5ZDkyOWNlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTEzICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQ29uc2lzdGVubHkg dXNlIGhhc1RhZ05hbWUgaW5zdGVhZCBvZiBpczw+IGluIEhUTUxTdGFja0l0ZW0gdGVzdGluZyBm dW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNjU3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIHJlYXNvbiB0byB1c2UgaXM8PiBmb3IgYSBjb3VwbGUgb2YgZWxlbWVudCBuYW1lcyBidXQg aGFzVGFnTmFtZSBmb3IKKyAgICAgICAgYWxsIG90aGVycy4KKworICAgICAgICAqIGh0bWwvcGFy c2VyL0hUTUxFbGVtZW50U3RhY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE5hbWVzOjpp c1Njb3BlTWFya2VyKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxOYW1lczo6aXNUYWJsZVNjb3Bl TWFya2VyKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxOYW1lczo6aXNTZWxlY3RTY29wZU1hcmtl cik6CisKIDIwMjItMDItMTMgIENhbWVyb24gTWNDb3JtYWNrICA8aGV5Y2FtQGFwcGxlLmNvbT4K IAogICAgICAgICBDYWNoZSBhbiBlbnRpcmUgYXR0cmlidXRlIFF1YWxpZmllZE5hbWUgd2hlbiBw YXJzaW5nIEhUTUwsIG5vdCBqdXN0IGl0cyBsb2NhbCBuYW1lIEF0b21TdHJpbmcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRTdGFjay5jcHAKaW5kZXggNmVmMTcx MmI5ZDYzYjcxYWNiN2MxNjlmNjJiNDljODJmMzEwNTgxNC4uMjI5ZDU0ZjdkMGM3NDk4M2VjOGYy YjJiNjhmYjExNTQ2MWE3OWI3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTEVsZW1lbnRTdGFjay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIv SFRNTEVsZW1lbnRTdGFjay5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgaW5saW5lIGJvb2wgaXNTY29w ZU1hcmtlcihIVE1MU3RhY2tJdGVtJiBpdGVtKQogICAgICAgICB8fCBpdGVtLmhhc1RhZ05hbWUo Y2FwdGlvblRhZykKICAgICAgICAgfHwgaXRlbS5oYXNUYWdOYW1lKG1hcnF1ZWVUYWcpCiAgICAg ICAgIHx8IGl0ZW0uaGFzVGFnTmFtZShvYmplY3RUYWcpCi0gICAgICAgIHx8IGlzPEhUTUxUYWJs ZUVsZW1lbnQ+KGl0ZW0ubm9kZSgpKQorICAgICAgICB8fCBpdGVtLmhhc1RhZ05hbWUodGFibGVU YWcpCiAgICAgICAgIHx8IGl0ZW0uaGFzVGFnTmFtZSh0ZFRhZykKICAgICAgICAgfHwgaXRlbS5o YXNUYWdOYW1lKHRoVGFnKQogICAgICAgICB8fCBpdGVtLmhhc1RhZ05hbWUoTWF0aE1MTmFtZXM6 Om1pVGFnKQpAQCAtNzQsNyArNzQsNyBAQCBpbmxpbmUgYm9vbCBpc0xpc3RJdGVtU2NvcGVNYXJr ZXIoSFRNTFN0YWNrSXRlbSYgaXRlbSkKIAogaW5saW5lIGJvb2wgaXNUYWJsZVNjb3BlTWFya2Vy KEhUTUxTdGFja0l0ZW0mIGl0ZW0pCiB7Ci0gICAgcmV0dXJuIGlzPEhUTUxUYWJsZUVsZW1lbnQ+ KGl0ZW0ubm9kZSgpKQorICAgIHJldHVybiBpdGVtLmhhc1RhZ05hbWUodGFibGVUYWcpCiAgICAg ICAgIHx8IGl0ZW0uaGFzVGFnTmFtZSh0ZW1wbGF0ZVRhZykKICAgICAgICAgfHwgaXNSb290Tm9k ZShpdGVtKTsKIH0KQEAgLTExMCw3ICsxMTAsNyBAQCBpbmxpbmUgYm9vbCBpc0J1dHRvblNjb3Bl TWFya2VyKEhUTUxTdGFja0l0ZW0mIGl0ZW0pCiAKIGlubGluZSBib29sIGlzU2VsZWN0U2NvcGVN YXJrZXIoSFRNTFN0YWNrSXRlbSYgaXRlbSkKIHsKLSAgICByZXR1cm4gIWlzPEhUTUxPcHRHcm91 cEVsZW1lbnQ+KGl0ZW0ubm9kZSgpKSAmJiAhaXM8SFRNTE9wdGlvbkVsZW1lbnQ+KGl0ZW0ubm9k ZSgpKTsKKyAgICByZXR1cm4gIWl0ZW0uaGFzVGFnTmFtZShvcHRncm91cFRhZykgJiYgIWl0ZW0u aGFzVGFnTmFtZShvcHRpb25UYWcpOwogfQogCiB9Cg==