236567 2022-02-13 11:41:02 -0800 Make StructureMemoryManager alignment assert a RELEASE_ASSERT 2022-02-13 13:12:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1841041 0 keith_miller 2022-02-13 11:41:02 -0800 Make StructureMemoryManager alignment assert a RELEASE_ASSERT 1841043 1 451831 keith_miller 2022-02-13 11:41:50 -0800 Created attachment 451831 Patch 1841046 2 451831 saam 2022-02-13 11:43:41 -0800 Comment on attachment 451831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review r=me > Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 > + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); let's also release assert it's not null. 1841047 3 451831 saam 2022-02-13 11:44:00 -0800 Comment on attachment 451831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); > > let's also release assert it's not null. lol, I should read the code before commenting :-) 1841048 4 451831 keith_miller 2022-02-13 11:45:31 -0800 Comment on attachment 451831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >>> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >>> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); >> >> let's also release assert it's not null. > > lol, I should read the code before commenting :-) :P 1841056 5 ews-feeder 2022-02-13 12:23:35 -0800 Committed r289717 (247202@main): <https://commits.webkit.org/247202@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451831. 1841057 6 webkit-bug-importer 2022-02-13 12:24:16 -0800 <rdar://problem/88875697> 451831 2022-02-13 11:41:50 -0800 2022-02-13 13:12:26 -0800 Patch bug-236567-20220213144149.patch text/plain 1597 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NTk1OGNkODFhZGEzZGRlODMwZTZlM2Y5M2EwYzEyOWQ3NGFiY2FiLi44NDhhN2YwMmRkNWRmZTgz NmEzNDY5MDI5NGFlYWRlZmQ5YWM2OTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMi0wMi0xMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBNYWtlIFN0cnVjdHVyZU1lbW9yeU1hbmFnZXIgYWxpZ25tZW50IGFz c2VydCBhIFJFTEVBU0VfQVNTRVJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzY1NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBbHNvLCBjaGVjayB0aGUgc3RydWN0dXJlIGJhc2UgcG9pbnRlciBpcyBu b24temVyby4KKworICAgICAgICAqIGhlYXAvU3RydWN0dXJlQWxpZ25lZE1lbW9yeUFsbG9jYXRv ci5jcHA6CisgICAgICAgIChKU0M6OlN0cnVjdHVyZU1lbW9yeU1hbmFnZXI6OlN0cnVjdHVyZU1l bW9yeU1hbmFnZXIpOgorCiAyMDIyLTAyLTEwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJA YXBwbGUuY29tPgogCiAgICAgICAgIHRyeVJlc2VydmVVbmNvbW1pdHRlZEFsaWduZWQgc2hvdWxk IGV4cGxpY2l0bHkgdGFrZSB0aGUgYWxpZ25tZW50IHJlcXVlc3RlZApkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3RydWN0dXJlQWxpZ25lZE1lbW9yeUFsbG9jYXRvci5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TdHJ1Y3R1cmVBbGlnbmVkTWVtb3J5QWxs b2NhdG9yLmNwcAppbmRleCAxZmM4MzE0NTI3Njc3MWFjYmEwYTU2NTczZjY4M2QxYmVhOTI1MDdm Li45YTg0YzI0ZDY2M2E4MmZhYTFhOTBhZTUwNDllZWRhNTc5MTkwNzNlIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TdHJ1Y3R1cmVBbGlnbmVkTWVtb3J5QWxsb2NhdG9y LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TdHJ1Y3R1cmVBbGlnbmVkTWVt b3J5QWxsb2NhdG9yLmNwcApAQCAtODIsNyArODIsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBt X21hcHBlZEhlYXBTaXplIC89IDI7CiAgICAgICAgIH0KIAotICAgICAgICBBU1NFUlQoKGdfanNj Q29uZmlnLnN0YXJ0T2ZTdHJ1Y3R1cmVIZWFwICYgfnN0cnVjdHVyZUlETWFzaykgPT0gZ19qc2ND b25maWcuc3RhcnRPZlN0cnVjdHVyZUhlYXApOworICAgICAgICBSRUxFQVNFX0FTU0VSVChnX2pz Y0NvbmZpZy5zdGFydE9mU3RydWN0dXJlSGVhcCAmJiAoKGdfanNjQ29uZmlnLnN0YXJ0T2ZTdHJ1 Y3R1cmVIZWFwICYgfnN0cnVjdHVyZUlETWFzaykgPT0gZ19qc2NDb25maWcuc3RhcnRPZlN0cnVj dHVyZUhlYXApKTsKICAgICB9CiAKICAgICB2b2lkKiB0cnlNYWxsb2NTdHJ1Y3R1cmVCbG9jaygp Cg==