236560 2022-02-13 04:34:28 -0800 [JSC] Fix test sharding when using --make-runner and --remote 2022-03-08 02:19:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 angelos angelos aperez jbedard mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1840975 0 angelos 2022-02-13 04:34:28 -0800 [JSC] Fix test sharding when using --remote 1840976 1 451814 angelos 2022-02-13 04:36:48 -0800 Created attachment 451814 Patch 1841703 2 452020 angelos 2022-02-15 07:21:55 -0800 Created attachment 452020 Patch 1841868 3 angelos 2022-02-15 12:17:47 -0800 For reviewers who might be unfamiliar with ruby: @remoteHosts refers to an instance variable of the class (a field) and defaults to nil if the variable doesn't exist. The patch has prepareRunnerForRemote accept remoteHosts as an argument instead and updates all callers. 1841869 4 angelos 2022-02-15 12:21:00 -0800 Oh, also to the best of my knowledge --make-runner is not used with --remote in any public buildbot. 1843770 5 ews-feeder 2022-02-18 20:05:56 -0800 Tools/Scripts/svn-apply failed to apply attachment 452020 to trunk. Please resolve the conflicts and upload a new patch. 1844053 6 webkit-bug-importer 2022-02-20 04:35:15 -0800 <rdar://problem/89202446> 1844169 7 452020 aakash_jain 2022-02-21 05:05:47 -0800 Comment on attachment 452020 Patch Commit-Queue landed it in https://ews-build.webkit.org/#/builders/28/builds/19893 https://commits.webkit.org/247513@main (r290185) 1849169 8 aperez 2022-03-08 02:19:29 -0800 Closing as fixed, because the patch has landed :) 451814 2022-02-13 04:36:48 -0800 2022-02-15 07:21:39 -0800 Patch bug-236560-20220213123646.patch text/plain 2622 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4OTU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjU5MjA0MzdiMjczYzgzOTdhNmI4OGRmNzA1ZmIxYmU5 OTdlYzgwZS4uYTVkNTMxZmVmZTUyYmU5NmVkMWU5YmVkY2FiZmY5MWNkZDFjM2ZiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIyLTAyLTEzICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFtKU0NdIEZpeCB0ZXN0IHNoYXJkaW5nIHdoZW4gdXNpbmcgLS1tYWtl LXJ1bm5lciBhbmQgLS1yZW1vdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzNjU2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFmdGVyIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnLzI0NDQ5NkBtYWlu LCB0ZXN0IHNoYXJkaW5nIHdhcyBicm9rZW4KKyAgICAgICAgZm9yIHRoZSBtYWtlIHJ1bm5lci4g U3BlY2lmaWNhbGx5LCBhbGwgcmVtb3RlcyB3b3VsZCBnZXQgYXNzaWduZWQgYWxsCisgICAgICAg IHRlc3RzIChpbnN0ZWFkIG9mIGEgc3Vic2V0KS4KKworICAgICAgICBGaXggdGhpcyBieSBwcm9w YWdhdGluZyBhbmQgdXNpbmcgdGhlIGNvcnJlY3QgdmFsdWUgZm9yIHJlbW90ZUhvc3RzLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRydWJ5L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItZGVmYXVs dC5yYjoKKwogMjAyMi0wMi0wMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgQ2xhcmlmeSB0aGF0IHNvbWUgVVVJRCByb3V0aW5lcyBhcmUgZGVkaWNhdGVkIHRv IFVVSUQgdjQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVieS9qc2Mtc3RyZXNz LXRlc3Qtd3JpdGVyLWRlZmF1bHQucmIgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHJ1YnkvanNjLXN0 cmVzcy10ZXN0LXdyaXRlci1kZWZhdWx0LnJiCmluZGV4IDM5ZjFkYjA3MmZhMDEwZmQ1ZGQ1MTll NjQ4ZjNiYWI3ZGFmZTFhYzEuLmI0ODEzNjZhZjMyNmE4MjY2NmI3OWQ1MTc5N2NjZDY5ZjM3ZTU5 NWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVieS9qc2Mtc3RyZXNzLXRlc3Qt d3JpdGVyLWRlZmF1bHQucmIKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRydWJ5L2pzYy1zdHJl c3MtdGVzdC13cml0ZXItZGVmYXVsdC5yYgpAQCAtMzU2LDcgKzM1Niw3IEBAIGNsYXNzIFRlc3RS dW5uZXJNYWtlIDwgVGVzdFJ1bm5lcgogICAgICAgICBvdXRwLnB1dHMgIlx0c2ggdGVzdF9zY3Jp cHRfI3tpbmRleH0iCiAgICAgICAgIHRhcmdldAogICAgIGVuZAotICAgIGRlZiBwcmVwYXJlUnVu bmVyRm9yUmVtb3RlKHJ1bmxpc3QsIHNlcmlhbFBsYW5zLCBjb21wbGV0ZWRQbGFucywgcmVtb3Rl SW5kZXgpCisgICAgZGVmIHByZXBhcmVSdW5uZXJGb3JSZW1vdGUocnVubGlzdCwgc2VyaWFsUGxh bnMsIGNvbXBsZXRlZFBsYW5zLCByZW1vdGVIb3N0cywgcmVtb3RlSW5kZXgpCiAgICAgICAgICMg VGhlIGdvYWxzIG9mIG91ciBwYXJhbGxlbCB0ZXN0IHJ1bm5lciBhcmUgc2NhbGFiaWxpdHkgYW5k IHNpbXBsaWNpdHkuIFRoZQogICAgICAgICAjIHNpbXBsaWNpdHkgcGFydCBpcyBwYXJ0aWN1bGFy bHkgaW1wb3J0YW50LiBXZSBkb24ndCB3YW50IHRvIGhhdmUgdG8gaGF2ZQogICAgICAgICAjIGEg ZnVsbC10aW1lIGNvbnRyaWJ1dG9yIGp1c3QgcGhpbG9zb3BoaXNpbmcgYWJvdXQgcGFyYWxsZWwg dGVzdGluZy4KQEAgLTQwMCw3ICs0MDAsNyBAQCBjbGFzcyBUZXN0UnVubmVyTWFrZSA8IFRlc3RS dW5uZXIKICAgICAgICAgICAgIGlmIGNvbXBsZXRlZFBsYW5zLmluY2x1ZGU/KHBsYW4pCiAgICAg ICAgICAgICAgICAgbmV4dAogICAgICAgICAgICAgZW5kCi0gICAgICAgICAgICBpZiBAcmVtb3Rl SG9zdHMubmlsPyBvciBwbGFuLmluZGV4ICUgQHJlbW90ZUhvc3RzLmxlbmd0aCA9PSByZW1vdGVJ bmRleAorICAgICAgICAgICAgaWYgcmVtb3RlSG9zdHMubmlsPyBvciBwbGFuLmluZGV4ICUgcmVt b3RlSG9zdHMubGVuZ3RoID09IHJlbW90ZUluZGV4CiAgICAgICAgICAgICAgICAgaWYgc2VyaWFs UGxhbnMuaW5jbHVkZT8ocGxhbikKICAgICAgICAgICAgICAgICAgICAgc2VyaWFsUnVuUGxhbnMg PDwgcGxhbgogICAgICAgICAgICAgICAgIGVsc2UKQEAgLTQzNSw3ICs0MzUsNyBAQCBjbGFzcyBU ZXN0UnVubmVyTWFrZSA8IFRlc3RSdW5uZXIKICAgICAgICAgZWxzZQogICAgICAgICAgICAgcmVt b3RlSG9zdHMuZWFjaF9pbmRleCB7CiAgICAgICAgICAgICAgICAgfHJlbW90ZUluZGV4fAotICAg ICAgICAgICAgICAgIHByZXBhcmVSdW5uZXJGb3JSZW1vdGUocnVubGlzdCwgc2VyaWFsUGxhbnMs IGNvbXBsZXRlZFBsYW5zLCByZW1vdGVJbmRleCkKKyAgICAgICAgICAgICAgICBwcmVwYXJlUnVu bmVyRm9yUmVtb3RlKHJ1bmxpc3QsIHNlcmlhbFBsYW5zLCBjb21wbGV0ZWRQbGFucywgcmVtb3Rl SG9zdHMsIHJlbW90ZUluZGV4KQogICAgICAgICAgICAgfQogICAgICAgICBlbmQKICAgICBlbmQK 452020 2022-02-15 07:21:55 -0800 2022-03-08 02:19:04 -0800 Patch bug-236560-20220215152154.patch text/plain 2903 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4OTU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjU5MjA0MzdiMjczYzgzOTdhNmI4OGRmNzA1ZmIxYmU5 OTdlYzgwZS4uYTVkNTMxZmVmZTUyYmU5NmVkMWU5YmVkY2FiZmY5MWNkZDFjM2ZiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIyLTAyLTEzICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFtKU0NdIEZpeCB0ZXN0IHNoYXJkaW5nIHdoZW4gdXNpbmcgLS1tYWtl LXJ1bm5lciBhbmQgLS1yZW1vdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzNjU2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFmdGVyIGh0dHBzOi8vY29tbWl0cy53ZWJraXQub3JnLzI0NDQ5NkBtYWlu LCB0ZXN0IHNoYXJkaW5nIHdhcyBicm9rZW4KKyAgICAgICAgZm9yIHRoZSBtYWtlIHJ1bm5lci4g U3BlY2lmaWNhbGx5LCBhbGwgcmVtb3RlcyB3b3VsZCBnZXQgYXNzaWduZWQgYWxsCisgICAgICAg IHRlc3RzIChpbnN0ZWFkIG9mIGEgc3Vic2V0KS4KKworICAgICAgICBGaXggdGhpcyBieSBwcm9w YWdhdGluZyBhbmQgdXNpbmcgdGhlIGNvcnJlY3QgdmFsdWUgZm9yIHJlbW90ZUhvc3RzLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRydWJ5L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItZGVmYXVs dC5yYjoKKwogMjAyMi0wMi0wMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgQ2xhcmlmeSB0aGF0IHNvbWUgVVVJRCByb3V0aW5lcyBhcmUgZGVkaWNhdGVkIHRv IFVVSUQgdjQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVieS9qc2Mtc3RyZXNz LXRlc3Qtd3JpdGVyLWRlZmF1bHQucmIgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHJ1YnkvanNjLXN0 cmVzcy10ZXN0LXdyaXRlci1kZWZhdWx0LnJiCmluZGV4IDM5ZjFkYjA3MmZhMDEwZmQ1ZGQ1MTll NjQ4ZjNiYWI3ZGFmZTFhYzEuLmVjOWQ5MzQwYWFhYmM1YjFkNTg3YjhmN2FiMTQ5NzU1NmE4YjUx MDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVieS9qc2Mtc3RyZXNzLXRlc3Qt d3JpdGVyLWRlZmF1bHQucmIKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRydWJ5L2pzYy1zdHJl c3MtdGVzdC13cml0ZXItZGVmYXVsdC5yYgpAQCAtMzU2LDcgKzM1Niw3IEBAIGNsYXNzIFRlc3RS dW5uZXJNYWtlIDwgVGVzdFJ1bm5lcgogICAgICAgICBvdXRwLnB1dHMgIlx0c2ggdGVzdF9zY3Jp cHRfI3tpbmRleH0iCiAgICAgICAgIHRhcmdldAogICAgIGVuZAotICAgIGRlZiBwcmVwYXJlUnVu bmVyRm9yUmVtb3RlKHJ1bmxpc3QsIHNlcmlhbFBsYW5zLCBjb21wbGV0ZWRQbGFucywgcmVtb3Rl SW5kZXgpCisgICAgZGVmIHByZXBhcmVSdW5uZXJGb3JSZW1vdGUocnVubGlzdCwgc2VyaWFsUGxh bnMsIGNvbXBsZXRlZFBsYW5zLCByZW1vdGVIb3N0cywgcmVtb3RlSW5kZXgpCiAgICAgICAgICMg VGhlIGdvYWxzIG9mIG91ciBwYXJhbGxlbCB0ZXN0IHJ1bm5lciBhcmUgc2NhbGFiaWxpdHkgYW5k IHNpbXBsaWNpdHkuIFRoZQogICAgICAgICAjIHNpbXBsaWNpdHkgcGFydCBpcyBwYXJ0aWN1bGFy bHkgaW1wb3J0YW50LiBXZSBkb24ndCB3YW50IHRvIGhhdmUgdG8gaGF2ZQogICAgICAgICAjIGEg ZnVsbC10aW1lIGNvbnRyaWJ1dG9yIGp1c3QgcGhpbG9zb3BoaXNpbmcgYWJvdXQgcGFyYWxsZWwg dGVzdGluZy4KQEAgLTQwMCw3ICs0MDAsNyBAQCBjbGFzcyBUZXN0UnVubmVyTWFrZSA8IFRlc3RS dW5uZXIKICAgICAgICAgICAgIGlmIGNvbXBsZXRlZFBsYW5zLmluY2x1ZGU/KHBsYW4pCiAgICAg ICAgICAgICAgICAgbmV4dAogICAgICAgICAgICAgZW5kCi0gICAgICAgICAgICBpZiBAcmVtb3Rl SG9zdHMubmlsPyBvciBwbGFuLmluZGV4ICUgQHJlbW90ZUhvc3RzLmxlbmd0aCA9PSByZW1vdGVJ bmRleAorICAgICAgICAgICAgaWYgcmVtb3RlSG9zdHMubmlsPyBvciBwbGFuLmluZGV4ICUgcmVt b3RlSG9zdHMubGVuZ3RoID09IHJlbW90ZUluZGV4CiAgICAgICAgICAgICAgICAgaWYgc2VyaWFs UGxhbnMuaW5jbHVkZT8ocGxhbikKICAgICAgICAgICAgICAgICAgICAgc2VyaWFsUnVuUGxhbnMg PDwgcGxhbgogICAgICAgICAgICAgICAgIGVsc2UKQEAgLTQzMSwxMSArNDMxLDExIEBAIGNsYXNz IFRlc3RSdW5uZXJNYWtlIDwgVGVzdFJ1bm5lcgogICAgIGVuZAogICAgIGRlZiBwcmVwYXJlUnVu bmVyKHJ1bmxpc3QsIHNlcmlhbFBsYW5zLCBjb21wbGV0ZWRQbGFucywgcmVtb3RlSG9zdHMpCiAg ICAgICAgIGlmIHJlbW90ZUhvc3RzLm5pbD8KLSAgICAgICAgICAgIHByZXBhcmVSdW5uZXJGb3JS ZW1vdGUocnVubGlzdCwgc2VyaWFsUGxhbnMsIGNvbXBsZXRlZFBsYW5zLCAwKQorICAgICAgICAg ICAgcHJlcGFyZVJ1bm5lckZvclJlbW90ZShydW5saXN0LCBzZXJpYWxQbGFucywgY29tcGxldGVk UGxhbnMsIHJlbW90ZUhvc3RzLCAwKQogICAgICAgICBlbHNlCiAgICAgICAgICAgICByZW1vdGVI b3N0cy5lYWNoX2luZGV4IHsKICAgICAgICAgICAgICAgICB8cmVtb3RlSW5kZXh8Ci0gICAgICAg ICAgICAgICAgcHJlcGFyZVJ1bm5lckZvclJlbW90ZShydW5saXN0LCBzZXJpYWxQbGFucywgY29t cGxldGVkUGxhbnMsIHJlbW90ZUluZGV4KQorICAgICAgICAgICAgICAgIHByZXBhcmVSdW5uZXJG b3JSZW1vdGUocnVubGlzdCwgc2VyaWFsUGxhbnMsIGNvbXBsZXRlZFBsYW5zLCByZW1vdGVIb3N0 cywgcmVtb3RlSW5kZXgpCiAgICAgICAgICAgICB9CiAgICAgICAgIGVuZAogICAgIGVuZAo=