23655 2009-01-30 14:11:18 -0800 Clean up storage layout tests a bit 2009-02-04 14:53:16 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 dglazkov dglazkov oldest_to_newest 107772 0 dglazkov 2009-01-30 14:11:18 -0800 Just some minor style fixups and one place where the transaction error callback had wrong params. 107775 1 27194 dglazkov 2009-01-30 14:12:52 -0800 Created attachment 27194 v1 submitted for review LayoutTests/ChangeLog | 16 ++++++++++++++++ LayoutTests/storage/close-during-stress-test.html | 3 ++- LayoutTests/storage/empty-statement.html | 3 ++- LayoutTests/storage/execute-sql-args.html | 3 ++- LayoutTests/storage/quota-tracking.html | 3 ++- LayoutTests/storage/success-callback.html | 5 +++-- .../transaction-callback-exception-crash.html | 20 ++++++++++++++++++++ .../transaction-callback-exception-crash.txt | 2 ++ ...ansaction_callback_exception_crash-expected.txt | 2 -- .../transaction_callback_exception_crash.html | 20 -------------------- 10 files changed, 49 insertions(+), 28 deletions(-) 108337 2 dglazkov 2009-02-04 14:53:16 -0800 Landed in trac.webkit.org/changeset/40632. 27194 2009-01-30 14:12:52 -0800 2009-02-03 15:23:55 -0800 v1 submitted for review v1-submitted-for-review.patch text/plain 6197 dglazkov ZmVlYTRiZjI0NDdhNWY1MWE5ZmU5NWRiZTJiYTMyZDVkNTIxYjhjMApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ1N2RjZGQu LjA5Y2M5YWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wMS0zMCAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzY1NQorICAgICAgICBDbGVhbiB1cCBzdG9yYWdlIGxheW91dCB0ZXN0cyBhIGJpdC4K KworICAgICAgICAqIHN0b3JhZ2UvY2xvc2UtZHVyaW5nLXN0cmVzcy10ZXN0Lmh0bWw6CisgICAg ICAgICogc3RvcmFnZS9lbXB0eS1zdGF0ZW1lbnQuaHRtbDoKKyAgICAgICAgKiBzdG9yYWdlL2V4 ZWN1dGUtc3FsLWFyZ3MuaHRtbDoKKyAgICAgICAgKiBzdG9yYWdlL3F1b3RhLXRyYWNraW5nLmh0 bWw6CisgICAgICAgICogc3RvcmFnZS9zdWNjZXNzLWNhbGxiYWNrLmh0bWw6CisgICAgICAgICog c3RvcmFnZS90cmFuc2FjdGlvbi1jYWxsYmFjay1leGNlcHRpb24tY3Jhc2guaHRtbDogQWRkZWQu CisgICAgICAgICogc3RvcmFnZS90cmFuc2FjdGlvbi1jYWxsYmFjay1leGNlcHRpb24tY3Jhc2gu dHh0OiBSZW5hbWVkIGZyb20gTGF5b3V0VGVzdHMvc3RvcmFnZS90cmFuc2FjdGlvbl9jYWxsYmFj a19leGNlcHRpb25fY3Jhc2gtZXhwZWN0ZWQudHh0LgorICAgICAgICAqIHN0b3JhZ2UvdHJhbnNh Y3Rpb25fY2FsbGJhY2tfZXhjZXB0aW9uX2NyYXNoLmh0bWw6IFJlbW92ZWQuCisKIDIwMDktMDEt MzAgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2Nsb3Nl LWR1cmluZy1zdHJlc3MtdGVzdC5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9jbG9zZS1kdXJp bmctc3RyZXNzLXRlc3QuaHRtbAppbmRleCBmZjEwNWM0Li4yMTgzZTJmIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9zdG9yYWdlL2Nsb3NlLWR1cmluZy1zdHJlc3MtdGVzdC5odG1sCisrKyBiL0xh eW91dFRlc3RzL3N0b3JhZ2UvY2xvc2UtZHVyaW5nLXN0cmVzcy10ZXN0Lmh0bWwKQEAgLTksNyAr OSw4IEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiB9CiAKLWZ1bmN0aW9uIHN0YXJ0VGVzdCgpIHsKK2Z1 bmN0aW9uIHN0YXJ0VGVzdCgpCit7CiAgICAgc2V0VGltZW91dCgiZG9jdW1lbnQuZ2V0RWxlbWVu dHNCeVRhZ05hbWUoJ2lmcmFtZScpWzBdLnNyYyA9ICdhYm91dDpibGFuayciLCAxMDApOwogICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgIHNldFRpbWVvdXQoImxh eW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKSIsIDUwMCk7CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9zdG9yYWdlL2VtcHR5LXN0YXRlbWVudC5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS9lbXB0eS1zdGF0ZW1lbnQuaHRtbAppbmRleCBhZDc3YzNkLi4zNmVjNWI4IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9zdG9yYWdlL2VtcHR5LXN0YXRlbWVudC5odG1sCisrKyBiL0xheW91dFRl c3RzL3N0b3JhZ2UvZW1wdHktc3RhdGVtZW50Lmh0bWwKQEAgLTE2LDcgKzE2LDggQEAgZnVuY3Rp b24gZXhlY3V0ZUVtcHR5U3RhdGVtZW50KHRyYW5zYWN0aW9uKQogICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiB9CiAKLWZ1bmN0aW9uIHJ1blRlc3QoKSB7CitmdW5j dGlvbiBydW5UZXN0KCkKK3sKICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7 CiAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvc3RvcmFnZS9leGVjdXRlLXNxbC1hcmdzLmh0bWwgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2V4 ZWN1dGUtc3FsLWFyZ3MuaHRtbAppbmRleCBmOTQ4Mjc4Li44YjUwMWM2IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9zdG9yYWdlL2V4ZWN1dGUtc3FsLWFyZ3MuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9zdG9yYWdlL2V4ZWN1dGUtc3FsLWFyZ3MuaHRtbApAQCAtODgsNyArODgsOCBAQCBmdW5jdGlv biBydW5UcmFuc2FjdGlvblRlc3RzKHRyYW5zYWN0aW9uKQogICAgICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5ub3RpZnlEb25lKCk7CiB9CiAKLWZ1bmN0aW9uIHJ1blRlc3QoKSB7CitmdW5jdGlv biBydW5UZXN0KCkKK3sKICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv c3RvcmFnZS9xdW90YS10cmFja2luZy5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9xdW90YS10 cmFja2luZy5odG1sCmluZGV4IDczMGNjYjIuLmJhZjRlMjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3N0b3JhZ2UvcXVvdGEtdHJhY2tpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdl L3F1b3RhLXRyYWNraW5nLmh0bWwKQEAgLTUzLDcgKzUzLDggQEAgZnVuY3Rpb24gdGVzdERhdGFi YXNlKGRiKQogICAgIH0pOwogfQogCi1mdW5jdGlvbiBydW5UZXN0KCkgeworZnVuY3Rpb24gcnVu VGVzdCgpCit7CiAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5jbGVhckFsbERhdGFiYXNlcygpOwogICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wRGF0YWJhc2VDYWxsYmFja3MoKTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3N0b3JhZ2Uvc3VjY2Vzcy1jYWxsYmFjay5odG1sIGIvTGF5b3V0VGVzdHMvc3Rv cmFnZS9zdWNjZXNzLWNhbGxiYWNrLmh0bWwKaW5kZXggMmFjMTg5OC4uYzIzN2FiYSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9zdWNjZXNzLWNhbGxiYWNrLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvc3RvcmFnZS9zdWNjZXNzLWNhbGxiYWNrLmh0bWwKQEAgLTE0LDcgKzE0LDcgQEAg ZnVuY3Rpb24gZmluaXNoVGVzdCgpCiAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlm eURvbmUoKTsKIH0KIAotZnVuY3Rpb24gZXJyb3JGdW5jdGlvbih0eCwgZXJyb3IpCitmdW5jdGlv biBlcnJvckZ1bmN0aW9uKGVycm9yKQogewogICAgIGxvZygiVGVzdCBmYWlsZWQgLSAiICsgZXJy b3IubWVzc2FnZSk7CiAgICAgZmluaXNoVGVzdCgpOwpAQCAtMjksNyArMjksOCBAQCBmdW5jdGlv biBzdWNjZXNzRnVuY3Rpb24obWVzc2FnZSkKICAgICAgICAgZmluaXNoVGVzdCgpOwogfQogCi1m dW5jdGlvbiBydW5UZXN0KCkgeworZnVuY3Rpb24gcnVuVGVzdCgpCit7CiAgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5j bGVhckFsbERhdGFiYXNlcygpOwogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL3RyYW5zYWN0aW9uLWNhbGxi YWNrLWV4Y2VwdGlvbi1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS90cmFuc2FjdGlv bi1jYWxsYmFjay1leGNlcHRpb24tY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwLi40YmNjNzMyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS90cmFuc2FjdGlvbi1jYWxsYmFjay1leGNlcHRpb24tY3Jhc2guaHRtbApAQCAtMCwwICsxLDIw IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCit2YXIgZGIgPSBvcGVuRGF0 YWJhc2UoIjE1OTc2VGVzdCIsICIxLjAiLCAiVGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NzYiLCAxKTsKK2RiLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4 KSB7CisgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgIHdpbmRvdy5z ZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCkg fSwgMCk7CisgICB0aHJvdyAiVHJhbnNhY3Rpb25DYWxsYmFja0Vycm9yIjsKK30pOworPC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keT4KK0lmIFdlYktpdCBkb2Vzbid0IGNyYXNoLCB0aGlzIHRlc3Qg aGFzIHBhc3NlZAorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3Rv cmFnZS90cmFuc2FjdGlvbi1jYWxsYmFjay1leGNlcHRpb24tY3Jhc2gudHh0IGIvTGF5b3V0VGVz dHMvc3RvcmFnZS90cmFuc2FjdGlvbi1jYWxsYmFjay1leGNlcHRpb24tY3Jhc2gudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjBlMmViMzMKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9zdG9yYWdlL3RyYW5zYWN0aW9uLWNhbGxiYWNrLWV4Y2VwdGlvbi1jcmFz aC50eHQKQEAgLTAsMCArMSwyIEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMDogVHJhbnNhY3Rp b25DYWxsYmFja0Vycm9yCitJZiBXZWJLaXQgZG9lc24ndCBjcmFzaCwgdGhpcyB0ZXN0IGhhcyBw YXNzZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvdHJhbnNhY3Rpb25fY2FsbGJh Y2tfZXhjZXB0aW9uX2NyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvdHJh bnNhY3Rpb25fY2FsbGJhY2tfZXhjZXB0aW9uX2NyYXNoLWV4cGVjdGVkLnR4dApkZWxldGVkIGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMGUyZWIzMy4uMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9z dG9yYWdlL3RyYW5zYWN0aW9uX2NhbGxiYWNrX2V4Y2VwdGlvbl9jcmFzaC1leHBlY3RlZC50eHQK KysrIC9kZXYvbnVsbApAQCAtMSwyICswLDAgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAwOiBU cmFuc2FjdGlvbkNhbGxiYWNrRXJyb3IKLUlmIFdlYktpdCBkb2Vzbid0IGNyYXNoLCB0aGlzIHRl c3QgaGFzIHBhc3NlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS90cmFuc2FjdGlv bl9jYWxsYmFja19leGNlcHRpb25fY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvdHJh bnNhY3Rpb25fY2FsbGJhY2tfZXhjZXB0aW9uX2NyYXNoLmh0bWwKZGVsZXRlZCBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IGFlNjZiZWMuLjAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS90 cmFuc2FjdGlvbl9jYWxsYmFja19leGNlcHRpb25fY3Jhc2guaHRtbAorKysgL2Rldi9udWxsCkBA IC0xLDIwICswLDAgQEAKLTxodG1sPgotPGhlYWQ+Ci08c2NyaXB0PgotaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikgewotICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Ci19Ci0KLXZhciBk YiA9IG9wZW5EYXRhYmFzZSgiMTU5NzZUZXN0IiwgIjEuMCIsICJUZXN0IGZvciBodHRwOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk3NiIsIDEpOwotZGIudHJhbnNhY3Rpb24o ZnVuY3Rpb24odHgpIHsgCi0gICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAg ICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeyBsYXlvdXRUZXN0Q29udHJvbGxlci5u b3RpZnlEb25lKCkgfSwgMCk7Ci0gICB0aHJvdyAiVHJhbnNhY3Rpb25DYWxsYmFja0Vycm9yIjsK LX0pOwotPC9zY3JpcHQ+Ci08L2hlYWQ+Ci08Ym9keT4KLUlmIFdlYktpdCBkb2Vzbid0IGNyYXNo LCB0aGlzIHRlc3QgaGFzIHBhc3NlZAotPC9ib2R5PgotPC9odG1sPgo=