236541 2022-02-12 10:07:56 -0800 `Array#{ groupBy, groupByToMap }` should throw a `TypeError` when `this` is `null` or `undefined` 2022-02-14 16:16:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235549 InRadar P2 Normal --- 1 zloirock ysuzuki ashvayka ews-watchlist joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1840708 0 zloirock 2022-02-12 10:07:56 -0800 (tested in playwright) Array.prototype.groupBy.call(null, () => { /* empty */ }) // should be a TypeError Array.prototype.groupByToMap.call(null, () => { /* empty */ }) // should be a TypeError 1841286 1 ashvayka 2022-02-14 09:31:55 -0800 (In reply to zloirock from comment #0) > (tested in playwright) > > Array.prototype.groupBy.call(null, () => { /* empty */ }) // should be a > TypeError > Array.prototype.groupByToMap.call(null, () => { /* empty */ }) // should be > a TypeError Wow, that's a nice catch, thank you. We've missed "use strict". 1841289 2 451916 ysuzuki 2022-02-14 09:42:33 -0800 Created attachment 451916 Patch 1841291 3 451916 ashvayka 2022-02-14 09:45:08 -0800 Comment on attachment 451916 Patch I wish we could mandate "use strict" for built-ins with exception of Reflect.has, which we need to be sloppy mode JS built-in for inlining + caching. 1841468 4 ews-feeder 2022-02-14 16:15:42 -0800 Committed r289780 (247248@main): <https://commits.webkit.org/247248@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451916. 1841469 5 webkit-bug-importer 2022-02-14 16:16:18 -0800 <rdar://problem/88934440> 451916 2022-02-14 09:42:33 -0800 2022-02-14 16:15:45 -0800 Patch bug-236541-20220214094233.patch text/plain 4015 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YjhiNGQyZGJkYzZiOWZlOWJhZTE1NjY0ODUwMGRkNDYyZjg4NDMyLi5jNjMzN2IxOTA1MjU2NWE4 YTczMjg5ODQzYWJjMzAyYmJiZGZhMzZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMi0wMi0xNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIGBBcnJheSN7IGdyb3VwQnksIGdyb3VwQnlUb01hcCB9YCBzaG91bGQgdGhy b3cgYSBgVHlwZUVycm9yYCB3aGVuIGB0aGlzYCBpcyBgbnVsbGAgb3IgYHVuZGVmaW5lZGAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjU0MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIHdlIGFy ZSBjb3JyZWN0bHkgdXNpbmcgQHRvT2JqZWN0LCB0aGVzZSBmdW5jdGlvbnMgbWlzc2VkICJ1c2Ug c3RyaWN0Iiwgd2hpY2ggZW5mb3JjZXMgYSBmdW5jdGlvbgorICAgICAgICB0byBjaGFuZ2UgYSBu b24gb2JqZWN0IHx0aGlzfCB0byBhbiBvYmplY3QgKGluIHRoaXMgY2FzZSwgZ2xvYmFsIG9iamVj dCkuIFRoaXMgcGF0Y2ggYWRkcyAidXNlIHN0cmljdCIsCisgICAgICAgIHRvIG1ha2UgdGhlc2Ug ZnVuY3Rpb24gc3RyaWN0IGNvZGUuCisKKyAgICAgICAgKiBidWlsdGlucy9BcnJheVByb3RvdHlw ZS5qczoKKyAgICAgICAgKGdyb3VwQnkpOgorICAgICAgICAoZ3JvdXBCeVRvTWFwKToKKwogMjAy Mi0wMi0xMyAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCBub24tdW5pZmllZCBidWlsZCBmaXhlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J1aWx0aW5zL0FycmF5UHJvdG90eXBlLmpzIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2J1aWx0aW5zL0FycmF5UHJvdG90eXBlLmpzCmluZGV4IDI3NjhkMTQwMTc4MGU0YjUzMzM2 MzMzNGFjZmIxYTgyNjUzZTllMTQuLjMzMDdhNmRjMmQ0YmJjYWM0MGIwNjdlNmVlZDgwZWU1YjJj ZTdjMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9BcnJheVBy b3RvdHlwZS5qcworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlQcm90 b3R5cGUuanMKQEAgLTE1OCw2ICsxNTgsOCBAQCBmdW5jdGlvbiBmaWx0ZXIoY2FsbGJhY2sgLyos IHRoaXNBcmcgKi8pCiAKIGZ1bmN0aW9uIGdyb3VwQnkoY2FsbGJhY2sgLyosIHRoaXNBcmcgKi8p CiB7CisgICAgInVzZSBzdHJpY3QiOworCiAgICAgdmFyIGFycmF5ID0gQHRvT2JqZWN0KHRoaXMs ICJBcnJheS5wcm90b3R5cGUuZ3JvdXBCeSByZXF1aXJlcyB0aGF0IHx0aGlzfCBub3QgYmUgbnVs bCBvciB1bmRlZmluZWQiKTsKICAgICB2YXIgbGVuZ3RoID0gQHRvTGVuZ3RoKGFycmF5Lmxlbmd0 aCk7CiAKQEAgLTE4Miw2ICsxODQsOCBAQCBmdW5jdGlvbiBncm91cEJ5KGNhbGxiYWNrIC8qLCB0 aGlzQXJnICovKQogCiBmdW5jdGlvbiBncm91cEJ5VG9NYXAoY2FsbGJhY2sgLyosIHRoaXNBcmcg Ki8pCiB7CisgICAgInVzZSBzdHJpY3QiOworCiAgICAgdmFyIGFycmF5ID0gQHRvT2JqZWN0KHRo aXMsICJBcnJheS5wcm90b3R5cGUuZ3JvdXBCeVRvTWFwIHJlcXVpcmVzIHRoYXQgfHRoaXN8IG5v dCBiZSBudWxsIG9yIHVuZGVmaW5lZCIpOwogICAgIHZhciBsZW5ndGggPSBAdG9MZW5ndGgoYXJy YXkubGVuZ3RoKTsKIApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0No YW5nZUxvZwppbmRleCBjMzgxZjZiY2M0ZGIwZTgzMDE0Y2QzZGIxZDllOTg3N2ZmNThkNzA2Li40 ZjcwYTg5ZGU5YmUzYTg4Yjc4ZTM5MWE5OGQyMWFiMzg5ODNiM2YwIDEwMDY0NAotLS0gYS9KU1Rl c3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy MDIyLTAyLTE0ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAg YEFycmF5I3sgZ3JvdXBCeSwgZ3JvdXBCeVRvTWFwIH1gIHNob3VsZCB0aHJvdyBhIGBUeXBlRXJy b3JgIHdoZW4gYHRoaXNgIGlzIGBudWxsYCBvciBgdW5kZWZpbmVkYAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NTQxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvYXJyYXktZ3JvdXAtYnkt bnVsbC1vci11bmRlZmluZWQuanM6IEFkZGVkLgorICAgICAgICAoc2hvdWxkVGhyb3cpOgorCiAy MDIyLTAyLTA5ICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFNraXAgZmFpbGluZyBzaGFkb3cgcmVhbG1zIHRlc3RzIG9uIE1JUFMKZGlmZiAt LWdpdCBhL0pTVGVzdHMvc3RyZXNzL2FycmF5LWdyb3VwLWJ5LW51bGwtb3ItdW5kZWZpbmVkLmpz IGIvSlNUZXN0cy9zdHJlc3MvYXJyYXktZ3JvdXAtYnktbnVsbC1vci11bmRlZmluZWQuanMKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uZGI0Y2IyMTM3ZWJkY2UwNTBmMzYyMjNhNjM4M2JhNzc4MjU4NDE3YQotLS0gL2Rl di9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL2FycmF5LWdyb3VwLWJ5LW51bGwtb3ItdW5kZWZp bmVkLmpzCkBAIC0wLDAgKzEsMzAgQEAKKy8vQCByZXF1aXJlT3B0aW9ucygiLS11c2VBcnJheUdy b3VwQnlNZXRob2Q9MSIpCisKK2Z1bmN0aW9uIHNob3VsZFRocm93KGZ1bmMsIGVycm9yTWVzc2Fn ZSkgeworICAgIHZhciBlcnJvclRocm93biA9IGZhbHNlOworICAgIHZhciBlcnJvciA9IG51bGw7 CisgICAgdHJ5IHsKKyAgICAgICAgZnVuYygpOworICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAg ZXJyb3JUaHJvd24gPSB0cnVlOworICAgICAgICBlcnJvciA9IGU7CisgICAgfQorICAgIGlmICgh ZXJyb3JUaHJvd24pCisgICAgICAgIHRocm93IG5ldyBFcnJvcignbm90IHRocm93bicpOworICAg IGlmIChTdHJpbmcoZXJyb3IpICE9PSBlcnJvck1lc3NhZ2UpCisgICAgICAgIHRocm93IG5ldyBF cnJvcihgYmFkIGVycm9yOiAke1N0cmluZyhlcnJvcil9YCk7Cit9CisKK3Nob3VsZFRocm93KCgp ID0+IHsKKyAgICBBcnJheS5wcm90b3R5cGUuZ3JvdXBCeS5jYWxsKG51bGwsICgpID0+IHsgLyog ZW1wdHkgKi8gfSkKK30sIGBUeXBlRXJyb3I6IEFycmF5LnByb3RvdHlwZS5ncm91cEJ5IHJlcXVp cmVzIHRoYXQgfHRoaXN8IG5vdCBiZSBudWxsIG9yIHVuZGVmaW5lZGApOworc2hvdWxkVGhyb3co KCkgPT4geworICAgIEFycmF5LnByb3RvdHlwZS5ncm91cEJ5LmNhbGwodW5kZWZpbmVkLCAoKSA9 PiB7IC8qIGVtcHR5ICovIH0pCit9LCBgVHlwZUVycm9yOiBBcnJheS5wcm90b3R5cGUuZ3JvdXBC eSByZXF1aXJlcyB0aGF0IHx0aGlzfCBub3QgYmUgbnVsbCBvciB1bmRlZmluZWRgKTsKKworc2hv dWxkVGhyb3coKCkgPT4geworICAgIEFycmF5LnByb3RvdHlwZS5ncm91cEJ5VG9NYXAuY2FsbChu dWxsLCAoKSA9PiB7IC8qIGVtcHR5ICovIH0pCit9LCBgVHlwZUVycm9yOiBBcnJheS5wcm90b3R5 cGUuZ3JvdXBCeVRvTWFwIHJlcXVpcmVzIHRoYXQgfHRoaXN8IG5vdCBiZSBudWxsIG9yIHVuZGVm aW5lZGApOworc2hvdWxkVGhyb3coKCkgPT4geworICAgIEFycmF5LnByb3RvdHlwZS5ncm91cEJ5 VG9NYXAuY2FsbCh1bmRlZmluZWQsICgpID0+IHsgLyogZW1wdHkgKi8gfSkKK30sIGBUeXBlRXJy b3I6IEFycmF5LnByb3RvdHlwZS5ncm91cEJ5VG9NYXAgcmVxdWlyZXMgdGhhdCB8dGhpc3wgbm90 IGJlIG51bGwgb3IgdW5kZWZpbmVkYCk7Cg==