236538 2022-02-12 05:02:29 -0800 [LFC][Integration] Take writing mode value into account setting vertical margin 2022-02-13 06:40:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1840677 0 zalan 2022-02-12 05:02:29 -0800 ssia 1840678 1 451782 zalan 2022-02-12 05:05:39 -0800 Created attachment 451782 Patch 1840984 2 ews-feeder 2022-02-13 06:39:42 -0800 Committed r289707 (247192@main): <https://commits.webkit.org/247192@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451782. 1840985 3 webkit-bug-importer 2022-02-13 06:40:16 -0800 <rdar://problem/88871876> 451782 2022-02-12 05:05:39 -0800 2022-02-13 06:39:43 -0800 Patch bug-236538-20220212050538.patch text/plain 5356 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRhYzQ3ZjU2YzVlZTQ5 ODdlZTZmNjdhZTRlMTg5MjcxOWUzY2FiNi4uMTM1OTk2MzlkN2Y0ZDI3Njg5YTZjOWJiMmJiMDEz MmJlOTU5NWE3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAyLTEyICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0g VGFrZSB3cml0aW5nIG1vZGUgdmFsdWUgaW50byBhY2NvdW50IHNldHRpbmcgdmVydGljYWwgbWFy Z2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY1 MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaW5l IGxheW91dCB3b3JrcyB3aXRoIGxvZ2ljYWwgdmFsdWVzLgorCisgICAgICAgICogbGF5b3V0L2lu dGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6aG9yaXpvbnRhbExvZ2ljYWxNYXJnaW4pOgorICAgICAg ICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246OnZlcnRpY2FsTG9naWNhbE1hcmdpbik6Cisg ICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6TGluZUxheW91dDo6dXBkYXRlTGF5 b3V0Qm94RGltZW5zaW9ucyk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6 TGluZUxheW91dDo6dXBkYXRlSW5saW5lQm94RGltZW5zaW9ucyk6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXRJbnRlZ3JhdGlvbjo6bG9naWNhbE1hcmdpbik6IERlbGV0ZWQuCisKIDIwMjItMDIt MTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtDU1MgQ29u dGFpbmVyIFF1ZXJpZXNdIEltcGxlbWVudCBjb250YWluZXIgbmFtZSBtYXRjaGluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9u TGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0 SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcAppbmRleCBjN2EyNGI4ODVlNDlhNzhjZWVjOTg4OWZl YWM4ZTEzYmIxODFiZmZmLi41YzU2NjBjNGYyODg0MjUyMjQ5N2QxNTJlNmNlMTI3ZDFkZGRiZTZl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50 ZWdyYXRpb25MaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdy YXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcApAQCAtMTU4LDcgKzE1OCw3IEBA IHN0YXRpYyBpbmxpbmUgTGF5b3V0VW5pdCBjb250ZW50TG9naWNhbEhlaWdodEZvclJlbmRlcmVy KGNvbnN0IFJlbmRlckJveCYgcmVuZGVyCiAgICAgcmV0dXJuIHJlbmRlcmVyLnBhcmVudCgpLT5z dHlsZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgPyByZW5kZXJlci5jb250ZW50SGVpZ2h0 KCkgOiByZW5kZXJlci5jb250ZW50V2lkdGgoKTsKIH0KIAotc3RhdGljIGlubGluZSBMYXlvdXQ6 OkJveEdlb21ldHJ5OjpIb3Jpem9udGFsTWFyZ2luIGxvZ2ljYWxNYXJnaW4oY29uc3QgUmVuZGVy Qm94TW9kZWxPYmplY3QmIHJlbmRlcmVyLCBib29sIGlzTGVmdFRvUmlnaHREaXJlY3Rpb24sIGJv b2wgaXNIb3Jpem9udGFsV3JpdGluZ01vZGUsIGJvb2wgcmV0YWluTWFyZ2luU3RhcnQgPSB0cnVl LCBib29sIHJldGFpbk1hcmdpbkVuZCA9IHRydWUpCitzdGF0aWMgaW5saW5lIExheW91dDo6Qm94 R2VvbWV0cnk6Okhvcml6b250YWxNYXJnaW4gaG9yaXpvbnRhbExvZ2ljYWxNYXJnaW4oY29uc3Qg UmVuZGVyQm94TW9kZWxPYmplY3QmIHJlbmRlcmVyLCBib29sIGlzTGVmdFRvUmlnaHREaXJlY3Rp b24sIGJvb2wgaXNIb3Jpem9udGFsV3JpdGluZ01vZGUsIGJvb2wgcmV0YWluTWFyZ2luU3RhcnQg PSB0cnVlLCBib29sIHJldGFpbk1hcmdpbkVuZCA9IHRydWUpCiB7CiAgICAgYXV0byBtYXJnaW5M ZWZ0ID0gcmVuZGVyZXIubWFyZ2luTGVmdCgpOwogICAgIGF1dG8gbWFyZ2luUmlnaHQgPSByZW5k ZXJlci5tYXJnaW5SaWdodCgpOwpAQCAtMTc1LDYgKzE3NSwxMyBAQCBzdGF0aWMgaW5saW5lIExh eW91dDo6Qm94R2VvbWV0cnk6Okhvcml6b250YWxNYXJnaW4gbG9naWNhbE1hcmdpbihjb25zdCBS ZW5kZXJCbwogICAgIHJldHVybiB7IHJldGFpbk1hcmdpblN0YXJ0ID8gbWFyZ2luQm90dG9tIDog MF9sdSwgcmV0YWluTWFyZ2luRW5kID8gbWFyZ2luVG9wIDogMF9sdSB9OwogfQogCitzdGF0aWMg aW5saW5lIExheW91dDo6Qm94R2VvbWV0cnk6OlZlcnRpY2FsTWFyZ2luIHZlcnRpY2FsTG9naWNh bE1hcmdpbihjb25zdCBSZW5kZXJCb3hNb2RlbE9iamVjdCYgcmVuZGVyZXIsIGJvb2wgaXNIb3Jp em9udGFsV3JpdGluZ01vZGUpCit7CisgICAgaWYgKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKQor ICAgICAgICByZXR1cm4geyByZW5kZXJlci5tYXJnaW5Ub3AoKSwgcmVuZGVyZXIubWFyZ2luQm90 dG9tKCkgfTsKKyAgICByZXR1cm4geyByZW5kZXJlci5tYXJnaW5SaWdodCgpLCByZW5kZXJlci5t YXJnaW5MZWZ0KCkgfTsKK30KKwogc3RhdGljIGlubGluZSBMYXlvdXQ6OkVkZ2VzIGxvZ2ljYWxC b3JkZXIoY29uc3QgUmVuZGVyQm94TW9kZWxPYmplY3QmIHJlbmRlcmVyLCBib29sIGlzTGVmdFRv UmlnaHREaXJlY3Rpb24sIGJvb2wgaXNIb3Jpem9udGFsV3JpdGluZ01vZGUsIGJvb2wgcmV0YWlu Qm9yZGVyU3RhcnQgPSB0cnVlLCBib29sIHJldGFpbkJvcmRlckVuZCA9IHRydWUpCiB7CiAgICAg YXV0byBib3JkZXJMZWZ0ID0gcmVuZGVyZXIuYm9yZGVyTGVmdCgpOwpAQCAtMjMwLDExICsyMzcs MTEgQEAgdm9pZCBMaW5lTGF5b3V0Ojp1cGRhdGVMYXlvdXRCb3hEaW1lbnNpb25zKGNvbnN0IFJl bmRlckJveCYgcmVwbGFjZWRPcklubGluZUJsb2MKICAgICByZXBsYWNlZEJveEdlb21ldHJ5LnNl dENvbnRlbnRCb3hXaWR0aChjb250ZW50TG9naWNhbFdpZHRoRm9yUmVuZGVyZXIocmVwbGFjZWRP cklubGluZUJsb2NrKSk7CiAgICAgcmVwbGFjZWRCb3hHZW9tZXRyeS5zZXRDb250ZW50Qm94SGVp Z2h0KGNvbnRlbnRMb2dpY2FsSGVpZ2h0Rm9yUmVuZGVyZXIocmVwbGFjZWRPcklubGluZUJsb2Nr KSk7CiAKLSAgICByZXBsYWNlZEJveEdlb21ldHJ5LnNldFZlcnRpY2FsTWFyZ2luKHsgcmVwbGFj ZWRPcklubGluZUJsb2NrLm1hcmdpblRvcCgpLCByZXBsYWNlZE9ySW5saW5lQmxvY2subWFyZ2lu Qm90dG9tKCkgfSk7CiAgICAgYXV0byBpc0xlZnRUb1JpZ2h0RGlyZWN0aW9uID0gcmVwbGFjZWRP cklubGluZUJsb2NrLnBhcmVudCgpLT5zdHlsZSgpLmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKTsK ICAgICBhdXRvIGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlID0gcmVwbGFjZWRPcklubGluZUJsb2Nr LnBhcmVudCgpLT5zdHlsZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCk7CiAKLSAgICByZXBs YWNlZEJveEdlb21ldHJ5LnNldEhvcml6b250YWxNYXJnaW4obG9naWNhbE1hcmdpbihyZXBsYWNl ZE9ySW5saW5lQmxvY2ssIGlzTGVmdFRvUmlnaHREaXJlY3Rpb24sIGlzSG9yaXpvbnRhbFdyaXRp bmdNb2RlKSk7CisgICAgcmVwbGFjZWRCb3hHZW9tZXRyeS5zZXRWZXJ0aWNhbE1hcmdpbih2ZXJ0 aWNhbExvZ2ljYWxNYXJnaW4ocmVwbGFjZWRPcklubGluZUJsb2NrLCBpc0hvcml6b250YWxXcml0 aW5nTW9kZSkpOworICAgIHJlcGxhY2VkQm94R2VvbWV0cnkuc2V0SG9yaXpvbnRhbE1hcmdpbiho b3Jpem9udGFsTG9naWNhbE1hcmdpbihyZXBsYWNlZE9ySW5saW5lQmxvY2ssIGlzTGVmdFRvUmln aHREaXJlY3Rpb24sIGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKSk7CiAgICAgcmVwbGFjZWRCb3hH ZW9tZXRyeS5zZXRCb3JkZXIobG9naWNhbEJvcmRlcihyZXBsYWNlZE9ySW5saW5lQmxvY2ssIGlz TGVmdFRvUmlnaHREaXJlY3Rpb24sIGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKSk7CiAgICAgcmVw bGFjZWRCb3hHZW9tZXRyeS5zZXRQYWRkaW5nKGxvZ2ljYWxQYWRkaW5nKHJlcGxhY2VkT3JJbmxp bmVCbG9jaywgaXNMZWZ0VG9SaWdodERpcmVjdGlvbiwgaXNIb3Jpem9udGFsV3JpdGluZ01vZGUp KTsKIApAQCAtMjY2LDcgKzI3Myw3IEBAIHZvaWQgTGluZUxheW91dDo6dXBkYXRlSW5saW5lQm94 RGltZW5zaW9ucyhjb25zdCBSZW5kZXJJbmxpbmUmIHJlbmRlcklubGluZSkKICAgICBhdXRvIGlz TGVmdFRvUmlnaHREaXJlY3Rpb24gPSByZW5kZXJJbmxpbmUuc3R5bGUoKS5pc0xlZnRUb1JpZ2h0 RGlyZWN0aW9uKCk7CiAgICAgYXV0byBpc0hvcml6b250YWxXcml0aW5nTW9kZSA9IHJlbmRlcklu bGluZS5zdHlsZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCk7CiAKLSAgICBib3hHZW9tZXRy eS5zZXRIb3Jpem9udGFsTWFyZ2luKGxvZ2ljYWxNYXJnaW4ocmVuZGVySW5saW5lLCBpc0xlZnRU b1JpZ2h0RGlyZWN0aW9uLCBpc0hvcml6b250YWxXcml0aW5nTW9kZSwgIXNob3VsZE5vdFJldGFp bkJvcmRlclBhZGRpbmdBbmRNYXJnaW5TdGFydCwgIXNob3VsZE5vdFJldGFpbkJvcmRlclBhZGRp bmdBbmRNYXJnaW5FbmQpKTsKKyAgICBib3hHZW9tZXRyeS5zZXRIb3Jpem9udGFsTWFyZ2luKGhv cml6b250YWxMb2dpY2FsTWFyZ2luKHJlbmRlcklubGluZSwgaXNMZWZ0VG9SaWdodERpcmVjdGlv biwgaXNIb3Jpem9udGFsV3JpdGluZ01vZGUsICFzaG91bGROb3RSZXRhaW5Cb3JkZXJQYWRkaW5n QW5kTWFyZ2luU3RhcnQsICFzaG91bGROb3RSZXRhaW5Cb3JkZXJQYWRkaW5nQW5kTWFyZ2luRW5k KSk7CiAgICAgYm94R2VvbWV0cnkuc2V0Qm9yZGVyKGxvZ2ljYWxCb3JkZXIocmVuZGVySW5saW5l LCBpc0xlZnRUb1JpZ2h0RGlyZWN0aW9uLCBpc0hvcml6b250YWxXcml0aW5nTW9kZSwgIXNob3Vs ZE5vdFJldGFpbkJvcmRlclBhZGRpbmdBbmRNYXJnaW5TdGFydCwgIXNob3VsZE5vdFJldGFpbkJv cmRlclBhZGRpbmdBbmRNYXJnaW5FbmQpKTsKICAgICBib3hHZW9tZXRyeS5zZXRQYWRkaW5nKGxv Z2ljYWxQYWRkaW5nKHJlbmRlcklubGluZSwgaXNMZWZ0VG9SaWdodERpcmVjdGlvbiwgaXNIb3Jp em9udGFsV3JpdGluZ01vZGUsICFzaG91bGROb3RSZXRhaW5Cb3JkZXJQYWRkaW5nQW5kTWFyZ2lu U3RhcnQsICFzaG91bGROb3RSZXRhaW5Cb3JkZXJQYWRkaW5nQW5kTWFyZ2luRW5kKSk7CiB9Cg==