236528 2022-02-11 14:46:59 -0800 [run-webkit-tests] Do not try and read from /dev/null 2022-02-12 18:05:54 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230513 InRadar P2 Normal --- 1 jbedard jbedard ap ashvayka dewei_zhu ews-watchlist glenn slewis webkit-bug-importer ysuzuki oldest_to_newest 1840569 0 jbedard 2022-02-11 14:46:59 -0800 We should not try to read from /dev/null. While some distributions define this behavior well, Darwin, notably, does not. Use PIPE instead. 1840571 1 webkit-bug-importer 2022-02-11 14:48:13 -0800 <rdar://problem/88836868> 1840573 2 jbedard 2022-02-11 14:50:01 -0800 Stumbled into this when investigating https://bugs.webkit.org/show_bug.cgi?id=230513. This change isn't implicated in that bug, but we should still fix this. 1840575 3 451749 jbedard 2022-02-11 14:51:53 -0800 Created attachment 451749 Patch 1840608 4 451749 ap 2022-02-11 16:09:48 -0800 Comment on attachment 451749 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451749&action=review > Tools/ChangeLog:9 > + While writing to /dev/null is well defined, reading from it is not. Do not I didn't know this. What is the source of this information? That said, the patch removes more code than it adds, and webkitpy tests pass, so it's good. 1840617 5 jbedard 2022-02-11 16:45:42 -0800 Man page for 'null': NAME null – the null device DESCRIPTION The null device accepts and reads data as any ordinary (and willing) file - but throws it away. The length of the null device is always zero. FILES /dev/null HISTORY A null device appeared in Version 7 AT&T UNIX. Notably, says nothing about what happens if you try and read from this file. 1840749 6 ews-feeder 2022-02-12 17:19:59 -0800 Committed r289703 (247188@main): <https://commits.webkit.org/247188@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451749. 1840756 7 ap 2022-02-12 18:05:54 -0800 Reading from /dev/null is standardized, https://pubs.opengroup.org/onlinepubs/9699919799/ 451749 2022-02-11 14:51:53 -0800 2022-02-12 17:20:00 -0800 Patch bug-236528-20220211145152.patch text/plain 3182 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzcxYTkwMzVkZjg4ODA0YWU3NTVmNTNkMjg1MjQwYjgx NjM2MjhjOC4uMGQzNjE3NmRjOTgzZTIyNGY0ZGUxNWFjMDlmMjM0NWJmMmM0Yzk0NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIyLTAyLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbcnVuLXdlYmtpdC10ZXN0c10gRG8gbm90IHRyeSBhbmQgcmVhZCBmcm9tIC9kZXYv bnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2 NTI4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODgzNjg2OD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGlsZSB3cml0aW5nIHRvIC9kZXYvbnVs bCBpcyB3ZWxsIGRlZmluZWQsIHJlYWRpbmcgZnJvbSBpdCBpcyBub3QuIERvIG5vdAorICAgICAg ICByZWFkIGZyb20gL2Rldi9udWxsLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvc2VydmVycy93ZWJzb2NrZXRfc2VydmVyLnB5OgorICAgICAgICAoUHlXZWJTb2Nr ZXQuX19pbml0X18pOiBEZWxldGUgX3dzaW4uCisgICAgICAgIChQeVdlYlNvY2tldC5fcHJlcGFy ZV9jb25maWcpOiBEaXR0by4KKyAgICAgICAgKFB5V2ViU29ja2V0Ll9zcGF3bl9wcm9jZXNzKTog VXNlIGV4ZWN1dGl2ZS5QSVBFIGluc3RlYWQgb2Ygb3MuZGV2bnVsbC4KKyAgICAgICAgKFB5V2Vi U29ja2V0Ll9zdG9wX3J1bm5pbmdfc2VydmVyKTogRGVsZXRlIF93c2luLgorCiAyMDIyLTAyLTAy ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbZ2l0LXdl YmtpdF0gSGFuZGxlIGxvY2FsIGNvbW1pdCBvbiBwcm9kdWN0aW9uIGJyYW5jaApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVycy93ZWJzb2NrZXRf c2VydmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVycy93 ZWJzb2NrZXRfc2VydmVyLnB5CmluZGV4IGI0ZTMxMDhkYjM2MWQ3ZmI3Y2Y1ZjA5MjY0NTBkMjJj MzY5YmEzOGMuLjg3ZDJlODViNGE2OTRlMjU0NGQ0NDVlNWY5MmIxY2U0NzQxNDliMGYgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvd2Vic29j a2V0X3NlcnZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9z ZXJ2ZXJzL3dlYnNvY2tldF9zZXJ2ZXIucHkKQEAgLTc5LDcgKzc5LDYgQEAgY2xhc3MgUHlXZWJT b2NrZXQoaHR0cF9zZXJ2ZXIuTGlnaHR0cGQpOgogICAgICAgICBzZWxmLl9jYV9jZXJ0aWZpY2F0 ZSA9IGNhX2NlcnRpZmljYXRlCiAgICAgICAgIGlmIHNlbGYuX3BvcnQ6CiAgICAgICAgICAgICBz ZWxmLl9wb3J0ID0gaW50KHNlbGYuX3BvcnQpCi0gICAgICAgIHNlbGYuX3dzaW4gPSBOb25lCiAg ICAgICAgIHNlbGYuX3dzb3V0ID0gTm9uZQogICAgICAgICBzZWxmLl9tYXBwaW5ncyA9IFt7J3Bv cnQnOiBzZWxmLl9wb3J0fV0KIApAQCAtMTExLDkgKzExMCw2IEBAIGNsYXNzIFB5V2ViU29ja2V0 KGh0dHBfc2VydmVyLkxpZ2h0dHBkKToKICAgICBkZWYgX3ByZXBhcmVfY29uZmlnKHNlbGYpOgog ICAgICAgICBzZWxmLl9maWxlc3lzdGVtLm1heWJlX21ha2VfZGlyZWN0b3J5KHNlbGYuX291dHB1 dF9kaXIpCiAgICAgICAgIGxvZ19maWxlX25hbWUgPSBzZWxmLl9sb2dfcHJlZml4Ci0gICAgICAg ICMgRklYTUU6IERvZXNuJ3QgRXhlY3V0aXZlIGhhdmUgYSBkZXZudWxsLCBzbyB0aGF0IHdlIGRv bid0IGhhdmUgdG8gdXNlIG9zLmRldm51bGwgZGlyZWN0bHk/Ci0gICAgICAgIHNlbGYuX3dzaW4g PSBvcGVuKG9zLmRldm51bGwsICdyJykKLQogICAgICAgICBlcnJvcl9sb2cgPSBzZWxmLl9maWxl c3lzdGVtLmpvaW4oc2VsZi5fb3V0cHV0X2RpciwgbG9nX2ZpbGVfbmFtZSArICItZXJyLnR4dCIp CiAgICAgICAgIG91dHB1dF9sb2cgPSBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5fb3V0cHV0 X2RpciwgbG9nX2ZpbGVfbmFtZSArICItb3V0LnR4dCIpCiAgICAgICAgIHNlbGYuX3dzb3V0ID0g c2VsZi5fZmlsZXN5c3RlbS5vcGVuX3RleHRfZmlsZV9mb3Jfd3JpdGluZyhvdXRwdXRfbG9nKQpA QCAtMTY2LDE2ICsxNjIsMTMgQEAgY2xhc3MgUHlXZWJTb2NrZXQoaHR0cF9zZXJ2ZXIuTGlnaHR0 cGQpOgogCiAgICAgZGVmIF9zcGF3bl9wcm9jZXNzKHNlbGYpOgogICAgICAgICBfbG9nLmRlYnVn KCdTdGFydGluZyAlcyBzZXJ2ZXIsIGNtZD0iJXMiJyAlIChzZWxmLl9uYW1lLCBzZWxmLl9zdGFy dF9jbWQpKQotICAgICAgICBzZWxmLl9wcm9jZXNzID0gc2VsZi5fZXhlY3V0aXZlLnBvcGVuKHNl bGYuX3N0YXJ0X2NtZCwgZW52PXNlbGYuX2Vudiwgc2hlbGw9RmFsc2UsIHN0ZGluPXNlbGYuX3dz aW4sIHN0ZG91dD1zZWxmLl93c291dCwgc3RkZXJyPXNlbGYuX2V4ZWN1dGl2ZS5TVERPVVQpCisg ICAgICAgIHNlbGYuX3Byb2Nlc3MgPSBzZWxmLl9leGVjdXRpdmUucG9wZW4oc2VsZi5fc3RhcnRf Y21kLCBlbnY9c2VsZi5fZW52LCBzaGVsbD1GYWxzZSwgc3RkaW49c2VsZi5fZXhlY3V0aXZlLlBJ UEUsIHN0ZG91dD1zZWxmLl93c291dCwgc3RkZXJyPXNlbGYuX2V4ZWN1dGl2ZS5TVERPVVQpCiAg ICAgICAgIHNlbGYuX2ZpbGVzeXN0ZW0ud3JpdGVfdGV4dF9maWxlKHNlbGYuX3BpZF9maWxlLCBz dHIoc2VsZi5fcHJvY2Vzcy5waWQpKQogICAgICAgICByZXR1cm4gc2VsZi5fcHJvY2Vzcy5waWQK IAogICAgIGRlZiBfc3RvcF9ydW5uaW5nX3NlcnZlcihzZWxmKToKICAgICAgICAgc3VwZXIoUHlX ZWJTb2NrZXQsIHNlbGYpLl9zdG9wX3J1bm5pbmdfc2VydmVyKCkKIAotICAgICAgICBpZiBzZWxm Ll93c2luOgotICAgICAgICAgICAgc2VsZi5fd3Npbi5jbG9zZSgpCi0gICAgICAgICAgICBzZWxm Ll93c2luID0gTm9uZQogICAgICAgICBpZiBzZWxmLl93c291dDoKICAgICAgICAgICAgIHNlbGYu X3dzb3V0LmNsb3NlKCkKICAgICAgICAgICAgIHNlbGYuX3dzb3V0ID0gTm9uZQo=