236514 2022-02-11 09:53:54 -0800 Skip positioned object and line break boxes as they have no affect on width 2022-02-15 16:01:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 brandonstewart mmaxfield bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1840414 0 brandonstewart 2022-02-11 09:53:54 -0800 <rdar://88491516> 1840419 1 451716 brandonstewart 2022-02-11 09:57:23 -0800 Created attachment 451716 Patch 1840609 2 451716 mmaxfield 2022-02-11 16:10:36 -0800 Comment on attachment 451716 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451716&action=review > Source/WebCore/rendering/LegacyLineLayout.cpp:571 > + for (auto* leafChild = rootBox.firstLeafDescendant(); leafChild && i < expansionOpportunities.size(); leafChild = leafChild->nextLeafOnLine()) { I think this is a band-aid fix. It's not harmful, but it doesn't solve the underlying problem that the invariant is being violated. (The invariant is expansionOpportunities.size() == number of leaves on line.) 1840632 3 mmaxfield 2022-02-11 17:34:36 -0800 The bidi runs are: 1. U+0600 2. U+2E80 3. A ruby run expansionOpportunities.size() is 2, however. 1840640 4 mmaxfield 2022-02-11 17:56:15 -0800 Whoops, that's wrong. The first time LegacyLineLayout::computeExpansionForJustifiedText() is called, the runs are: 1. U+0600 2. U+2E80 The second time it's called, the runs are: 1. \n 2. ruby run. Inside this run, the first root box has 2 leaves on the line. 1840641 5 mmaxfield 2022-02-11 18:00:38 -0800 Regarding the second time, both expansion opportunities appended to expansionOpportunities are regarding the insides of the ruby run. For some reason, the previous \n run didn't seem to append anything to expansionOpportunities. 1840647 6 451767 mmaxfield 2022-02-11 18:20:10 -0800 Created attachment 451767 Root cause fix 1841876 7 452073 brandonstewart 2022-02-15 12:35:44 -0800 Created attachment 452073 Patch 1841879 8 452073 mmaxfield 2022-02-15 12:38:20 -0800 Comment on attachment 452073 Patch r=me assuming there is a test somewhere 1841995 9 ews-feeder 2022-02-15 16:00:55 -0800 Committed r289859 (247300@main): <https://commits.webkit.org/247300@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452073. 451716 2022-02-11 09:57:23 -0800 2022-02-15 12:35:40 -0800 Patch bug-236514-20220211095722.patch text/plain 2080 brandonstewart U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGMxZmY5ZGYxZGJmYzNh ODNjNzQwOGM0ZTE3YjEyMzgzNDRmMDY0NS4uYzFiYzBlNGQxMjJmZWY4ZWI4Y2I3N2JkMzkxNmM5 ZmQ4ZDIxNjE1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTAyLTExICBCcmFu ZG9uIFN0ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGNo ZWNrIHRvIGVuc3VyZSB3ZSBsaW1pdCB0aGUgbnVtYmVyIG9mIGV4cGFuc2lvbk9wcG9ydHVuaXRp ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjUx NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3Vy ZSB3ZSBsaW1pdCB0aGUgbnVtYmVyIG9mIHJ1bnMgb3ZlciB0aGUgZXhwYW5zaW9uT3Bwb3J0dW5p dGllcy4KKworICAgICAgICAqIHJlbmRlcmluZy9MZWdhY3lMaW5lTGF5b3V0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxlZ2FjeUxpbmVMYXlvdXQ6OnVwZGF0ZVJ1YnlGb3JKdXN0aWZpZWRUZXh0 KToKKwogMjAyMi0wMi0xMCAgVGltIE5ndXllbiAgPG50aW1AYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCB3ZWJraXQtcGRmanMtdmlld2VyIHNjaGVtZSBmb3IgUERGLmpzIHJlc291cmNlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xlZ2FjeUxpbmVMYXlvdXQuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xlZ2FjeUxpbmVMYXlvdXQuY3BwCmluZGV4IDZlOWQz YzAzYWIxYzA3NTYzOWRmODZjZGU0ZGM1N2ViY2E4ZjdjOTkuLjk2MDk3ZTBlMDFmYjRmOTZjMGYw OTY1YzkzYzkwMDcyODUxOWRlZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9MZWdhY3lMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGVn YWN5TGluZUxheW91dC5jcHAKQEAgLTU2OCwxNSArNTY4LDE3IEBAIHZvaWQgTGVnYWN5TGluZUxh eW91dDo6dXBkYXRlUnVieUZvckp1c3RpZmllZFRleHQoUmVuZGVyUnVieVJ1biYgcnVieVJ1biwg QmlkaVJ1CiAKICAgICBmbG9hdCB0b3RhbEV4cGFuc2lvbiA9IDA7CiAgICAgdW5zaWduZWQgdG90 YWxPcHBvcnR1bml0aWVzSW5SdW4gPSAwOwotICAgIGZvciAoYXV0byogbGVhZkNoaWxkID0gcm9v dEJveC5maXJzdExlYWZEZXNjZW5kYW50KCk7IGxlYWZDaGlsZDsgbGVhZkNoaWxkID0gbGVhZkNo aWxkLT5uZXh0TGVhZk9uTGluZSgpKSB7CisgICAgZm9yIChhdXRvKiBsZWFmQ2hpbGQgPSByb290 Qm94LmZpcnN0TGVhZkRlc2NlbmRhbnQoKTsgbGVhZkNoaWxkICYmIGkgPCBleHBhbnNpb25PcHBv cnR1bml0aWVzLnNpemUoKTsgbGVhZkNoaWxkID0gbGVhZkNoaWxkLT5uZXh0TGVhZk9uTGluZSgp KSB7CiAgICAgICAgIGlmICghbGVhZkNoaWxkLT5pc0lubGluZVRleHRCb3goKSkKICAgICAgICAg ICAgIGNvbnRpbnVlOwogCiAgICAgICAgIHVuc2lnbmVkIG9wcG9ydHVuaXRpZXNJblJ1biA9IGV4 cGFuc2lvbk9wcG9ydHVuaXRpZXNbaSsrXTsKKyAgICAgICAgdG90YWxPcHBvcnR1bml0aWVzSW5S dW4gKz0gb3Bwb3J0dW5pdGllc0luUnVuOworCiAgICAgICAgIEFTU0VSVChvcHBvcnR1bml0aWVz SW5SdW4gPD0gZXhwYW5zaW9uT3Bwb3J0dW5pdHlDb3VudCk7CisKICAgICAgICAgYXV0byBleHBh bnNpb24gPSAoYXZhaWxhYmxlTG9naWNhbFdpZHRoIC0gdG90YWxMb2dpY2FsV2lkdGgpICogb3Bw b3J0dW5pdGllc0luUnVuIC8gZXhwYW5zaW9uT3Bwb3J0dW5pdHlDb3VudDsKICAgICAgICAgdG90 YWxFeHBhbnNpb24gKz0gZXhwYW5zaW9uOwotICAgICAgICB0b3RhbE9wcG9ydHVuaXRpZXNJblJ1 biArPSBvcHBvcnR1bml0aWVzSW5SdW47CiAgICAgfQogCiAgICAgQVNTRVJUKCFydWJ5UnVuLmhh c092ZXJyaWRpbmdMb2dpY2FsV2lkdGgoKSk7Cg== 451767 2022-02-11 18:20:10 -0800 2022-02-15 12:38:27 -0800 Root cause fix bug-236514-20220211182009.patch text/plain 1953 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIxYmRhMzYyY2UzOTA3 NjI0ZmUxYWJhMDU5Y2NhMjhmZTgzMGRhZi4uZTJmNzBjMmI0ODc1YWQwMTIxMGJiMTgxMTg5OWUx Yjc3NjE0Y2FhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTExICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGNoZWNr IHRvIGVuc3VyZSB3ZSBsaW1pdCB0aGUgbnVtYmVyIG9mIGV4cGFuc2lvbk9wcG9ydHVuaXRpZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjUxNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbXB1dGVF eHBhbnNpb25Gb3JKdXN0aWZpZWRUZXh0KCkgaGFzIGxvZ2ljIHRoYXQgbmVlZHMgdG8gbWF0Y2gg Y29tcHV0ZUlubGluZURpcmVjdGlvblBvc2l0aW9uc0ZvclNlZ21lbnQoKS4KKyAgICAgICAgVGhl IGxvZ2ljIHdhcyBhbG1vc3QgaWRlbnRpY2FsLCBleGNlcHQgZm9yIGFuIGVhcmx5IGNvbnRpbnVl LgorCisgICAgICAgIFRlc3RlZCBzb21ld2hlcmUgZWxzZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9MZWdhY3lMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxlZ2FjeUxpbmVMYXlv dXQ6OmNvbXB1dGVFeHBhbnNpb25Gb3JKdXN0aWZpZWRUZXh0KToKKwogMjAyMi0wMi0xMSAgVGlt IE5ndXllbiAgPG50aW1AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4 OiByZXZlcnQgcjI4OTYxNgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xl Z2FjeUxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xlZ2FjeUxpbmVM YXlvdXQuY3BwCmluZGV4IDZlOWQzYzAzYWIxYzA3NTYzOWRmODZjZGU0ZGM1N2ViY2E4ZjdjOTku LjNlM2FiZGVhYWJmYThkZDVmYWMxYTY4YzdiMjY5NjU5Y2ZlNTdlOWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MZWdhY3lMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvTGVnYWN5TGluZUxheW91dC5jcHAKQEAgLTYwNyw2ICs2MDcsMTIg QEAgdm9pZCBMZWdhY3lMaW5lTGF5b3V0Ojpjb21wdXRlRXhwYW5zaW9uRm9ySnVzdGlmaWVkVGV4 dChCaWRpUnVuKiBmaXJzdFJ1biwgQmlkaVIKICAgICBmb3IgKEJpZGlSdW4qIHJ1biA9IGZpcnN0 UnVuOyBydW47IHJ1biA9IHJ1bi0+bmV4dCgpKSB7CiAgICAgICAgIGlmICghcnVuLT5ib3goKSB8 fCBydW4gPT0gdHJhaWxpbmdTcGFjZVJ1bikKICAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAg ICAgIGlmICghcnVuLT5ib3goKSB8fCBydW4tPnJlbmRlcmVyKCkuaXNPdXRPZkZsb3dQb3NpdGlv bmVkKCkgfHwgcnVuLT5ib3goKS0+aXNMaW5lQnJlYWsoKSkgeworICAgICAgICAgICAgLy8gUG9z aXRpb25lZCBvYmplY3RzIGFyZSBvbmx5IHBhcnRpY2lwYXRpbmcgdG8gZmlndXJlIG91dCB0aGVp ciBjb3JyZWN0IHN0YXRpYyB4IHBvc2l0aW9uLgorICAgICAgICAgICAgLy8gVGhleSBoYXZlIG5v IGVmZmVjdCBvbiB0aGUgd2lkdGguIFNpbWlsYXJseSwgbGluZSBicmVhayBib3hlcyBoYXZlIG5v IGVmZmVjdCBvbiB0aGUgd2lkdGguCisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQog ICAgICAgICAKICAgICAgICAgaWYgKGlzPFJlbmRlclRleHQ+KHJ1bi0+cmVuZGVyZXIoKSkpIHsK ICAgICAgICAgICAgIHVuc2lnbmVkIG9wcG9ydHVuaXRpZXNJblJ1biA9IGV4cGFuc2lvbk9wcG9y dHVuaXRpZXNbaSsrXTsK 452073 2022-02-15 12:35:44 -0800 2022-02-15 16:00:58 -0800 Patch bug-236514-20220215123543.patch text/plain 1980 brandonstewart U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQ1YWE2NDg2MTk0OWI2 ZjFmNWQyZjA4OTc5ODExNTYyODlkZWZlMC4uZWNlZDQ4MTM5MDdiMmNhNjUyZDdhZTRlYmNjOGQ5 ZWRiZmEwOTc4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTE1ICBCcmFu ZG9uIFN0ZXdhcnQgIDxicmFuZG9uc3Rld2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgU2tpcCBw b3NpdGlvbmVkIG9iamVjdHMgYW5kIGxpbmUgYnJlYWsgYm94ZXMgYXMgdGhleSBoYXZlIG5vIGFm ZmVjdCBvbiB3aWR0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM2NTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxpZ24gY29tcHV0ZUlubGluZURpcmVjdGlvblBvc2l0aW9uc0ZvclNlZ21lbnQoKSBh bmQgY29tcHV0ZUV4cGFuc2lvbkZvckp1c3RpZmllZFRleHQoKSBsb2dpYy4KKyAgICAgICAgU2tp cHBpbmcgcG9zaXRpb25lZCBvYmplY3RzIGFuZCBsaW5lIGJyZWFrIGJveGVzIGFzIHRoZXkgd2ls bCBub3QgYWZmZWN0IHRoZSB3aWR0aC4gCisKKyAgICAgICAgKiByZW5kZXJpbmcvTGVnYWN5TGlu ZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMZWdhY3lMaW5lTGF5b3V0Ojpjb21wdXRl RXhwYW5zaW9uRm9ySnVzdGlmaWVkVGV4dCk6CisKIDIwMjItMDItMTAgIFNlcmdpbyBWaWxsYXIg U2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgRG8gbm90IHVwZGF0ZSB0aGUg ZnJhZ21lbnRlZCBmbG93IHN0YXRlIHdoaWxlIGludGVybmFsbHkgbXV0YXRpbmcgdGhlIHJlbmRl ciB0cmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGVnYWN5TGluZUxh eW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGVnYWN5TGluZUxheW91dC5jcHAK aW5kZXggNmU5ZDNjMDNhYjFjMDc1NjM5ZGY4NmNkZTRkYzU3ZWJjYThmN2M5OS4uMjIxOWQwOWM1 OGQxODJkMzE2Yjg4NGE1MjUwYWQ1Y2JkMjJjNGFlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0xlZ2FjeUxpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9MZWdhY3lMaW5lTGF5b3V0LmNwcApAQCAtNjA3LDcgKzYwNywxMiBAQCB2b2lkIExl Z2FjeUxpbmVMYXlvdXQ6OmNvbXB1dGVFeHBhbnNpb25Gb3JKdXN0aWZpZWRUZXh0KEJpZGlSdW4q IGZpcnN0UnVuLCBCaWRpUgogICAgIGZvciAoQmlkaVJ1biogcnVuID0gZmlyc3RSdW47IHJ1bjsg cnVuID0gcnVuLT5uZXh0KCkpIHsKICAgICAgICAgaWYgKCFydW4tPmJveCgpIHx8IHJ1biA9PSB0 cmFpbGluZ1NwYWNlUnVuKQogICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIAorCisgICAg ICAgIC8vIFBvc2l0aW9uZWQgb2JqZWN0cyBhcmUgb25seSBwYXJ0aWNpcGF0aW5nIHRvIGZpZ3Vy ZSBvdXQgdGhlaXIgY29ycmVjdCBzdGF0aWMgeCBwb3NpdGlvbi4KKyAgICAgICAgLy8gVGhleSBo YXZlIG5vIGFmZmVjdCBvbiB0aGUgd2lkdGguIFNpbWlsYXJseSwgbGluZSBicmVhayBib3hlcyBo YXZlIG5vIGFmZmVjdCBvbiB0aGUgd2lkdGguCisgICAgICAgIGlmIChydW4tPnJlbmRlcmVyKCku aXNPdXRPZkZsb3dQb3NpdGlvbmVkKCkgfHwgcnVuLT5ib3goKS0+aXNMaW5lQnJlYWsoKSkKKyAg ICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgIGlmIChpczxSZW5kZXJUZXh0PihydW4tPnJl bmRlcmVyKCkpKSB7CiAgICAgICAgICAgICB1bnNpZ25lZCBvcHBvcnR1bml0aWVzSW5SdW4gPSBl eHBhbnNpb25PcHBvcnR1bml0aWVzW2krK107CiAgICAgICAgICAgICAK