236470 2022-02-10 16:09:43 -0800 `contain:content` breaks fullscreen 2022-02-11 17:54:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser zalan bfulgham esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard rbuis simon.fraser webkit-bug-importer zalan oldest_to_newest 1840025 0 simon.fraser 2022-02-10 16:09:43 -0800 Taking the YouTube embed fullscreen on https://www.fluentu.com/blog/french/funny-french-videos/ is broken with containment enabled; you see the page content, not the video in fullscreen. CSS has: lite-youtube { background-color: #000; position: relative; display: block; contain: content; background-position: center center; background-size: cover; cursor: pointer; max-width: 720px; } If I remove contain: content the bug does not occur. This site seems to be using https://github.com/paulirish/lite-youtube-embed, so this might be common. 1840026 1 simon.fraser 2022-02-10 16:10:34 -0800 <rdar://88689388> 1840029 2 451615 simon.fraser 2022-02-10 16:17:05 -0800 Created attachment 451615 Simple testcase 1840188 3 zalan 2022-02-10 21:41:33 -0800 diff --git a/Source/WebCore/css/fullscreen.css b/Source/WebCore/css/fullscreen.css index c2a71ca3ceda..b67ed6ee0d01 100644 --- a/Source/WebCore/css/fullscreen.css +++ b/Source/WebCore/css/fullscreen.css @@ -48,6 +48,7 @@ perspective: none !important; -webkit-transform-style: flat !important; overflow: visible !important; + contain: none !important; } video:-webkit-full-screen, audio:-webkit-full-screen { diff --git a/Source/WebCore/css/parser/CSSParserContext.cpp b/Source/WebCore/css/parser/CSSParserContext.cpp index 55d36bb58616..f6b19755e2ea 100644 --- a/Source/WebCore/css/parser/CSSParserContext.cpp +++ b/Source/WebCore/css/parser/CSSParserContext.cpp @@ -51,6 +51,7 @@ CSSParserContext::CSSParserContext(CSSParserMode mode, const URL& baseURL) individualTransformPropertiesEnabled = true; focusVisibleEnabled = true; inputSecurityEnabled = true; + containmentEnabled = true; #if ENABLE(CSS_TRANSFORM_STYLE_OPTIMIZED_3D) transformStyleOptimized3DEnabled = true; #endif will submit a patch once I figured out how to test fullscreen. 1840406 4 451710 zalan 2022-02-11 09:34:06 -0800 Created attachment 451710 Patch 1840639 5 ews-feeder 2022-02-11 17:54:10 -0800 Committed r289686 (247172@main): <https://commits.webkit.org/247172@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451710. 451615 2022-02-10 16:17:05 -0800 2022-02-10 16:17:05 -0800 Simple testcase fullscreen-contain-ancestor.html text/html 1129 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgICA8c3R5bGU+CiAgICBib2R5IHsKICAg ICAgICBoZWlnaHQ6IDIwMDBweDsKICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBvcmFuZ2U7CiAg ICB9CiAgICAKICAgIC5jb250YWluZXIgewogICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNr OwogICAgICAgIHBhZGRpbmc6IDEwcHg7CiAgICAgICAgY29udGFpbjogY29udGVudDsKICAgIH0K ICAgICNmdWxsc2NyZWVuZXIgewogICAgICAgIGJhY2tncm91bmQtY29sb3I6IHNpbHZlcjsKICAg ICAgICBib3JkZXI6IDIwcHggc29saWQgZ3JheTsKICAgICAgICBwYWRkaW5nOiAxMDBweDsKICAg ICAgICB0ZXh0LWFsaWduOiBjZW50ZXI7CiAgICAgICAgZm9udC1zaXplOiA4MHB0OwogICAgfQog ICAgCiAgICAubWVzc2FnZSB7CiAgICAgICAgZm9udC1zaXplOiAyMHB0OwogICAgICAgIG1hcmdp bjogNTBweDsKICAgIH0KICAgIDwvc3R5bGU+CiAgICA8c2NyaXB0PgogICAgCiAgICBmdW5jdGlv biBnb0Z1bGxzY3JlZW4oKQogICAgewogICAgICAgIHZhciBmdWxsc2NyZWVuZXIgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnZnVsbHNjcmVlbmVyJyk7CiAgICAgICAgZnVsbHNjcmVlbmVyLndl YmtpdFJlcXVlc3RGdWxsc2NyZWVuKCk7CiAgICB9CgogICAgZnVuY3Rpb24gZG9TZXR1cCgpCiAg ICB7CiAgICAgICAgdmFyIGZ1bGxzY3JlZW5lciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdm dWxsc2NyZWVuZXInKTsKICAgICAgICBmdWxsc2NyZWVuZXIuYWRkRXZlbnRMaXN0ZW5lcignY2xp Y2snLCBnb0Z1bGxzY3JlZW4sIGZhbHNlKTsKICAgIH0KICAgIHdpbmRvdy5hZGRFdmVudExpc3Rl bmVyKCdsb2FkJywgZG9TZXR1cCwgZmFsc2UpOwogICAgPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+ Cgo8ZGl2IGNsYXNzPSJjb250YWluZXIiPgogICAgPGRpdiBpZD0iZnVsbHNjcmVlbmVyIj4KICAg ICAgICBUaGlzIGlzIHRoZSBmdWxsc2NyZWVuIGVsZW1lbnQuCiAgICAgICAgPGRpdiBjbGFzcz0i bWVzc2FnZSI+CiAgICAgICAgICAgIENsaWNrIG1lIHRvIGdvIGZ1bGxzY3JlZW4uCiAgICAgICAg PC9kaXY+CiAgICA8L2Rpdj4gICAgCjwvZGl2PgoKPC9ib2R5Pgo8L2h0bWw+Cg== 451710 2022-02-11 09:34:06 -0800 2022-02-11 17:54:12 -0800 Patch bug-236470-20220211093405.patch text/plain 4939 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRhYzQ3ZjU2YzVlZTQ5 ODdlZTZmNjdhZTRlMTg5MjcxOWUzY2FiNi4uZGZiZjBjNjU4ZTExMjAxN2U3YjVmZTk3MTA5MzEx N2MwMmM2YjU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAyLTExICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBgY29udGFpbjpjb250ZW50YCBi cmVha3MgZnVsbHNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM2NDcwCisgICAgICAgIDxyZGFyOi8vODg2ODkzODg+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFpbnQvbGF5b3V0IGNvbnRhaW5t ZW50IGZvcm1zIGEgY29udGFpbmluZyBibG9jayBmb3IgZml4ZWQgcG9zaXRpb25lZCBibG9jayBi b3hlcy4gSXQgbWFrZXMgYWxsIGZpeGVkCisgICAgICAgIHBvc2l0aW9uZWQgZGVzY2VuZGFudHMg YW5jaG9yZWQgKGNvbnRhaW5lZCkgdG8gdGhpcyBsYXlvdXQgY29udGFpbmVyLgorICAgICAgICBU aGlzIHBhdGNoIGVuYWJsZXMgZnVsbHNjcmVlbiBib3hlcyBicmVhayBvdXQgb2YgdGhpcyBub24t SUNCIGJhc2VkIGxheW91dCBzY29wZSAodGhpcyBpcyBzaW1pbGFyIHRvIHdoYXQgd2UKKyAgICAg ICAgZG8gZm9yIG90aGVyLCAibGF5b3V0IHNjb3BlIGNoYW5naW5nIiBwcm9wZXJ0aWVzLCBzZWUg Y2FuQ29udGFpbkZpeGVkUG9zaXRpb25PYmplY3RzKS4KKworICAgICAgICBUZXN0OiBmdWxsc2Ny ZWVuL2Z1bGxzY3JlZW4tcHJldmVudGVkLWJ5LWNvbnRhaW5tZW50Lmh0bWwKKworICAgICAgICAq IGNzcy9mdWxsc2NyZWVuLmNzczoKKyAgICAgICAgKDotd2Via2l0LWZ1bGwtc2NyZWVuLWFuY2Vz dG9yOm5vdChpZnJhbWUpKToKKyAgICAgICAgKiBjc3MvcGFyc2VyL0NTU1BhcnNlckNvbnRleHQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyQ29udGV4dDo6Q1NTUGFyc2VyQ29udGV4 dCk6CisKIDIwMjItMDItMTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFtDU1MgQ29udGFpbmVyIFF1ZXJpZXNdIEltcGxlbWVudCBjb250YWluZXIgbmFtZSBt YXRjaGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL2Z1bGxzY3JlZW4uY3NzIGIv U291cmNlL1dlYkNvcmUvY3NzL2Z1bGxzY3JlZW4uY3NzCmluZGV4IGMyYTcxY2EzY2VkYTJjNmRh Nzc3MmNhZmJiN2IzNDBjOGJjM2NiMGYuLmI2N2VkNmVlMGQwMWExZmMzZGMwZmZkZDcyNTY5YWE1 YWU2MDg0ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9mdWxsc2NyZWVuLmNzcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvZnVsbHNjcmVlbi5jc3MKQEAgLTQ4LDYgKzQ4LDcgQEAK ICAgICBwZXJzcGVjdGl2ZTogbm9uZSAhaW1wb3J0YW50OwogICAgIC13ZWJraXQtdHJhbnNmb3Jt LXN0eWxlOiBmbGF0ICFpbXBvcnRhbnQ7CiAgICAgb3ZlcmZsb3c6IHZpc2libGUgIWltcG9ydGFu dDsKKyAgICBjb250YWluOiBub25lICFpbXBvcnRhbnQ7CiB9CiAKIHZpZGVvOi13ZWJraXQtZnVs bC1zY3JlZW4sIGF1ZGlvOi13ZWJraXQtZnVsbC1zY3JlZW4gewpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9wYXJzZXIvQ1NTUGFyc2VyQ29udGV4dC5jcHAKaW5kZXggNTVkMzZiYjU4NjE2ODMwZWE1 YjU0Yzg5OTllMmEwYjliMDQxNDk2My4uZjZiMTk3NTVlMmVhODg0NTMzNjc5ODdmZDJlZDU4Njhk ODczNzdjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJD b250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlckNvbnRl eHQuY3BwCkBAIC01MSw2ICs1MSw3IEBAIENTU1BhcnNlckNvbnRleHQ6OkNTU1BhcnNlckNvbnRl eHQoQ1NTUGFyc2VyTW9kZSBtb2RlLCBjb25zdCBVUkwmIGJhc2VVUkwpCiAgICAgICAgIGluZGl2 aWR1YWxUcmFuc2Zvcm1Qcm9wZXJ0aWVzRW5hYmxlZCA9IHRydWU7CiAgICAgICAgIGZvY3VzVmlz aWJsZUVuYWJsZWQgPSB0cnVlOwogICAgICAgICBpbnB1dFNlY3VyaXR5RW5hYmxlZCA9IHRydWU7 CisgICAgICAgIGNvbnRhaW5tZW50RW5hYmxlZCA9IHRydWU7CiAjaWYgRU5BQkxFKENTU19UUkFO U0ZPUk1fU1RZTEVfT1BUSU1JWkVEXzNEKQogICAgICAgICB0cmFuc2Zvcm1TdHlsZU9wdGltaXpl ZDNERW5hYmxlZCA9IHRydWU7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0ZTEwOTc4ZmQ0MzdhYTFlMGFjNjRi ZmFhOGI4NGE0ZjQ3YTA4YjM5Li40NTFiNmU1ZjRlZDZkNzhlNjhiNGU4YWVhM2NlNzVjOTQ1NDhl ZDQ0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDItMTEgIEFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgorCisgICAgICAgIGBjb250YWluOmNvbnRlbnRgIGJyZWFrcyBmdWxsc2Ny ZWVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY0 NzAKKyAgICAgICAgPHJkYXI6Ly84ODY4OTM4OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGZ1bGxzY3JlZW4vZnVsbHNjcmVlbi1wcmV2ZW50ZWQt YnktY29udGFpbm1lbnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmdWxsc2NyZWVu L2Z1bGxzY3JlZW4tcHJldmVudGVkLWJ5LWNvbnRhaW5tZW50Lmh0bWw6IEFkZGVkLgorCiAyMDIy LTAyLTExICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAg ICAgVGFiIGNoYXJhY3RlcnMgYW5kIGNoIHVuaXRzIGRvIG5vdCBvYmV5IHN5bnRoZXRpYyBib2xk IHdpZHRoIGFkanVzdG1lbnRzIGNvcnJlY3RseQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVs bHNjcmVlbi9mdWxsc2NyZWVuLXByZXZlbnRlZC1ieS1jb250YWlubWVudC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGxzY3JlZW4tcHJldmVudGVkLWJ5LWNvbnRhaW5t ZW50LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45ZWNiMzU5NmJiZDFlMDVkOWEyODRmMTBlNjVi OTM5MmEzZmU3MTU0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9m dWxsc2NyZWVuLXByZXZlbnRlZC1ieS1jb250YWlubWVudC1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSw0IEBACitUaGlzIGlzIHRoZSBmdWxsc2NyZWVuIGVsZW1lbnQgKGNsaWNrIHRvIGFjdGl2YXRl KQorRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5nZSkgVEVTVChmdWxsc2NyZWVuZXIub2Zmc2V0 V2lkdGggPT0gd2luZG93LmlubmVyV2lkdGggJiYgZnVsbHNjcmVlbmVyLm9mZnNldEhlaWdodCA9 PSB3aW5kb3cuaW5uZXJIZWlnaHQpIE9LCitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGxzY3JlZW4tcHJldmVudGVkLWJ5LWNvbnRhaW5tZW50Lmh0 bWwgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGxzY3JlZW4tcHJldmVudGVkLWJ5LWNvbnRh aW5tZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODllMGYyY2Y5NmQwNGZjNzQyMjZiZjcyNGU4NjdiM2Y2 NzM4OWM4MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbHNj cmVlbi1wcmV2ZW50ZWQtYnktY29udGFpbm1lbnQuaHRtbApAQCAtMCwwICsxLDMyIEBACis8IURP Q1RZUEUgaHRtbD4KKzxzY3JpcHQgc3JjPSJmdWxsLXNjcmVlbi10ZXN0LmpzIj48L3NjcmlwdD4K KzxzdHlsZT4KKy5jb250ZW50LWFuY2VzdG9yIHsKKyAgYmFja2dyb3VuZC1jb2xvcjogcmVkOwor ICBoZWlnaHQ6IDUwMHB4OworICB3aWR0aDogNTAwcHg7Cit9CisuY29udGVudCB7CisgIGNvbnRh aW46IGNvbnRlbnQ7Cit9CisKKyNmdWxsc2NyZWVuZXIgeworICBiYWNrZ3JvdW5kLWNvbG9yOiBn cmVlbjsKK30KKzwvc3R5bGU+Cis8ZGl2IGNsYXNzPWNvbnRlbnQtYW5jZXN0b3I+CisgIDxkaXYg Y2xhc3M9Y29udGVudD4KKyAgICA8ZGl2IGlkPWZ1bGxzY3JlZW5lcj5UaGlzIGlzIHRoZSBmdWxs c2NyZWVuIGVsZW1lbnQgKGNsaWNrIHRvIGFjdGl2YXRlKTwvZGl2PgorPC9kaXY+Cis8c2NyaXB0 PgorICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICB3YWl0Rm9yRXZlbnRUZXN0QW5kRW5k KGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsICJmdWxsc2NyZWVuZXIub2Zmc2V0 V2lkdGggPT0gd2luZG93LmlubmVyV2lkdGggJiYgZnVsbHNjcmVlbmVyLm9mZnNldEhlaWdodCA9 PSB3aW5kb3cuaW5uZXJIZWlnaHQiKTsKKyAgICBydW5XaXRoS2V5RG93bihmdW5jdGlvbigpIHsK KyAgICAgIGZ1bGxzY3JlZW5lci53ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbigpOworICAgIH0pOwor ICB9IGVsc2UgeworICAgICBmdWxsc2NyZWVuZXIuYWRkRXZlbnRMaXN0ZW5lcignY2xpY2snLCBm dW5jdGlvbiAoKSB7CisgICAgICAgIGZ1bGxzY3JlZW5lci53ZWJraXRSZXF1ZXN0RnVsbHNjcmVl bigpOworICAgICB9LCBmYWxzZSk7CisgfQorPC9zY3JpcHQ+Cg==