236459 2022-02-10 12:37:53 -0800 [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit 2022-02-10 21:19:00 -0800 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=236181 https://bugs.webkit.org/show_bug.cgi?id=236202 InRadar P2 Normal --- 1 ddkilzer ddkilzer benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1839872 0 ddkilzer 2022-02-10 12:37:53 -0800 [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit. Found by clang static analyzer. 1839873 1 webkit-bug-importer 2022-02-10 12:38:29 -0800 <rdar://problem/88772313> 1839874 2 451588 ddkilzer 2022-02-10 12:39:29 -0800 Created attachment 451588 Patch v1 1839914 3 451588 darin 2022-02-10 13:56:48 -0800 Comment on attachment 451588 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=451588&action=review > Source/WTF/wtf/IteratorAdaptors.h:110 > template<typename Transform, typename Iterator> > inline TransformIterator<Transform, Iterator> makeTransformIterator(Transform&& transform, Iterator&& iter) > { > - return TransformIterator<Transform, Iterator>(WTFMove(transform), WTFMove(iter)); > + return TransformIterator<Transform, Iterator>(std::forward<Transform>(transform), std::forward<Iterator>(iter)); > } We should dump this function and take advantage of deduction guides instead. OK to fix it for now, though. 1840159 4 451588 ddkilzer 2022-02-10 20:30:12 -0800 Comment on attachment 451588 Patch v1 Marking cq+ as enough bots have built and tested for this change. 1840180 5 ews-feeder 2022-02-10 21:18:56 -0800 Committed r289602 (247115@main): <https://commits.webkit.org/247115@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451588. 451588 2022-02-10 12:39:29 -0800 2022-02-10 21:18:58 -0800 Patch v1 bug-236459-20220210123928.patch text/plain 2056 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVmOWNiZDllZWM5OTNiZmFhZjFhNDc1 MTU3MjU0MjkzOGQyNDU2NWEuLjM4Yzk3OTMwMGViZjJjZjljZjA0NzQxOTFkMDFhMGVhYmZiYTg0 YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDItMTAgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV1RGXSBGaXggY2xhbmcgdGlkeSBidWdwcm9uZS1t b3ZlLWZvcndhcmRpbmctcmVmZXJlbmNlIHN0YXRpYyBhbmFseXplciB3YXJuaW5ncyBmcm9tIFdl YkNvcmUvV2ViS2l0CisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzY0NTk+CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS84ODc3MjMxMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9JdGVyYXRvckFkYXB0b3JzLmg6CisgICAgICAg IChXVEY6Om1ha2VUcmFuc2Zvcm1JdGVyYXRvcik6CisgICAgICAgICogd3RmL1dlYWtIYXNoTWFw Lmg6CisgICAgICAgIChXVEY6OldlYWtIYXNoTWFwOjpzZXQpOgorICAgICAgICAtIFJlcGxhY2Ug V1RGTW92ZSgpIHdpdGggc3RkOjpmb3J3YXJkPD4oKS4KKwogMjAyMi0wMi0wNyAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdURjo6SGFzaEFuZFVURjhDaGFy YWN0ZXJzVHJhbnNsYXRvcjo6dHJhbnNsYXRlKCkgZmFsbHMgdGhyb3VnaCBBU1NFUlRfTk9UX1JF QUNIRUQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvSXRlcmF0b3JBZGFwdG9ycy5oIGIv U291cmNlL1dURi93dGYvSXRlcmF0b3JBZGFwdG9ycy5oCmluZGV4IGE0ZTA3ZWJhMjhiODYzYWJl YjQ2OTM3MjVjOWIyMzNhMjJmMjNiNDcuLjk4NjFhOTllY2Y3YzUwYmRmMjNkYTVhNGIzYzRkZjNi N2E4ODVkNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0l0ZXJhdG9yQWRhcHRvcnMuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9JdGVyYXRvckFkYXB0b3JzLmgKQEAgLTEwNiw3ICsxMDYsNyBA QCBwcml2YXRlOgogdGVtcGxhdGU8dHlwZW5hbWUgVHJhbnNmb3JtLCB0eXBlbmFtZSBJdGVyYXRv cj4KIGlubGluZSBUcmFuc2Zvcm1JdGVyYXRvcjxUcmFuc2Zvcm0sIEl0ZXJhdG9yPiBtYWtlVHJh bnNmb3JtSXRlcmF0b3IoVHJhbnNmb3JtJiYgdHJhbnNmb3JtLCBJdGVyYXRvciYmIGl0ZXIpCiB7 Ci0gICAgcmV0dXJuIFRyYW5zZm9ybUl0ZXJhdG9yPFRyYW5zZm9ybSwgSXRlcmF0b3I+KFdURk1v dmUodHJhbnNmb3JtKSwgV1RGTW92ZShpdGVyKSk7CisgICAgcmV0dXJuIFRyYW5zZm9ybUl0ZXJh dG9yPFRyYW5zZm9ybSwgSXRlcmF0b3I+KHN0ZDo6Zm9yd2FyZDxUcmFuc2Zvcm0+KHRyYW5zZm9y bSksIHN0ZDo6Zm9yd2FyZDxJdGVyYXRvcj4oaXRlcikpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBX VEYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1dlYWtIYXNoTWFwLmggYi9Tb3VyY2UvV1RG L3d0Zi9XZWFrSGFzaE1hcC5oCmluZGV4IDEzMTg4NTdlMTE1NzA2NWFiNmMwYjkyNmYwMDEyZjVh ZjljMWM4NTQuLmM0YmRlNGM1ZDA5MmQ4OWMxNmE2Y2JmZjc4ZDkyNDBlNTkxYjQ5ZDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1dlYWtIYXNoTWFwLmgKKysrIGIvU291cmNlL1dURi93dGYv V2Vha0hhc2hNYXAuaApAQCAtMjIxLDcgKzIyMSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldChj b25zdCBUJiBrZXksIFYmJiB2YWx1ZSkKICAgICB7CiAgICAgICAgIGFtb3J0aXplZENsZWFudXBJ Zk5lZWRlZCgpOwotICAgICAgICBtX21hcC5zZXQobWFrZUtleUltcGwoa2V5KSwgV1RGTW92ZSh2 YWx1ZSkpOworICAgICAgICBtX21hcC5zZXQobWFrZUtleUltcGwoa2V5KSwgc3RkOjpmb3J3YXJk PFY+KHZhbHVlKSk7CiAgICAgfQogCiAgICAgaXRlcmF0b3IgZmluZChjb25zdCBLZXlUeXBlJiBr ZXkpCg==