236456 2022-02-10 11:02:02 -0800 Don't throw exception when controls are removed 2022-02-14 04:22:19 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eocanha eocanha calvaris eric.carlson ews-watchlist glenn jer.noble joepeck philipj sergio webkit-bug-importer oldest_to_newest 1839814 0 eocanha 2022-02-10 11:02:02 -0800 In mediaControlsBase.js, when media controls are removed, calling controlsAreHidden() can cause an exception because the panel has no parentElement. 1839828 1 451577 eocanha 2022-02-10 11:08:20 -0800 Created attachment 451577 Patch 1840224 2 451577 calvaris 2022-02-10 23:24:01 -0800 Comment on attachment 451577 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451577&action=review > Source/WebCore/ChangeLog:1 > +2022-02-10 Eugene Mutavchi <Ievgen_Mutavchi@comcast.com> You're responsible for this patch, your name should be here. Eugene's one is already in below. > Source/WebCore/ChangeLog:3 > + Don't throw exception when controls are hidden If the crash happens because controls are removed, then this title is misleading. 1840283 3 451666 eocanha 2022-02-11 02:58:14 -0800 Created attachment 451666 Patch 1841197 4 ews-feeder 2022-02-14 04:21:55 -0800 Committed r289730 (247215@main): <https://commits.webkit.org/247215@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451666. 1841198 5 webkit-bug-importer 2022-02-14 04:22:19 -0800 <rdar://problem/88898131> 451577 2022-02-10 11:08:20 -0800 2022-02-11 02:58:09 -0800 Patch bug-236456-20220210200819.patch text/plain 1750 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE4OTFkZjgwYTFiMDNi NzhlZWU3Yjg0YTk4MzE2ZWMwMGE3MGExOC4uNWVjZTJiYWI5YTQxYmExNDk2YmY2N2M2OWU5NDdi YzMwNjdkNGMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTEwICBFdWdl bmUgTXV0YXZjaGkgIDxJZXZnZW5fTXV0YXZjaGlAY29tY2FzdC5jb20+CisKKyAgICAgICAgRG9u J3QgdGhyb3cgZXhjZXB0aW9uIHdoZW4gY29udHJvbHMgYXJlIGhpZGRlbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NDU2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gbWVkaWFDb250cm9sc0Jhc2Uu anMsIHdoZW4gbWVkaWEgY29udHJvbHMgYXJlIHJlbW92ZWQsIGNhbGxpbmcgY29udHJvbHNBcmVI aWRkZW4oKSBjYW4gY2F1c2UKKyAgICAgICAgYW4gZXhjZXB0aW9uIGJlY2F1c2UgdGhlIHBhbmVs IGhhcyBubyBwYXJlbnRFbGVtZW50LgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYXV0aG9yZWQg YnkgRXVnZW5lIE11dGF2Y2hpIDxJZXZnZW5fTXV0YXZjaGlAY29tY2FzdC5jb20+CisgICAgICAg IFNlZTogaHR0cHM6Ly9naXRodWIuY29tL1dlYlBsYXRmb3JtRm9yRW1iZWRkZWQvV1BFV2ViS2l0 L3B1bGwvNzc1CisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0Jhc2UuanM6IFJldHVybiBmYWxzZSBpZiB0aGVyZSdzIG5vIHBhcmVudC4KKwogMjAyMi0wMi0w OSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3Agb2JmdXNj YXRpbmcgZXhjZXB0aW9ucyB0aHJvd24gYnkgc2NyaXB0cyBpbiBkYXRhIFVSTHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQmFz ZS5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xz QmFzZS5qcwppbmRleCBmNzg2OTZkNjQ5MGZlZjlmNjZlOTkwYmY3M2YyMGZhYzIwZTlmZGU5Li45 ZjE0ODFjMmQxMjY2NTdhNmI5ZGU1MTAwODE0YmE1NzI5ZTQ3YjMyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Jhc2UuanMKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNCYXNl LmpzCkBAIC0xMDM1LDYgKzEwMzUsOCBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgICAgICB2YXIgcGFuZWwgPSB0aGlzLmNvbnRyb2xz LnBhbmVsOworICAgICAgICBpZiAoIXBhbmVsLnBhcmVudEVsZW1lbnQpCisgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICAgICAgcmV0dXJuICghcGFuZWwuY2xhc3NMaXN0LmNvbnRhaW5zKHRo aXMuQ2xhc3NOYW1lcy5zaG93KSB8fCBwYW5lbC5jbGFzc0xpc3QuY29udGFpbnModGhpcy5DbGFz c05hbWVzLmhpZGRlbikpCiAgICAgICAgICAgICAmJiAocGFuZWwucGFyZW50RWxlbWVudC5xdWVy eVNlbGVjdG9yKCc6aG92ZXInKSAhPT0gcGFuZWwpOwogICAgIH0sCg== 451666 2022-02-11 02:58:14 -0800 2022-02-14 04:21:57 -0800 Patch bug-236456-20220211115812.patch text/plain 1760 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE4OTFkZjgwYTFiMDNi NzhlZWU3Yjg0YTk4MzE2ZWMwMGE3MGExOC4uYWNmN2Y2MDZhYTM1YmU3MTQ2N2Y3NDBjNzRiNGFm OWZjZWVmZjFhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTEwICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgRG9u J3QgdGhyb3cgZXhjZXB0aW9uIHdoZW4gY29udHJvbHMgYXJlIHJlbW92ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjQ1NgorCisgICAgICAgIFJl dmlld2VkIGJ5IFhhYmllciBSb2RyaWd1ZXotQ2FsdmFyLgorCisgICAgICAgIEluIG1lZGlhQ29u dHJvbHNCYXNlLmpzLCB3aGVuIG1lZGlhIGNvbnRyb2xzIGFyZSByZW1vdmVkLCBjYWxsaW5nIGNv bnRyb2xzQXJlSGlkZGVuKCkgY2FuIGNhdXNlCisgICAgICAgIGFuIGV4Y2VwdGlvbiBiZWNhdXNl IHRoZSBwYW5lbCBoYXMgbm8gcGFyZW50RWxlbWVudC4KKworICAgICAgICBUaGlzIHBhdGNoIGlz IGF1dGhvcmVkIGJ5IEV1Z2VuZSBNdXRhdmNoaSA8SWV2Z2VuX011dGF2Y2hpQGNvbWNhc3QuY29t PgorICAgICAgICBTZWU6IGh0dHBzOi8vZ2l0aHViLmNvbS9XZWJQbGF0Zm9ybUZvckVtYmVkZGVk L1dQRVdlYktpdC9wdWxsLzc3NQorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNCYXNlLmpzOiBSZXR1cm4gZmFsc2UgaWYgdGhlcmUncyBubyBwYXJlbnQuCisK IDIwMjItMDItMDkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBT dG9wIG9iZnVzY2F0aW5nIGV4Y2VwdGlvbnMgdGhyb3duIGJ5IHNjcmlwdHMgaW4gZGF0YSBVUkxz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFD b250cm9sc0Jhc2UuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVk aWFDb250cm9sc0Jhc2UuanMKaW5kZXggZjc4Njk2ZDY0OTBmZWY5ZjY2ZTk5MGJmNzNmMjBmYWMy MGU5ZmRlOS4uOWYxNDgxYzJkMTI2NjU3YTZiOWRlNTEwMDgxNGJhNTcyOWU0N2IzMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNC YXNlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzQmFzZS5qcwpAQCAtMTAzNSw2ICsxMDM1LDggQEAgQ29udHJvbGxlci5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgdmFyIHBhbmVsID0gdGhp cy5jb250cm9scy5wYW5lbDsKKyAgICAgICAgaWYgKCFwYW5lbC5wYXJlbnRFbGVtZW50KQorICAg ICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIHJldHVybiAoIXBhbmVsLmNsYXNzTGlzdC5j b250YWlucyh0aGlzLkNsYXNzTmFtZXMuc2hvdykgfHwgcGFuZWwuY2xhc3NMaXN0LmNvbnRhaW5z KHRoaXMuQ2xhc3NOYW1lcy5oaWRkZW4pKQogICAgICAgICAgICAgJiYgKHBhbmVsLnBhcmVudEVs ZW1lbnQucXVlcnlTZWxlY3RvcignOmhvdmVyJykgIT09IHBhbmVsKTsKICAgICB9LAo=