236453 2022-02-10 10:35:10 -0800 [GStreamer][MSE] Let MSE set natural video size when using holepunch 2022-02-15 04:04:58 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eocanha eocanha calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble magomez menard philipj pnormand sergio vjaquez webkit-bug-importer oldest_to_newest 1839789 0 eocanha 2022-02-10 10:35:10 -0800 Currently the holepunch implementation completely overrides the video size to a hardcoded value. It would be desirable to let the m_videoSize value set by MediaPlayerPrivateGStreamerMSE::setInitialVideoSize() take precedence over the hardcoded value. 1839794 1 451565 eocanha 2022-02-10 10:43:35 -0800 Created attachment 451565 Patch 1840223 2 451565 calvaris 2022-02-10 23:20:02 -0800 Comment on attachment 451565 Patch I'm ok, but let's wait for Miguel, our holepunch expert to give the final green light. 1841241 3 magomez 2022-02-14 07:03:14 -0800 (In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 451565 [details] > Patch > > I'm ok, but let's wait for Miguel, our holepunch expert to give the final > green light. LGTM 1841648 4 ews-feeder 2022-02-15 04:03:12 -0800 Committed r289800 (247265@main): <https://commits.webkit.org/247265@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451565. 1841649 5 webkit-bug-importer 2022-02-15 04:04:58 -0800 <rdar://problem/88957858> 451565 2022-02-10 10:43:35 -0800 2022-02-15 04:03:14 -0800 Patch bug-236453-20220210194333.patch text/plain 3013 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE4OTFkZjgwYTFiMDNi NzhlZWU3Yjg0YTk4MzE2ZWMwMGE3MGExOC4uZWU5ZTUxODE0MjVhNWQ4MGMzYTY5Mzc0NzlkNDBh YTc5ZmY0MjQwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAyLTEwICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bTVNFXSBMZXQgTVNFIHNldCBuYXR1cmFsIHZpZGVvIHNpemUgd2hlbiB1c2luZyBo b2xlcHVuY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNjQ1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEN1cnJlbnRseSB0aGUgaG9sZXB1bmNoIGltcGxlbWVudGF0aW9uIGNvbXBsZXRlbHkgb3ZlcnJp ZGVzIHRoZSB2aWRlbyBzaXplIHRvIGEgaGFyZGNvZGVkCisgICAgICAgIHZhbHVlLiBJdCB3b3Vs ZCBiZSBkZXNpcmFibGUgdG8gbGV0IHRoZSBtX3ZpZGVvU2l6ZSB2YWx1ZSBzZXQgYnkKKyAgICAg ICAgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFOjpzZXRJbml0aWFsVmlkZW9TaXplKCkg dGFrZSBwcmVjZWRlbmNlIG92ZXIgdGhlIGhhcmRjb2RlZCB2YWx1ZS4KKworICAgICAgICBUaGlz IGlzIGEgZml4IGZvciBtZWRpYSBlbGVtZW50IGV2ZW50cyB0ZXN0IGNhc2UgZnJvbSBZVFM6CisK KyAgICAgICAgaHR0cHM6Ly95dGxyLWNlcnQuYXBwc3BvdC5jb20vMjAyMS9tYWluLmh0bWw/dGVz dHM9MTgKKworICAgICAgICBUaGlzIHBhdGNoIGlzIGF1dGhvcmVkIGJ5IEV1Z2VuZSBNdXRhdmNo aSA8SWV2Z2VuX011dGF2Y2hpQGNvbWNhc3QuY29tPgorICAgICAgICBTZWU6IGh0dHBzOi8vZ2l0 aHViLmNvbS9XZWJQbGF0Zm9ybUZvckVtYmVkZGVkL1dQRVdlYktpdC9wdWxsLzc3NQorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6 Om5hdHVyYWxTaXplIGNvbnN0KTogUmV0dXJuIG1fdmlkZW9TaXplIHdoZW4gc2V0LgorCiAyMDIy LTAyLTA5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcCBv YmZ1c2NhdGluZyBleGNlcHRpb25zIHRocm93biBieSBzY3JpcHRzIGluIGRhdGEgVVJMcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBmZjBm YWQ1ZjA0Yjc0OGMyODRiYjVmNTljYjgwMTBlNmZmY2ZlOTM5Li45ZDE2MWQyMzQxNTgzM2I3OTdi MTA4M2QzMjMyZDE5NWY2NWE5OTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTU1NSwxMyArMTU1NSw2IEBAIGJvb2wgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVOZWVkQ29udGV4dE1lc3NhZ2UoR3N0TWVzc2FnZSog bWVzc2FnZSkKIC8vIFJldHVybnMgdGhlIHNpemUgb2YgdGhlIHZpZGVvLgogRmxvYXRTaXplIE1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bmF0dXJhbFNpemUoKSBjb25zdAogewotI2lmIFVT RShHU1RSRUFNRVJfSE9MRVBVTkNIKQotICAgIC8vIFdoZW4gdXNpbmcgdGhlIGhvbGVwdWNoIHdl IG1heSBub3QgYmUgYWJsZSB0byBnZXQgdGhlIHZpZGVvIGZyYW1lcyBzaXplLCBzbyB3ZSBjYW4n dCB1c2UKLSAgICAvLyBpdC4gQnV0IHdlIG5lZWQgdG8gcmVwb3J0IHNvbWUgbm9uIGVtcHR5IG5h dHVyYWxTaXplIGZvciB0aGUgcGxheWVyJ3MgR3JhcGhpY3NMYXllcgotICAgIC8vIHRvIGJlIHBy b3Blcmx5IGNyZWF0ZWQuCi0gICAgcmV0dXJuIHNfaG9sZVB1bmNoRGVmYXVsdEZyYW1lU2l6ZTsK LSNlbmRpZgotCiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKICAgICBpZiAoIW1faXNMZWdhY3lQ bGF5YmluICYmICFtX3dhbnRlZFZpZGVvU3RyZWFtSWQuaXNFbXB0eSgpKSB7CiAgICAgICAgIFJl ZlB0cjxWaWRlb1RyYWNrUHJpdmF0ZUdTdHJlYW1lcj4gdmlkZW9UcmFjayA9IG1fdmlkZW9UcmFj a3MuZ2V0KG1fd2FudGVkVmlkZW9TdHJlYW1JZCk7CkBAIC0xNTc5LDYgKzE1NzIsMTYgQEAgRmxv YXRTaXplIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bmF0dXJhbFNpemUoKSBjb25zdAog ICAgIGlmICghaGFzVmlkZW8oKSkKICAgICAgICAgcmV0dXJuIEZsb2F0U2l6ZSgpOwogCisgICAg aWYgKCFtX3ZpZGVvU2l6ZS5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBtX3ZpZGVvU2l6ZTsK KworI2lmIFVTRShHU1RSRUFNRVJfSE9MRVBVTkNIKQorICAgIC8vIFdoZW4gdXNpbmcgdGhlIGhv bGVwdWNoIHdlIG1heSBub3QgYmUgYWJsZSB0byBnZXQgdGhlIHZpZGVvIGZyYW1lcyBzaXplLCBz byB3ZSBjYW4ndCB1c2UKKyAgICAvLyBpdC4gQnV0IHdlIG5lZWQgdG8gcmVwb3J0IHNvbWUgbm9u IGVtcHR5IG5hdHVyYWxTaXplIGZvciB0aGUgcGxheWVyJ3MgR3JhcGhpY3NMYXllcgorICAgIC8v IHRvIGJlIHByb3Blcmx5IGNyZWF0ZWQuCisgICAgcmV0dXJuIHNfaG9sZVB1bmNoRGVmYXVsdEZy YW1lU2l6ZTsKKyNlbmRpZgorCiAgICAgcmV0dXJuIG1fdmlkZW9TaXplOwogfQogCg==