236419 2022-02-09 16:46:23 -0800 Fail synchronously when constructing a SharedWorker with an URL that is not same-origin 2022-02-10 07:35:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 230382 1 cdumez cdumez achristensen bfulgham darin ggaren webkit-bug-importer youennf oldest_to_newest 1839455 0 cdumez 2022-02-09 16:46:23 -0800 Fail synchronously when constructing a SharedWorker with an unsupported protocol. 1839465 1 451467 cdumez 2022-02-09 17:03:58 -0800 Created attachment 451467 Patch 1839478 2 451467 darin 2022-02-09 17:36:20 -0800 Comment on attachment 451467 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451467&action=review > LayoutTests/imported/w3c/ChangeLog:16 > + * web-platform-tests/workers/shared-worker-in-data-url-context.window-expected.txt: > + Even though this looks like a regression, this actually aligns our behavior with both > + Blink & Gecko (who also fail this check). Note that the load fails no matter what. > + However, the test expects it to fail asynchronously instead of synchronously in this > + case. When will we fix WPT? 1839507 3 cdumez 2022-02-09 19:36:17 -0800 (In reply to Darin Adler from comment #2) > Comment on attachment 451467 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451467&action=review > > > LayoutTests/imported/w3c/ChangeLog:16 > > + * web-platform-tests/workers/shared-worker-in-data-url-context.window-expected.txt: > > + Even though this looks like a regression, this actually aligns our behavior with both > > + Blink & Gecko (who also fail this check). Note that the load fails no matter what. > > + However, the test expects it to fail asynchronously instead of synchronously in this > > + case. > > When will we fix WPT? I will follow-up. I think I may need to start a discussion on the spec. Technically, I think the test matches the spec and was written by a Chrome engineer to point out issues with their implementation. However, the test landed over a year ago and Chrome still hasn't updated their implementation to pass the test they added. Since the spec isn't in agreement with browsers it seems, I guess the best way forward is to modify the spec to match Blink & Gecko's implementation. 1839647 4 ews-feeder 2022-02-10 07:34:53 -0800 Committed r289532 (247063@main): <https://commits.webkit.org/247063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451467. 1839648 5 webkit-bug-importer 2022-02-10 07:35:22 -0800 <rdar://problem/88753909> 451467 2022-02-09 17:03:58 -0800 2022-02-10 07:34:55 -0800 Patch bug-236419-20220209170357.patch text/plain 5408 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI2YWM3MzJhNGM0OGQ5 NmY0YmZmMjJjMWE0NzdjOTAzYTAwM2I1NC4uMWVkNjJiMTFjNWQ2OTBlYWYwMzk2MWFmMDVmNDcz NTc5MWUyYWQ4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRmFpbCBzeW5jaHJvbm91c2x5 IHdoZW4gY29uc3RydWN0aW5nIGEgU2hhcmVkV29ya2VyIHdpdGggYW4gVVJMIHRoYXQgaXMgbm90 IHNhbWUtb3JpZ2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzY0MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGYWlsIHN5bmNocm9ub3VzbHkgd2hlbiBjb25zdHJ1Y3RpbmcgYSBTaGFyZWRXb3JrZXIg d2l0aCBhbiBVUkwgdGhhdCBpcyBub3Qgc2FtZS1vcmlnaW4uCisgICAgICAgIFRoaXMgYWxpZ25z IG91ciBiZWhhdmlvciB3aXRoIENocm9tZSBhbmQgbWF0Y2hlcyB0aGUgbGFuZ3VhZ2UgaW4gdGhl IHNwZWNpZmljYXRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCByZWJhc2VsaW5lZCBleGlz dGluZyB0ZXN0LgorCisgICAgICAgICogd29ya2Vycy9zaGFyZWQvU2hhcmVkV29ya2VyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZFdvcmtlcjo6Y3JlYXRlKToKKwogMjAyMi0wMi0wOSAg RXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBXS1dlYlZp ZXc6IFdLVVJMU2NoZW1lSGFuZGxlciDigJxyZXF1ZXN0IHRvIHRoZSBlbmQgb2YgdGhlIHJlc291 cmNl4oCdIHByb2R1Y2VzIGFuIGludmFsaWQgaGVhZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL3NoYXJlZC9TaGFyZWRXb3JrZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvd29y a2Vycy9zaGFyZWQvU2hhcmVkV29ya2VyLmNwcAppbmRleCAwYTc4MTliOGIzYTE4NjU5NmRhNmJi YTA4MjhlMGY1ZWUxODM2MDJkLi5hZTgzZjMyZDViNmQ4OGU0YzE0ZDZkMjk5YmVkYzAwOTU2MTMx ZTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NoYXJlZC9TaGFyZWRXb3Jr ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2hhcmVkL1NoYXJlZFdvcmtlci5j cHAKQEAgLTc0LDggKzc0LDkgQEAgRXhjZXB0aW9uT3I8UmVmPFNoYXJlZFdvcmtlcj4+IFNoYXJl ZFdvcmtlcjo6Y3JlYXRlKERvY3VtZW50JiBkb2N1bWVudCwgU3RyaW5nJiYKICAgICBpZiAoIXVy bC5pc1ZhbGlkKCkpCiAgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBTeW50YXhFcnJvciwgIklu dmFsaWQgc2NyaXB0IFVSTCJfcyB9OwogCi0gICAgaWYgKHVybC5pc0xvY2FsRmlsZSgpKQotICAg ICAgICByZXR1cm4gRXhjZXB0aW9uIHsgU2VjdXJpdHlFcnJvciwgIkNhbm5vdCBjb25zdHJ1Y3Qg YSBzaGFyZWQgd29ya2VyIHdpdGggYSBmaWxlOi8vIFVSTCJfcyB9OworICAgIC8vIFBlciB0aGUg c3BlY2lmaWNhdGlvbiwgYW55IHNhbWUtb3JpZ2luIFVSTCAoaW5jbHVkaW5nIGJsb2I6IFVSTHMp IGNhbiBiZSB1c2VkLiBkYXRhOiBVUkxzIGNhbiBhbHNvIGJlIHVzZWQsIGJ1dCB0aGV5IGNyZWF0 ZSBhIHdvcmtlciB3aXRoIGFuIG9wYXF1ZSBvcmlnaW4uCisgICAgaWYgKCFkb2N1bWVudC5zZWN1 cml0eU9yaWdpbigpLmNhblJlcXVlc3QodXJsKSAmJiAhdXJsLnByb3RvY29sSXNEYXRhKCkpCisg ICAgICAgIHJldHVybiBFeGNlcHRpb24geyBTZWN1cml0eUVycm9yLCAiVVJMIG9mIHRoZSBzaGFy ZWQgd29ya2VyIGlzIGNyb3NzLW9yaWdpbiJfcyB9OwogCiAgICAgaWYgKGF1dG8qIGNvbnRlbnRT ZWN1cml0eVBvbGljeSA9IGRvY3VtZW50LmNvbnRlbnRTZWN1cml0eVBvbGljeSgpKSB7CiAgICAg ICAgIGlmICghY29udGVudFNlY3VyaXR5UG9saWN5LT5hbGxvd1dvcmtlckZyb21Tb3VyY2UodXJs KSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDQ2ODgwNGYzNDU4MDZlNGYxY2Fh YzFjOTVmN2JlOTVjM2Y0NGYwZGQuLjAwYzFjMDI3YWQxNzg3OTczZmRiNTMzYzA5OWRhNWRkZjAw NTVhMzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisy MDIyLTAyLTA5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRmFp bCBzeW5jaHJvbm91c2x5IHdoZW4gY29uc3RydWN0aW5nIGEgU2hhcmVkV29ya2VyIHdpdGggYW4g VVJMIHRoYXQgaXMgbm90IHNhbWUtb3JpZ2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzY0MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy93b3JrZXJzL2NvbnN0cnVj dG9ycy9TaGFyZWRXb3JrZXIvc2FtZS1vcmlnaW4tZXhwZWN0ZWQudHh0OgorICAgICAgICBSZWJh c2VsaW5lIHRlc3QgdGhhdCBpcyBub3cgZnVsbHkgcGFzc2luZy4gSSBoYXZlIHZlcmlmaWVkIHRo YXQgaXQgaXMgcGFzc2luZyBpbiBib3RoCisgICAgICAgIEJsaW5rIGFuZCBHZWNrbyB0b28uCisK KyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvd29ya2Vycy9zaGFyZWQtd29ya2VyLWluLWRh dGEtdXJsLWNvbnRleHQud2luZG93LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgRXZlbiB0aG91Z2gg dGhpcyBsb29rcyBsaWtlIGEgcmVncmVzc2lvbiwgdGhpcyBhY3R1YWxseSBhbGlnbnMgb3VyIGJl aGF2aW9yIHdpdGggYm90aAorICAgICAgICBCbGluayAmIEdlY2tvICh3aG8gYWxzbyBmYWlsIHRo aXMgY2hlY2spLiBOb3RlIHRoYXQgdGhlIGxvYWQgZmFpbHMgbm8gbWF0dGVyIHdoYXQuCisgICAg ICAgIEhvd2V2ZXIsIHRoZSB0ZXN0IGV4cGVjdHMgaXQgdG8gZmFpbCBhc3luY2hyb25vdXNseSBp bnN0ZWFkIG9mIHN5bmNocm9ub3VzbHkgaW4gdGhpcworICAgICAgICBjYXNlLgorCiAyMDIyLTAy LTA5ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIERpYWxv ZyBlbGVtZW50IG9ubHkgYW5pbWF0ZXMgb25jZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93b3JrZXJzL2NvbnN0cnVjdG9ycy9TaGFyZWRX b3JrZXIvc2FtZS1vcmlnaW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy93b3JrZXJzL2NvbnN0cnVjdG9ycy9TaGFyZWRXb3JrZXIvc2Ft ZS1vcmlnaW4tZXhwZWN0ZWQudHh0CmluZGV4IGNlZmY4NzcwNDc5MDA5MGQ2ZTZjNDM0MGI4MjVh OTcwYzY5NmI4YmYuLmQ3YWRiNjZkNmFhMGQzZjYyYjVmOTVmMTg2ZDliNzZiMzM3ZDE5YjcgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd29y a2Vycy9jb25zdHJ1Y3RvcnMvU2hhcmVkV29ya2VyL3NhbWUtb3JpZ2luLWV4cGVjdGVkLnR4dAor KysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dvcmtlcnMv Y29uc3RydWN0b3JzL1NoYXJlZFdvcmtlci9zYW1lLW9yaWdpbi1leHBlY3RlZC50eHQKQEAgLTEs MTMgKzEsNSBAQAotQ09OU09MRSBNRVNTQUdFOiBDYW5ub3QgbG9hZCB1bnN1cHBvcnRlZDouCi1D T05TT0xFIE1FU1NBR0U6IENhbm5vdCBsb2FkIGphdmFzY3JpcHQ6IiIuCi1DT05TT0xFIE1FU1NB R0U6IENhbm5vdCBsb2FkIGFib3V0OmJsYW5rLgotQ09OU09MRSBNRVNTQUdFOiBDYW5ub3QgbG9h ZCBodHRwOi8vd3d3Lm9wZXJhLmNvbS8uCi1DT05TT0xFIE1FU1NBR0U6IENhbm5vdCBsb2FkIGh0 dHA6Ly9sb2NhbGhvc3Q6ODEvLgotQ09OU09MRSBNRVNTQUdFOiBDYW5ub3QgbG9hZCBodHRwczov L2xvY2FsaG9zdDo4MC8uCi1DT05TT0xFIE1FU1NBR0U6IENhbm5vdCBsb2FkIGh0dHBzOi8vbG9j YWxob3N0OjgwMDAvLgotQ09OU09MRSBNRVNTQUdFOiBDYW5ub3QgbG9hZCBodHRwOi8vbG9jYWxo b3N0OjgwMTIvLgogCi1GQUlMIHVuc3VwcG9ydGVkX3NjaGVtZSBhc3NlcnRfdGhyb3dzX2RvbTog ZnVuY3Rpb24gIigpID0+IHsgbmV3IFNoYXJlZFdvcmtlcigndW5zdXBwb3J0ZWQ6JywgJycpOyB9 IiBkaWQgbm90IHRocm93CitQQVNTIHVuc3VwcG9ydGVkX3NjaGVtZQogUEFTUyBkYXRhX3VybAog UEFTUyBqYXZhc2NyaXB0X3VybAogUEFTUyBhYm91dF9ibGFuawpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93b3JrZXJzL3NoYXJlZC13b3Jr ZXItaW4tZGF0YS11cmwtY29udGV4dC53aW5kb3ctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93b3JrZXJzL3NoYXJlZC13b3JrZXItaW4t ZGF0YS11cmwtY29udGV4dC53aW5kb3ctZXhwZWN0ZWQudHh0CmluZGV4IDA1ZTY2YTNjNzYwMWFi N2Q0MGViNmFlZGIxY2JlYWFlMDY5M2M0YTUuLjQ5OThhMTg1MDUyYTkzZjM3Y2ExZDYzNjAyMjA0 ZWVkOGEyYzkyYzMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvd29ya2Vycy9zaGFyZWQtd29ya2VyLWluLWRhdGEtdXJsLWNvbnRleHQud2lu ZG93LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL3dvcmtlcnMvc2hhcmVkLXdvcmtlci1pbi1kYXRhLXVybC1jb250ZXh0LndpbmRv dy1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw0IEBACi1DT05TT0xFIE1FU1NBR0U6IENhbm5vdCBs b2FkIGh0dHA6Ly9sb2NhbGhvc3Q6ODgwMC93b3JrZXJzL3N1cHBvcnQvcG9zdC1tZXNzYWdlLW9u LWxvYWQtd29ya2VyLmpzLgogCi1QQVNTIENyZWF0ZSBhIHNoYXJlZCB3b3JrZXIgaW4gYSBkYXRh IHVybCBmcmFtZQorRkFJTCBDcmVhdGUgYSBzaGFyZWQgd29ya2VyIGluIGEgZGF0YSB1cmwgZnJh bWUgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgIlBBU1MiIGJ1dCBnb3QgIlNoYXJlZFdvcmtlciBj b25zdHJ1Y3Rpb24gdW5leHBlY3RlZGx5IHN5bmNocm9ub3VzbHkgZmFpbGVkIgogUEFTUyBDcmVh dGUgYSBkYXRhIHVybCBzaGFyZWQgd29ya2VyIGluIGEgZGF0YSB1cmwgZnJhbWUKIAo=