236408 2022-02-09 14:14:17 -0800 Use Ref<> for getBackground/MaskShorthandValue 2022-02-10 15:39:16 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mattwoodrow mattwoodrow esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard ntim webkit-bug-importer oldest_to_newest 1839404 0 mattwoodrow 2022-02-09 14:14:17 -0800 These can never return nullptr, so we should use Ref. 1839406 1 451442 mattwoodrow 2022-02-09 14:15:55 -0800 Created attachment 451442 Patch 1839867 2 451442 ntim 2022-02-10 12:16:43 -0800 Comment on attachment 451442 Patch LGTM! EWS is green too. 1839997 3 ews-feeder 2022-02-10 15:38:13 -0800 Committed r289588 (247101@main): <https://commits.webkit.org/247101@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451442. 1839998 4 webkit-bug-importer 2022-02-10 15:39:16 -0800 <rdar://problem/88782405> 451442 2022-02-09 14:15:55 -0800 2022-02-10 15:38:15 -0800 Patch bug-236408-20220210111553.patch text/plain 4780 mattwoodrow U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmM2MjUxMWFlZDlmZWJi ZDg5N2ZiM2I2MTI2MDk4NTk1ZTBkNWFhNi4uNjFiZjZhMGQ3NDk3YWY0ZWFkYjZlMmZjMzc1M2U0 OTFjNTM3Y2NjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTA5ICBNYXR0 IFdvb2Ryb3cgIDxtYXR0d29vZHJvd0BhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFJlZjw+IGZv ciBnZXRCYWNrZ3JvdW5kL01hc2tTaG9ydGhhbmRWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2ltcGxlIGNsZWFudXAgdG8gbWFrZSBpdCBjbGVh cmVyIHRoYXQgdGhlc2UgY2FuJ3QgcmV0dXJuIG51bGxwdHIsIG5vIHRlc3RzIG5lZWRlZC4KKwor ICAgICAgICAqIGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q29tcHV0ZWRTdHlsZUV4dHJhY3Rvcjo6Z2V0RmlsbExheWVyUHJvcGVydHlTaG9y dGhhbmRWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpDb21wdXRlZFN0eWxlRXh0cmFjdG9yOjpn ZXRCYWNrZ3JvdW5kU2hvcnRoYW5kVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6Q29tcHV0ZWRT dHlsZUV4dHJhY3Rvcjo6Z2V0TWFza1Nob3J0aGFuZFZhbHVlKToKKyAgICAgICAgKiBjc3MvQ1NT Q29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmg6CisKIDIwMjItMDItMDkgIEFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gVmVydGljYWwgd3JpdGluZyBt b2RlIHdpdGggUlRMIHRleHQgY29udGVudCBoYXMgaW5jb3JyZWN0IGFkdmFuY2VzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCmluZGV4 IGNiNDVlMGQ4MTVhNjhjNDIwMTliMGJiNjA0ODYxMGM2OWRjZGQyMjIuLjU3YTc3NTRkMDc1Njhk MWJhMDA0ZWZjNDQ5NDQwOGFjMTMwM2JjODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCkBAIC00NDM0LDcgKzQ0MzQsNyBAQCBz aXplX3QgQ29tcHV0ZWRTdHlsZUV4dHJhY3Rvcjo6Z2V0TGF5ZXJDb3VudChDU1NQcm9wZXJ0eUlE IHByb3BlcnR5KQogICAgIHJldHVybiBsYXllckNvdW50OwogfQogCi1SZWZQdHI8Q1NTVmFsdWU+ IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OmdldEZpbGxMYXllclByb3BlcnR5U2hvcnRoYW5kVmFs dWUoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eSwgY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCYg cHJvcGVydGllc0JlZm9yZVNsYXNoU2VwYXJhdG9yLCBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRo YW5kJiBwcm9wZXJ0aWVzQWZ0ZXJTbGFzaFNlcGFyYXRvciwgQ1NTUHJvcGVydHlJRCBsYXN0TGF5 ZXJQcm9wZXJ0eSkKK1JlZjxDU1NWYWx1ZT4gQ29tcHV0ZWRTdHlsZUV4dHJhY3Rvcjo6Z2V0Rmls bExheWVyUHJvcGVydHlTaG9ydGhhbmRWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BlcnR5LCBjb25z dCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBwcm9wZXJ0aWVzQmVmb3JlU2xhc2hTZXBhcmF0b3Is IGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIHByb3BlcnRpZXNBZnRlclNsYXNoU2VwYXJh dG9yLCBDU1NQcm9wZXJ0eUlEIGxhc3RMYXllclByb3BlcnR5KQogewogICAgIEFTU0VSVChwcm9w ZXJ0eSA9PSBDU1NQcm9wZXJ0eUJhY2tncm91bmQgfHwgcHJvcGVydHkgPT0gQ1NTUHJvcGVydHlN YXNrKTsKICAgICBzaXplX3QgbGF5ZXJDb3VudCA9IGdldExheWVyQ291bnQocHJvcGVydHkpOwpA QCAtNDQ4Miw3ICs0NDgyLDcgQEAgUmVmUHRyPENTU1ZhbHVlPiBDb21wdXRlZFN0eWxlRXh0cmFj dG9yOjpnZXRGaWxsTGF5ZXJQcm9wZXJ0eVNob3J0aGFuZFZhbHVlKENTU1AKIH0KIAogCi1SZWZQ dHI8Q1NTVmFsdWU+IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OmdldEJhY2tncm91bmRTaG9ydGhh bmRWYWx1ZSgpCitSZWY8Q1NTVmFsdWU+IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OmdldEJhY2tn cm91bmRTaG9ydGhhbmRWYWx1ZSgpCiB7CiAgICAgc3RhdGljIGNvbnN0IENTU1Byb3BlcnR5SUQg cHJvcGVydGllc0JlZm9yZVNsYXNoU2VwYXJhdG9yW10gPSB7IENTU1Byb3BlcnR5QmFja2dyb3Vu ZEltYWdlLCBDU1NQcm9wZXJ0eUJhY2tncm91bmRSZXBlYXQsIENTU1Byb3BlcnR5QmFja2dyb3Vu ZEF0dGFjaG1lbnQsIENTU1Byb3BlcnR5QmFja2dyb3VuZFBvc2l0aW9uIH07CiAgICAgc3RhdGlj IGNvbnN0IENTU1Byb3BlcnR5SUQgcHJvcGVydGllc0FmdGVyU2xhc2hTZXBhcmF0b3JbXSA9IHsg Q1NTUHJvcGVydHlCYWNrZ3JvdW5kU2l6ZSwgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kT3JpZ2luLCBD U1NQcm9wZXJ0eUJhY2tncm91bmRDbGlwIH07CkBAIC00NDkwLDcgKzQ0OTAsNyBAQCBSZWZQdHI8 Q1NTVmFsdWU+IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OmdldEJhY2tncm91bmRTaG9ydGhhbmRW YWx1ZSgpCiAgICAgcmV0dXJuIGdldEZpbGxMYXllclByb3BlcnR5U2hvcnRoYW5kVmFsdWUoQ1NT UHJvcGVydHlCYWNrZ3JvdW5kLCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kKENTU1Byb3BlcnR5QmFj a2dyb3VuZCwgcHJvcGVydGllc0JlZm9yZVNsYXNoU2VwYXJhdG9yKSwgU3R5bGVQcm9wZXJ0eVNo b3J0aGFuZChDU1NQcm9wZXJ0eUJhY2tncm91bmQsIHByb3BlcnRpZXNBZnRlclNsYXNoU2VwYXJh dG9yKSwgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3IpOwogfQogCi1SZWZQdHI8Q1NTVmFsdWU+ IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OmdldE1hc2tTaG9ydGhhbmRWYWx1ZSgpCitSZWY8Q1NT VmFsdWU+IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OmdldE1hc2tTaG9ydGhhbmRWYWx1ZSgpCiB7 CiAgICAgc3RhdGljIGNvbnN0IENTU1Byb3BlcnR5SUQgcHJvcGVydGllc0JlZm9yZVNsYXNoU2Vw ZXJhdG9yWzJdID0geyBDU1NQcm9wZXJ0eU1hc2tJbWFnZSwgQ1NTUHJvcGVydHlNYXNrUG9zaXRp b24gfTsKICAgICBzdGF0aWMgY29uc3QgQ1NTUHJvcGVydHlJRCBwcm9wZXJ0aWVzQWZ0ZXJTbGFz aFNlcGVyYXRvcls2XSA9IHsgQ1NTUHJvcGVydHlNYXNrU2l6ZSwgQ1NTUHJvcGVydHlNYXNrUmVw ZWF0LCBDU1NQcm9wZXJ0eU1hc2tPcmlnaW4sIENTU1Byb3BlcnR5TWFza0NsaXAsIENTU1Byb3Bl cnR5TWFza0NvbXBvc2l0ZSwgQ1NTUHJvcGVydHlNYXNrTW9kZSB9OwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5oIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5oCmluZGV4IGZhYTQ1ZjIyNWQ0 MDAyOWJlODhkYTc0YzFjYmYyOTE1NDk5NjZhMjIuLmMxNmM1ZjZmMmViY2Q1ZjFkM2E4ODQwNjRl YWY5OTRiY2EwMWJlYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRl ZFN0eWxlRGVjbGFyYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRT dHlsZURlY2xhcmF0aW9uLmgKQEAgLTk0LDkgKzk0LDkgQEAgcHJpdmF0ZToKICAgICBSZWZQdHI8 Q1NTVmFsdWVMaXN0PiBnZXRDU1NQcm9wZXJ0eVZhbHVlc0ZvcjRTaWRlc1Nob3J0aGFuZChjb25z dCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJik7CiAKICAgICBzaXplX3QgZ2V0TGF5ZXJDb3VudChD U1NQcm9wZXJ0eUlEKTsKLSAgICBSZWZQdHI8Q1NTVmFsdWU+IGdldEZpbGxMYXllclByb3BlcnR5 U2hvcnRoYW5kVmFsdWUoQ1NTUHJvcGVydHlJRCwgY29uc3QgU3R5bGVQcm9wZXJ0eVNob3J0aGFu ZCYgcHJvcGVydGllc0JlZm9yZVNsYXNoU2VwYXJhdG9yLCBjb25zdCBTdHlsZVByb3BlcnR5U2hv cnRoYW5kJiBwcm9wZXJ0aWVzQWZ0ZXJTbGFzaFNlcGFyYXRvciwgQ1NTUHJvcGVydHlJRCBsYXN0 TGF5ZXJQcm9wZXJ0eSk7Ci0gICAgUmVmUHRyPENTU1ZhbHVlPiBnZXRCYWNrZ3JvdW5kU2hvcnRo YW5kVmFsdWUoKTsKLSAgICBSZWZQdHI8Q1NTVmFsdWU+IGdldE1hc2tTaG9ydGhhbmRWYWx1ZSgp OworICAgIFJlZjxDU1NWYWx1ZT4gZ2V0RmlsbExheWVyUHJvcGVydHlTaG9ydGhhbmRWYWx1ZShD U1NQcm9wZXJ0eUlELCBjb25zdCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kJiBwcm9wZXJ0aWVzQmVm b3JlU2xhc2hTZXBhcmF0b3IsIGNvbnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIHByb3BlcnRp ZXNBZnRlclNsYXNoU2VwYXJhdG9yLCBDU1NQcm9wZXJ0eUlEIGxhc3RMYXllclByb3BlcnR5KTsK KyAgICBSZWY8Q1NTVmFsdWU+IGdldEJhY2tncm91bmRTaG9ydGhhbmRWYWx1ZSgpOworICAgIFJl ZjxDU1NWYWx1ZT4gZ2V0TWFza1Nob3J0aGFuZFZhbHVlKCk7CiAgICAgUmVmPENTU1ZhbHVlTGlz dD4gZ2V0Q1NTUHJvcGVydHlWYWx1ZXNGb3JHcmlkU2hvcnRoYW5kKGNvbnN0IFN0eWxlUHJvcGVy dHlTaG9ydGhhbmQmKTsKIAogICAgIFJlZlB0cjxFbGVtZW50PiBtX2VsZW1lbnQ7Cg==