236355 2022-02-09 02:06:59 -0800 Allow hanging run-javascriptcore-tests to print backtrace 2022-02-09 06:59:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 angelos angelos aakash_jain cgarcia ews-watchlist jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1839060 0 angelos 2022-02-09 02:06:59 -0800 Allow hanging run-javascriptcore-tests to print backtrace 1839061 1 451350 angelos 2022-02-09 02:10:05 -0800 Created attachment 451350 Patch 1839084 2 aakash_jain 2022-02-09 04:12:17 -0800 I'm interested in seeing how the output looks like in practice when sigtermTime is used. Do you have an example, maybe from ews? 1839086 3 angelos 2022-02-09 04:20:03 -0800 (In reply to Aakash Jain from comment #2) > I'm interested in seeing how the output looks like in practice when > sigtermTime is used. Do you have an example, maybe from ews? Sure! See jscore-test in https://ews-build.webkit.org/#/builders/45/builds/9028. 1839099 4 451350 aakash_jain 2022-02-09 05:22:01 -0800 Comment on attachment 451350 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451350&action=review > Tools/CISupport/build-webkit-org/steps.py:467 > + if 'sigtermTime' not in kwargs: Not sure if you had specific reason for guarding with this if condition, could have skipped if condition as well. Either way is fine though. 1839108 5 angelos 2022-02-09 05:42:52 -0800 No specific reason, just allowing the caller to override the value if necessary. 1839122 6 ews-feeder 2022-02-09 06:58:12 -0800 Committed r289468 (247011@main): <https://commits.webkit.org/247011@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451350. 1839123 7 webkit-bug-importer 2022-02-09 06:59:16 -0800 <rdar://problem/88687428> 451350 2022-02-09 02:10:05 -0800 2022-02-09 06:58:14 -0800 Patch bug-236355-20220209111004.patch text/plain 1421 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NDYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTViNzM5YzQ2ZDNiMjZiMTU0ZGRjZWUxYTNhZjYxYjZk M2UwMWIwNy4uOWMwYjA3MDJiNDNkMmM0ODljYzI4ZmU0ZjMxMjdiYjhlMWVkYWVlNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIyLTAyLTA5ICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIEFsbG93IGhhbmdpbmcgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIHRv IHByaW50IGJhY2t0cmFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjM2MzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBpcyB0byBkZWJ1ZyAnY29tbWFuZCB0aW1lZCBvdXQ6IDM2MDAgc2Vjb25k cyB3aXRob3V0IG91dHB1dCcKKyAgICAgICAgaXNzdWVzIG9uIGJ1aWxkLndlYmtpdC5vcmcsIHNh bWUgYXMgd2UgZG8gZm9yIEVXUy4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQt b3JnL3N0ZXBzLnB5OgorICAgICAgICAoUnVuSmF2YVNjcmlwdENvcmVUZXN0cy5fX2luaXRfXyk6 CisKIDIwMjItMDItMDIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAg ICAgICAgIFtFV1NdIEVtYmVkIGFkZGVkL21vZGlmaWVkL2RlbGV0ZWQgc3RhdHVzIGludG8gY2hh bmdlZCBmaWxlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcv c3RlcHMucHkgYi9Ub29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weQppbmRl eCBmOWIwYWJmY2I5M2VkNjRkOGE0NzViMjMyOGNiOGVlMmZlMDk3YTdhLi43MGQwNWQ4MzJkZDQ5 NTgzNThjN2NkZDNmOTUyNWRiOWRlNzk0MTI0IDEwMDY0NAotLS0gYS9Ub29scy9DSVN1cHBvcnQv YnVpbGQtd2Via2l0LW9yZy9zdGVwcy5weQorKysgYi9Ub29scy9DSVN1cHBvcnQvYnVpbGQtd2Vi a2l0LW9yZy9zdGVwcy5weQpAQCAtNDY0LDYgKzQ2NCw4IEBAIGNsYXNzIFJ1bkphdmFTY3JpcHRD b3JlVGVzdHMoVGVzdFdpdGhGYWlsdXJlQ291bnQpOgogCiAgICAgZGVmIF9faW5pdF9fKHNlbGYs ICphcmdzLCAqKmt3YXJncyk6CiAgICAgICAgIGt3YXJnc1snbG9nRW52aXJvbiddID0gRmFsc2UK KyAgICAgICAgaWYgJ3NpZ3Rlcm1UaW1lJyBub3QgaW4ga3dhcmdzOgorICAgICAgICAgICAga3dh cmdzWydzaWd0ZXJtVGltZSddID0gMTAKICAgICAgICAgVGVzdFdpdGhGYWlsdXJlQ291bnQuX19p bml0X18oc2VsZiwgKmFyZ3MsICoqa3dhcmdzKQogCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgo=